16313 2007-12-05 15:13:19 -0800 text search (find) keybindings should work in the Web Inspector 2008-08-15 10:03:10 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 rachael webkit-unassigned aroben jalkut mitz rik oldest_to_newest 63385 0 rachael 2007-12-05 15:13:19 -0800 Current behavior: hitting cmd-F gives an error bonk, cmd-G does nothing desired behavior: hitting cmd-F should either bring up a find panel, for searching just the file you're focused on, or at least move your cursor to the find field in the upper right so that you can enter search terms. cmd-G and cmd-shift-G should cycle forwards and backwards through search results like it does elsewhere. (This is something of a pet peeve of mine) 68647 1 aroben 2008-01-29 11:07:18 -0800 <rdar://problem/5712878> 86626 2 22419 rik 2008-07-22 01:03:34 -0700 Created attachment 22419 Patch for Cmd-F or Ctrl-F I'm not sure the early break; is a good idea for code readability. I'll post a patch for Cmd+G and Cmd-Shift-G later. 87053 3 jalkut 2008-07-26 23:04:59 -0700 I stumbled on this bug because it was referenced in IRC. The only skepticism that jumps to my mind is whether the "match" is too inclusive. For instance, this patch is intended to allow ctrl-F and cmd-F to perform a certain action, but the code as written will (I think) allow many key combinations to perform this action: cmd-ctrl-F cmd-shift-F ctrl-shift-F opt-ctrl-F Etc. I don't know enough about the code flow around this to know whether this matters. But generally when keyboard shortcut modifiers are being explicitly tested, it's important to confirm that the desired modifier is being pressed TO THE EXCLUSION of the other modifier keys. 87062 4 22500 jalkut 2008-07-27 00:44:25 -0700 Created attachment 22500 Same as original but endeavors to avoid false-positive keystrokes... I confirmed my suspicion that the original patch made it possible to invoke the find command by a number of undesired keystrokes. With this adjusted patch, the keystroke only invokes find if it's a pure cmd-f or ctrl-f. 87065 5 22502 jalkut 2008-07-27 01:43:31 -0700 Created attachment 22502 Same as original + avoid false positives + style edits via bdash Fixes style mistakes I made. Props to bdash for noticing/informing. 87066 6 22500 jalkut 2008-07-27 01:44:56 -0700 Comment on attachment 22500 Same as original but endeavors to avoid false-positive keystrokes... Obsoleted by later patch. 87078 7 22506 jalkut 2008-07-27 10:39:45 -0700 Created attachment 22506 Add credit/blame line in case there are questions or requests for fixes from review. 87079 8 22507 jalkut 2008-07-27 10:43:42 -0700 Created attachment 22507 Ugh - learn to spell my email addr. 87080 9 22506 mitz 2008-07-27 10:49:02 -0700 Comment on attachment 22506 Add credit/blame line in case there are questions or requests for fixes from review. Is it okay to hard-code 'F' in inspector.js? How will it work with non-US keyboard layouts or with localizations where the keyboard shortcut for Find is not Command-F? 87081 10 jalkut 2008-07-27 10:53:06 -0700 Perhaps a better long-term solution is to arrange for the Inspector to react to the existing menu items of the app. First-responder style. For instance, it's kind of dumb that "Cmd-F" will now work to activate the find field, yet Edit -> Find is disabled in the menu bar. This also touches on another issue that a friend noticed, where he wanted a "printable" version of the inspector window. If "Print" from the hosting app's menu was hooked up to the inspector, it might "just work" for some definition of working. Daniel 87631 11 22507 timothy 2008-08-01 15:20:22 -0700 Comment on attachment 22507 Ugh - learn to spell my email addr. We should find a way to hook up to the menu, for sure. But I think this is fine for now. We might also have different find in the future, like a current file find (Command-F and Command-G). Then the global search, so the shortcut might change to mean local find in the future. 88586 12 timothy 2008-08-15 10:03:10 -0700 Landed in r35785. 22419 2008-07-22 01:03:34 -0700 2008-07-28 00:41:46 -0700 Patch for Cmd-F or Ctrl-F youhou.patch text/plain 1457 rik SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTI4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDctMjIgIEFudGhvbnkgUmljYXVkICA8cmlrMjRkQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8 aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzEzPgorICAgICAgICBC dWcgMTYzMTM6IHRleHQgc2VhcmNoIChmaW5kKSBrZXliaW5kaW5ncyBzaG91bGQgd29yayBpbiB0 aGUgV2ViIEluc3BlY3RvcgorICAgICAgICAKKyAgICAgICAgQ21kLUYgb24gTWFjIG9yIEN0cmwt RiBvbiBvdGhlciBwbGF0Zm9ybXMgbm93IGZvY3VzIHRoZSBzZWFyY2ggZmllbGQuCisgICAgICAg IAorICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL2luc3BlY3Rvci5qczogQWRkZWQgYSBjYXNlIGZv ciB0aGUgRiBrZXkKKwogMjAwOC0wNy0yMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFdlYkNv cmUvcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFn ZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzCShyZXZpc2lvbiAzNTI4NCkKKysrIFdlYkNvcmUvcGFn ZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzCSh3b3JraW5nIGNvcHkpCkBAIC00MjgsNiArNDI4LDEz IEBAIFdlYkluc3BlY3Rvci5kb2N1bWVudEtleURvd24gPSBmdW5jdGlvbigKICAgICAgICAgICAg ICAgICB0aGlzLmNvbnNvbGUudmlzaWJsZSA9ICF0aGlzLmNvbnNvbGUudmlzaWJsZTsKICAgICAg ICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwogICAgICAgICAgICAgICAgIGJyZWFr OworICAgICAgICAgICAgY2FzZSAiVSswMDQ2IjogLy8gRiBrZXkKKyAgICAgICAgICAgICAgICB2 YXIgaXNNYWMgPSBJbnNwZWN0b3JDb250cm9sbGVyLnBsYXRmb3JtKCkuaW5kZXhPZigibWFjLSIp ID09PSAwOworICAgICAgICAgICAgICAgIGlmICgoaXNNYWMgJiYgIWV2ZW50Lm1ldGFLZXkpIHx8 ICghaXNNYWMgJiYgIWV2ZW50LmN0cmxLZXkpKQorICAgICAgICAgICAgICAgICAgICBicmVhazsK KyAgICAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic2VhcmNoIikuZm9jdXMo KTsKKyAgICAgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOworICAgICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfQogfQo= 22500 2008-07-27 00:44:25 -0700 2008-07-27 01:44:56 -0700 Same as original but endeavors to avoid false-positive keystrokes... ExclusiveFKeyHandler.patch text/plain 1823 jalkut SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTQwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDctMjYgIEFudGhvbnkgUmljYXVkICA8cmlrMjRkQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8 aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzEzPgorICAgICAgICBC dWcgMTYzMTM6IHRleHQgc2VhcmNoIChmaW5kKSBrZXliaW5kaW5ncyBzaG91bGQgd29yayBpbiB0 aGUgV2ViIEluc3BlY3RvcgorICAgICAgICAKKyAgICAgICAgQ21kLUYgb24gTWFjIG9yIEN0cmwt RiBvbiBvdGhlciBwbGF0Zm9ybXMgbm93IGZvY3VzIHRoZSBzZWFyY2ggZmllbGQuCisgICAgICAg IAorICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL2luc3BlY3Rvci5qczogQWRkZWQgYSBjYXNlIGZv ciB0aGUgRiBrZXkKKwogMjAwOC0wNy0yNiAgRGlyayBTY2h1bHplICA8dmJzODVAZ214LmRlPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogV2ViQ29yZS9wYWdlL2lu c3BlY3Rvci9pbnNwZWN0b3IuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL2luc3BlY3Rv ci9pbnNwZWN0b3IuanMJKHJldmlzaW9uIDM1NDAwKQorKysgV2ViQ29yZS9wYWdlL2luc3BlY3Rv ci9pbnNwZWN0b3IuanMJKHdvcmtpbmcgY29weSkKQEAgLTQyOCw2ICs0MjgsMjEgQEAgV2ViSW5z cGVjdG9yLmRvY3VtZW50S2V5RG93biA9IGZ1bmN0aW9uKAogICAgICAgICAgICAgICAgIHRoaXMu Y29uc29sZS52aXNpYmxlID0gIXRoaXMuY29uc29sZS52aXNpYmxlOwogICAgICAgICAgICAgICAg IGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAg ICAgICBjYXNlICJVKzAwNDYiOiAvLyBGIGtleQorICAgICAgICAgICAgICAgIHZhciBpc01hYyA9 IEluc3BlY3RvckNvbnRyb2xsZXIucGxhdGZvcm0oKS5pbmRleE9mKCJtYWMtIikgPT09IDA7Cisg ICAgICAgICAgICAgICAgdmFyIGlzRmluZEtleSA9IGZhbHNlOworICAgICAgICAgICAgICAgIC8v IFdlIHdhbnQgY21kLUYgZm9yIE1hYywgb3IgY3RybC1GIGZvciBub24tTWFjCisgICAgICAgICAg ICAgICAgaWYgKGlzTWFjKSB7CisgICAgICAgICAgICAgICAgICAgIGlzRmluZEtleSA9IChldmVu dC5tZXRhS2V5ICYmICFldmVudC5jdHJsS2V5ICYmICFldmVudC5hbHRLZXkgJiYgIWV2ZW50LnNo aWZ0S2V5KTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgZWxzZSB7CisgICAg ICAgICAgICAgICAgICAgIGlzRmluZEtleSA9IChldmVudC5jdHJsS2V5ICYmICFldmVudC5tZXRh S2V5ICYmICFldmVudC5hbHRLZXkgJiYgIWV2ZW50LnNoaWZ0S2V5KTsgICAgICAgICAgICAgICAg CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIGlmIChpc0ZpbmRLZXkpIHsKKyAg ICAgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNlYXJjaCIpLmZvY3Vz KCk7CisgICAgICAgICAgICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CisgICAgICAg ICAgICAgICAgfQorICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfQogfQo= 22502 2008-07-27 01:43:31 -0700 2008-07-27 10:39:45 -0700 Same as original + avoid false positives + style edits via bdash ExclusiveFKeyHandlerV2.patch text/plain 1771 jalkut SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTQwMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDctMjYgIEFudGhvbnkgUmljYXVkICA8cmlrMjRkQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8 aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzEzPgorICAgICAgICBC dWcgMTYzMTM6IHRleHQgc2VhcmNoIChmaW5kKSBrZXliaW5kaW5ncyBzaG91bGQgd29yayBpbiB0 aGUgV2ViIEluc3BlY3RvcgorICAgICAgICAKKyAgICAgICAgQ21kLUYgb24gTWFjIG9yIEN0cmwt RiBvbiBvdGhlciBwbGF0Zm9ybXMgbm93IGZvY3VzIHRoZSBzZWFyY2ggZmllbGQuCisgICAgICAg IAorICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL2luc3BlY3Rvci5qczogQWRkZWQgYSBjYXNlIGZv ciB0aGUgRiBrZXkKKwogMjAwOC0wNy0yNiAgRGlyayBTY2h1bHplICA8dmJzODVAZ214LmRlPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogV2ViQ29yZS9wYWdlL2lu c3BlY3Rvci9pbnNwZWN0b3IuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL2luc3BlY3Rv ci9pbnNwZWN0b3IuanMJKHJldmlzaW9uIDM1NDAxKQorKysgV2ViQ29yZS9wYWdlL2luc3BlY3Rv ci9pbnNwZWN0b3IuanMJKHdvcmtpbmcgY29weSkKQEAgLTQyOCw2ICs0MjgsMjAgQEAgV2ViSW5z cGVjdG9yLmRvY3VtZW50S2V5RG93biA9IGZ1bmN0aW9uKAogICAgICAgICAgICAgICAgIHRoaXMu Y29uc29sZS52aXNpYmxlID0gIXRoaXMuY29uc29sZS52aXNpYmxlOwogICAgICAgICAgICAgICAg IGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAg ICAgICBjYXNlICJVKzAwNDYiOiAvLyBGIGtleQorICAgICAgICAgICAgICAgIHZhciBpc01hYyA9 IEluc3BlY3RvckNvbnRyb2xsZXIucGxhdGZvcm0oKS5pbmRleE9mKCJtYWMtIikgPT09IDA7Cisg ICAgICAgICAgICAgICAgdmFyIGlzRmluZEtleTsKKyAgICAgICAgICAgICAgICAvLyBXZSB3YW50 IGNtZC1GIGZvciBNYWMsIG9yIGN0cmwtRiBmb3Igbm9uLU1hYworICAgICAgICAgICAgICAgIGlm IChpc01hYykKKyAgICAgICAgICAgICAgICAgICAgaXNGaW5kS2V5ID0gZXZlbnQubWV0YUtleSAm JiAhZXZlbnQuY3RybEtleSAmJiAhZXZlbnQuYWx0S2V5ICYmICFldmVudC5zaGlmdEtleTsKKyAg ICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgIGlzRmluZEtleSA9IGV2ZW50 LmN0cmxLZXkgJiYgIWV2ZW50Lm1ldGFLZXkgJiYgIWV2ZW50LmFsdEtleSAmJiAhZXZlbnQuc2hp ZnRLZXk7ICAgICAgICAgICAgICAgIAorCisgICAgICAgICAgICAgICAgaWYgKGlzRmluZEtleSkg eworICAgICAgICAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic2VhcmNoIiku Zm9jdXMoKTsKKyAgICAgICAgICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKKyAg ICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICB9 CiB9Cg== 22506 2008-07-27 10:39:45 -0700 2008-07-27 10:43:42 -0700 Add credit/blame line in case there are questions or requests for fixes from review. ExclusiveFKeyHandlerV3.patch text/plain 1890 jalkut SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTQwMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDctMjYgIEFudGhvbnkgUmljYXVkICA8cmlrMjRkQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ bGF0Zm9ybSBkaXN0aW5jdGlvbiBhbmQgbW9kaWZpZXIga2V5IG1hdGNoaW5nIGFkanVzdGVkIAor ICAgICAgICBieSBEYW5pZWwgSmFsa3V0IDxqYWxrdXRAcmVkLXN3YWV0ZXIuY29tPgorCisgICAg ICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMTM+CisgICAg ICAgIEJ1ZyAxNjMxMzogdGV4dCBzZWFyY2ggKGZpbmQpIGtleWJpbmRpbmdzIHNob3VsZCB3b3Jr IGluIHRoZSBXZWIgSW5zcGVjdG9yCisgICAgICAgIAorICAgICAgICBDbWQtRiBvbiBNYWMgb3Ig Q3RybC1GIG9uIG90aGVyIHBsYXRmb3JtcyBub3cgZm9jdXMgdGhlIHNlYXJjaCBmaWVsZC4KKyAg ICAgICAgCisgICAgICAgICogcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzOiBBZGRlZCBhIGNh c2UgZm9yIHRoZSBGIGtleQorCiAyMDA4LTA3LTI2ICBEaXJrIFNjaHVsemUgIDx2YnM4NUBnbXgu ZGU+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL3Bh Z2UvaW5zcGVjdG9yL2luc3BlY3Rvci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvaW5z cGVjdG9yL2luc3BlY3Rvci5qcwkocmV2aXNpb24gMzU0MDEpCisrKyBXZWJDb3JlL3BhZ2UvaW5z cGVjdG9yL2luc3BlY3Rvci5qcwkod29ya2luZyBjb3B5KQpAQCAtNDI4LDYgKzQyOCwyMCBAQCBX ZWJJbnNwZWN0b3IuZG9jdW1lbnRLZXlEb3duID0gZnVuY3Rpb24oCiAgICAgICAgICAgICAgICAg dGhpcy5jb25zb2xlLnZpc2libGUgPSAhdGhpcy5jb25zb2xlLnZpc2libGU7CiAgICAgICAgICAg ICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKICAgICAgICAgICAgICAgICBicmVhazsKKyAg ICAgICAgICAgIGNhc2UgIlUrMDA0NiI6IC8vIEYga2V5CisgICAgICAgICAgICAgICAgdmFyIGlz TWFjID0gSW5zcGVjdG9yQ29udHJvbGxlci5wbGF0Zm9ybSgpLmluZGV4T2YoIm1hYy0iKSA9PT0g MDsKKyAgICAgICAgICAgICAgICB2YXIgaXNGaW5kS2V5OworICAgICAgICAgICAgICAgIC8vIFdl IHdhbnQgY21kLUYgZm9yIE1hYywgb3IgY3RybC1GIGZvciBub24tTWFjCisgICAgICAgICAgICAg ICAgaWYgKGlzTWFjKQorICAgICAgICAgICAgICAgICAgICBpc0ZpbmRLZXkgPSBldmVudC5tZXRh S2V5ICYmICFldmVudC5jdHJsS2V5ICYmICFldmVudC5hbHRLZXkgJiYgIWV2ZW50LnNoaWZ0S2V5 OworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgaXNGaW5kS2V5ID0g ZXZlbnQuY3RybEtleSAmJiAhZXZlbnQubWV0YUtleSAmJiAhZXZlbnQuYWx0S2V5ICYmICFldmVu dC5zaGlmdEtleTsgICAgICAgICAgICAgICAgCisKKyAgICAgICAgICAgICAgICBpZiAoaXNGaW5k S2V5KSB7CisgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJzZWFy Y2giKS5mb2N1cygpOworICAgICAgICAgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgp OworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQog ICAgIH0KIH0K 22507 2008-07-27 10:43:42 -0700 2008-08-01 15:20:22 -0700 Ugh - learn to spell my email addr. ExclusiveFKeyHandlerV4.patch text/plain 1890 jalkut SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTQwMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDctMjYgIEFudGhvbnkgUmljYXVkICA8cmlrMjRkQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ bGF0Zm9ybSBkaXN0aW5jdGlvbiBhbmQgbW9kaWZpZXIga2V5IG1hdGNoaW5nIGFkanVzdGVkIAor ICAgICAgICBieSBEYW5pZWwgSmFsa3V0IDxqYWxrdXRAcmVkLXN3ZWF0ZXIuY29tPgorCisgICAg ICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMTM+CisgICAg ICAgIEJ1ZyAxNjMxMzogdGV4dCBzZWFyY2ggKGZpbmQpIGtleWJpbmRpbmdzIHNob3VsZCB3b3Jr IGluIHRoZSBXZWIgSW5zcGVjdG9yCisgICAgICAgIAorICAgICAgICBDbWQtRiBvbiBNYWMgb3Ig Q3RybC1GIG9uIG90aGVyIHBsYXRmb3JtcyBub3cgZm9jdXMgdGhlIHNlYXJjaCBmaWVsZC4KKyAg ICAgICAgCisgICAgICAgICogcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzOiBBZGRlZCBhIGNh c2UgZm9yIHRoZSBGIGtleQorCiAyMDA4LTA3LTI2ICBEaXJrIFNjaHVsemUgIDx2YnM4NUBnbXgu ZGU+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL3Bh Z2UvaW5zcGVjdG9yL2luc3BlY3Rvci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvaW5z cGVjdG9yL2luc3BlY3Rvci5qcwkocmV2aXNpb24gMzU0MDEpCisrKyBXZWJDb3JlL3BhZ2UvaW5z cGVjdG9yL2luc3BlY3Rvci5qcwkod29ya2luZyBjb3B5KQpAQCAtNDI4LDYgKzQyOCwyMCBAQCBX ZWJJbnNwZWN0b3IuZG9jdW1lbnRLZXlEb3duID0gZnVuY3Rpb24oCiAgICAgICAgICAgICAgICAg dGhpcy5jb25zb2xlLnZpc2libGUgPSAhdGhpcy5jb25zb2xlLnZpc2libGU7CiAgICAgICAgICAg ICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKICAgICAgICAgICAgICAgICBicmVhazsKKyAg ICAgICAgICAgIGNhc2UgIlUrMDA0NiI6IC8vIEYga2V5CisgICAgICAgICAgICAgICAgdmFyIGlz TWFjID0gSW5zcGVjdG9yQ29udHJvbGxlci5wbGF0Zm9ybSgpLmluZGV4T2YoIm1hYy0iKSA9PT0g MDsKKyAgICAgICAgICAgICAgICB2YXIgaXNGaW5kS2V5OworICAgICAgICAgICAgICAgIC8vIFdl IHdhbnQgY21kLUYgZm9yIE1hYywgb3IgY3RybC1GIGZvciBub24tTWFjCisgICAgICAgICAgICAg ICAgaWYgKGlzTWFjKQorICAgICAgICAgICAgICAgICAgICBpc0ZpbmRLZXkgPSBldmVudC5tZXRh S2V5ICYmICFldmVudC5jdHJsS2V5ICYmICFldmVudC5hbHRLZXkgJiYgIWV2ZW50LnNoaWZ0S2V5 OworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgaXNGaW5kS2V5ID0g ZXZlbnQuY3RybEtleSAmJiAhZXZlbnQubWV0YUtleSAmJiAhZXZlbnQuYWx0S2V5ICYmICFldmVu dC5zaGlmdEtleTsgICAgICAgICAgICAgICAgCisKKyAgICAgICAgICAgICAgICBpZiAoaXNGaW5k S2V5KSB7CisgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJzZWFy Y2giKS5mb2N1cygpOworICAgICAgICAgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgp OworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQog ICAgIH0KIH0K