163104 2016-10-07 02:27:46 -0700 WebRTC: Misc gardening: Use typedefs consistently and remove unused code 2016-10-07 05:00:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 143211 1 adam.bergkvist webkit-unassigned alex commit-queue eric.carlson pnormand oldest_to_newest 1237539 0 adam.bergkvist 2016-10-07 02:27:46 -0700 ... also move some includes from header to cpp-file. 1237543 1 290917 adam.bergkvist 2016-10-07 02:43:14 -0700 Created attachment 290917 Proposed patch 1237556 2 290917 adam.bergkvist 2016-10-07 04:37:04 -0700 Comment on attachment 290917 Proposed patch Thanks for reviewing Philippe. 1237564 3 290917 commit-queue 2016-10-07 05:00:01 -0700 Comment on attachment 290917 Proposed patch Clearing flags on attachment: 290917 Committed r206908: <http://trac.webkit.org/changeset/206908> 1237565 4 commit-queue 2016-10-07 05:00:04 -0700 All reviewed patches have been landed. Closing bug. 290917 2016-10-07 02:43:14 -0700 2016-10-07 05:00:01 -0700 Proposed patch webrtc-gardening_0.patch text/plain 6571 adam.bergkvist ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMWM3MjhmLi4yNWRkMDY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEg QEAKKzIwMTYtMTAtMDcgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24u Y29tPgorCisgICAgICAgIFdlYlJUQzogTWlzYyBnYXJkZW5pbmc6IFVzZSB0eXBlZGVmcyBjb25z aXN0ZW50bHkgYW5kIHJlbW92ZSB1bnVzZWQgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTWlzY2VsbGFuZW91cyBXZWJSVEMgZ2FyZGVuaW5nLiBT ZWUgZmlsZSBsaXN0IGJlbG93IGZvciBkZXRhaWxzLgorCisgICAgICAgIFRlc3Rpbmc6IE5vIGNo YW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFF bmRwb2ludFBlZXJDb25uZWN0aW9uLmNwcDoKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFt L01lZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlvbi5oOgorICAgICAgICBNb3ZlIE5vdEltcGxlbWVu dGVkIGluY2x1ZGUgdG8gY3BwLWZpbGUuCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0v TWVkaWFFbmRwb2ludC5oOgorICAgICAgICBVc2UgTWVkaWFQYXlsb2FkVmVjdG9yIHR5cGVkZWYg KGluc3RlYWQgb2YgVmVjdG9yPFJlZlB0cjxNZWRpYVBheWxvYWQ+PikuCisgICAgICAgICogcGxh dGZvcm0vbWVkaWFzdHJlYW0vUGVlck1lZGlhRGVzY3JpcHRpb24uaDoKKyAgICAgICAgKFdlYkNv cmU6OlBlZXJNZWRpYURlc2NyaXB0aW9uOjpzb3VyY2UpOiBEZWxldGVkLgorICAgICAgICAoV2Vi Q29yZTo6UGVlck1lZGlhRGVzY3JpcHRpb246OnNldFNvdXJjZSk6IERlbGV0ZWQuCisgICAgICAg IFNvdXJjZXMgYXJlIHBhc3NlZCB0byB1cGRhdGVTZW5kQ29uZmlndXJhdGlvbigpIHZpYSBhIHNv dXJjZSBtYXAgYW5kIG5vdCBhZGRlZCB0byBlYWNoCisgICAgICAgIFBlZXJNZWRpYURlc2NyaXB0 aW9uIGFueW1vcmUuIFJlbW92ZSB1bnVzZWQgY29kZS4KKyAgICAgICAgKiBwbGF0Zm9ybS9tb2Nr L01vY2tNZWRpYUVuZHBvaW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1vY2tNZWRpYUVuZHBv aW50OjpnZXREZWZhdWx0QXVkaW9QYXlsb2Fkcyk6CisgICAgICAgIChXZWJDb3JlOjpNb2NrTWVk aWFFbmRwb2ludDo6Z2V0RGVmYXVsdFZpZGVvUGF5bG9hZHMpOgorICAgICAgICBVc2UgTWVkaWFQ YXlsb2FkVmVjdG9yIHR5cGVkZWYuCisgICAgICAgICogcGxhdGZvcm0vbW9jay9Nb2NrTWVkaWFF bmRwb2ludC5oOgorICAgICAgICBVc2UgTWVkaWFQYXlsb2FkVmVjdG9yIHR5cGVkZWYuCisKIDIw MTYtMTAtMDYgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CiAKICAgICAgICAg VXBkYXRlIFJlc291cmNlIExvYWQgU3RhdGlzdGljcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rpb24uY3BwIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYUVuZHBvaW50UGVlckNvbm5l Y3Rpb24uY3BwCmluZGV4IDU4YTY0NTUuLjQxMDExZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9uLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhRW5kcG9pbnRQZWVy Q29ubmVjdGlvbi5jcHAKQEAgLTM5LDYgKzM5LDcgQEAKICNpbmNsdWRlICJNZWRpYVN0cmVhbS5o IgogI2luY2x1ZGUgIk1lZGlhU3RyZWFtRXZlbnQuaCIKICNpbmNsdWRlICJNZWRpYVN0cmVhbVRy YWNrLmgiCisjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKICNpbmNsdWRlICJQZWVyTWVkaWFE ZXNjcmlwdGlvbi5oIgogI2luY2x1ZGUgIlJUQ0NvbmZpZ3VyYXRpb24uaCIKICNpbmNsdWRlICJS VENJY2VDYW5kaWRhdGUuaCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzdHJlYW0vTWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc3RyZWFtL01lZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlvbi5oCmluZGV4IGY1 MTM3MjguLjdkODk0NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz dHJlYW0vTWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rpb24uaApAQCAtMzUs NyArMzUsNiBAQAogCiAjaW5jbHVkZSAiTWVkaWFFbmRwb2ludC5oIgogI2luY2x1ZGUgIk1lZGlh RW5kcG9pbnRTZXNzaW9uRGVzY3JpcHRpb24uaCIKLSNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5o IgogI2luY2x1ZGUgIlBlZXJDb25uZWN0aW9uQmFja2VuZC5oIgogI2luY2x1ZGUgPHd0Zi9GdW5j dGlvbi5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhRW5kcG9pbnQuaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhRW5kcG9pbnQuaAppbmRleCAzODcyMjI3Li5kOGQ1 N2NhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRp YUVuZHBvaW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVk aWFFbmRwb2ludC5oCkBAIC02Niw4ICs2Niw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQg c2V0Q29uZmlndXJhdGlvbihSZWZQdHI8TWVkaWFFbmRwb2ludENvbmZpZ3VyYXRpb24+JiYpID0g MDsKIAogICAgIHZpcnR1YWwgdm9pZCBnZW5lcmF0ZUR0bHNJbmZvKCkgPSAwOwotICAgIHZpcnR1 YWwgVmVjdG9yPFJlZlB0cjxNZWRpYVBheWxvYWQ+PiBnZXREZWZhdWx0QXVkaW9QYXlsb2Fkcygp ID0gMDsKLSAgICB2aXJ0dWFsIFZlY3RvcjxSZWZQdHI8TWVkaWFQYXlsb2FkPj4gZ2V0RGVmYXVs dFZpZGVvUGF5bG9hZHMoKSA9IDA7CisgICAgdmlydHVhbCBNZWRpYVBheWxvYWRWZWN0b3IgZ2V0 RGVmYXVsdEF1ZGlvUGF5bG9hZHMoKSA9IDA7CisgICAgdmlydHVhbCBNZWRpYVBheWxvYWRWZWN0 b3IgZ2V0RGVmYXVsdFZpZGVvUGF5bG9hZHMoKSA9IDA7CiAgICAgdmlydHVhbCBNZWRpYVBheWxv YWRWZWN0b3IgZmlsdGVyUGF5bG9hZHMoY29uc3QgTWVkaWFQYXlsb2FkVmVjdG9yJiByZW1vdGVQ YXlsb2FkcywgY29uc3QgTWVkaWFQYXlsb2FkVmVjdG9yJiBkZWZhdWx0UGF5bG9hZHMpID0gMDsK IAogICAgIHZpcnR1YWwgVXBkYXRlUmVzdWx0IHVwZGF0ZVJlY2VpdmVDb25maWd1cmF0aW9uKE1l ZGlhRW5kcG9pbnRTZXNzaW9uQ29uZmlndXJhdGlvbiosIGJvb2wgaXNJbml0aWF0b3IpID0gMDsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1BlZXJNZWRp YURlc2NyaXB0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9QZWVy TWVkaWFEZXNjcmlwdGlvbi5oCmluZGV4IGI3ZDRhMTAuLjU0MjNhMWYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1BlZXJNZWRpYURlc2NyaXB0aW9uLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vUGVlck1lZGlhRGVzY3Jp cHRpb24uaApAQCAtMTA5LDkgKzEwOSw2IEBAIHB1YmxpYzoKICAgICBjb25zdCBWZWN0b3I8UmVm UHRyPEljZUNhbmRpZGF0ZT4+JiBpY2VDYW5kaWRhdGVzKCkgY29uc3QgeyByZXR1cm4gbV9pY2VD YW5kaWRhdGVzOyB9CiAgICAgdm9pZCBhZGRJY2VDYW5kaWRhdGUoUmVmUHRyPEljZUNhbmRpZGF0 ZT4mJiBjYW5kaWRhdGUpIHsgbV9pY2VDYW5kaWRhdGVzLmFwcGVuZChXVEZNb3ZlKGNhbmRpZGF0 ZSkpOyB9CiAKLSAgICBSZWFsdGltZU1lZGlhU291cmNlKiBzb3VyY2UoKSBjb25zdCB7IHJldHVy biBtX3NvdXJjZS5nZXQoKTsgfQotICAgIHZvaWQgc2V0U291cmNlKFJlZlB0cjxSZWFsdGltZU1l ZGlhU291cmNlPiYmIHNvdXJjZSkgeyBtX3NvdXJjZSA9IHNvdXJjZTsgfQotCiAgICAgUmVmUHRy PFBlZXJNZWRpYURlc2NyaXB0aW9uPiBjbG9uZSgpIGNvbnN0CiAgICAgewogICAgICAgICBSZWZQ dHI8UGVlck1lZGlhRGVzY3JpcHRpb24+IGNvcHkgPSBjcmVhdGUoKTsKQEAgLTE3OCw4ICsxNzUs NiBAQCBwcml2YXRlOgogICAgIFN0cmluZyBtX2ljZVVmcmFnOwogICAgIFN0cmluZyBtX2ljZVBh c3N3b3JkOwogICAgIFZlY3RvcjxSZWZQdHI8SWNlQ2FuZGlkYXRlPj4gbV9pY2VDYW5kaWRhdGVz OwotCi0gICAgUmVmUHRyPFJlYWx0aW1lTWVkaWFTb3VyY2U+IG1fc291cmNlIHsgbnVsbHB0ciB9 OwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbW9jay9Nb2NrTWVkaWFFbmRwb2ludC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tb2NrL01vY2tNZWRpYUVuZHBvaW50LmNwcAppbmRleCA4MzE0MTdjLi5hZTE4ZGQx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tb2NrL01vY2tNZWRpYUVuZHBv aW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tb2NrL01vY2tNZWRpYUVuZHBv aW50LmNwcApAQCAtNzMsOSArNzMsOSBAQCB2b2lkIE1vY2tNZWRpYUVuZHBvaW50OjpnZW5lcmF0 ZUR0bHNJbmZvKCkKICAgICB9KTsKIH0KIAotVmVjdG9yPFJlZlB0cjxNZWRpYVBheWxvYWQ+PiBN b2NrTWVkaWFFbmRwb2ludDo6Z2V0RGVmYXVsdEF1ZGlvUGF5bG9hZHMoKQorTWVkaWFQYXlsb2Fk VmVjdG9yIE1vY2tNZWRpYUVuZHBvaW50OjpnZXREZWZhdWx0QXVkaW9QYXlsb2FkcygpCiB7Ci0g ICAgVmVjdG9yPFJlZlB0cjxNZWRpYVBheWxvYWQ+PiBwYXlsb2FkczsKKyAgICBNZWRpYVBheWxv YWRWZWN0b3IgcGF5bG9hZHM7CiAKICAgICBSZWZQdHI8TWVkaWFQYXlsb2FkPiBwYXlsb2FkID0g TWVkaWFQYXlsb2FkOjpjcmVhdGUoKTsKICAgICBwYXlsb2FkLT5zZXRUeXBlKDExMSk7CkBAIC0x MDEsOSArMTAxLDkgQEAgVmVjdG9yPFJlZlB0cjxNZWRpYVBheWxvYWQ+PiBNb2NrTWVkaWFFbmRw b2ludDo6Z2V0RGVmYXVsdEF1ZGlvUGF5bG9hZHMoKQogICAgIHJldHVybiBwYXlsb2FkczsKIH0K IAotVmVjdG9yPFJlZlB0cjxNZWRpYVBheWxvYWQ+PiBNb2NrTWVkaWFFbmRwb2ludDo6Z2V0RGVm YXVsdFZpZGVvUGF5bG9hZHMoKQorTWVkaWFQYXlsb2FkVmVjdG9yIE1vY2tNZWRpYUVuZHBvaW50 OjpnZXREZWZhdWx0VmlkZW9QYXlsb2FkcygpCiB7Ci0gICAgVmVjdG9yPFJlZlB0cjxNZWRpYVBh eWxvYWQ+PiBwYXlsb2FkczsKKyAgICBNZWRpYVBheWxvYWRWZWN0b3IgcGF5bG9hZHM7CiAKICAg ICBSZWZQdHI8TWVkaWFQYXlsb2FkPiBwYXlsb2FkID0gTWVkaWFQYXlsb2FkOjpjcmVhdGUoKTsK ICAgICBwYXlsb2FkLT5zZXRUeXBlKDEwMyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tb2NrL01vY2tNZWRpYUVuZHBvaW50LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tb2NrL01vY2tNZWRpYUVuZHBvaW50LmgKaW5kZXggOWY2MDE5NC4uZmFmOTFmOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbW9jay9Nb2NrTWVkaWFFbmRwb2ludC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21vY2svTW9ja01lZGlhRW5kcG9pbnQuaApAQCAt NDgsOCArNDgsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRDb25maWd1cmF0aW9uKFJlZlB0cjxN ZWRpYUVuZHBvaW50Q29uZmlndXJhdGlvbj4mJikgb3ZlcnJpZGU7CiAKICAgICB2b2lkIGdlbmVy YXRlRHRsc0luZm8oKSBvdmVycmlkZTsKLSAgICBWZWN0b3I8UmVmUHRyPE1lZGlhUGF5bG9hZD4+ IGdldERlZmF1bHRBdWRpb1BheWxvYWRzKCkgb3ZlcnJpZGU7Ci0gICAgVmVjdG9yPFJlZlB0cjxN ZWRpYVBheWxvYWQ+PiBnZXREZWZhdWx0VmlkZW9QYXlsb2FkcygpIG92ZXJyaWRlOworICAgIE1l ZGlhUGF5bG9hZFZlY3RvciBnZXREZWZhdWx0QXVkaW9QYXlsb2FkcygpIG92ZXJyaWRlOworICAg IE1lZGlhUGF5bG9hZFZlY3RvciBnZXREZWZhdWx0VmlkZW9QYXlsb2FkcygpIG92ZXJyaWRlOwog ICAgIE1lZGlhUGF5bG9hZFZlY3RvciBmaWx0ZXJQYXlsb2Fkcyhjb25zdCBNZWRpYVBheWxvYWRW ZWN0b3ImIHJlbW90ZVBheWxvYWRzLCBjb25zdCBNZWRpYVBheWxvYWRWZWN0b3ImIGRlZmF1bHRQ YXlsb2Fkcykgb3ZlcnJpZGU7CiAKICAgICBVcGRhdGVSZXN1bHQgdXBkYXRlUmVjZWl2ZUNvbmZp Z3VyYXRpb24oTWVkaWFFbmRwb2ludFNlc3Npb25Db25maWd1cmF0aW9uKiwgYm9vbCBpc0luaXRp YXRvcikgb3ZlcnJpZGU7Cg==