163099 2016-10-06 21:18:11 -0700 [JSC] Clean up callOperation APIs 2016-10-06 22:42:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 ysuzuki webkit-unassigned saam oldest_to_newest 1237454 0 ysuzuki 2016-10-06 21:18:11 -0700 From Saam's idea. https://bugs.webkit.org/show_bug.cgi?id=162978#c3 class Call { struct Argument { Argument(GPRReg); Argument(JSValueRegs); Argument(immediate type: int32/int64/pointer); } Type m_resultType; Vector<Arguments> m_arguments; FunctionPtr m_function; }; and then have a function like: setupCallWithExecState(const Call& call); And API should correctly construct the frame according to Vector<Arguments>. 1237481 1 saam 2016-10-06 22:42:20 -0700 (In reply to comment #0) > From Saam's idea. https://bugs.webkit.org/show_bug.cgi?id=162978#c3 > > class Call { > struct Argument { > Argument(GPRReg); > Argument(JSValueRegs); > Argument(immediate type: int32/int64/pointer); > } > Type m_resultType; > Vector<Arguments> m_arguments; > FunctionPtr m_function; > }; > > and then have a function like: > setupCallWithExecState(const Call& call); > > And API should correctly construct the frame according to Vector<Arguments>. Thinking about it more, we'd probably want to encode if the first argument is ExecState or not since we have some operations that don't take ExecState