163095 2016-10-06 17:36:58 -0700 Remove unused WebCore::contentDispositionType() 2016-10-06 17:53:47 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates achristensen darin youennf oldest_to_newest 1237412 0 dbates 2016-10-06 17:36:58 -0700 The function WebCore::contentDispositionType() (defined in HTTPParsers.h) is unused. It was first added in the patch for bug #36395 and it was only used by the Chromium and Qt ports. Both the Chromium and Qt ports have long since been removed from the repository. We should remove WebCore::contentDispositionType(). 1237415 1 290879 dbates 2016-10-06 17:40:13 -0700 Created attachment 290879 Patch 1237419 2 dbates 2016-10-06 17:53:47 -0700 Committed r206891: <http://trac.webkit.org/changeset/206891> 290879 2016-10-06 17:40:13 -0700 2016-10-06 17:42:24 -0700 Patch bug-163095-20161006173659.patch text/plain 3509 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2ODg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWMyNDIzMjE3MTZlMjFi ZmY3MDNjNDJjYzhmMjc2MGZlYzIxZTgyNS4uMmRjYmIzZWZlMWNhNDIzN2NlYzQzZDJiYjc0Yjlm NjJiZGFjZWM4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTEwLTA2ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW51c2VkIFdl YkNvcmU6OmNvbnRlbnREaXNwb3NpdGlvblR5cGUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMDk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZ1bmN0aW9uIFdlYkNvcmU6OmNvbnRlbnREaXNw b3NpdGlvblR5cGUoKSB3YXMgb25seSB1c2VkIGJ5IHRoZSBDaHJvbWl1bSBhbmQgUXQgcG9ydHMK KyAgICAgICAgdG8gcGFyc2UgdGhlIENvbnRlbnQtRGlzcG9zaXRpb24gSFRUUCBoZWFkZXIuIEJv dGggb2YgdGhlc2UgcG9ydHMgaGF2ZSBsb25nIHNpbmNlIGJlZW4KKyAgICAgICAgcmVtb3ZlZCBm cm9tIHRoZSByZXBvc2l0b3J5LiBXZSBzaG91bGQgcmVtb3ZlIFdlYkNvcmU6OmNvbnRlbnREaXNw b3NpdGlvblR5cGUoKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvSFRUUFBhcnNlcnMu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29udGVudERpc3Bvc2l0aW9uVHlwZSk6IERlbGV0ZWQu CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5oOgorCiAyMDE2LTEwLTA2 ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgT3ZlcndyaXRpbmcg YW4gYXR0cmlidXRlIGV2ZW50IGxpc3RlbmVyIGNhbiBsZWFkIHRvIHdyb25nIGV2ZW50IGxpc3Rl bmVyIGZpcmluZyBvcmRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9IVFRQUGFyc2Vycy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hU VFBQYXJzZXJzLmNwcAppbmRleCAyNzE4Y2JlMjVkNDEwZDEwOGZlMzM0ZGE4ZmYyYTM2M2Q3MjRj ODAwLi41ZmVkMzg5NTc3MzcwZDg2YWRkZmJmZDFhYWQ0MjYyYWNkMWIzZTdiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmNwcApAQCAtMTUyLDM2 ICsxNTIsNiBAQCBzdGF0aWMgU3RyaW5nIHRyaW1JbnB1dFNhbXBsZShjb25zdCBjaGFyKiBwLCBz aXplX3QgbGVuZ3RoKQogICAgIHJldHVybiBzOwogfQogCi1Db250ZW50RGlzcG9zaXRpb25UeXBl IGNvbnRlbnREaXNwb3NpdGlvblR5cGUoY29uc3QgU3RyaW5nJiBjb250ZW50RGlzcG9zaXRpb24p Ci17Ci0gICAgaWYgKGNvbnRlbnREaXNwb3NpdGlvbi5pc0VtcHR5KCkpCi0gICAgICAgIHJldHVy biBDb250ZW50RGlzcG9zaXRpb25Ob25lOwotCi0gICAgVmVjdG9yPFN0cmluZz4gcGFyYW1ldGVy czsKLSAgICBjb250ZW50RGlzcG9zaXRpb24uc3BsaXQoJzsnLCBwYXJhbWV0ZXJzKTsKLQotICAg IFN0cmluZyBkaXNwb3NpdGlvblR5cGUgPSBwYXJhbWV0ZXJzWzBdOwotICAgIGRpc3Bvc2l0aW9u VHlwZS5zdHJpcFdoaXRlU3BhY2UoKTsKLQotICAgIGlmIChlcXVhbExldHRlcnNJZ25vcmluZ0FT Q0lJQ2FzZShkaXNwb3NpdGlvblR5cGUsICJpbmxpbmUiKSkKLSAgICAgICAgcmV0dXJuIENvbnRl bnREaXNwb3NpdGlvbklubGluZTsKLQotICAgIC8vIFNvbWUgYnJva2VuIHNpdGVzIGp1c3Qgc2Vu ZCBib2d1cyBoZWFkZXJzIGxpa2UKLSAgICAvLwotICAgIC8vICAgQ29udGVudC1EaXNwb3NpdGlv bjogOyBmaWxlbmFtZT0iZmlsZSIKLSAgICAvLyAgIENvbnRlbnQtRGlzcG9zaXRpb246IGZpbGVu YW1lPSJmaWxlIgotICAgIC8vICAgQ29udGVudC1EaXNwb3NpdGlvbjogbmFtZT0iZmlsZSIKLSAg ICAvLwotICAgIC8vIHdpdGhvdXQgYSBkaXNwb3NpdGlvbiB0b2tlbi4uLiBzY3JlZW4gdGhvc2Ug b3V0LgotICAgIGlmICghaXNWYWxpZEhUVFBUb2tlbihkaXNwb3NpdGlvblR5cGUpKQotICAgICAg ICByZXR1cm4gQ29udGVudERpc3Bvc2l0aW9uTm9uZTsKLQotICAgIC8vIFdlIGhhdmUgYSBjb250 ZW50LWRpc3Bvc2l0aW9uIG9mICJhdHRhY2htZW50IiBvciB1bmtub3duLgotICAgIC8vIFJGQyAy MTgzLCBzZWN0aW9uIDIuOCBzYXlzIHRoYXQgYW4gdW5rbm93biBkaXNwb3NpdGlvbgotICAgIC8v IHZhbHVlIHNob3VsZCBiZSB0cmVhdGVkIGFzICJhdHRhY2htZW50IgotICAgIHJldHVybiBDb250 ZW50RGlzcG9zaXRpb25BdHRhY2htZW50OyAgCi19Ci0KIGJvb2wgcGFyc2VIVFRQUmVmcmVzaChj b25zdCBTdHJpbmcmIHJlZnJlc2gsIGRvdWJsZSYgZGVsYXksIFN0cmluZyYgdXJsKQogewogICAg IHVuc2lnbmVkIGxlbiA9IHJlZnJlc2gubGVuZ3RoKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmgKaW5kZXggYWRiNjBiMGE0OTQzYTE5MmM3ZDYwZDg0 OWY0OTAwYzZmNjU5MDE1NS4uMWY0YTU2NjIxNjQ1MDg3ZGE3ZGVhNTJlZGVmYWM3NmZiYWIxMzM2 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vy cy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUFBhcnNlcnMuaApA QCAtNTEsMTMgKzUxLDYgQEAgZW51bSBjbGFzcyBYU1NQcm90ZWN0aW9uRGlzcG9zaXRpb24gewog ICAgIEJsb2NrRW5hYmxlZCwKIH07CiAKLWVudW0gQ29udGVudERpc3Bvc2l0aW9uVHlwZSB7Ci0g ICAgQ29udGVudERpc3Bvc2l0aW9uTm9uZSwKLSAgICBDb250ZW50RGlzcG9zaXRpb25JbmxpbmUs Ci0gICAgQ29udGVudERpc3Bvc2l0aW9uQXR0YWNobWVudCwKLSAgICBDb250ZW50RGlzcG9zaXRp b25PdGhlcgotfTsKLQogI2lmIEVOQUJMRShOT1NOSUZGKQogZW51bSBDb250ZW50VHlwZU9wdGlv bnNEaXNwb3NpdGlvbiB7CiAgICAgQ29udGVudFR5cGVPcHRpb25zTm9uZSwKQEAgLTc0LDcgKzY3 LDYgQEAgZW51bSBYRnJhbWVPcHRpb25zRGlzcG9zaXRpb24gewogICAgIFhGcmFtZU9wdGlvbnND b25mbGljdAogfTsKIAotQ29udGVudERpc3Bvc2l0aW9uVHlwZSBjb250ZW50RGlzcG9zaXRpb25U eXBlKGNvbnN0IFN0cmluZyYpOwogYm9vbCBpc1ZhbGlkUmVhc29uUGhyYXNlKGNvbnN0IFN0cmlu ZyYpOwogYm9vbCBpc1ZhbGlkSFRUUEhlYWRlclZhbHVlKGNvbnN0IFN0cmluZyYpOwogYm9vbCBp c1ZhbGlkSFRUUFRva2VuKGNvbnN0IFN0cmluZyYpOwo=