16306 2007-12-05 05:33:25 -0800 Assertion failed in WebCore/loader/FrameLoader.cpp:4642 2007-12-05 22:58:44 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Major --- 1 oobermick darin alp darin kdecker pierre-luc.beaudoin oldest_to_newest 63328 0 oobermick 2007-12-05 05:33:25 -0800 I have just build webkit with gtk and debug and an assertion fails on startup ASSERT(!m_didDispatchDidCommitLoad); I attached to the process and I can see what is going on (fixing is a whole other ball game!) * dispatchDidCommitLoad is called and m_didDispatchDidCommitLoad is set true * checkLoadCompleteForThisFrame is called and we return early because m_creatingInitialEmptyDocument==true * dispatchDidCommitLoad is called and the assertion fails 63337 1 alp 2007-12-05 07:04:01 -0800 The assertion added in r28399 is causing this issue. 63343 2 ddkilzer 2007-12-05 08:30:00 -0800 I'm not seeing this with a local debug build of WebKit r28434 on Mac OS X 10.4.11 (8S165). 63347 3 alp 2007-12-05 08:54:13 -0800 (In reply to comment #2) > I'm not seeing this with a local debug build of WebKit r28434 on Mac OS X > 10.4.11 (8S165). > The reports of this issue I've seen have been in the GTK+, suggesting that either the assertion is identifying something we're doing wrong in the port, or the assertion is too strict and needs to be removed. 5 - added an assertion for a situation that leads to a Safari assertion: 6 a commit that is not followed by a load completion http://trac.webkit.org/projects/webkit/changeset/28399 Sounds like this may be a bug we need to fix in the GTK+ port rather than just removing the assertion and moving on. Darin, Kevin, any thoughts? 63359 4 17720 darin 2007-12-05 10:44:34 -0800 Created attachment 17720 patch 63365 5 17720 aroben 2007-12-05 11:07:05 -0800 Comment on attachment 17720 patch r=me 17720 2007-12-05 10:44:34 -0800 2007-12-05 11:07:05 -0800 patch AssertPatch.txt text/plain 1596 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODQ0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMTItMDUgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzA2CisgICAgICAgICAg QXNzZXJ0aW9uIGZhaWxlZCBpbiBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHA6NDY0Mgor CisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZy YW1lTG9hZGVyOjpkaXNwYXRjaERpZENvbW1pdExvYWQpOiBDaGVjayBtX2NyZWF0aW5nSW5pdGlh bEVtcHR5RG9jdW1lbnQKKyAgICAgICAgYW5kIGRvbid0IGRlbGl2ZXIgdGhlIGNsaWVudCBjYWxs IGluIHRoYXQgY2FzZS4KKwogMjAwNy0xMi0wNCAgQWxwIFRva2VyICA8YWxwQGF0b2tlci5jb20+ CiAKICAgICAgICAgUG90ZW50aWFsIEdUSysgYnVpbGQgZml4IGZvciB0aGUgZ2xpYi1nZW5tYXJz aGFsIGlzc3VlLgpJbmRleDogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gMjg0NDEpCisr KyBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUwNiw3 ICs1MDYsNyBAQCB2b2lkIEZyYW1lTG9hZGVyOjpzdWJtaXRGb3JtQWdhaW4oKQogdm9pZCBGcmFt ZUxvYWRlcjo6c3VibWl0Rm9ybShjb25zdCBjaGFyKiBhY3Rpb24sIGNvbnN0IFN0cmluZyYgdXJs LCBQYXNzUmVmUHRyPEZvcm1EYXRhPiBmb3JtRGF0YSwKICAgICBjb25zdCBTdHJpbmcmIHRhcmdl dCwgY29uc3QgU3RyaW5nJiBjb250ZW50VHlwZSwgY29uc3QgU3RyaW5nJiBib3VuZGFyeSwgRXZl bnQqIGV2ZW50KQogewotICAgIEFTU0VSVChmb3JtRGF0YS5nZXQoKSk7CisgICAgQVNTRVJUKGZv cm1EYXRhKTsKICAgICAKICAgICBLVVJMIHUgPSBjb21wbGV0ZVVSTCh1cmwuaXNOdWxsKCkgPyAi IiA6IHVybCk7CiAgICAgLy8gRklYTUU6IERvIHdlIHJlYWxseSBuZWVkIHRvIHNwZWNpYWwtY2Fz ZSBhbiBlbXB0eSBVUkw/CkBAIC00NjM4LDYgKzQ2MzgsOSBAQCBib29sIEZyYW1lTG9hZGVyOjpz aG91bGRUcmVhdFNjaGVtZUFzTG9jCiAKIHZvaWQgRnJhbWVMb2FkZXI6OmRpc3BhdGNoRGlkQ29t bWl0TG9hZCgpCiB7CisgICAgaWYgKG1fY3JlYXRpbmdJbml0aWFsRW1wdHlEb2N1bWVudCkKKyAg ICAgICAgcmV0dXJuOworCiAjaWZuZGVmIE5ERUJVRwogICAgIEFTU0VSVCghbV9kaWREaXNwYXRj aERpZENvbW1pdExvYWQpOwogICAgIG1fZGlkRGlzcGF0Y2hEaWRDb21taXRMb2FkID0gdHJ1ZTsK