16305 2007-12-05 02:37:22 -0800 Width of svg elements not applied to container elements 2007-12-15 12:03:52 -0800 1 1 1 Unclassified WebKit SVG 523.x (Safari 3) All All RESOLVED FIXED HasReduction P2 Normal --- 1 yoah webkit-unassigned eric oldest_to_newest 63325 0 yoah 2007-12-05 02:37:22 -0800 When adding svg element into the dom, the width of the element is not applied to the width of it's parent (the height is properly applied). Included is a simple example where an svg element is added into a table cell. Note that the row height is correctly set, but the cell width is not. <!DOCTYPE HTML> <html> <head> <title>WebKit SVG Bug</title> <script type="text/javascript"> function draw() { var NS = "http://www.w3.org/2000/svg"; var s = document.createElementNS(NS, "svg"); s.setAttribute("width", 400); s.setAttribute("height", 200); var rect = document.createElementNS(NS, "rect"); rect.setAttribute("x", "0"); rect.setAttribute("y", "0"); rect.setAttribute("width", "400"); rect.setAttribute("height", "200"); rect.setAttribute("fill", "yellow"); s.appendChild(rect); document.getElementById("d").appendChild(s); } </script> </head> <body onload="draw()"> <table border="1"> <tr> <td>X</td> <td id="d"></td> </tr> </table> </body> </html> 63326 1 17716 yoah 2007-12-05 02:39:13 -0800 Created attachment 17716 Simple problem demo with an svg rectangle 63342 2 ddkilzer 2007-12-05 08:26:27 -0800 Confirmed with a local debug build of WebKit r28434 with Safari 3.0.4 (523.12) on Mac OS X 10.4.11 (8S165). 64250 3 eric 2007-12-15 01:37:52 -0800 I doubt this has much to do with <svg>. This should basically function the same as <img>, I wonder if <img> works in this case. Cool bug though. 64256 4 eric 2007-12-15 02:20:18 -0800 This also shows the bug: <html> <head> <script type="text/javascript"> function draw() { var NS = "http://www.w3.org/2000/svg"; var s = document.createElementNS(NS, "svg"); s.setAttribute("width", 400); s.setAttribute("height", 200); var rect = document.createElementNS(NS, "rect"); rect.setAttribute("width", "100%"); rect.setAttribute("height", "100%"); rect.setAttribute("fill", "yellow"); s.appendChild(rect); document.getElementById("d").appendChild(s); } </script> </head> <body onload="draw()"> <div style="border: 3px solid black; float: left;" id="d"></div> </body> </html> Interestingly, Firefox seems to have the same bug in the float case. Opera does not. 64258 5 17909 eric 2007-12-15 02:44:29 -0800 Created attachment 17909 Add RenderSVGRoot::calcPrefWidth and test case LayoutTests/ChangeLog | 12 +++++++++ .../svg/css/css-box-min-width-expected.checksum | 1 + .../mac/svg/css/css-box-min-width-expected.png | Bin 0 -> 7834 bytes .../mac/svg/css/css-box-min-width-expected.txt | 11 ++++++++ LayoutTests/svg/css/css-box-min-width.html | 26 ++++++++++++++++++++ WebCore/ChangeLog | 15 +++++++++++ WebCore/rendering/RenderSVGRoot.cpp | 14 ++++++++++ WebCore/rendering/RenderSVGRoot.h | 1 + 8 files changed, 80 insertions(+), 0 deletions(-) 64312 6 eric 2007-12-15 12:03:52 -0800 Landed as r28755 17716 2007-12-05 02:39:13 -0800 2007-12-05 02:39:13 -0800 Simple problem demo with an svg rectangle webkitsvgwidth.html text/html 778 yoah PCFET0NUWVBFIEhUTUw+CjxodG1sPgo8aGVhZD4KICA8dGl0bGU+V2ViS2l0IFNWRyBCdWc8L3Rp dGxlPgogIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KICAgIGZ1bmN0aW9uIGRyYXco KSB7CiAgICAgIHZhciBOUyA9ICJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI7CiAgICAgIHZh ciBzID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudE5TKE5TLCAic3ZnIik7DQogICAgICBzLnNldEF0 dHJpYnV0ZSgid2lkdGgiLCA0MDApOw0KICAgICAgcy5zZXRBdHRyaWJ1dGUoImhlaWdodCIsIDIw MCk7DQoNCiAgICAgIHZhciByZWN0ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudE5TKE5TLCAicmVj dCIpOw0KICAgICAgcmVjdC5zZXRBdHRyaWJ1dGUoIngiLCAiMCIpOw0KICAgICAgcmVjdC5zZXRB dHRyaWJ1dGUoInkiLCAiMCIpOwogICAgICByZWN0LnNldEF0dHJpYnV0ZSgid2lkdGgiLCAiNDAw Iik7DQogICAgICByZWN0LnNldEF0dHJpYnV0ZSgiaGVpZ2h0IiwgIjIwMCIpOw0KICAgICAgcmVj dC5zZXRBdHRyaWJ1dGUoImZpbGwiLCAieWVsbG93Iik7DQoKICAgICAgcy5hcHBlbmRDaGlsZChy ZWN0KTsKICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImQiKS5hcHBlbmRDaGlsZChzKTsN CiAgIH0KICA8L3NjcmlwdD4KCjwvaGVhZD4KCjxib2R5IG9ubG9hZD0iZHJhdygpIj4KPHRhYmxl IGJvcmRlcj0iMSI+DQogIDx0cj4NCiAgICA8dGQ+WDwvdGQ+DQogICAgPHRkIGlkPSJkIj48L3Rk Pg0KICA8L3RyPg0KPC90YWJsZT4NCjwvYm9keT4KPC9odG1sPg== 17909 2007-12-15 02:44:29 -0800 2007-12-15 11:57:09 -0800 Add RenderSVGRoot::calcPrefWidth and test case Add-RenderSVGRoot-calcPrefWidth-and-test-case.patch text/plain 5552 eric MjQ0OGUxOWZlYjE0NTMyMzE5ZGJlMDVhMzU2YzIyNmNmYjJjODE5NgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDU3NDMzOGMu LjgwYzkwMTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwNy0xMi0xNSAgRXJpYyBTZWlkZWwg IDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisgICAgICAgIAorICAgICAgICBXaWR0aCBvZiBTVkcgZWxlbWVudHMgbm90IGFwcGxpZWQgdG8g Y29udGFpbmVyIGVsZW1lbnRzCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2MzA1CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvc3ZnL2Nzcy9jc3MtYm94 LW1pbi13aWR0aC1leHBlY3RlZC5jaGVja3N1bTogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0v bWFjL3N2Zy9jc3MvY3NzLWJveC1taW4td2lkdGgtZXhwZWN0ZWQucG5nOiBBZGRlZC4KKyAgICAg ICAgKiBwbGF0Zm9ybS9tYWMvc3ZnL2Nzcy9jc3MtYm94LW1pbi13aWR0aC1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIHN2Zy9jc3MvY3NzLWJveC1taW4td2lkdGguaHRtbDogQWRkZWQu CisKIDIwMDctMTItMTUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9zdmcvY3NzL2Nzcy1ib3gtbWluLXdpZHRoLWV4cGVjdGVkLmNoZWNrc3VtIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jc3MvY3NzLWJveC1taW4td2lkdGgtZXhwZWN0ZWQu Y2hlY2tzdW0KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZDQ1ZjljNgotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9zdmcvY3NzL2Nzcy1ib3gt bWluLXdpZHRoLWV4cGVjdGVkLmNoZWNrc3VtCkBAIC0wLDAgKzEgQEAKKzY1OGJiODk5YTMwOWIw OTU0MGZlMWQ3ODY4ODM1ZTU4ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jc3MvY3NzLWJveC1taW4td2lkdGgtZXhw ZWN0ZWQucG5nIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jc3MvY3NzLWJveC1taW4t d2lkdGgtZXhwZWN0ZWQucG5nCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjEy ZDlhNWYKQmluYXJ5IGZpbGVzIC9kZXYvbnVsbCBhbmQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvc3ZnL2Nzcy9jc3MtYm94LW1pbi13aWR0aC1leHBlY3RlZC5wbmcgZGlmZmVyCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL2Nzcy9jc3MtYm94LW1pbi13aWR0aC1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL2Nzcy9jc3MtYm94LW1p bi13aWR0aC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4u MDk2OTdmMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9zdmcv Y3NzL2Nzcy1ib3gtbWluLXdpZHRoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDExIEBACitsYXll ciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgwMHg2 MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJCbG9jayB7SFRNTH0gYXQg KDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsOCkgc2l6ZSA3 ODR4NTc2CisgICAgICBSZW5kZXJCbG9jayAoZmxvYXRpbmcpIHtESVZ9IGF0ICgwLDApIHNpemUg MTEweDExMCBbYm9yZGVyOiAoNXB4IHNvbGlkICMwMDAwMDApXQorICAgICAgICBSZW5kZXJTVkdS b290IHtzdmd9IGF0ICgxMywxMykgc2l6ZSAxMDB4MTAwCisgICAgICAgICAgUmVuZGVyUGF0aCB7 cmVjdH0gYXQgKDEzLDEzKSBzaXplIDEwMHgxMDAgW2ZpbGw9e1t0eXBlPVNPTElEXSBbY29sb3I9 IzAwMDBGRl19XSBbZGF0YT0iTTAuMDAsMC4wMEwxMDAuMDAsMC4wMEwxMDAuMDAsMTAwLjAwTDAu MDAsMTAwLjAwIl0KKyAgICAgIFJlbmRlckJsb2NrIHtQfSBhdCAoMCwxMTApIHNpemUgNzg0eDE4 CisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDQzNXgxOAorICAgICAg ICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDQzNTogIllvdSBzaG91bGQgc2VlIGEgc29saWQg NXB4IGJsYWNrIGJvcmRlciBhcm91bmQgYSAxMDB4MTAwIGJsdWUgcmVjdC4iCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9zdmcvY3NzL2Nzcy1ib3gtbWluLXdpZHRoLmh0bWwgYi9MYXlvdXRUZXN0 cy9zdmcvY3NzL2Nzcy1ib3gtbWluLXdpZHRoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uYTJjMzJkYgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9j c3MvY3NzLWJveC1taW4td2lkdGguaHRtbApAQCAtMCwwICsxLDI2IEBACis8aHRtbD4KKzxoZWFk PgorICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisgICAgZnVuY3Rpb24gZHJhdygp IHsKKyAgICAgIHZhciBOUyA9ICJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI7CisgICAgICB2 YXIgcyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnROUyhOUywgInN2ZyIpOworICAgICAgcy5zZXRB dHRyaWJ1dGUoIndpZHRoIiwgMTAwKTsKKyAgICAgIHMuc2V0QXR0cmlidXRlKCJoZWlnaHQiLCAx MDApOworICAgICAgCisgICAgICB2YXIgcmVjdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnROUyhO UywgInJlY3QiKTsKKyAgICAgIHJlY3Quc2V0QXR0cmlidXRlKCJ3aWR0aCIsICIxMDAlIik7Cisg ICAgICByZWN0LnNldEF0dHJpYnV0ZSgiaGVpZ2h0IiwgIjEwMCUiKTsKKyAgICAgIHJlY3Quc2V0 QXR0cmlidXRlKCJmaWxsIiwgImJsdWUiKTsKKyAgICAgIAorICAgICAgcy5hcHBlbmRDaGlsZChy ZWN0KTsKKyAgICAgIAorICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImQiKS5hcHBlbmRD aGlsZChzKTsKKyAgIH0KKyAgPC9zY3JpcHQ+Cis8L2hlYWQ+CisKKzxib2R5IG9ubG9hZD0iZHJh dygpIj4KKyAgPGRpdiBzdHlsZT0iYm9yZGVyOiA1cHggc29saWQgYmxhY2s7IGZsb2F0OiBsZWZ0 OyIgaWQ9ImQiPjwvZGl2PgorICA8cCBzdHlsZT0iY2xlYXI6IGxlZnQ7Ij5Zb3Ugc2hvdWxkIHNl ZSBhIHNvbGlkIDVweCBibGFjayBib3JkZXIgYXJvdW5kIGEgMTAweDEwMCBibHVlIHJlY3QuPC9w PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCBlNTYyZTYwLi5hMTVhM2ZjIDEwMDY0NAotLS0gYS9XZWJDb3Jl L0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDA3 LTEyLTE1ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFdpZHRoIG9mIFNWRyBlbGVt ZW50cyBub3QgYXBwbGllZCB0byBjb250YWluZXIgZWxlbWVudHMKKyAgICAgICAgaHR0cDovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMDUKKyAgICAgICAgQWRkZWQgY2FsY1By ZWZXaWR0aHMgZm9yIFJlbmRlclNWR1Jvb3QgKGNvcGllZCBmcm9tIFJlbmRlclJlcGxhY2VkKQor ICAgICAgICBUaGlzIGlzIGNhdXNlZCBieSBwb29yIGZhY3RvcmluZyBpbiB0aGUgcmVuZGVyIHRy ZWUuICBSZW5kZXJDb250YWluZXIgcHJvYmFibHkgc2hvdWxkIGJlIGEgdGVtcGxhdGUuCisKKyAg ICAgICAgc3ZnL2Nzcy9jc3MtYm94LW1pbi13aWR0aC5odG1sCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyU1ZHUm9vdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdSb290Ojpj YWxjUHJlZldpZHRocyk6IEFkZGVkLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJTVkdSb290 Lmg6CisKIDIwMDctMTItMTUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyU1ZHUm9vdC5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTVkdSb290LmNw cAppbmRleCBhYTJmMmNhLi4wNjg0YjA4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJTVkdSb290LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTVkdSb290LmNw cApAQCAtNjEsNiArNjEsMjAgQEAgc2hvcnQgUmVuZGVyU1ZHUm9vdDo6YmFzZWxpbmVQb3NpdGlv bihib29sIGIsIGJvb2wgaXNSb290TGluZUJveCkgY29uc3QKICAgICByZXR1cm4gaGVpZ2h0KCkg KyBtYXJnaW5Ub3AoKSArIG1hcmdpbkJvdHRvbSgpOwogfQogCit2b2lkIFJlbmRlclNWR1Jvb3Q6 OmNhbGNQcmVmV2lkdGhzKCkKK3sKKyAgICBBU1NFUlQocHJlZldpZHRoc0RpcnR5KCkpOworCisg ICAgaW50IHdpZHRoID0gY2FsY1JlcGxhY2VkV2lkdGgoKSArIHBhZGRpbmdMZWZ0KCkgKyBwYWRk aW5nUmlnaHQoKSArIGJvcmRlckxlZnQoKSArIGJvcmRlclJpZ2h0KCk7CisgICAgaWYgKHN0eWxl KCktPndpZHRoKCkuaXNQZXJjZW50KCkgfHwgKHN0eWxlKCktPndpZHRoKCkuaXNBdXRvKCkgJiYg c3R5bGUoKS0+aGVpZ2h0KCkuaXNQZXJjZW50KCkpKSB7CisgICAgICAgIG1fbWluUHJlZldpZHRo ID0gMDsKKyAgICAgICAgbV9tYXhQcmVmV2lkdGggPSB3aWR0aDsKKyAgICB9IGVsc2UKKyAgICAg ICAgbV9taW5QcmVmV2lkdGggPSBtX21heFByZWZXaWR0aCA9IHdpZHRoOworCisgICAgc2V0UHJl ZldpZHRoc0RpcnR5KGZhbHNlKTsKK30KKwogdm9pZCBSZW5kZXJTVkdSb290OjpsYXlvdXQoKQog ewogICAgIEFTU0VSVChuZWVkc0xheW91dCgpKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclNWR1Jvb3QuaCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR1Jvb3QuaApp bmRleCA1ZjRlNGIwLi4xZTEzNmIzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJTVkdSb290LmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU1ZHUm9vdC5oCkBAIC00 Miw2ICs0Miw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgc2hvcnQgbGluZUhlaWdodChib29s IGIsIGJvb2wgaXNSb290TGluZUJveCA9IGZhbHNlKSBjb25zdDsKICAgICB2aXJ0dWFsIHNob3J0 IGJhc2VsaW5lUG9zaXRpb24oYm9vbCBiLCBib29sIGlzUm9vdExpbmVCb3ggPSBmYWxzZSkgY29u c3Q7CisgICAgdmlydHVhbCB2b2lkIGNhbGNQcmVmV2lkdGhzKCk7CiAgICAgCiAgICAgdmlydHVh bCB2b2lkIGxheW91dCgpOwogICAgIHZpcnR1YWwgdm9pZCBwYWludChQYWludEluZm8mLCBpbnQg cGFyZW50WCwgaW50IHBhcmVudFkpOwo=