163039 2016-10-06 11:18:56 -0700 Web Inspector: RemoteInspector should cache client capabilities for off-main thread usage 2016-10-06 12:48:26 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1237174 0 bburg 2016-10-06 11:18:56 -0700 Take two. 1237184 1 bburg 2016-10-06 11:21:08 -0700 <rdar://problem/28571460> 1237235 2 290847 bburg 2016-10-06 12:14:28 -0700 Created attachment 290847 Proposed Fix 1237263 3 290847 commit-queue 2016-10-06 12:48:22 -0700 Comment on attachment 290847 Proposed Fix Clearing flags on attachment: 290847 Committed r206875: <http://trac.webkit.org/changeset/206875> 1237264 4 commit-queue 2016-10-06 12:48:26 -0700 All reviewed patches have been landed. Closing bug. 290847 2016-10-06 12:14:28 -0700 2016-10-06 12:48:22 -0700 Proposed Fix bug-163039-20161006121114.patch text/plain 6812 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2ODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MWE3ZDA5YWYwZDg3MDhjYTE1OTJlMTlmODgyZDFkYTJmMjM3YjE4Li4yNmM0ZjI3MDIzYTlmNTlm ZTk5Y2Q5YThmNzZhYTA1ZWI0Y2Q4MDRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxNi0xMC0wNiAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdGVJbnNwZWN0b3Igc2hvdWxkIGNhY2hlIGNsaWVu dCBjYXBhYmlsaXRpZXMgZm9yIG9mZi1tYWluIHRocmVhZCB1c2FnZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMDM5CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8yODU3MTQ2MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgZml4IGluIHIyMDY3OTcgd2FzIGluY29ycmVjdCBiZWNhdXNlIGxpc3Rp bmdzIGFyZSBhbHdheXMgcHVzaGVkIG91dCBvbiB0aGUgWFBDIGNvbm5lY3Rpb24gcXVldWUuCisg ICAgICAgIEluc3RlYWQgb2YgZGVsYXlpbmcgdGhlIGxpc3RpbmcgbmVlZGxlc3NseSwgUmVtb3Rl SW5zcGVjdG9yIHNob3VsZCBjYWNoZSB0aGUgY2FwYWJpbGl0aWVzIG9mIGl0cworICAgICAgICBj bGllbnQgd2hpbGUgb24gdGhlIG1haW4gdGhyZWFkLCB0aGVuIHVzZSB0aGUgY2FjaGVkIHN0cnVj dCBkYXRhIG9uIHRoZSBYUEMgY29ubmVjdGlvbiBxdWV1ZSByYXRoZXIKKyAgICAgICAgdGhhbiBk aXJlY3RseSBhY2Nlc3NpbmcgbV9jbGllbnQuIFRoaXMgaXMgc2ltaWxhciB0byBob3cgUmVtb3Rl Q29ubmVjdGlvblRvVGFyZ2V0IG1hcnNoYWxscyBsaXN0aW5nCisgICAgICAgIGluZm9ybWF0aW9u IGZyb20gYXJiaXRyYXJ5IHF1ZXVlcyBpbnRvIG1fdGFyZ2V0TGlzdGluZ01hcCwgd2hpY2ggY2Fu IHRoZW4gYmUgcmVhZCBmcm9tIGFueSBxdWV1ZS4KKworICAgICAgICAqIGluc3BlY3Rvci9yZW1v dGUvUmVtb3RlSW5zcGVjdG9yLmg6CisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJ bnNwZWN0b3IubW06CisgICAgICAgIChJbnNwZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6dXBkYXRl Q2xpZW50Q2FwYWJpbGl0aWVzKTogQ2FjaGUgdGhlIGNhcGFiaWxpdGllcy4KKyAgICAgICAgKElu c3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9yOjpzZXRSZW1vdGVJbnNwZWN0b3JDbGllbnQpOgorICAg ICAgICBSZS1jYWNoZSB0aGUgY2FwYWJpbGl0aWVzLiBTY29wZSB0aGUgbG9jayB0byBhdm9pZCBy ZWVudHJhbnQgbG9ja2luZy4KKworICAgICAgICAoSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3I6 OmNsaWVudENhcGFiaWxpdGllc0RpZENoYW5nZSk6IENhY2hlIHRoZSBjYXBhYmlsaXRpZXMuCisg ICAgICAgIChJbnNwZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6cHVzaExpc3RpbmdzTm93KTogVXNl IGNhY2hlZCBjbGllbnQgY2FwYWJpbGl0aWVzLgorICAgICAgICAoSW5zcGVjdG9yOjpSZW1vdGVJ bnNwZWN0b3I6OnJlY2VpdmVkR2V0TGlzdGluZ01lc3NhZ2UpOiBSZXZlcnQgdGhlIGNoYW5nZSBp biByMjA2Nzk3LgorICAgICAgICAoSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3I6OnJlY2VpdmVk QXV0b21hdGlvblNlc3Npb25SZXF1ZXN0TWVzc2FnZSk6CisKIDIwMTYtMTAtMDUgIFl1c3VrZSBT dXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0pTQ10gQWRkIEB0aHJv d1hYWEVycm9yIGJ5dGVjb2RlIGludHJpbnNpYwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmggYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IuaAppbmRleCA3M2M4YWEz ODZlOWZkNTBhNjU2MmVjN2ExNjMzNzM5N2FmNjk2YmYxLi40ZWE3ZjM5MjVmOGQzZWI5ZmJkNjY4 ZDJjMjlhZDUzYmY5YWE2N2E1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5z cGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IuaApAQCAtNDgsNiArNDgsMTAgQEAg Y2xhc3MgSlNfRVhQT1JUX1BSSVZBVEUgUmVtb3RlSW5zcGVjdG9yIGZpbmFsIDogcHVibGljIFJl bW90ZUluc3BlY3RvclhQQ0Nvbm5lY3QKIHB1YmxpYzoKICAgICBjbGFzcyBDbGllbnQgewogICAg IHB1YmxpYzoKKyAgICAgICAgc3RydWN0IENhcGFiaWxpdGllcyB7CisgICAgICAgICAgICBib29s IHJlbW90ZUF1dG9tYXRpb25BbGxvd2VkIDogMTsKKyAgICAgICAgfTsKKwogICAgICAgICB2aXJ0 dWFsIH5DbGllbnQoKSB7IH0KICAgICAgICAgdmlydHVhbCBib29sIHJlbW90ZUF1dG9tYXRpb25B bGxvd2VkKCkgY29uc3QgPSAwOwogICAgICAgICB2aXJ0dWFsIHZvaWQgcmVxdWVzdEF1dG9tYXRp b25TZXNzaW9uKGNvbnN0IFN0cmluZyYgc2Vzc2lvbklkZW50aWZpZXIpID0gMDsKQEAgLTYyLDEz ICs2NiwxMyBAQCBwdWJsaWM6CiAgICAgdm9pZCB1cGRhdGVUYXJnZXQoUmVtb3RlQ29udHJvbGxh YmxlVGFyZ2V0Kik7CiAgICAgdm9pZCBzZW5kTWVzc2FnZVRvUmVtb3RlKHVuc2lnbmVkIHRhcmdl dElkZW50aWZpZXIsIGNvbnN0IFN0cmluZyYgbWVzc2FnZSk7CiAKLSAgICB2b2lkIHVwZGF0ZUF1 dG9tYXRpY0luc3BlY3Rpb25DYW5kaWRhdGUoUmVtb3RlSW5zcGVjdGlvblRhcmdldCopOwogICAg IHZvaWQgc2V0UmVtb3RlSW5zcGVjdG9yQ2xpZW50KFJlbW90ZUluc3BlY3Rvcjo6Q2xpZW50Kik7 CisgICAgdm9pZCBjbGllbnRDYXBhYmlsaXRpZXNEaWRDaGFuZ2UoKTsKIAogICAgIHZvaWQgc2V0 dXBGYWlsZWQodW5zaWduZWQgdGFyZ2V0SWRlbnRpZmllcik7CiAgICAgdm9pZCBzZXR1cENvbXBs ZXRlZCh1bnNpZ25lZCB0YXJnZXRJZGVudGlmaWVyKTsKICAgICBib29sIHdhaXRpbmdGb3JBdXRv bWF0aWNJbnNwZWN0aW9uKHVuc2lnbmVkIHRhcmdldElkZW50aWZpZXIpOwotICAgIHZvaWQgY2xp ZW50Q2FwYWJpbGl0aWVzRGlkQ2hhbmdlKCkgeyBwdXNoTGlzdGluZ3NTb29uKCk7IH0KKyAgICB2 b2lkIHVwZGF0ZUF1dG9tYXRpY0luc3BlY3Rpb25DYW5kaWRhdGUoUmVtb3RlSW5zcGVjdGlvblRh cmdldCopOwogCiAgICAgYm9vbCBlbmFibGVkKCkgY29uc3QgeyByZXR1cm4gbV9lbmFibGVkOyB9 CiAgICAgYm9vbCBoYXNBY3RpdmVEZWJ1Z1Nlc3Npb24oKSBjb25zdCB7IHJldHVybiBtX2hhc0Fj dGl2ZURlYnVnU2Vzc2lvbjsgfQpAQCAtOTksNiArMTAzLDcgQEAgcHJpdmF0ZToKICAgICB2b2lk IHB1c2hMaXN0aW5nc1Nvb24oKTsKIAogICAgIHZvaWQgdXBkYXRlSGFzQWN0aXZlRGVidWdTZXNz aW9uKCk7CisgICAgdm9pZCB1cGRhdGVDbGllbnRDYXBhYmlsaXRpZXMoKTsKIAogICAgIHZvaWQg c2VuZEF1dG9tYXRpY0luc3BlY3Rpb25DYW5kaWRhdGVNZXNzYWdlKCk7CiAKQEAgLTEzMiw2ICsx MzcsNyBAQCBwcml2YXRlOgogICAgIFJlZlB0cjxSZW1vdGVJbnNwZWN0b3JYUENDb25uZWN0aW9u PiBtX3JlbGF5Q29ubmVjdGlvbjsKIAogICAgIFJlbW90ZUluc3BlY3Rvcjo6Q2xpZW50KiBtX2Ns aWVudCB7IG51bGxwdHIgfTsKKyAgICBPcHRpb25hbDxSZW1vdGVJbnNwZWN0b3I6OkNsaWVudDo6 Q2FwYWJpbGl0aWVzPiBtX2NsaWVudENhcGFiaWxpdGllczsKIAogICAgIGRpc3BhdGNoX3F1ZXVl X3QgbV94cGNRdWV1ZTsKICAgICB1bnNpZ25lZCBtX25leHRBdmFpbGFibGVUYXJnZXRJZGVudGlm aWVyIHsgMSB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9y ZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rv ci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tCmluZGV4IGMzMGVkOWVmYjhmYWQ0MjIzOWEwN2Yw NzE4NGM2NWRkZTM5NDU5MWIuLmNiMGJhY2RmNmYzMGVjM2Y1NmQxZTQ0YWE5YWViODQ2NTU2ODI2 N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1Jl bW90ZUluc3BlY3Rvci5tbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Jl bW90ZS9SZW1vdGVJbnNwZWN0b3IubW0KQEAgLTI0OSwxNSArMjQ5LDM1IEBAIHZvaWQgUmVtb3Rl SW5zcGVjdG9yOjp1cGRhdGVBdXRvbWF0aWNJbnNwZWN0aW9uQ2FuZGlkYXRlKFJlbW90ZUluc3Bl Y3Rpb25UYXJnZXQqCiAgICAgfQogfQogCit2b2lkIFJlbW90ZUluc3BlY3Rvcjo6dXBkYXRlQ2xp ZW50Q2FwYWJpbGl0aWVzKCkKK3sKKyAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOworCisgICAg c3RkOjpsb2NrX2d1YXJkPExvY2s+IGxvY2sobV9tdXRleCk7CisKKyAgICBpZiAoIW1fY2xpZW50 KQorICAgICAgICBtX2NsaWVudENhcGFiaWxpdGllcyA9IE51bGxvcHQ7CisgICAgZWxzZSB7Cisg ICAgICAgIFJlbW90ZUluc3BlY3Rvcjo6Q2xpZW50OjpDYXBhYmlsaXRpZXMgdXBkYXRlZENhcGFi aWxpdGllcyA9IHsKKyAgICAgICAgICAgIG1fY2xpZW50LT5yZW1vdGVBdXRvbWF0aW9uQWxsb3dl ZCgpIC8vIHJlbW90ZUF1dG9tYXRpb25BbGxvd2VkCisgICAgICAgIH07CisKKyAgICAgICAgbV9j bGllbnRDYXBhYmlsaXRpZXMgPSB1cGRhdGVkQ2FwYWJpbGl0aWVzOworICAgIH0KK30KKwogdm9p ZCBSZW1vdGVJbnNwZWN0b3I6OnNldFJlbW90ZUluc3BlY3RvckNsaWVudChSZW1vdGVJbnNwZWN0 b3I6OkNsaWVudCogY2xpZW50KQogewogICAgIEFTU0VSVF9BUkcoY2xpZW50LCBjbGllbnQpOwog ICAgIEFTU0VSVCghbV9jbGllbnQpOwogCi0gICAgc3RkOjpsb2NrX2d1YXJkPExvY2s+IGxvY2so bV9tdXRleCk7Ci0gICAgbV9jbGllbnQgPSBjbGllbnQ7CisgICAgeworICAgICAgICBzdGQ6Omxv Y2tfZ3VhcmQ8TG9jaz4gbG9jayhtX211dGV4KTsKKyAgICAgICAgbV9jbGllbnQgPSBjbGllbnQ7 CisgICAgfQogCiAgICAgLy8gU2VuZCBhbiB1cGRhdGVkIGxpc3RpbmcgdGhhdCBpbmNsdWRlcyB3 aGV0aGVyIHRoZSBjbGllbnQgYWxsb3dzIHJlbW90ZSBhdXRvbWF0aW9uLgorICAgIHVwZGF0ZUNs aWVudENhcGFiaWxpdGllcygpOwogICAgIHB1c2hMaXN0aW5nc1Nvb24oKTsKIH0KIApAQCAtMzIx LDYgKzM0MSwxMiBAQCBib29sIFJlbW90ZUluc3BlY3Rvcjo6d2FpdGluZ0ZvckF1dG9tYXRpY0lu c3BlY3Rpb24odW5zaWduZWQpCiAgICAgcmV0dXJuIG1fYXV0b21hdGljSW5zcGVjdGlvblBhdXNl ZDsKIH0KIAordm9pZCBSZW1vdGVJbnNwZWN0b3I6OmNsaWVudENhcGFiaWxpdGllc0RpZENoYW5n ZSgpCit7CisgICAgdXBkYXRlQ2xpZW50Q2FwYWJpbGl0aWVzKCk7CisgICAgcHVzaExpc3Rpbmdz U29vbigpOworfQorCiB2b2lkIFJlbW90ZUluc3BlY3Rvcjo6c3RhcnQoKQogewogICAgIHN0ZDo6 bG9ja19ndWFyZDxMb2NrPiBsb2NrKG1fbXV0ZXgpOwpAQCAtNTY3LDcgKzU5Myw3IEBAIHZvaWQg UmVtb3RlSW5zcGVjdG9yOjpwdXNoTGlzdGluZ3NOb3coKQogICAgIFJldGFpblB0cjxOU011dGFi bGVEaWN0aW9uYXJ5PiBtZXNzYWdlID0gYWRvcHROUyhbW05TTXV0YWJsZURpY3Rpb25hcnkgYWxs b2NdIGluaXRdKTsKICAgICBbbWVzc2FnZSBzZXRPYmplY3Q6bGlzdGluZ3MuZ2V0KCkgZm9yS2V5 OldJUkxpc3RpbmdLZXldOwogCi0gICAgQk9PTCBpc0FsbG93ZWQgPSBtX2NsaWVudCAmJiBtX2Ns aWVudC0+cmVtb3RlQXV0b21hdGlvbkFsbG93ZWQoKTsKKyAgICBCT09MIGlzQWxsb3dlZCA9IG1f Y2xpZW50Q2FwYWJpbGl0aWVzICYmIG1fY2xpZW50Q2FwYWJpbGl0aWVzLT5yZW1vdGVBdXRvbWF0 aW9uQWxsb3dlZDsKICAgICBbbWVzc2FnZSBzZXRPYmplY3Q6QChpc0FsbG93ZWQpIGZvcktleTpX SVJSZW1vdGVBdXRvbWF0aW9uRW5hYmxlZEtleV07CiAKICAgICBtX3JlbGF5Q29ubmVjdGlvbi0+ c2VuZE1lc3NhZ2UoV0lSTGlzdGluZ01lc3NhZ2UsIG1lc3NhZ2UuZ2V0KCkpOwpAQCAtNjk2LDcg KzcyMiw3IEBAIHZvaWQgUmVtb3RlSW5zcGVjdG9yOjpyZWNlaXZlZERpZENsb3NlTWVzc2FnZShO U0RpY3Rpb25hcnkgKnVzZXJJbmZvKQogCiB2b2lkIFJlbW90ZUluc3BlY3Rvcjo6cmVjZWl2ZWRH ZXRMaXN0aW5nTWVzc2FnZShOU0RpY3Rpb25hcnkgKikKIHsKLSAgICBwdXNoTGlzdGluZ3NTb29u KCk7CisgICAgcHVzaExpc3RpbmdzTm93KCk7CiB9CiAKIHZvaWQgUmVtb3RlSW5zcGVjdG9yOjpy ZWNlaXZlZEluZGljYXRlTWVzc2FnZShOU0RpY3Rpb25hcnkgKnVzZXJJbmZvKQpAQCAtNzk0LDcg KzgyMCw3IEBAIHZvaWQgUmVtb3RlSW5zcGVjdG9yOjpyZWNlaXZlZEF1dG9tYXRpb25TZXNzaW9u UmVxdWVzdE1lc3NhZ2UoTlNEaWN0aW9uYXJ5ICp1c2VyCiAgICAgaWYgKCFtX2NsaWVudCkKICAg ICAgICAgcmV0dXJuOwogCi0gICAgaWYgKCFtX2NsaWVudC0+cmVtb3RlQXV0b21hdGlvbkFsbG93 ZWQoKSkKKyAgICBpZiAoIW1fY2xpZW50Q2FwYWJpbGl0aWVzIHx8ICFtX2NsaWVudENhcGFiaWxp dGllcy0+cmVtb3RlQXV0b21hdGlvbkFsbG93ZWQpCiAgICAgICAgIHJldHVybjsKIAogICAgIE5T U3RyaW5nICpzdWdnZXN0ZWRTZXNzaW9uSWRlbnRpZmllciA9IFt1c2VySW5mbyBvYmplY3RGb3JL ZXk6V0lSU2Vzc2lvbklkZW50aWZpZXJLZXldOwo=