163010 2016-10-06 06:41:29 -0700 Network Session: Allow NetworkDataTask decide what to do when override is allowed for a download 2016-10-07 09:35:23 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned achristensen oldest_to_newest 1237039 0 cgarcia 2016-10-06 06:41:29 -0700 Current code always deletes the file before starting a download when allow override is True. In soup backend we use glib API that takes care of it and tries to ensure that the original file is not deleted if the new file creation fails for whatever reason. 1237042 1 290821 cgarcia 2016-10-06 06:43:56 -0700 Created attachment 290821 Patch 1237614 2 cgarcia 2016-10-07 09:35:23 -0700 Committed r206913: <http://trac.webkit.org/changeset/206913> 290821 2016-10-06 06:43:56 -0700 2016-10-06 09:02:10 -0700 Patch wk2-allow-override.diff text/plain 4544 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ZTk0Yzc1Li4zYWZjNzRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMg QEAKIDIwMTYtMTAtMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIE5ldHdvcmsgU2Vzc2lvbjogQWxsb3cgTmV0d29ya0RhdGFUYXNrIGRlY2lk ZSB3aGF0IHRvIGRvIHdoZW4gb3ZlcnJpZGUgaXMgYWxsb3dlZCBmb3IgYSBkb3dubG9hZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMDEwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudCBjb2Rl IGFsd2F5cyBkZWxldGVzIHRoZSBmaWxlIGJlZm9yZSBzdGFydGluZyBhIGRvd25sb2FkIHdoZW4g YWxsb3cgb3ZlcnJpZGUgaXMgVHJ1ZS4gSW4gc291cCBiYWNrZW5kIHdlCisgICAgICAgIHVzZSBn bGliIEFQSSB0aGF0IHRha2VzIGNhcmUgb2YgaXQgYW5kIHRyaWVzIHRvIGVuc3VyZSB0aGF0IHRo ZSBvcmlnaW5hbCBmaWxlIGlzIG5vdCBkZWxldGVkIGlmIHRoZSBuZXcgZmlsZQorICAgICAgICBj cmVhdGlvbiBmYWlscyBmb3Igd2hhdGV2ZXIgcmVhc29uLgorCisgICAgICAgICogTmV0d29ya1By b2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRv d25sb2FkTWFuYWdlcjo6Y29udGludWVEZWNpZGVQZW5kaW5nRG93bmxvYWREZXN0aW5hdGlvbik6 IFBhc3MgYWxsb3dPdmVycmlkZSB0byBzZXRQZW5kaW5nRG93bmxvYWRMb2NhdGlvbigpLgorICAg ICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtEYXRhVGFzay5oOgorICAgICAgICAqIE5ldHdv cmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tOgorICAgICAgICAoV2ViS2l0 OjpOZXR3b3JrRGF0YVRhc2s6OnNldFBlbmRpbmdEb3dubG9hZExvY2F0aW9uKTogRGVsZXRlIHRo ZSBkZXN0aW5hdGlvbiBmaWxlIGlmIGV4aXN0cyBhbmQgYWxsb3dPdmVycmlkZQorICAgICAgICBp cyBUcnVlLgorCisyMDE2LTEwLTA2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdh bGlhLmNvbT4KKwogICAgICAgICBOZXR3b3JrIFNlc3Npb246IFBlbmRpbmdEb3dubG9hZCBpcyBh bHdheXMgbnVsbHB0ciBpbiBEb3dubG9hZE1hbmFnZXI6OmRhdGFUYXNrQmVjYW1lRG93bmxvYWRU YXNrCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMw MDYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRz L0Rvd25sb2FkTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9Eb3du bG9hZHMvRG93bmxvYWRNYW5hZ2VyLmNwcAppbmRleCA5OTQzMjhjLi5hOTUyYThjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRNYW5h Z2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMvRG93 bmxvYWRNYW5hZ2VyLmNwcApAQCAtMTI0LDExICsxMjQsNyBAQCB2b2lkIERvd25sb2FkTWFuYWdl cjo6Y29udGludWVEZWNpZGVQZW5kaW5nRG93bmxvYWREZXN0aW5hdGlvbihEb3dubG9hZElEIGRv d25sbwogICAgICAgICBpZiAoIW5ldHdvcmtEYXRhVGFzayB8fCAhY29tcGxldGlvbkhhbmRsZXIp CiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgbmV0d29ya0RhdGFUYXNrLT5zZXRQZW5k aW5nRG93bmxvYWRMb2NhdGlvbihkZXN0aW5hdGlvbiwgc2FuZGJveEV4dGVuc2lvbkhhbmRsZSk7 Ci0KLSAgICAgICAgaWYgKGFsbG93T3ZlcndyaXRlICYmIGZpbGVFeGlzdHMoZGVzdGluYXRpb24p KQotICAgICAgICAgICAgZGVsZXRlRmlsZShkZXN0aW5hdGlvbik7Ci0KKyAgICAgICAgbmV0d29y a0RhdGFUYXNrLT5zZXRQZW5kaW5nRG93bmxvYWRMb2NhdGlvbihkZXN0aW5hdGlvbiwgc2FuZGJv eEV4dGVuc2lvbkhhbmRsZSwgYWxsb3dPdmVyd3JpdGUpOwogICAgICAgICBjb21wbGV0aW9uSGFu ZGxlcihQb2xpY3lEb3dubG9hZCk7CiAKICAgICAgICAgQVNTRVJUKCFtX2Rvd25sb2Fkc0FmdGVy RGVzdGluYXRpb25EZWNpZGVkLmNvbnRhaW5zKGRvd25sb2FkSUQpKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtEYXRhVGFzay5oIGIvU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0RhdGFUYXNrLmgKaW5kZXggYzM1ZTEyNi4uY2Ux OWVhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Rh dGFUYXNrLmgKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0RhdGFU YXNrLmgKQEAgLTEzMyw3ICsxMzMsNyBAQCBwdWJsaWM6CiAgICAgICAgIEFTU0VSVCghbV9wZW5k aW5nRG93bmxvYWQpOwogICAgICAgICBtX3BlbmRpbmdEb3dubG9hZCA9ICZwZW5kaW5nRG93bmxv YWQ7CiAgICAgfQotICAgIHZvaWQgc2V0UGVuZGluZ0Rvd25sb2FkTG9jYXRpb24oY29uc3QgU3Ry aW5nJiBmaWxlbmFtZSwgY29uc3QgU2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlJik7CisgICAgdm9p ZCBzZXRQZW5kaW5nRG93bmxvYWRMb2NhdGlvbihjb25zdCBTdHJpbmcmIGZpbGVuYW1lLCBjb25z dCBTYW5kYm94RXh0ZW5zaW9uOjpIYW5kbGUmLCBib29sIGFsbG93T3ZlcndyaXRlKTsKICAgICBj b25zdCBTdHJpbmcmIHBlbmRpbmdEb3dubG9hZExvY2F0aW9uKCkgeyByZXR1cm4gbV9wZW5kaW5n RG93bmxvYWRMb2NhdGlvbjsgfQogCiAgICAgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0 JiBmaXJzdFJlcXVlc3QoKSBjb25zdCB7IHJldHVybiBtX2ZpcnN0UmVxdWVzdDsgfQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNr Q29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0 YVRhc2tDb2NvYS5tbQppbmRleCA1M2M2OWQ4Li4wMDU3MjY2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2Nv YS5tbQpAQCAtMzYsNiArMzYsNyBAQAogI2ltcG9ydCAiV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgi CiAjaW1wb3J0IDxXZWJDb3JlL0F1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlLmg+CiAjaW1wb3J0IDxX ZWJDb3JlL0NGTmV0d29ya1NQSS5oPgorI2ltcG9ydCA8V2ViQ29yZS9GaWxlU3lzdGVtLmg+CiAj aW1wb3J0IDxXZWJDb3JlL05ldHdvcmtTdG9yYWdlU2Vzc2lvbi5oPgogI2ltcG9ydCA8V2ViQ29y ZS9SZXNvdXJjZVJlcXVlc3QuaD4KICNpbXBvcnQgPHd0Zi9NYWluVGhyZWFkLmg+CkBAIC0yNjgs NyArMjY5LDcgQEAgdm9pZCBOZXR3b3JrRGF0YVRhc2s6OmZhaWx1cmVUaW1lckZpcmVkKCkKICAg ICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKIH0KIAotdm9pZCBOZXR3b3JrRGF0YVRhc2s6OnNldFBl bmRpbmdEb3dubG9hZExvY2F0aW9uKGNvbnN0IFdURjo6U3RyaW5nJiBmaWxlbmFtZSwgY29uc3Qg U2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlJiBzYW5kYm94RXh0ZW5zaW9uSGFuZGxlKQordm9pZCBO ZXR3b3JrRGF0YVRhc2s6OnNldFBlbmRpbmdEb3dubG9hZExvY2F0aW9uKGNvbnN0IFdURjo6U3Ry aW5nJiBmaWxlbmFtZSwgY29uc3QgU2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlJiBzYW5kYm94RXh0 ZW5zaW9uSGFuZGxlLCBib29sIGFsbG93T3ZlcndyaXRlKQogewogICAgIEFTU0VSVCghbV9zYW5k Ym94RXh0ZW5zaW9uKTsKICAgICBtX3NhbmRib3hFeHRlbnNpb24gPSBTYW5kYm94RXh0ZW5zaW9u OjpjcmVhdGUoc2FuZGJveEV4dGVuc2lvbkhhbmRsZSk7CkBAIC0yNzcsNiArMjc4LDkgQEAgdm9p ZCBOZXR3b3JrRGF0YVRhc2s6OnNldFBlbmRpbmdEb3dubG9hZExvY2F0aW9uKGNvbnN0IFdURjo6 U3RyaW5nJiBmaWxlbmFtZSwgY28KIAogICAgIG1fcGVuZGluZ0Rvd25sb2FkTG9jYXRpb24gPSBm aWxlbmFtZTsKICAgICBtX3Rhc2suZ2V0KCkuX3BhdGhUb0Rvd25sb2FkVGFza0ZpbGUgPSBmaWxl bmFtZTsKKworICAgIGlmIChhbGxvd092ZXJ3cml0ZSAmJiBXZWJDb3JlOjpmaWxlRXhpc3RzKGZp bGVuYW1lKSkKKyAgICAgICAgV2ViQ29yZTo6ZGVsZXRlRmlsZShmaWxlbmFtZSk7CiB9CiAKIGJv b2wgTmV0d29ya0RhdGFUYXNrOjp0cnlQYXNzd29yZEJhc2VkQXV0aGVudGljYXRpb24oY29uc3Qg V2ViQ29yZTo6QXV0aGVudGljYXRpb25DaGFsbGVuZ2UmIGNoYWxsZW5nZSwgY29uc3QgQ2hhbGxl bmdlQ29tcGxldGlvbkhhbmRsZXImIGNvbXBsZXRpb25IYW5kbGVyKQo=