162979 2016-10-05 10:52:56 -0700 URLParser should correctly strip unnecessary 0's in IPv6 addresses 2016-10-05 11:30:56 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1236713 0 achristensen 2016-10-05 10:52:56 -0700 URLParser should correctly strip unnecessary 0's in IPv6 addresses 1236714 1 290727 achristensen 2016-10-05 10:54:06 -0700 Created attachment 290727 Patch 1236735 2 290727 achristensen 2016-10-05 11:30:48 -0700 Comment on attachment 290727 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290727&action=review > Source/WebCore/platform/URLParser.cpp:2318 > + if (UNLIKELY((value && leadingZeros) || (!value && length > 1) || (length > 1 && !value))) Oops. This was redundant. Removed one of the checks. 1236736 3 achristensen 2016-10-05 11:30:56 -0700 http://trac.webkit.org/changeset/206819 290727 2016-10-05 10:54:06 -0700 2016-10-05 11:10:10 -0700 Patch bug-162979-20161005105056.patch text/plain 4296 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjgwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTEwLTA1ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVVJMUGFyc2Vy IHNob3VsZCBjb3JyZWN0bHkgc3RyaXAgdW5uZWNlc3NhcnkgMCdzIGluIElQdjYgYWRkcmVzc2Vz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI5NzkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVk IGJ5IG5ldyBBUEkgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9VUkxQYXJzZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6VVJMUGFyc2VyOjpwYXJzZUlQdjZIb3N0KToKKyAgICAgICAgU3Ry aXAgbGVhZGluZyAwJ3MgYW5kIGFueSAwJ3MgYmVmb3JlIHRoZSBsYXN0IDAgaWYgdGhlIHZhbHVl IGlzIDAuCisKIDIwMTYtMTAtMDQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBJbXBsZW1lbnQgS2V5Ym9hcmRFdmVudC5jb2RlIGZyb20gdGhlIFVJIEV2ZW50IHNw ZWMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTFBhcnNlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcAkocmV2aXNpb24gMjA2 Nzg0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjMwMSw2ICsyMzAxLDcgQEAgT3B0aW9uYWw8VVJMUGFyc2VyOjpJUHY2QWRkcmVz cz4gVVJMUGFycwogICAgICAgICB9CiAgICAgICAgIHVpbnQxNl90IHZhbHVlID0gMDsKICAgICAg ICAgc2l6ZV90IGxlbmd0aCA9IDA7CisgICAgICAgIGJvb2wgbGVhZGluZ1plcm9zID0gZmFsc2U7 CiAgICAgICAgIGZvciAoOyBsZW5ndGggPCA0OyBsZW5ndGgrKykgewogICAgICAgICAgICAgaWYg KGMuYXRFbmQoKSkKICAgICAgICAgICAgICAgICBicmVhazsKQEAgLTIzMDgsMTAgKzIzMDksMTMg QEAgT3B0aW9uYWw8VVJMUGFyc2VyOjpJUHY2QWRkcmVzcz4gVVJMUGFycwogICAgICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICAgICAgaWYgKGlzQVNDSUlVcHBlcigqYykpCiAgICAgICAgICAg ICAgICAgc3ludGF4VmlvbGF0aW9uKGhvc3RCZWdpbik7CisgICAgICAgICAgICBpZiAoKmMgPT0g JzAnICYmICFsZW5ndGgpCisgICAgICAgICAgICAgICAgbGVhZGluZ1plcm9zID0gdHJ1ZTsKICAg ICAgICAgICAgIHZhbHVlID0gdmFsdWUgKiAweDEwICsgdG9BU0NJSUhleFZhbHVlKCpjKTsKICAg ICAgICAgICAgIGFkdmFuY2UoYywgaG9zdEJlZ2luKTsKICAgICAgICAgfQotICAgICAgICBpZiAo VU5MSUtFTFkobGVuZ3RoID4gMSAmJiAhdmFsdWUpKQorICAgICAgICAKKyAgICAgICAgaWYgKFVO TElLRUxZKCh2YWx1ZSAmJiBsZWFkaW5nWmVyb3MpIHx8ICghdmFsdWUgJiYgbGVuZ3RoID4gMSkg fHwgKGxlbmd0aCA+IDEgJiYgIXZhbHVlKSkpCiAgICAgICAgICAgICBzeW50YXhWaW9sYXRpb24o aG9zdEJlZ2luKTsKIAogICAgICAgICBhZGRyZXNzW3BpZWNlUG9pbnRlcisrXSA9IHZhbHVlOwpJ bmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2 aXNpb24gMjA2ODE2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTYtMTAtMDUgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Vi a2l0Lm9yZz4KKworICAgICAgICBVUkxQYXJzZXIgc2hvdWxkIGNvcnJlY3RseSBzdHJpcCB1bm5l Y2Vzc2FyeSAwJ3MgaW4gSVB2NiBhZGRyZXNzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Mjk3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBh cnNlci5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUX0YpOgorCiAyMDE2LTEwLTA1 ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW5hbWUg RU5BQkxFX0VOQ1JZUFRFRF9NRURJQV9WMiB0byBFTkFCTEVfTEVHQUNZX0VOQ1JZUFRFRF9NRURJ QQpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNl ci5jcHAJKHJldmlzaW9uIDIwNjc5MikKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi Q29yZS9VUkxQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzAsNiArNTcwLDIxIEBAIFRF U1RfRihVUkxQYXJzZXJUZXN0LCBQYXJzZXJEaWZmZXJlbmNlcykKICAgICBjaGVja1VSTERpZmZl cmVuY2VzKCJodHRwOi8vW2E6MDowOjA6YjpjOjpkXSIsCiAgICAgICAgIHsiaHR0cCIsICIiLCAi IiwgIlthOjpiOmM6MDpkXSIsIDAsICIvIiwgIiIsICIiLCAiaHR0cDovL1thOjpiOmM6MDpkXS8i fSwKICAgICAgICAgeyJodHRwIiwgIiIsICIiLCAiW2E6MDowOjA6YjpjOjpkXSIsIDAsICIvIiwg IiIsICIiLCAiaHR0cDovL1thOjA6MDowOmI6Yzo6ZF0vIn0pOworICAgIGNoZWNrVVJMRGlmZmVy ZW5jZXMoImh0dHA6Ly9bOjo3ZjAwOjAwMDFdLyIsCisgICAgICAgIHsiaHR0cCIsICIiLCAiIiwg Ils6OjdmMDA6MV0iLCAwLCAiLyIsICIiLCAiIiwgImh0dHA6Ly9bOjo3ZjAwOjFdLyJ9LAorICAg ICAgICB7Imh0dHAiLCAiIiwgIiIsICJbOjo3ZjAwOjAwMDFdIiwgMCwgIi8iLCAiIiwgIiIsICJo dHRwOi8vWzo6N2YwMDowMDAxXS8ifSk7CisgICAgY2hlY2tVUkxEaWZmZXJlbmNlcygiaHR0cDov L1s6OjdmMDA6MDBdLyIsCisgICAgICAgIHsiaHR0cCIsICIiLCAiIiwgIls6OjdmMDA6MF0iLCAw LCAiLyIsICIiLCAiIiwgImh0dHA6Ly9bOjo3ZjAwOjBdLyJ9LAorICAgICAgICB7Imh0dHAiLCAi IiwgIiIsICJbOjo3ZjAwOjAwXSIsIDAsICIvIiwgIiIsICIiLCAiaHR0cDovL1s6OjdmMDA6MDBd LyJ9KTsKKyAgICBjaGVja1VSTERpZmZlcmVuY2VzKCJodHRwOi8vWzo6MDo3ZjAwOjAwMDFdLyIs CisgICAgICAgIHsiaHR0cCIsICIiLCAiIiwgIls6OjdmMDA6MV0iLCAwLCAiLyIsICIiLCAiIiwg Imh0dHA6Ly9bOjo3ZjAwOjFdLyJ9LAorICAgICAgICB7Imh0dHAiLCAiIiwgIiIsICJbOjowOjdm MDA6MDAwMV0iLCAwLCAiLyIsICIiLCAiIiwgImh0dHA6Ly9bOjowOjdmMDA6MDAwMV0vIn0pOwor ICAgIGNoZWNrVVJMRGlmZmVyZW5jZXMoImh0dHA6Ly8xMjcuMDAuMC4xLyIsCisgICAgICAgIHsi aHR0cCIsICIiLCAiIiwgIjEyNy4wLjAuMSIsIDAsICIvIiwgIiIsICIiLCAiaHR0cDovLzEyNy4w LjAuMS8ifSwKKyAgICAgICAgeyJodHRwIiwgIiIsICIiLCAiMTI3LjAwLjAuMSIsIDAsICIvIiwg IiIsICIiLCAiaHR0cDovLzEyNy4wMC4wLjEvIn0pOworICAgIGNoZWNrVVJMRGlmZmVyZW5jZXMo Imh0dHA6Ly8xMjcuMC4wLjAxLyIsCisgICAgICAgIHsiaHR0cCIsICIiLCAiIiwgIjEyNy4wLjAu MSIsIDAsICIvIiwgIiIsICIiLCAiaHR0cDovLzEyNy4wLjAuMS8ifSwKKyAgICAgICAgeyJodHRw IiwgIiIsICIiLCAiMTI3LjAuMC4wMSIsIDAsICIvIiwgIiIsICIiLCAiaHR0cDovLzEyNy4wLjAu MDEvIn0pOwogICAgIGNoZWNrVVJMRGlmZmVyZW5jZXMoImh0dHA6Ly9leGFtcGxlLmNvbS9wYXRo MS8uJTJlIiwKICAgICAgICAgeyJodHRwIiwgIiIsICIiLCAiZXhhbXBsZS5jb20iLCAwLCAiLyIs ICIiLCAiIiwgImh0dHA6Ly9leGFtcGxlLmNvbS8ifSwKICAgICAgICAgeyJodHRwIiwgIiIsICIi LCAiZXhhbXBsZS5jb20iLCAwLCAiL3BhdGgxLy4lMmUiLCAiIiwgIiIsICJodHRwOi8vZXhhbXBs ZS5jb20vcGF0aDEvLiUyZSJ9KTsK