162960 2016-10-05 01:05:02 -0700 Reuse CodeGenerator::UpdateFile in Tools CodeGenerator 2016-10-05 23:48:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf cdumez cgarcia commit-queue fujii oldest_to_newest 1236574 0 youennf 2016-10-05 01:05:02 -0700 Currently, the binding generator is always updating generated files. Sometimes the content might be the same. In those cases, it might be best to let the generated files unchanged so that this does not trigger unnecessary compilation steps. 1236579 1 290699 youennf 2016-10-05 02:33:25 -0700 Created attachment 290699 Patch 1236588 2 fujii 2016-10-05 03:24:15 -0700 This approach has a problem described a following bug: Bug 131756 – Fix CodeGenerator.pm to only write files if the generated content has changed 1236590 3 youennf 2016-10-05 03:35:13 -0700 (In reply to comment #2) > This approach has a problem described a following bug: > > Bug 131756 – Fix CodeGenerator.pm to only write files if the generated > content has changed Ah, thanks for the link! That is so bad though... 1236592 4 290702 youennf 2016-10-05 03:39:42 -0700 Created attachment 290702 Patch 1236593 5 youennf 2016-10-05 03:40:29 -0700 (In reply to comment #4) > Created attachment 290702 [details] > Patch Patch does some small refactoring and adds a FIXME about bug 131756. 1236637 6 290702 achristensen 2016-10-05 08:53:00 -0700 Comment on attachment 290702 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290702&action=review r=me minus adding the comment. > Source/WebCore/bindings/scripts/CodeGenerator.pm:223 > + # FIXME: We should only write content if it is different from what is in the file. > + # But that would mean running more often the binding generator, see https://bugs.webkit.org/show_bug.cgi?id=131756 Nope, we've decided against this several times. We do lots of incremental builds on bots. It's faster to run the bindings generator once, update the files, and recompile things once than having to re-run all the bindings generators every time we build on that machine just to verify that the output would've been exactly what is on disk. 1236651 7 youennf 2016-10-05 09:11:42 -0700 (In reply to comment #6) > Comment on attachment 290702 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=290702&action=review > > r=me minus adding the comment. > > > Source/WebCore/bindings/scripts/CodeGenerator.pm:223 > > + # FIXME: We should only write content if it is different from what is in the file. > > + # But that would mean running more often the binding generator, see https://bugs.webkit.org/show_bug.cgi?id=131756 > > Nope, we've decided against this several times. We do lots of incremental > builds on bots. It's faster to run the bindings generator once, update the > files, and recompile things once than having to re-run all the bindings > generators every time we build on that machine just to verify that the > output would've been exactly what is on disk. Ideally, we would like a solution that works for bots and people messing with the binding generator, hence the FIXME. FIXME is also there for preventing people to do what I did in the first patch. Do you want me to clarify the FIXME or is it good like that? 1236915 8 290702 commit-queue 2016-10-05 23:48:03 -0700 Comment on attachment 290702 Patch Clearing flags on attachment: 290702 Committed r206851: <http://trac.webkit.org/changeset/206851> 1236916 9 commit-queue 2016-10-05 23:48:09 -0700 All reviewed patches have been landed. Closing bug. 290699 2016-10-05 02:33:25 -0700 2016-10-05 03:39:34 -0700 Patch bug-162960-20161005113013.patch text/plain 7093 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmViNzUwZjkyYTE5ODc2 MTgzNzlhYmRkODM2ODA5MDA0NmE1ZTBhYy4uODU0ZTk1OWEwZjU1ZGNmYWU3ZjEwMmE3OWE2YTQ5 MjAyZDNmMWM5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2LTEwLTA1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBCaW5kaW5nIGdlbmVyYXRv ciBzaG91bGQgbm90IG92ZXJ3cml0ZSBmaWxlcyB3aXRoIHRoZSBzYW1lIGNvbnRlbnQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Mjk2MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5nZSBvZiBi ZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbToK KyAgICAgICAgKFVwZGF0ZUZpbGUpOiBTa2lwcGluZyBmaWxlIHVwZGF0ZSBpZiBjb250ZW50IGlz IHRoZSBzYW1lLgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvZ2VuZXJhdGUtYmluZGluZ3Mu cGw6CisgICAgICAgIChnZW5lcmF0ZUVtcHR5SGVhZGVyQW5kQ3BwKTogRGl0dG8uCisKKzIwMTYt MTAtMDUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCiAgICAgICAgIFtGZXRj aCBBUEldIE1lbW9yeSBjYWNoZSBzaG91bGQgbm90IGJ5cGFzcyByZWRpcmVjdCBtb2RlCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI5NTkKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBt IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtCmluZGV4 IDMxYmU3MTFhNGE1MTIyM2YxYmY0ZDM5MDI0NWU2YjJkMzUzNzg3N2YuLjliMjM4YzExNzQ1MmMw YTlmZTY2Mzg1ZmM5NTA1YzNkMTJjNWYxNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3IucG0KQEAgLTI5LDYgKzI5LDcgQEAgcGFja2FnZSBD b2RlR2VuZXJhdG9yOwogdXNlIHN0cmljdDsKIAogdXNlIEZpbGU6OkZpbmQ7Cit1c2UgRmlsZTo6 U2x1cnA7CiAKIG15ICR1c2VEb2N1bWVudCA9ICIiOwogbXkgJHVzZUdlbmVyYXRvciA9ICIiOwpA QCAtMjE5LDYgKzIyMCw4IEBAIHN1YiBVcGRhdGVGaWxlCiAgICAgbXkgJGZpbGVOYW1lID0gc2hp ZnQ7CiAgICAgbXkgJGNvbnRlbnRzID0gc2hpZnQ7CiAKKyAgICByZXR1cm4gaWYgKHJlYWRfZmls ZSgkZmlsZU5hbWUsIGVycl9tb2RlID0+ICdjYXJwJykgZXEgJGNvbnRlbnRzKTsKKwogICAgIG9w ZW4gRkgsICI+IiwgJGZpbGVOYW1lIG9yIGRpZSAiQ291bGRuJ3Qgb3BlbiAkZmlsZU5hbWU6ICQh XG4iOwogICAgIHByaW50IEZIICRjb250ZW50czsKICAgICBjbG9zZSBGSDsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvZ2VuZXJhdGUtYmluZGluZ3MucGwgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL2dlbmVyYXRlLWJpbmRpbmdzLnBsCmluZGV4 IDk0YmM0MWU5MDMyNDdkZDkxYmNkMmNjYzNkMjZkNTEyMzk5NzZjYjguLmU4ZDBmNjZlNGE3ODJj OTg0OGY3Y2I3NjA1ZGQ4ZDEzM2E0N2NmNWYgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvZ2VuZXJhdGUtYmluZGluZ3MucGwKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5kaW5ncy5wbApAQCAtMSwyNyArMSwyNyBAQAog IyEvdXNyL2Jpbi9wZXJsIC13CiAjCi0jIENvcHlyaWdodCAoQykgMjAwNSBBcHBsZSBJbmMuCisj IENvcHlyaWdodCAoQykgMjAwNS0yMDE2IEFwcGxlIEluYy4KICMgQ29weXJpZ2h0IChDKSAyMDA2 IEFuZGVycyBDYXJsc3NvbiA8YW5kZXJzY2FAbWFjLmNvbT4KLSMgCisjCiAjIFRoaXMgZmlsZSBp cyBwYXJ0IG9mIFdlYktpdAotIyAKKyMKICMgVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7 IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogIyBtb2RpZnkgaXQgdW5kZXIgdGhlIHRl cm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwogIyBMaWNlbnNlIGFzIHB1Ymxp c2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKICMgdmVyc2lvbiAy IG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgot IyAKKyMKICMgVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQg d2lsbCBiZSB1c2VmdWwsCiAjIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVu IHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCiAjIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZP UiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCiAjIExpYnJhcnkgR2VuZXJhbCBQ dWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgotIyAKKyMKICMgWW91IHNob3VsZCBoYXZl IHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGljZW5z ZQogIyBhbG9uZyB3aXRoIHRoaXMgbGlicmFyeTsgc2VlIHRoZSBmaWxlIENPUFlJTkcuTElCLiAg SWYgbm90LCB3cml0ZSB0bwogIyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuLCA1 MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZsb29yLAogIyBCb3N0b24sIE1BIDAyMTEwLTEzMDEs IFVTQS4KLSMgCisjCiAKLSMgVGhpcyBzY3JpcHQgaXMgYSB0ZW1wb3JhcnkgaGFjay4gCisjIFRo aXMgc2NyaXB0IGlzIGEgdGVtcG9yYXJ5IGhhY2suCiAjIEZpbGVzIGFyZSBnZW5lcmF0ZWQgaW4g dGhlIHNvdXJjZSBkaXJlY3RvcnksIHdoZW4gdGhleSByZWFsbHkgc2hvdWxkIGdvCiAjIHRvIHRo ZSBEZXJpdmVkU291cmNlcyBkaXJlY3RvcnkuCiAjIFRoaXMgc2hvdWxkIGFsc28gZXZlbnR1YWxs eSBiZSBhIGJ1aWxkIHJ1bGUgZHJpdmVuIG9mZiBvZiAuaWRsIGZpbGVzCkBAIC0zMCwxMSArMzAs MTIgQEAKIAogdXNlIHN0cmljdDsKIAotdXNlIEZpbGU6OlBhdGg7Cit1c2UgQ3dkOwogdXNlIEZp bGU6OkJhc2VuYW1lOwordXNlIEZpbGU6OlBhdGg7Cit1c2UgRmlsZTo6U2x1cnA7CiB1c2UgR2V0 b3B0OjpMb25nOwogdXNlIFRleHQ6OlBhcnNlV29yZHM7Ci11c2UgQ3dkOwogCiB1c2UgSURMUGFy c2VyOwogdXNlIENvZGVHZW5lcmF0b3I7CkBAIC0yMDcsMTMgKzIwOCwxOSBAQCBzdWIgZ2VuZXJh dGVFbXB0eUhlYWRlckFuZENwcAogICAgICRjcHBOYW1lIGF0IGV2ZXJ5IGJ1aWxkLiBUaGlzIGZp bGUgbXVzdCBub3QgYmUgdHJpZWQgdG8gY29tcGlsZS4KICovCiAiOwotICAgIG9wZW4gRkgsICI+ ICR7b3V0cHV0SGVhZGVyc0RpcmVjdG9yeX0vJHtoZWFkZXJOYW1lfSIgb3IgZGllICJDYW5ub3Qg b3BlbiAkaGVhZGVyTmFtZVxuIjsKLSAgICBwcmludCBGSCAkY29udGVudHM7Ci0gICAgY2xvc2Ug Rkg7CisgICAgbXkgJGZpbGVQYXRoID0gIiR7b3V0cHV0SGVhZGVyc0RpcmVjdG9yeX0vJHtoZWFk ZXJOYW1lfSI7CisgICAgaWYgKHJlYWRfZmlsZSgkZmlsZVBhdGgsIGVycl9tb2RlID0+ICdjYXJw JykgbmUgJGNvbnRlbnRzKSB7CisgICAgICAgIG9wZW4gRkgsICI+IiwgJGZpbGVQYXRoIG9yIGRp ZSAiQ2Fubm90IG9wZW4gJGhlYWRlck5hbWVcbiI7CisgICAgICAgIHByaW50IEZIICRjb250ZW50 czsKKyAgICAgICAgY2xvc2UgRkg7CisgICAgfQogCi0gICAgb3BlbiBGSCwgIj4gJHtvdXRwdXRE aXJlY3Rvcnl9LyR7Y3BwTmFtZX0iIG9yIGRpZSAiQ2Fubm90IG9wZW4gJGNwcE5hbWVcbiI7Ci0g ICAgcHJpbnQgRkggJGNvbnRlbnRzOwotICAgIGNsb3NlIEZIOworICAgICRmaWxlUGF0aCA9ICIk e291dHB1dEhlYWRlcnNEaXJlY3Rvcnl9LyR7Y3BwTmFtZX0iOworICAgIGlmIChyZWFkX2ZpbGUo JGZpbGVQYXRoLCBlcnJfbW9kZSA9PiAnY2FycCcpIG5lICRjb250ZW50cykgeworICAgICAgICBv cGVuIEZILCAiPiIsICRmaWxlUGF0aCBvciBkaWUgIkNhbm5vdCBvcGVuICRjcHBOYW1lXG4iOwor ICAgICAgICBwcmludCBGSCAkY29udGVudHM7CisgICAgICAgIGNsb3NlIEZIOworICAgIH0KIH0K IAogc3ViIGxvYWRJRExBdHRyaWJ1dGVzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9U b29scy9DaGFuZ2VMb2cKaW5kZXggYjA1ZTAxNzJjNzVjNTA2Yjk1ZGZhZjM5NjMxMzBjMmY1N2Nl ZGFiNS4uM2Q1MWViZWIyMTc5NGFkNDQ0MDBiMmYxMTAxZDhiMzUyNTY1OTIxZSAxMDA2NDQKLS0t IGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBA CisyMDE2LTEwLTA1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAg ICBCaW5kaW5nIGdlbmVyYXRvciBzaG91bGQgbm90IG92ZXJ3cml0ZSBmaWxlcyB3aXRoIHRoZSBz YW1lIGNvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2Mjk2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvQmluZGluZ3MvQ29kZUdlbmVyYXRvckR1bXBSZW5kZXJUcmVl LnBtOgorICAgICAgICAoV3JpdGVEYXRhKTogVXNpbmcgQ29kZUdlbmVyYXRvcjo6VXBkYXRlRmls ZSB0byBkbyBsYXp5IGdlbmVyYXRlZCBmaWxlIHVwZGF0ZS4KKyAgICAgICAgKiBXZWJLaXRUZXN0 UnVubmVyL0luamVjdGVkQnVuZGxlL0JpbmRpbmdzL0NvZGVHZW5lcmF0b3JUZXN0UnVubmVyLnBt OgorICAgICAgICAoV3JpdGVEYXRhKTogRGl0dG8uCisKIDIwMTYtMTAtMDMgIEFsZXggQ2hyaXN0 ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVUkxQYXJzZXIgc2hv dWxkIGlnbm9yZSB0YWJzIGF0IGFsbCBsb2NhdGlvbnMKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL0JpbmRpbmdzL0NvZGVHZW5lcmF0b3JEdW1wUmVuZGVyVHJlZS5wbSBiL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL0JpbmRpbmdzL0NvZGVHZW5lcmF0b3JEdW1wUmVuZGVyVHJlZS5wbQpp bmRleCBlMDk4ODM1NjMxYzQ0MjM1ODNhN2E1NWQ0NTg2NTFhYzQ5YzNlYjdmLi4yMGRkOGYxODUx MGRhOTcyNjlkNDdkNGQ2ZTQwMDBlMDhjZWUzYTZmIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9CaW5kaW5ncy9Db2RlR2VuZXJhdG9yRHVtcFJlbmRlclRyZWUucG0KKysrIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvQmluZGluZ3MvQ29kZUdlbmVyYXRvckR1bXBSZW5kZXJUcmVlLnBt CkBAIC00OSw5ICs0OSw3IEBAIHN1YiBXcml0ZURhdGEKICAgICBteSAoJHNlbGYsICRpbnRlcmZh Y2UsICRvdXRwdXREaXIpID0gQF87CiAKICAgICBmb3JlYWNoIG15ICRmaWxlICgkc2VsZi0+X2dl bmVyYXRlSGVhZGVyRmlsZSgkaW50ZXJmYWNlKSwgJHNlbGYtPl9nZW5lcmF0ZUltcGxlbWVudGF0 aW9uRmlsZSgkaW50ZXJmYWNlKSkgewotICAgICAgICBvcGVuKEZJTEUsICI+IiwgRmlsZTo6U3Bl Yy0+Y2F0ZmlsZSgkb3V0cHV0RGlyLCAkJGZpbGV7bmFtZX0pKSBvciBkaWUgIkZhaWxlZCB0byBv cGVuICQkZmlsZXtuYW1lfSBmb3Igd3JpdGluZzogJCEiOwotICAgICAgICBwcmludCBGSUxFIEB7 JCRmaWxle2NvbnRlbnRzfX07Ci0gICAgICAgIGNsb3NlKEZJTEUpIG9yIGRpZSAiRmFpbGVkIHRv IGNsb3NlICQkZmlsZXtuYW1lfSBhZnRlciB3cml0aW5nOiAkISI7CisgICAgICAgICQkc2VsZntj b2RlR2VuZXJhdG9yfS0+VXBkYXRlRmlsZShGaWxlOjpTcGVjLT5jYXRmaWxlKCRvdXRwdXREaXIs ICQkZmlsZXtuYW1lfSksIGpvaW4oIiIsIEB7JCRmaWxle2NvbnRlbnRzfX0pKTsKICAgICB9CiB9 CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvQmlu ZGluZ3MvQ29kZUdlbmVyYXRvclRlc3RSdW5uZXIucG0gYi9Ub29scy9XZWJLaXRUZXN0UnVubmVy L0luamVjdGVkQnVuZGxlL0JpbmRpbmdzL0NvZGVHZW5lcmF0b3JUZXN0UnVubmVyLnBtCmluZGV4 IDE5NDg2YzQ4NWQ2YTU1MzVhMzNkNWIzZjg3M2U4ODhhZDM3Mzc2MzIuLjk1MmQ1OGQ3N2IwNTBj OTI4YzU2NDhlNTA4NDUxMTYzNTIyY2UwYjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvQmluZGluZ3MvQ29kZUdlbmVyYXRvclRlc3RSdW5uZXIucG0K KysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9Db2Rl R2VuZXJhdG9yVGVzdFJ1bm5lci5wbQpAQCAtNTAsOSArNTAsNyBAQCBzdWIgV3JpdGVEYXRhCiAg ICAgbXkgKCRzZWxmLCAkaW50ZXJmYWNlLCAkb3V0cHV0RGlyKSA9IEBfOwogCiAgICAgZm9yZWFj aCBteSAkZmlsZSAoJHNlbGYtPl9nZW5lcmF0ZUhlYWRlckZpbGUoJGludGVyZmFjZSksICRzZWxm LT5fZ2VuZXJhdGVJbXBsZW1lbnRhdGlvbkZpbGUoJGludGVyZmFjZSkpIHsKLSAgICAgICAgb3Bl bihGSUxFLCAiPiIsIEZpbGU6OlNwZWMtPmNhdGZpbGUoJG91dHB1dERpciwgJCRmaWxle25hbWV9 KSkgb3IgZGllICJGYWlsZWQgdG8gb3BlbiAkJGZpbGV7bmFtZX0gZm9yIHdyaXRpbmc6ICQhIjsK LSAgICAgICAgcHJpbnQgRklMRSBAeyQkZmlsZXtjb250ZW50c319OwotICAgICAgICBjbG9zZShG SUxFKSBvciBkaWUgIkZhaWxlZCB0byBjbG9zZSAkJGZpbGV7bmFtZX0gYWZ0ZXIgd3JpdGluZzog JCEiOworICAgICAgICAkJHNlbGZ7Y29kZUdlbmVyYXRvcn0tPlVwZGF0ZUZpbGUoRmlsZTo6U3Bl Yy0+Y2F0ZmlsZSgkb3V0cHV0RGlyLCAkJGZpbGV7bmFtZX0pLCBqb2luKCIiLCBAeyQkZmlsZXtj b250ZW50c319KSk7CiAgICAgfQogfQogCg== 290702 2016-10-05 03:39:42 -0700 2016-10-05 23:48:03 -0700 Patch bug-162960-20161005123629.patch text/plain 4283 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmViNzUwZjkyYTE5ODc2 MTgzNzlhYmRkODM2ODA5MDA0NmE1ZTBhYy4uMjNiZmIwODA5NWZkMjgzOTE2ZjNmYTkzZTM4YzYz MGU3YTU5M2UxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTEwLTA1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXVzZSBDb2RlR2VuZXJh dG9yOjpVcGRhdGVGaWxlIGluIFRvb2xzIENvZGVHZW5lcmF0b3IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Mjk2MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5nZSBvZiBiZWhhdmlvci4KKwor ICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbToKKyAgICAgICAgKFVw ZGF0ZUZpbGUpOiBBZGRpbmcgRklYTUUgdG8gZW5hYmxlIGxhenkgd3JpdGluZyB3aGVuIGZlYXNp YmxlLgorCisyMDE2LTEwLTA1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKwog ICAgICAgICBbRmV0Y2ggQVBJXSBNZW1vcnkgY2FjaGUgc2hvdWxkIG5vdCBieXBhc3MgcmVkaXJl Y3QgbW9kZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTYyOTU5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvci5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvci5wbQppbmRleCAzMWJlNzExYTRhNTEyMjNmMWJmNGQzOTAyNDVlNmIyZDM1Mzc4NzdmLi5i ZjRiMDQwOGMxNWJhOWQ4MGQ2YWFlMDE2ZTYyM2Q3ZDc3MTc5Mzk2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3IucG0KKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtCkBAIC0yMTksNiArMjE5 LDggQEAgc3ViIFVwZGF0ZUZpbGUKICAgICBteSAkZmlsZU5hbWUgPSBzaGlmdDsKICAgICBteSAk Y29udGVudHMgPSBzaGlmdDsKIAorICAgICMgRklYTUU6IFdlIHNob3VsZCBvbmx5IHdyaXRlIGNv bnRlbnQgaWYgaXQgaXMgZGlmZmVyZW50IGZyb20gd2hhdCBpcyBpbiB0aGUgZmlsZS4KKyAgICAj IEJ1dCB0aGF0IHdvdWxkIG1lYW4gcnVubmluZyBtb3JlIG9mdGVuIHRoZSBiaW5kaW5nIGdlbmVy YXRvciwgc2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE3NTYK ICAgICBvcGVuIEZILCAiPiIsICRmaWxlTmFtZSBvciBkaWUgIkNvdWxkbid0IG9wZW4gJGZpbGVO YW1lOiAkIVxuIjsKICAgICBwcmludCBGSCAkY29udGVudHM7CiAgICAgY2xvc2UgRkg7CmRpZmYg LS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA1ZTAxNzJj NzVjNTA2Yjk1ZGZhZjM5NjMxMzBjMmY1N2NlZGFiNS4uMDQzZDA1ZjA4YzA2NDY2Mzk4ZWY4OWYy ZTdkMmFjYTE5MWJlZDJhNSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTEwLTA1ICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZXVzZSBDb2RlR2VuZXJhdG9yOjpVcGRhdGVG aWxlIGluIFRvb2xzIENvZGVHZW5lcmF0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2Mjk2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvQmluZGluZ3MvQ29kZUdlbmVyYXRv ckR1bXBSZW5kZXJUcmVlLnBtOgorICAgICAgICAoV3JpdGVEYXRhKTogVXNpbmcgQ29kZUdlbmVy YXRvcjo6VXBkYXRlRmlsZSB0byBkbyBsYXp5IGdlbmVyYXRlZCBmaWxlIHVwZGF0ZSB3aGVuIGl0 IGlzIG1hZGUgZmVhc2libGUuCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1 bmRsZS9CaW5kaW5ncy9Db2RlR2VuZXJhdG9yVGVzdFJ1bm5lci5wbToKKyAgICAgICAgKFdyaXRl RGF0YSk6IERpdHRvLgorCiAyMDE2LTEwLTAzICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVVJMUGFyc2VyIHNob3VsZCBpZ25vcmUgdGFicyBh dCBhbGwgbG9jYXRpb25zCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9CaW5kaW5n cy9Db2RlR2VuZXJhdG9yRHVtcFJlbmRlclRyZWUucG0gYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9C aW5kaW5ncy9Db2RlR2VuZXJhdG9yRHVtcFJlbmRlclRyZWUucG0KaW5kZXggZTA5ODgzNTYzMWM0 NDIzNTgzYTdhNTVkNDU4NjUxYWM0OWMzZWI3Zi4uMjBkZDhmMTg1MTBkYTk3MjY5ZDQ3ZDRkNmU0 MDAwZTA4Y2VlM2E2ZiAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvQmluZGluZ3Mv Q29kZUdlbmVyYXRvckR1bXBSZW5kZXJUcmVlLnBtCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L0JpbmRpbmdzL0NvZGVHZW5lcmF0b3JEdW1wUmVuZGVyVHJlZS5wbQpAQCAtNDksOSArNDksNyBA QCBzdWIgV3JpdGVEYXRhCiAgICAgbXkgKCRzZWxmLCAkaW50ZXJmYWNlLCAkb3V0cHV0RGlyKSA9 IEBfOwogCiAgICAgZm9yZWFjaCBteSAkZmlsZSAoJHNlbGYtPl9nZW5lcmF0ZUhlYWRlckZpbGUo JGludGVyZmFjZSksICRzZWxmLT5fZ2VuZXJhdGVJbXBsZW1lbnRhdGlvbkZpbGUoJGludGVyZmFj ZSkpIHsKLSAgICAgICAgb3BlbihGSUxFLCAiPiIsIEZpbGU6OlNwZWMtPmNhdGZpbGUoJG91dHB1 dERpciwgJCRmaWxle25hbWV9KSkgb3IgZGllICJGYWlsZWQgdG8gb3BlbiAkJGZpbGV7bmFtZX0g Zm9yIHdyaXRpbmc6ICQhIjsKLSAgICAgICAgcHJpbnQgRklMRSBAeyQkZmlsZXtjb250ZW50c319 OwotICAgICAgICBjbG9zZShGSUxFKSBvciBkaWUgIkZhaWxlZCB0byBjbG9zZSAkJGZpbGV7bmFt ZX0gYWZ0ZXIgd3JpdGluZzogJCEiOworICAgICAgICAkJHNlbGZ7Y29kZUdlbmVyYXRvcn0tPlVw ZGF0ZUZpbGUoRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkb3V0cHV0RGlyLCAkJGZpbGV7bmFtZX0pLCBq b2luKCIiLCBAeyQkZmlsZXtjb250ZW50c319KSk7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9U b29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0JpbmRpbmdzL0NvZGVHZW5lcmF0 b3JUZXN0UnVubmVyLnBtIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9C aW5kaW5ncy9Db2RlR2VuZXJhdG9yVGVzdFJ1bm5lci5wbQppbmRleCAxOTQ4NmM0ODVkNmE1NTM1 YTMzZDViM2Y4NzNlODg4YWQzNzM3NjMyLi45NTJkNThkNzdiMDUwYzkyOGM1NjQ4ZTUwODQ1MTE2 MzUyMmNlMGI5IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVu ZGxlL0JpbmRpbmdzL0NvZGVHZW5lcmF0b3JUZXN0UnVubmVyLnBtCisrKyBiL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvQmluZGluZ3MvQ29kZUdlbmVyYXRvclRlc3RSdW5u ZXIucG0KQEAgLTUwLDkgKzUwLDcgQEAgc3ViIFdyaXRlRGF0YQogICAgIG15ICgkc2VsZiwgJGlu dGVyZmFjZSwgJG91dHB1dERpcikgPSBAXzsKIAogICAgIGZvcmVhY2ggbXkgJGZpbGUgKCRzZWxm LT5fZ2VuZXJhdGVIZWFkZXJGaWxlKCRpbnRlcmZhY2UpLCAkc2VsZi0+X2dlbmVyYXRlSW1wbGVt ZW50YXRpb25GaWxlKCRpbnRlcmZhY2UpKSB7Ci0gICAgICAgIG9wZW4oRklMRSwgIj4iLCBGaWxl OjpTcGVjLT5jYXRmaWxlKCRvdXRwdXREaXIsICQkZmlsZXtuYW1lfSkpIG9yIGRpZSAiRmFpbGVk IHRvIG9wZW4gJCRmaWxle25hbWV9IGZvciB3cml0aW5nOiAkISI7Ci0gICAgICAgIHByaW50IEZJ TEUgQHskJGZpbGV7Y29udGVudHN9fTsKLSAgICAgICAgY2xvc2UoRklMRSkgb3IgZGllICJGYWls ZWQgdG8gY2xvc2UgJCRmaWxle25hbWV9IGFmdGVyIHdyaXRpbmc6ICQhIjsKKyAgICAgICAgJCRz ZWxme2NvZGVHZW5lcmF0b3J9LT5VcGRhdGVGaWxlKEZpbGU6OlNwZWMtPmNhdGZpbGUoJG91dHB1 dERpciwgJCRmaWxle25hbWV9KSwgam9pbigiIiwgQHskJGZpbGV7Y29udGVudHN9fSkpOwogICAg IH0KIH0KIAo=