162953 2016-10-04 18:55:10 -0700 [Win][Direct2D] Clean up Bitmap Decoder Implementation 2016-10-24 16:32:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 162761 163349 161817 1 bfulgham webkit-unassigned achristensen bfulgham commit-queue dino pvollan simon.fraser oldest_to_newest 1236508 0 bfulgham 2016-10-04 18:55:10 -0700 Address some of Said's comments from Bug 162761. 1240504 1 291685 bfulgham 2016-10-14 17:24:50 -0700 Created attachment 291685 Cleanups to make this code less gross. This patch implements a set of improvements Said suggested in a prior review (made after the original patch landed). 1240508 2 291685 commit-queue 2016-10-14 17:35:23 -0700 Comment on attachment 291685 Cleanups to make this code less gross. Rejecting attachment 291685 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 291685, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ex: platform/graphics/win/ImageDecoderDirect2D.cpp |=================================================================== |--- platform/graphics/win/ImageDecoderDirect2D.cpp (revision 207357) |+++ platform/graphics/win/ImageDecoderDirect2D.cpp (working copy) -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2287417 1240657 3 291685 darin 2016-10-15 15:57:56 -0700 Comment on attachment 291685 Cleanups to make this code less gross. View in context: https://bugs.webkit.org/attachment.cgi?id=291685&action=review > platform/graphics/win/ImageDecoderDirect2D.cpp:175 > + auto frameSize = frameSizeAtIndex(index, subsamplingLevel); > + return frameSize.area() * 4; Would have made this a one-liner. 1243950 4 bfulgham 2016-10-24 16:32:15 -0700 Landed in r207365. <https://trac.webkit.org/changeset/207365> 291685 2016-10-14 17:24:50 -0700 2016-10-14 17:35:23 -0700 Cleanups to make this code less gross. said.patch text/plain 1761 bfulgham SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwNzM2 MSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTEw LTE0ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5d W0RpcmVjdDJEXSBNaW5vciBjbGVhbnVwcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTYyOTUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ29kZSBjbGVhbnVwLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vSW1hZ2VEZWNvZGVyRGlyZWN0MkQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VEZWNvZGVyOjpmcmFtZUlzQ29tcGxldGVBdEluZGV4 KToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRGVjb2Rlcjo6ZnJhbWVCeXRlc0F0SW5kZXgpOgor CiAyMDE2LTEwLTE0ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBD U1MgcGFyc2luZyBzaG91bGQgdXNlIENvbG9yIG5vdCBSR0JBMzIKSW5kZXg6IHBsYXRmb3JtL2dy YXBoaWNzL3dpbi9JbWFnZURlY29kZXJEaXJlY3QyRC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZv cm0vZ3JhcGhpY3Mvd2luL0ltYWdlRGVjb2RlckRpcmVjdDJELmNwcAkocmV2aXNpb24gMjA3MzU3 KQorKysgcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ltYWdlRGVjb2RlckRpcmVjdDJELmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTM5LDEwICsxMzksNyBAQAogCiAgICAgQ09NUHRyPElXSUNCaXRtYXBG cmFtZURlY29kZT4gZnJhbWU7CiAgICAgSFJFU1VMVCBociA9IG1fbmF0aXZlRGVjb2Rlci0+R2V0 RnJhbWUoaW5kZXgsICZmcmFtZSk7Ci0gICAgaWYgKCFTVUNDRUVERUQoaHIpKQotICAgICAgICBy ZXR1cm4gZmFsc2U7Ci0KLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gU1VDQ0VFREVEKGhy KTsKIH0KIAogSW1hZ2VPcmllbnRhdGlvbiBJbWFnZURlY29kZXI6OmZyYW1lT3JpZW50YXRpb25B dEluZGV4KHNpemVfdCBpbmRleCkgY29uc3QKQEAgLTE3NCwxNyArMTcxLDggQEAKICAgICBpZiAo IW1fbmF0aXZlRGVjb2RlcikKICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICBDT01QdHI8SVdJQ0Jp dG1hcEZyYW1lRGVjb2RlPiBmcmFtZTsKLSAgICBIUkVTVUxUIGhyID0gbV9uYXRpdmVEZWNvZGVy LT5HZXRGcmFtZShpbmRleCwgJmZyYW1lKTsKLSAgICBpZiAoIVNVQ0NFRURFRChocikpCi0gICAg ICAgIHJldHVybiAwOwotCi0gICAgVUlOVCB3aWR0aCwgaGVpZ2h0OwotICAgIGhyID0gZnJhbWUt PkdldFNpemUoJndpZHRoLCAmaGVpZ2h0KTsKLSAgICBpZiAoIVNVQ0NFRURFRChocikpCi0gICAg ICAgIHJldHVybiAwOwotCi0gICAgcmV0dXJuIHdpZHRoICogaGVpZ2h0ICogNDsKKyAgICBhdXRv IGZyYW1lU2l6ZSA9IGZyYW1lU2l6ZUF0SW5kZXgoaW5kZXgsIHN1YnNhbXBsaW5nTGV2ZWwpOwor ICAgIHJldHVybiBmcmFtZVNpemUuYXJlYSgpICogNDsKIH0KIAogdm9pZCBJbWFnZURlY29kZXI6 OnNldFRhcmdldENvbnRleHQoSUQyRDFSZW5kZXJUYXJnZXQqIHJlbmRlclRhcmdldCkK