162944 2016-10-04 15:17:22 -0700 Add Megan to contributor's list 2016-10-04 16:23:11 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 megan_gardner webkit-unassigned bdakin commit-queue glenn megan_gardner simon.fraser thorton oldest_to_newest 1236385 0 megan_gardner 2016-10-04 15:17:22 -0700 Add Megan to committer's list 1236386 1 290652 megan_gardner 2016-10-04 15:17:41 -0700 Created attachment 290652 Patch 1236398 2 290652 bdakin 2016-10-04 15:33:49 -0700 Comment on attachment 290652 Patch Oh, sorry for not explaining the process better! We will have to nominate you to be a committer, so this patch will come later. 1236399 3 bdakin 2016-10-04 15:37:23 -0700 (In reply to comment #2) > Comment on attachment 290652 [details] > Patch > > Oh, sorry for not explaining the process better! We will have to nominate > you to be a committer, so this patch will come later. OH! That's the contributors list. I see. Sorry for being thick. Just add a change log, and this will be good. 1236405 4 290652 thorton 2016-10-04 15:39:42 -0700 Comment on attachment 290652 Patch If you want, you can add yourself to the "Contributors" section of the file, down near line 3154, so that your name will autocomplete in places. 1236417 5 290659 megan_gardner 2016-10-04 15:51:59 -0700 Created attachment 290659 Patch 1236418 6 290659 thorton 2016-10-04 15:53:08 -0700 Comment on attachment 290659 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290659&action=review > Tools/Scripts/webkitpy/common/config/contributors.json:4691 > + "Megan Gardner" : { You went too far! This is the reviewers section. 1236420 7 290660 megan_gardner 2016-10-04 15:58:06 -0700 Created attachment 290660 Patch 1236434 8 290660 commit-queue 2016-10-04 16:23:07 -0700 Comment on attachment 290660 Patch Clearing flags on attachment: 290660 Committed r206793: <http://trac.webkit.org/changeset/206793> 1236435 9 commit-queue 2016-10-04 16:23:11 -0700 All reviewed patches have been landed. Closing bug. 290652 2016-10-04 15:17:41 -0700 2016-10-04 15:51:54 -0700 Patch bug-162944-20161004151430.patch text/plain 625 megan_gardner SW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMu anNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcv Y29udHJpYnV0b3JzLmpzb24JKHJldmlzaW9uIDIwNjY0NikKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbgkod29ya2luZyBjb3B5KQpAQCAt MjExOCw2ICsyMTE4LDE0IEBACiAgICAgICAgICAgICAibWF4aW1lLnNpbW9uIgogICAgICAgICAg XQogICAgICAgfSwKKyAgICAgICJNZWdhbiBHYXJkbmVyIiA6IHsKKyAgICAgICAgICJlbWFpbHMi IDogWworICAgICAgICAgICAgIm1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tIgorICAgICAgICAgXSwK KyAgICAgICAgICJuaWNrcyIgOiBbCisgICAgICAgICAgICAiR2FtZU1ha2VyIgorICAgICAgICAg XQorICAgICAgIH0sCiAgICAgICAiTWljaGFlbCBCclx1MDBmY25pbmciIDogewogICAgICAgICAg ImVtYWlscyIgOiBbCiAgICAgICAgICAgICAibWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbSIsCg== 290659 2016-10-04 15:51:59 -0700 2016-10-04 15:58:02 -0700 Patch bug-162944-20161004154848.patch text/plain 1253 megan_gardner SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNjc4OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTEwLTA0ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBs ZS5jb20+CisKKyAgICAgICAgQWRkIE1lZ2FuIHRvIGNvbnRyaWJ1dG9yJ3MgbGlzdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyOTQ0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIE1lZ2FuIHRvIHRo ZSBjb250cmlidXRvcidzIGxpc3RzIHNvIHRoYXQgaGVyIGUtbWFpbCBhdXRvY29tcGxldGVzIGZv ciBDQworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbnRyaWJ1 dG9ycy5qc29uOgorCiAyMDE2LTEwLTA0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBs ZS5jb20+CiAKICAgICAgICAgUHJvcGVybHkga2lsbCB3ZWIgcHJvY2Vzc2VzIGluIHRoZSBsYXVu Y2hpbmcgc3RhdGUKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9j b250cmlidXRvcnMuanNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jb25maWcvY29udHJpYnV0b3JzLmpzb24JKHJldmlzaW9uIDIwNjY0NikKKysrIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbgkod29ya2lu ZyBjb3B5KQpAQCAtNDY4OCw2ICs0Njg4LDE0IEBACiAgICAgICAgICAgICAibWF0dGJha2VyIgog ICAgICAgICAgXQogICAgICAgfSwKKyAgICAgICJNZWdhbiBHYXJkbmVyIiA6IHsKKyAgICAgICAg ICJlbWFpbHMiIDogWworICAgICAgICAgICAgIm1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tIgorICAg ICAgICAgXSwKKyAgICAgICAgICJuaWNrcyIgOiBbCisgICAgICAgICAgICAiR2FtZU1ha2VyIgor ICAgICAgICAgXQorICAgICAgfSwKICAgICAgICJNaWNoYWVsIENhdGFuemFybyIgOiB7CiAgICAg ICAgICAiZW1haWxzIiA6IFsKICAgICAgICAgICAgICJtY2F0YW56YXJvQGlnYWxpYS5jb20iLAo= 290660 2016-10-04 15:58:06 -0700 2016-10-04 16:23:07 -0700 Patch bug-162944-20161004155455.patch text/plain 1240 megan_gardner SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNjc4OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTEwLTA0ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBs ZS5jb20+CisKKyAgICAgICAgQWRkIE1lZ2FuIHRvIGNvbnRyaWJ1dG9yJ3MgbGlzdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyOTQ0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIE1lZ2FuIHRvIHRo ZSBjb250cmlidXRvcidzIGxpc3RzIHNvIHRoYXQgaGVyIGUtbWFpbCBhdXRvY29tcGxldGVzIGZv ciBDQworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbnRyaWJ1 dG9ycy5qc29uOgorCiAyMDE2LTEwLTA0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBs ZS5jb20+CiAKICAgICAgICAgUHJvcGVybHkga2lsbCB3ZWIgcHJvY2Vzc2VzIGluIHRoZSBsYXVu Y2hpbmcgc3RhdGUKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9j b250cmlidXRvcnMuanNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jb25maWcvY29udHJpYnV0b3JzLmpzb24JKHJldmlzaW9uIDIwNjY0NikKKysrIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbgkod29ya2lu ZyBjb3B5KQpAQCAtMzQ5Nyw2ICszNDk3LDE0IEBACiAgICAgICAgICAgICAiaG1hcnRpbiIKICAg ICAgICAgIF0KICAgICAgIH0sCisgICAgICAiTWVnYW4gR2FyZG5lciIgOiB7CisgICAgICAgICAi ZW1haWxzIiA6IFsKKyAgICAgICAgICAgICJtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbSIKKyAgICAg ICAgIF0sCisgICAgICAgICAibmlja3MiIDogWworICAgICAgICAgICAgIkdhbWVNYWtlciIKKyAg ICAgICAgIF0KKyAgICAgIH0sCiAgICAgICAiTWloYWkgQmFsYW4iIDogewogICAgICAgICAgImVt YWlscyIgOiBbCiAgICAgICAgICAgICAibWliYWxhbkBhZG9iZS5jb20iCg==