16290 2007-12-04 07:28:15 -0800 [GTK] Pasting clipboard in rich text 2007-12-05 12:28:01 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 0 lethalman88 webkit-unassigned alp lethalman88 oldest_to_newest 63244 0 lethalman88 2007-12-04 07:28:15 -0800 Hello, i created a patch which implements documentFragment but doesn't work pretty well. The problem is that the fragment is not pasted everywhere (in blogger for example). I don't think at all it's a problem if how documentFragment has been implemented. Any hint? 63245 1 17702 lethalman88 2007-12-04 07:29:41 -0800 Created attachment 17702 documentFragment implementation 63320 2 17712 lethalman88 2007-12-05 01:13:11 -0800 Created attachment 17712 complete patch I written this code according to the Qt implementation, and i think for now it's both complete and enough. 63363 3 alp 2007-12-05 10:53:33 -0800 This works well. Can you fix up the patch so: There are no spaces before parentheses: gdk_atom_intern_static_string ("text/html") ChangeLog should use spaces not tabs. Reviewer field should be left empty. + if (fragment) + return fragment.release(); + } + gtk_selection_data_free (data); This looks like a leak. data isn't freed when returning early. Thanks! 63366 4 alp 2007-12-05 11:12:46 -0800 String text = String::fromUTF8(gtk_clipboard_wait_for_text(clipboard)); This is also a leak. The return value must be freed -- see the code a few lines below for an example. 63369 5 17723 lethalman88 2007-12-05 11:25:20 -0800 Created attachment 17723 corrected patch Thanks for all these hints. Hope this is good this time. 63371 6 17723 alp 2007-12-05 12:27:23 -0800 Comment on attachment 17723 corrected patch r=me with the changes we discussed. 63372 7 alp 2007-12-05 12:28:01 -0800 Landed in r28448. Thanks, looking forward to copying support! 17702 2007-12-04 07:29:41 -0800 2007-12-05 01:13:11 -0800 documentFragment implementation richtextpaste.patch text/plain 1905 lethalman88 SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRHdGsuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRHdGsuY3BwCShyZXZpc2lvbiAyODM4 OCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRHdGsuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zOSw2ICszOSw3IEBACiAjaW5jbHVkZSAiSW1hZ2UuaCIKICNpbmNsdWRlICJSZW5k ZXJJbWFnZS5oIgogI2luY2x1ZGUgIktVUkwuaCIKKyNpbmNsdWRlICJtYXJrdXAuaCIKIAogI2lu Y2x1ZGUgPGd0ay9ndGsuaD4KIApAQCAtMTA2LDkgKzEwNywzNCBAQAogICAgIHJldHVybiBmYWxz ZTsKIH0KIAotUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBQYXN0ZWJvYXJkOjpkb2N1bWVu dEZyYWdtZW50KEZyYW1lKiwgUGFzc1JlZlB0cjxSYW5nZT4sIGJvb2wsIGJvb2wmKQorUGFzc1Jl ZlB0cjxEb2N1bWVudEZyYWdtZW50PiBQYXN0ZWJvYXJkOjpkb2N1bWVudEZyYWdtZW50KEZyYW1l KiBmcmFtZSwgUGFzc1JlZlB0cjxSYW5nZT4gY29udGV4dCwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIGFsbG93UGxhaW5UZXh0 LCBib29sJiBjaG9zZVBsYWluVGV4dCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIEd0 a1NlbGVjdGlvbkRhdGEgKmRhdGE7CisgICAgR2RrQXRvbSB0ZXh0X2h0bWwgPSBnZGtfYXRvbV9p bnRlcm5fc3RhdGljX3N0cmluZyAoInRleHQvaHRtbCIpOworICAgIEd0a0NsaXBib2FyZCogY2xp cGJvYXJkID0gZ3RrX2NsaXBib2FyZF9nZXRfZm9yX2Rpc3BsYXkoZ2RrX2Rpc3BsYXlfZ2V0X2Rl ZmF1bHQoKSwgR0RLX1NFTEVDVElPTl9DTElQQk9BUkQpOworCisgICAgY2hvc2VQbGFpblRleHQg PSBmYWxzZTsKKyAgICBwdXRzKCJ5ZSIpOworICAgIGlmIChndGtfY2xpcGJvYXJkX3dhaXRfaXNf dGFyZ2V0X2F2YWlsYWJsZShjbGlwYm9hcmQsIHRleHRfaHRtbCkpIHsKKyAgICAgICAgZGF0YSA9 IGd0a19jbGlwYm9hcmRfd2FpdF9mb3JfY29udGVudHMoY2xpcGJvYXJkLCB0ZXh0X2h0bWwpOwor ICAgICAgICBTdHJpbmcgaHRtbCA9IFN0cmluZzo6ZnJvbVVURjggKChjb25zdCBnY2hhciAqKWRh dGEtPmRhdGErMiwgZGF0YS0+bGVuZ3RoICogZGF0YS0+Zm9ybWF0IC8gOCk7CisgICAgICAgIGlm ICghaHRtbC5pc0VtcHR5KCkpIHsKKyAgICAgICAgICAgIFJlZlB0cjxEb2N1bWVudEZyYWdtZW50 PiBmcmFnbWVudCA9IGNyZWF0ZUZyYWdtZW50RnJvbU1hcmt1cChmcmFtZS0+ZG9jdW1lbnQoKSwg aHRtbCwgIiIpOworICAgICAgICAgICAgaWYgKGZyYWdtZW50KQorICAgICAgICAgICAgICAgIHJl dHVybiBmcmFnbWVudC5yZWxlYXNlKCk7CisgICAgICAgIH0KKyAgICAgICAgZ3RrX3NlbGVjdGlv bl9kYXRhX2ZyZWUgKGRhdGEpOworICAgIH0KKworICAgIGlmIChhbGxvd1BsYWluVGV4dCAmJiBn dGtfY2xpcGJvYXJkX3dhaXRfaXNfdGV4dF9hdmFpbGFibGUoY2xpcGJvYXJkKSkgeworICAgICAg ICBjaG9zZVBsYWluVGV4dCA9IHRydWU7CisgICAgICAgIFJlZlB0cjxEb2N1bWVudEZyYWdtZW50 PiBmcmFnbWVudCA9IGNyZWF0ZUZyYWdtZW50RnJvbVRleHQoY29udGV4dC5nZXQoKSwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBndGtfY2xpcGJvYXJkX3dhaXRfZm9yX3RleHQoY2xpcGJvYXJkKSk7CisgICAgICAgIGlm IChmcmFnbWVudCkKKyAgICAgICAgICAgIHJldHVybiBmcmFnbWVudC5yZWxlYXNlKCk7CisgICAg fQorCiAgICAgcmV0dXJuIDA7CiB9CiAK 17712 2007-12-05 01:13:11 -0800 2007-12-05 11:25:20 -0800 complete patch richtextpaste.patch text/plain 2406 lethalman88 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODQzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTAgQEAKKzIwMDctMTItMDUgIEx1Y2EgQnJ1bm8gIDxsZXRoYWxtYW44OEBnbWFp bC5jb20+CisKKwlSZXZpZXdlZCBieSBBbHAgVG9rZXIuCisKKwkqIHBsYXRmb3JtL2d0ay9QYXN0 ZWJvYXJkR3RrLmNwcDoKKwkoUGFzdGVib2FyZDo6ZG9jdW1lbnRGcmFnbWVudCk6IEltcGxlbWVu dGVkIGZvciBwYXN0aW5nIHJpY2ggdGV4dAorCiAyMDA3LTEyLTA0ICBBbHAgVG9rZXIgIDxhbHBA YXRva2VyLmNvbT4KIAogICAgICAgICBQb3RlbnRpYWwgR1RLKyBidWlsZCBmaXggZm9yIHRoZSBn bGliLWdlbm1hcnNoYWwgaXNzdWUuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0ZWJv YXJkR3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0ZWJvYXJk R3RrLmNwcAkocmV2aXNpb24gMjg0MzYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0ZWJv YXJkR3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzksNiArMzksNyBAQAogI2luY2x1ZGUgIklt YWdlLmgiCiAjaW5jbHVkZSAiUmVuZGVySW1hZ2UuaCIKICNpbmNsdWRlICJLVVJMLmgiCisjaW5j bHVkZSAibWFya3VwLmgiCiAKICNpbmNsdWRlIDxndGsvZ3RrLmg+CiAKQEAgLTEwNiw5ICsxMDcs MzYgQEAKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLVBhc3NSZWZQdHI8RG9jdW1lbnRGcmFnbWVu dD4gUGFzdGVib2FyZDo6ZG9jdW1lbnRGcmFnbWVudChGcmFtZSosIFBhc3NSZWZQdHI8UmFuZ2U+ LCBib29sLCBib29sJikKK1Bhc3NSZWZQdHI8RG9jdW1lbnRGcmFnbWVudD4gUGFzdGVib2FyZDo6 ZG9jdW1lbnRGcmFnbWVudChGcmFtZSogZnJhbWUsIFBhc3NSZWZQdHI8UmFuZ2U+IGNvbnRleHQs CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgYm9vbCBhbGxvd1BsYWluVGV4dCwgYm9vbCYgY2hvc2VQbGFpblRleHQpCiB7Ci0gICAgbm90 SW1wbGVtZW50ZWQoKTsKKyAgICBHdGtTZWxlY3Rpb25EYXRhICpkYXRhOworICAgIEdka0F0b20g dGV4dF9odG1sID0gZ2RrX2F0b21faW50ZXJuX3N0YXRpY19zdHJpbmcgKCJ0ZXh0L2h0bWwiKTsK KyAgICBHdGtDbGlwYm9hcmQqIGNsaXBib2FyZCA9IGd0a19jbGlwYm9hcmRfZ2V0X2Zvcl9kaXNw bGF5KGdka19kaXNwbGF5X2dldF9kZWZhdWx0KCksIEdES19TRUxFQ1RJT05fQ0xJUEJPQVJEKTsK KworICAgIGNob3NlUGxhaW5UZXh0ID0gZmFsc2U7CisKKyAgICBpZiAoZ3RrX2NsaXBib2FyZF93 YWl0X2lzX3RhcmdldF9hdmFpbGFibGUoY2xpcGJvYXJkLCB0ZXh0X2h0bWwpKSB7CisgICAgICAg IGRhdGEgPSBndGtfY2xpcGJvYXJkX3dhaXRfZm9yX2NvbnRlbnRzKGNsaXBib2FyZCwgdGV4dF9o dG1sKTsKKyAgICAgICAgaWYgKGRhdGEpIHsKKyAgICAgICAgICAgIFN0cmluZyBodG1sID0gU3Ry aW5nOjpmcm9tVVRGOCAoKGNvbnN0IGdjaGFyICopZGF0YS0+ZGF0YSwgZGF0YS0+bGVuZ3RoICog ZGF0YS0+Zm9ybWF0IC8gOCk7CisgICAgICAgICAgICBpZiAoIWh0bWwuaXNFbXB0eSgpKSB7Cisg ICAgICAgICAgICAgICAgUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IGZyYWdtZW50ID0gY3JlYXRl RnJhZ21lbnRGcm9tTWFya3VwKGZyYW1lLT5kb2N1bWVudCgpLCBodG1sLCAiIik7CisgICAgICAg ICAgICAgICAgaWYgKGZyYWdtZW50KQorICAgICAgICAgICAgICAgICAgICByZXR1cm4gZnJhZ21l bnQucmVsZWFzZSgpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgZ3RrX3NlbGVjdGlvbl9k YXRhX2ZyZWUgKGRhdGEpOworICAgICAgICB9CisgICAgfQorCisgICAgaWYgKGFsbG93UGxhaW5U ZXh0ICYmIGd0a19jbGlwYm9hcmRfd2FpdF9pc190ZXh0X2F2YWlsYWJsZShjbGlwYm9hcmQpKSB7 CisgICAgICAgIGNob3NlUGxhaW5UZXh0ID0gdHJ1ZTsKKyAgICAgICAgU3RyaW5nIHRleHQgPSBT dHJpbmc6OmZyb21VVEY4IChndGtfY2xpcGJvYXJkX3dhaXRfZm9yX3RleHQoY2xpcGJvYXJkKSk7 CisgICAgICAgIFJlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBmcmFnbWVudCA9IGNyZWF0ZUZyYWdt ZW50RnJvbVRleHQoY29udGV4dC5nZXQoKSwgdGV4dCk7CisgICAgICAgIGlmIChmcmFnbWVudCkK KyAgICAgICAgICAgIHJldHVybiBmcmFnbWVudC5yZWxlYXNlKCk7CisgICAgfQorCiAgICAgcmV0 dXJuIDA7CiB9CiAK 17723 2007-12-05 11:25:20 -0800 2007-12-05 12:27:23 -0800 corrected patch richtextpaste.patch text/plain 2548 lethalman88 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODQ0MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDctMTItMDUgIEx1Y2EgQnJ1bm8gIDxsZXRoYWxtYW44OEBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZLgorCisgICAgICAgIGh0dHA6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjkwCisgICAgICAgIFtHVEtdIFBhc3Rp bmcgY2xpcGJvYXJkIGluIHJpY2ggdGV4dC4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9QYXN0 ZWJvYXJkR3RrLmNwcDoKKyAgICAgICAgKFBhc3RlYm9hcmQ6OmRvY3VtZW50RnJhZ21lbnQpOiBJ bXBsZW1lbnRlZCBmb3IgcGFzdGluZyByaWNoIHRleHQKKwogMjAwNy0xMi0wNCAgQWxwIFRva2Vy ICA8YWxwQGF0b2tlci5jb20+CiAKICAgICAgICAgUG90ZW50aWFsIEdUSysgYnVpbGQgZml4IGZv ciB0aGUgZ2xpYi1nZW5tYXJzaGFsIGlzc3VlLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ndGsv UGFzdGVib2FyZEd0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFz dGVib2FyZEd0ay5jcHAJKHJldmlzaW9uIDI4NDQwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ndGsv UGFzdGVib2FyZEd0ay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDYgKzM5LDcgQEAKICNpbmNs dWRlICJJbWFnZS5oIgogI2luY2x1ZGUgIlJlbmRlckltYWdlLmgiCiAjaW5jbHVkZSAiS1VSTC5o IgorI2luY2x1ZGUgIm1hcmt1cC5oIgogCiAjaW5jbHVkZSA8Z3RrL2d0ay5oPgogCkBAIC0xMDYs OSArMTA3LDM4IEBACiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi1QYXNzUmVmUHRyPERvY3VtZW50 RnJhZ21lbnQ+IFBhc3RlYm9hcmQ6OmRvY3VtZW50RnJhZ21lbnQoRnJhbWUqLCBQYXNzUmVmUHRy PFJhbmdlPiwgYm9vbCwgYm9vbCYpCitQYXNzUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IFBhc3Rl Ym9hcmQ6OmRvY3VtZW50RnJhZ21lbnQoRnJhbWUqIGZyYW1lLCBQYXNzUmVmUHRyPFJhbmdlPiBj b250ZXh0LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGJvb2wgYWxsb3dQbGFpblRleHQsIGJvb2wmIGNob3NlUGxhaW5UZXh0KQogewot ICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgR3RrU2VsZWN0aW9uRGF0YSogZGF0YTsKKyAgICBH ZGtBdG9tIHRleHRIdG1sID0gZ2RrX2F0b21faW50ZXJuX3N0YXRpY19zdHJpbmcoInRleHQvaHRt bCIpOworICAgIEd0a0NsaXBib2FyZCogY2xpcGJvYXJkID0gZ3RrX2NsaXBib2FyZF9nZXRfZm9y X2Rpc3BsYXkoZ2RrX2Rpc3BsYXlfZ2V0X2RlZmF1bHQoKSwgR0RLX1NFTEVDVElPTl9DTElQQk9B UkQpOworCisgICAgY2hvc2VQbGFpblRleHQgPSBmYWxzZTsKKworICAgIGlmIChndGtfY2xpcGJv YXJkX3dhaXRfaXNfdGFyZ2V0X2F2YWlsYWJsZShjbGlwYm9hcmQsIHRleHRIdG1sKSkgeworICAg ICAgICBkYXRhID0gZ3RrX2NsaXBib2FyZF93YWl0X2Zvcl9jb250ZW50cyhjbGlwYm9hcmQsIHRl eHRIdG1sKTsKKyAgICAgICAgQVNTRVJUKGRhdGEpOworICAgICAgICBTdHJpbmcgaHRtbCA9IFN0 cmluZzo6ZnJvbVVURjgocmVpbnRlcnByZXRfY2FzdDxnY2hhcio+KGRhdGEtPmRhdGEpLCBkYXRh LT5sZW5ndGggKiBkYXRhLT5mb3JtYXQgLyA4KTsKKyAgICAgICAgZ3RrX3NlbGVjdGlvbl9kYXRh X2ZyZWUoZGF0YSk7CisgICAgICAgIGlmICghaHRtbC5pc0VtcHR5KCkpIHsKKyAgICAgICAgICAg IFJlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBmcmFnbWVudCA9IGNyZWF0ZUZyYWdtZW50RnJvbU1h cmt1cChmcmFtZS0+ZG9jdW1lbnQoKSwgaHRtbCwgIiIpOworICAgICAgICAgICAgaWYgKGZyYWdt ZW50KQorICAgICAgICAgICAgICAgIHJldHVybiBmcmFnbWVudC5yZWxlYXNlKCk7CisgICAgICAg IH0KKyAgICB9CisKKyAgICBpZiAoYWxsb3dQbGFpblRleHQgJiYgZ3RrX2NsaXBib2FyZF93YWl0 X2lzX3RleHRfYXZhaWxhYmxlKGNsaXBib2FyZCkpIHsKKyAgICAgICAgZ2NoYXIqIHV0ZjggPSBn dGtfY2xpcGJvYXJkX3dhaXRfZm9yX3RleHQoY2xpcGJvYXJkKTsKKyAgICAgICAgU3RyaW5nIHRl eHQgPSBTdHJpbmc6OmZyb21VVEY4KHV0ZjgpOworICAgICAgICBnX2ZyZWUodXRmOCk7CisKKyAg ICAgICAgY2hvc2VQbGFpblRleHQgPSB0cnVlOworICAgICAgICBSZWZQdHI8RG9jdW1lbnRGcmFn bWVudD4gZnJhZ21lbnQgPSBjcmVhdGVGcmFnbWVudEZyb21UZXh0KGNvbnRleHQuZ2V0KCksIHRl eHQpOworICAgICAgICBpZiAoZnJhZ21lbnQpCisgICAgICAgICAgICByZXR1cm4gZnJhZ21lbnQu cmVsZWFzZSgpOworICAgIH0KKwogICAgIHJldHVybiAwOwogfQogCg==