162885 2016-10-03 18:43:19 -0700 Add tests verifying non-special URL hosts are parsed according to spec 2016-10-04 16:17:05 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen annevk oldest_to_newest 1236026 0 achristensen 2016-10-03 18:43:19 -0700 Add tests verifying non-special URL hosts are parsed according to spec 1236027 1 290547 achristensen 2016-10-03 18:43:31 -0700 Created attachment 290547 Patch 1236030 2 achristensen 2016-10-03 18:48:08 -0700 The host parsing in https://url.spec.whatwg.org is a deviation from the behavior of Chrome, Firefox, and Safari, and there are no web platform tests verifying that non-special URLs are parsed the same as special URLs. Try this in different browsers: alert(new URL("notspecial://H%4fSt/path").toString()) It alerts "notspecial://H%4fSt/path" not "notspecial://host/path" as the spec says it should. Maybe I missed something in the spec, maybe the spec should be changed, or maybe it was intentional. 1236109 3 annevk 2016-10-04 01:36:36 -0700 Thanks, I filed https://github.com/whatwg/url/issues/148. I tend to think we should just change the standard. 1236211 4 achristensen 2016-10-04 09:44:16 -0700 I agree. It will increase compatibility. But this means the fragment is no longer the only part of the URL that can have non-ASCII characters :( 1236227 5 achristensen 2016-10-04 10:16:07 -0700 (In reply to comment #4) > But this means the fragment is no longer the only part of the URL that can have non-ASCII characters :( Oh, never mind. non-ASCII characters are percent encoded. 1236429 6 achristensen 2016-10-04 16:17:05 -0700 Nope, we don't want to percent encode things in the host. I think the spec is right and all browsers are wrong for different reasons. Everyone needs to change, ours is to punycode encode non-special hosts. http://trac.webkit.org/changeset/206792 290547 2016-10-03 18:43:31 -0700 2016-10-04 11:56:17 -0700 Patch bug-162885-20161003184022.patch text/plain 1970 achristensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNjc2NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE2LTEwLTAzICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgQWRkIHRlc3RzIHZlcmlmeWluZyBub24tc3BlY2lhbCBVUkwg aG9zdHMgYXJlIHBhcnNlZCBhY2NvcmRpbmcgdG8gc3BlYworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyODg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUv VVJMUGFyc2VyLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1RfRik6CisKIDIwMTYt MTAtMDMgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBVUkxQYXJzZXIgc2hvdWxkIGlnbm9yZSB0YWJzIGF0IGFsbCBsb2NhdGlvbnMKSW5kZXg6 IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9VUkxQYXJzZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9VUkxQYXJzZXIuY3BwCShy ZXZpc2lvbiAyMDY3NTgpCisrKyBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvVVJM UGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODQwLDYgKzg0MCwxOCBAQCBURVNUX0YoVVJM UGFyc2VyVGVzdCwgUGFyc2VyRGlmZmVyZW5jZXMpCiAgICAgY2hlY2tSZWxhdGl2ZVVSTERpZmZl cmVuY2VzKCJodHRwOi8vZjowMTAvYyIsICJodHRwOi8vZXhhbXBsZS5vcmcvZm9vL2JhciIsCiAg ICAgICAgIHsiaHR0cCIsICIiLCAiIiwgImYiLCAxMCwgIi9jIiwgIiIsICIiLCAiaHR0cDovL2Y6 MTAvYyJ9LAogICAgICAgICB7Imh0dHAiLCAiIiwgIiIsICJmIiwgMTAsICIvYyIsICIiLCAiIiwg Imh0dHA6Ly9mOjAxMC9jIn0pOworICAgIAorICAgIC8vIEZJWE1FOiBUaGlzIGRvZXMgbm90IG1h dGNoIHRoZSBiZWhhdmlvciBvZiBDaHJvbWUsIEZpcmVmb3gsIG9yIFNhZmFyaS4KKyAgICAvLyBD aGVjayBpZiBpdCdzIGludGVudGlvbmFsIG9yIGlmIHRoZSBzcGVjIG5lZWRzIGNoYW5naW5nLgor ICAgIGNoZWNrVVJMRGlmZmVyZW5jZXMoIm5vdHNwZWNpYWw6Ly9Ib1N0IiwKKyAgICAgICAgeyJu b3RzcGVjaWFsIiwgIiIsICIiLCAiaG9zdCIsIDAsICIvIiwgIiIsICIiLCAibm90c3BlY2lhbDov L2hvc3QvIn0sCisgICAgICAgIHsibm90c3BlY2lhbCIsICIiLCAiIiwgIkhvU3QiLCAwLCAiIiwg IiIsICIiLCAibm90c3BlY2lhbDovL0hvU3QifSk7CisgICAgY2hlY2tVUkxEaWZmZXJlbmNlcygi bm90c3BlY2lhbDovL0glNGZTdCIsCisgICAgICAgIHsibm90c3BlY2lhbCIsICIiLCAiIiwgImhv c3QiLCAwLCAiLyIsICIiLCAiIiwgIm5vdHNwZWNpYWw6Ly9ob3N0LyJ9LAorICAgICAgICB7Im5v dHNwZWNpYWwiLCAiIiwgIiIsICJIJTRmU3QiLCAwLCAiIiwgIiIsICIiLCAibm90c3BlY2lhbDov L0glNGZTdCJ9KTsKKyAgICBjaGVja1VSTERpZmZlcmVuY2VzKCJub3RzcGVjaWFsOi8vSPCfmI3D n3QiLAorICAgICAgICB7IiIsICIiLCAiIiwgIiIsIDAsICIiLCAiIiwgIiIsICJub3RzcGVjaWFs Oi8vSPCfmI3Dn3QifSwKKyAgICAgICAgeyIiLCAiIiwgIiIsICIiLCAwLCAiIiwgIiIsICIiLCAi YWJvdXQ6YmxhbmsifSwgdGVzdFRhYnNWYWx1ZUZvclN1cnJvZ2F0ZVBhaXJzKTsKIH0KIAogVEVT VF9GKFVSTFBhcnNlclRlc3QsIERlZmF1bHRQb3J0KQo=