162855 2016-10-01 20:37:09 -0700 Add support for KeyboardEvent.getModifierState() operation 2016-10-02 15:15:52 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://w3c.github.io/uievents/#dom-keyboardevent-getmodifierstate WebExposed P2 Normal --- 162852 162861 1 cdumez cdumez achristensen arv cdumez darin rniwa sam webkit oldest_to_newest 1235694 0 cdumez 2016-10-01 20:37:09 -0700 Add support for KeyboardEvent.getModifierState() operation: - https://w3c.github.io/uievents/#dom-keyboardevent-getmodifierstate 1235700 1 webkit 2016-10-01 20:51:20 -0700 *** Bug 40999 has been marked as a duplicate of this bug. *** 1235737 2 290473 cdumez 2016-10-02 12:39:43 -0700 Created attachment 290473 Patch 1235742 3 darin 2016-10-02 14:18:17 -0700 I’m kind of surprised we still had this function sitting around, almost unused but nt quite. Seems like the modifier name is kind of like an enumeration. Surprising that the specification just does it as a string rather than using an enumeration. As a side note, the only existing caller of the getModifierState function, the handleKeyboardSelectionMovement function in EventHandler.cpp, should *not* be using it. It should just be calling the different boolean functions directly. 1235747 4 290473 cdumez 2016-10-02 14:52:11 -0700 Comment on attachment 290473 Patch Clearing flags on attachment: 290473 Committed r206725: <http://trac.webkit.org/changeset/206725> 1235748 5 cdumez 2016-10-02 14:52:16 -0700 All reviewed patches have been landed. Closing bug. 1235750 6 webkit 2016-10-02 15:07:56 -0700 Is there a follow-up bug for support of the remaining modifiers which are listed as TODO in the commit? 1235751 7 cdumez 2016-10-02 15:11:56 -0700 (In reply to comment #6) > Is there a follow-up bug for support of the remaining modifiers which are > listed as TODO in the commit? Not yet, I'll file one soon. 290473 2016-10-02 12:39:43 -0700 2016-10-02 14:52:11 -0700 Patch bug-162855-20161002123635.patch text/plain 7172 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzM1YjhmMTQwZDg2MWZi ZGZlNmMyYTgzMzQ2NTA0ODI3NGI3ZDY4NC4uZGZkOTE5MjEyYjkyYzQ1ZDFjMDI1ZmFhMTc4ODBk ZjZiZGYwNjY1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE2LTEwLTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIEtl eWJvYXJkRXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgpIG9wZXJhdGlvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyODU1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIEtleWJvYXJk RXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgpIG9wZXJhdGlvbjoKKyAgICAgICAgLSBodHRwczovL3cz Yy5naXRodWIuaW8vdWlldmVudHMvI2RvbS1rZXlib2FyZGV2ZW50LWdldG1vZGlmaWVyc3RhdGUK KworICAgICAgICBUZXN0OiBmYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMva2V5Ym9hcmQtZXZlbnQt Z2V0TW9kaWZpZXJTdGF0ZS5odG1sCisKKyAgICAgICAgKiBkb20vS2V5Ym9hcmRFdmVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpLZXlib2FyZEV2ZW50OjpnZXRNb2RpZmllclN0YXRlKToKKyAg ICAgICAgKiBkb20vS2V5Ym9hcmRFdmVudC5pZGw6CisKKzIwMTYtMTAtMDIgIENocmlzIER1bWV6 ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy MjA2NjkyIGFuZCByMjA2NzE4LgogCiAgICAgICAgIFNlZW1zIHRvIGhhdmUgY2F1c2VkID4yMDAg ZmFpbHVyZXMgb24gU2llcnJhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vS2V5Ym9h cmRFdmVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vS2V5Ym9hcmRFdmVudC5jcHAKaW5kZXgg M2JmZmFlMzMxNzIxMjY1N2IzNTMyMDcyNGMwM2Y4NmYwZjE5OTdmYy4uZWYxMjMyZDc5YThiOTRj NjU2NDIwMDdlZTZjYTFlNDg4OWMyYjI1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L0tleWJvYXJkRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50 LmNwcApAQCAtMTY3LDYgKzE2Nyw5IEBAIGJvb2wgS2V5Ym9hcmRFdmVudDo6Z2V0TW9kaWZpZXJT dGF0ZShjb25zdCBTdHJpbmcmIGtleUlkZW50aWZpZXIpIGNvbnN0CiAgICAgICAgIHJldHVybiBh bHRLZXkoKTsKICAgICBpZiAoa2V5SWRlbnRpZmllciA9PSAiTWV0YSIpCiAgICAgICAgIHJldHVy biBtZXRhS2V5KCk7CisgICAgaWYgKGtleUlkZW50aWZpZXIgPT0gIkFsdEdyYXBoIikKKyAgICAg ICAgcmV0dXJuIGFsdEdyYXBoS2V5KCk7CisgICAgLy8gRklYTUU6IFdlIHNob3VsZCBzdXBwb3J0 IENhcHNMb2NrLCBGbiwgRm5Mb2NrLCBIeXBlciwgTnVtTG9jaywgU3VwZXIsIFNjcm9sbExvY2ss IFN5bWJvbCwgU3ltYm9sTG9jay4KICAgICByZXR1cm4gZmFsc2U7CiB9CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9LZXlib2FyZEV2ZW50LmlkbAppbmRleCA4NTJlNWMyZjVlZWI5ZDE2OTY3MTUxM2I1YmMyN2Yx MjFjYzJkZDM5Li42Njc3MTcwNDI4ZTkwNWVkZGJjMjQ4MzE4YjIwNDYwNDBjOTg2Y2VlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vS2V5Ym9hcmRFdmVudC5pZGwKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0tleWJvYXJkRXZlbnQuaWRsCkBAIC0zNyw2ICszNyw4IEBACiAgICAgW0lu aXRpYWxpemVkQnlFdmVudENvbnN0cnVjdG9yXSByZWFkb25seSBhdHRyaWJ1dGUgYm9vbGVhbiBt ZXRhS2V5OwogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFuIGFsdEdyYXBoS2V5OwogCisg ICAgYm9vbGVhbiBnZXRNb2RpZmllclN0YXRlKERPTVN0cmluZyBrZXlBcmcpOworCiAgICAgLy8g RklYTUU6IHRoaXMgZG9lcyBub3QgbWF0Y2ggdGhlIHZlcnNpb24gaW4gdGhlIERPTSBzcGVjLgog ICAgIC8vIEZJWE1FOiBVc2luZyAidW5kZWZpbmVkIiBhcyBkZWZhdWx0IHBhcmFtZXRlciB2YWx1 ZSBpcyB3cm9uZy4KICAgICB2b2lkIGluaXRLZXlib2FyZEV2ZW50KG9wdGlvbmFsIERPTVN0cmlu ZyB0eXBlID0gInVuZGVmaW5lZCIsIG9wdGlvbmFsIGJvb2xlYW4gY2FuQnViYmxlID0gZmFsc2Us IG9wdGlvbmFsIGJvb2xlYW4gY2FuY2VsYWJsZSA9IGZhbHNlLApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg2OTVlY2VjODkw MWU0ZWYyYjU0MDRlZWE0ZTZiMTQ4NWM5NzQxZGIuLmM5NTVhZTg0NTc1YzFmZGJiYTRmYTRlMWQz YzJlNzc4NjMyNTQ5ZmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxNi0xMC0wMiAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBLZXli b2FyZEV2ZW50LmdldE1vZGlmaWVyU3RhdGUoKSBvcGVyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Mjg1NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBsYXlvdXQgdGVzdCBjb3ZlcmFnZS4K KworICAgICAgICAqIGZhc3QvZXZlbnRzL2NvbnN0cnVjdG9ycy9rZXlib2FyZC1ldmVudC1nZXRN b2RpZmllclN0YXRlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9ldmVudHMv Y29uc3RydWN0b3JzL2tleWJvYXJkLWV2ZW50LWdldE1vZGlmaWVyU3RhdGUuaHRtbDogQWRkZWQu CisKKzIwMTYtMTAtMDIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjA2NjkyIGFuZCByMjA2NzE4LgogCiAgICAgICAg IFNlZW1zIHRvIGhhdmUgY2F1c2VkID4yMDAgZmFpbHVyZXMgb24gU2llcnJhCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMva2V5Ym9hcmQtZXZlbnQtZ2V0 TW9kaWZpZXJTdGF0ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jb25z dHJ1Y3RvcnMva2V5Ym9hcmQtZXZlbnQtZ2V0TW9kaWZpZXJTdGF0ZS1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uODE5NDI0NzEyODgwZGU3N2QzMzJiMzBmMDhjN2RhM2YwYzQwNWVhYgotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NvbnN0cnVjdG9ycy9rZXlib2Fy ZC1ldmVudC1nZXRNb2RpZmllclN0YXRlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMzIEBACitU aGlzIHRlc3RzIEtleWJvYXJkRXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgpLgorCitPbiBzdWNjZXNz LCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAi VEVTVCBDT01QTEVURSIuCisKKworUEFTUyBldmVudC5nZXRNb2RpZmllclN0YXRlKCdDb250cm9s JykgaXMgZmFsc2UKK1BBU1MgZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnQWx0JykgaXMgZmFsc2UK K1BBU1MgZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnU2hpZnQnKSBpcyBmYWxzZQorUEFTUyBldmVu dC5nZXRNb2RpZmllclN0YXRlKCdNZXRhJykgaXMgZmFsc2UKK1BBU1MgZXZlbnQuZ2V0TW9kaWZp ZXJTdGF0ZSgnQ29udHJvbCcpIGlzIHRydWUKK1BBU1MgZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgn QWx0JykgaXMgZmFsc2UKK1BBU1MgZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnU2hpZnQnKSBpcyBm YWxzZQorUEFTUyBldmVudC5nZXRNb2RpZmllclN0YXRlKCdNZXRhJykgaXMgZmFsc2UKK1BBU1Mg ZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnQ29udHJvbCcpIGlzIGZhbHNlCitQQVNTIGV2ZW50Lmdl dE1vZGlmaWVyU3RhdGUoJ0FsdCcpIGlzIHRydWUKK1BBU1MgZXZlbnQuZ2V0TW9kaWZpZXJTdGF0 ZSgnU2hpZnQnKSBpcyBmYWxzZQorUEFTUyBldmVudC5nZXRNb2RpZmllclN0YXRlKCdNZXRhJykg aXMgZmFsc2UKK1BBU1MgZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnQ29udHJvbCcpIGlzIGZhbHNl CitQQVNTIGV2ZW50LmdldE1vZGlmaWVyU3RhdGUoJ0FsdCcpIGlzIGZhbHNlCitQQVNTIGV2ZW50 LmdldE1vZGlmaWVyU3RhdGUoJ1NoaWZ0JykgaXMgdHJ1ZQorUEFTUyBldmVudC5nZXRNb2RpZmll clN0YXRlKCdNZXRhJykgaXMgZmFsc2UKK1BBU1MgZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnQ29u dHJvbCcpIGlzIGZhbHNlCitQQVNTIGV2ZW50LmdldE1vZGlmaWVyU3RhdGUoJ0FsdCcpIGlzIGZh bHNlCitQQVNTIGV2ZW50LmdldE1vZGlmaWVyU3RhdGUoJ1NoaWZ0JykgaXMgZmFsc2UKK1BBU1Mg ZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnTWV0YScpIGlzIHRydWUKK1BBU1MgZXZlbnQuZ2V0TW9k aWZpZXJTdGF0ZSgnQ29udHJvbCcpIGlzIHRydWUKK1BBU1MgZXZlbnQuZ2V0TW9kaWZpZXJTdGF0 ZSgnQWx0JykgaXMgdHJ1ZQorUEFTUyBldmVudC5nZXRNb2RpZmllclN0YXRlKCdTaGlmdCcpIGlz IHRydWUKK1BBU1MgZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnTWV0YScpIGlzIHRydWUKK1BBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMva2V5Ym9hcmQtZXZlbnQtZ2V0 TW9kaWZpZXJTdGF0ZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY29uc3RydWN0b3Jz L2tleWJvYXJkLWV2ZW50LWdldE1vZGlmaWVyU3RhdGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mMzQ4M2Fj MzI3Mzg2YTQ5YWFhM2RjODk5OWJjNGEzZmI3Nzg0YjA5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9ldmVudHMvY29uc3RydWN0b3JzL2tleWJvYXJkLWV2ZW50LWdldE1vZGlm aWVyU3RhdGUuaHRtbApAQCAtMCwwICsxLDQ5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHNjcmlwdD4KKworZGVzY3JpcHRpb24oIlRoaXMg dGVzdHMgS2V5Ym9hcmRFdmVudC5nZXRNb2RpZmllclN0YXRlKCkuIik7CisKK3ZhciBldmVudCA9 IG5ldyBLZXlib2FyZEV2ZW50KCdrZXlkb3duJywgeyB9KTsKK3Nob3VsZEJlRmFsc2UoImV2ZW50 LmdldE1vZGlmaWVyU3RhdGUoJ0NvbnRyb2wnKSIpOworc2hvdWxkQmVGYWxzZSgiZXZlbnQuZ2V0 TW9kaWZpZXJTdGF0ZSgnQWx0JykiKTsKK3Nob3VsZEJlRmFsc2UoImV2ZW50LmdldE1vZGlmaWVy U3RhdGUoJ1NoaWZ0JykiKTsKK3Nob3VsZEJlRmFsc2UoImV2ZW50LmdldE1vZGlmaWVyU3RhdGUo J01ldGEnKSIpOworCit2YXIgZXZlbnQgPSBuZXcgS2V5Ym9hcmRFdmVudCgna2V5ZG93bicsIHsg Y3RybEtleTogdHJ1ZSB9KTsKK3Nob3VsZEJlVHJ1ZSgiZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgn Q29udHJvbCcpIik7CitzaG91bGRCZUZhbHNlKCJldmVudC5nZXRNb2RpZmllclN0YXRlKCdBbHQn KSIpOworc2hvdWxkQmVGYWxzZSgiZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnU2hpZnQnKSIpOwor c2hvdWxkQmVGYWxzZSgiZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnTWV0YScpIik7CisKK3ZhciBl dmVudCA9IG5ldyBLZXlib2FyZEV2ZW50KCdrZXlkb3duJywgeyBhbHRLZXk6IHRydWUgfSk7Citz aG91bGRCZUZhbHNlKCJldmVudC5nZXRNb2RpZmllclN0YXRlKCdDb250cm9sJykiKTsKK3Nob3Vs ZEJlVHJ1ZSgiZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnQWx0JykiKTsKK3Nob3VsZEJlRmFsc2Uo ImV2ZW50LmdldE1vZGlmaWVyU3RhdGUoJ1NoaWZ0JykiKTsKK3Nob3VsZEJlRmFsc2UoImV2ZW50 LmdldE1vZGlmaWVyU3RhdGUoJ01ldGEnKSIpOworCit2YXIgZXZlbnQgPSBuZXcgS2V5Ym9hcmRF dmVudCgna2V5ZG93bicsIHsgc2hpZnRLZXk6IHRydWUgfSk7CitzaG91bGRCZUZhbHNlKCJldmVu dC5nZXRNb2RpZmllclN0YXRlKCdDb250cm9sJykiKTsKK3Nob3VsZEJlRmFsc2UoImV2ZW50Lmdl dE1vZGlmaWVyU3RhdGUoJ0FsdCcpIik7CitzaG91bGRCZVRydWUoImV2ZW50LmdldE1vZGlmaWVy U3RhdGUoJ1NoaWZ0JykiKTsKK3Nob3VsZEJlRmFsc2UoImV2ZW50LmdldE1vZGlmaWVyU3RhdGUo J01ldGEnKSIpOworCit2YXIgZXZlbnQgPSBuZXcgS2V5Ym9hcmRFdmVudCgna2V5ZG93bicsIHsg bWV0YUtleTogdHJ1ZSB9KTsKK3Nob3VsZEJlRmFsc2UoImV2ZW50LmdldE1vZGlmaWVyU3RhdGUo J0NvbnRyb2wnKSIpOworc2hvdWxkQmVGYWxzZSgiZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnQWx0 JykiKTsKK3Nob3VsZEJlRmFsc2UoImV2ZW50LmdldE1vZGlmaWVyU3RhdGUoJ1NoaWZ0JykiKTsK K3Nob3VsZEJlVHJ1ZSgiZXZlbnQuZ2V0TW9kaWZpZXJTdGF0ZSgnTWV0YScpIik7CisKK3ZhciBl dmVudCA9IG5ldyBLZXlib2FyZEV2ZW50KCdrZXlkb3duJywgeyBjdHJsS2V5OiB0cnVlLCBhbHRL ZXk6IHRydWUsIHNoaWZ0S2V5OiB0cnVlLCBtZXRhS2V5OiB0cnVlIH0pOworc2hvdWxkQmVUcnVl KCJldmVudC5nZXRNb2RpZmllclN0YXRlKCdDb250cm9sJykiKTsKK3Nob3VsZEJlVHJ1ZSgiZXZl bnQuZ2V0TW9kaWZpZXJTdGF0ZSgnQWx0JykiKTsKK3Nob3VsZEJlVHJ1ZSgiZXZlbnQuZ2V0TW9k aWZpZXJTdGF0ZSgnU2hpZnQnKSIpOworc2hvdWxkQmVUcnVlKCJldmVudC5nZXRNb2RpZmllclN0 YXRlKCdNZXRhJykiKTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNl cy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=