162854 2016-10-01 20:35:59 -0700 Add support for KeyboardEvent.repeat attribute 2019-06-14 04:40:32 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://w3c.github.io/uievents/#dom-keyboardevent-repeat WebExposed P2 Normal --- 162852 1 cdumez cdumez achristensen ap Brok1966 cdumez commit-queue crianizied40 darin noahwater47 rniwa samsunrock266 sam webkit zhaowanyi815 oldest_to_newest 1235693 0 cdumez 2016-10-01 20:35:59 -0700 Add support for KeyboardEvent.repeat attribute: - https://w3c.github.io/uievents/#dom-keyboardevent-repeat 1235731 1 290472 cdumez 2016-10-02 11:58:19 -0700 Created attachment 290472 Patch 1235741 2 290472 darin 2016-10-02 14:13:21 -0700 Comment on attachment 290472 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290472&action=review > Source/WebCore/dom/KeyboardEvent.cpp:109 > + , m_repeat(key.isAutoRepeat()) There are no tests that cover this code path. 1235745 3 290472 commit-queue 2016-10-02 14:35:54 -0700 Comment on attachment 290472 Patch Clearing flags on attachment: 290472 Committed r206724: <http://trac.webkit.org/changeset/206724> 1235746 4 commit-queue 2016-10-02 14:35:58 -0700 All reviewed patches have been landed. Closing bug. 290472 2016-10-02 11:58:19 -0700 2016-10-02 14:35:54 -0700 Patch bug-162854-20161002115512.patch text/plain 6879 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzM1YjhmMTQwZDg2MWZi ZGZlNmMyYTgzMzQ2NTA0ODI3NGI3ZDY4NC4uYzYwNDMyMDZmMjM2Yzc2ZWMwNWYwZTVhOTI3ZjEx NTMxYjhhYmNhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE2LTEwLTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIEtl eWJvYXJkRXZlbnQucmVwZWF0IGF0dHJpYnV0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyODU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIEtleWJvYXJkRXZlbnQucmVwZWF0 IGF0dHJpYnV0ZToKKyAgICAgICAgLSBodHRwczovL3czYy5naXRodWIuaW8vdWlldmVudHMvI2Rv bS1rZXlib2FyZGV2ZW50LXJlcGVhdAorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgZXh0ZW5kZWQg ZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIGRvbS9LZXlib2FyZEV2ZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OktleWJvYXJkRXZlbnQ6OktleWJvYXJkRXZlbnQpOgorICAgICAgICAqIGRv bS9LZXlib2FyZEV2ZW50Lmg6CisgICAgICAgICogZG9tL0tleWJvYXJkRXZlbnQuaWRsOgorCisy MDE2LTEwLTAyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIwNjY5MiBhbmQgcjIwNjcxOC4KIAogICAgICAgICBTZWVt cyB0byBoYXZlIGNhdXNlZCA+MjAwIGZhaWx1cmVzIG9uIFNpZXJyYQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZG9tL0tleWJvYXJkRXZlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0tl eWJvYXJkRXZlbnQuY3BwCmluZGV4IDNiZmZhZTMzMTcyMTI2NTdiMzUzMjA3MjRjMDNmODZmMGYx OTk3ZmMuLjk3YWRlZWFkZWJiYjZlYjY3MWE4ODJmZTM1ZGRiZTllNjE3NjFiODIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vS2V5Ym9hcmRFdmVudC5jcHAKQEAgLTEwNiw2ICsxMDYsNyBAQCBLZXlib2FyZEV2 ZW50OjpLZXlib2FyZEV2ZW50KGNvbnN0IFBsYXRmb3JtS2V5Ym9hcmRFdmVudCYga2V5LCBET01X aW5kb3cqIHZpZXcpCiAgICAgLCBtX2tleUV2ZW50KHN0ZDo6bWFrZV91bmlxdWU8UGxhdGZvcm1L ZXlib2FyZEV2ZW50PihrZXkpKQogICAgICwgbV9rZXlJZGVudGlmaWVyKGtleS5rZXlJZGVudGlm aWVyKCkpCiAgICAgLCBtX2xvY2F0aW9uKGtleUxvY2F0aW9uQ29kZShrZXkpKQorICAgICwgbV9y ZXBlYXQoa2V5LmlzQXV0b1JlcGVhdCgpKQogICAgICwgbV9hbHRHcmFwaEtleShmYWxzZSkKICNp ZiBQTEFURk9STShDT0NPQSkKICNpZiBVU0UoQVBQS0lUKQpAQCAtMTI4LDYgKzEyOSw3IEBAIEtl eWJvYXJkRXZlbnQ6OktleWJvYXJkRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUs IGNvbnN0IEtleWJvYXJkRXZlbnRJCiAgICAgOiBVSUV2ZW50V2l0aEtleVN0YXRlKGV2ZW50VHlw ZSwgaW5pdGlhbGl6ZXIpCiAgICAgLCBtX2tleUlkZW50aWZpZXIoaW5pdGlhbGl6ZXIua2V5SWRl bnRpZmllcikKICAgICAsIG1fbG9jYXRpb24oaW5pdGlhbGl6ZXIubG9jYXRpb24pCisgICAgLCBt X3JlcGVhdChpbml0aWFsaXplci5yZXBlYXQpCiAgICAgLCBtX2FsdEdyYXBoS2V5KGZhbHNlKQog I2lmIFBMQVRGT1JNKENPQ09BKQogICAgICwgbV9oYW5kbGVkQnlJbnB1dE1ldGhvZChmYWxzZSkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmggYi9Tb3VyY2Uv V2ViQ29yZS9kb20vS2V5Ym9hcmRFdmVudC5oCmluZGV4IDA3ZWRjZTQ5ZDM1MGEzMjA0ODQ4Njgw NWM3ZmJkNmY0ZjkyZDkzN2EuLjNiNzRkNGY2OGUzMDc5NjJlYTA4NGVhNDk1Y2IyNjVjNWQ4ZmY0 ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmgKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL0tleWJvYXJkRXZlbnQuaApAQCAtMzYsNiArMzYsNyBAQCBjbGFz cyBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ7CiBzdHJ1Y3QgS2V5Ym9hcmRFdmVudEluaXQgOiBwdWJs aWMgVUlFdmVudFdpdGhLZXlTdGF0ZUluaXQgewogICAgIFN0cmluZyBrZXlJZGVudGlmaWVyOwog ICAgIHVuc2lnbmVkIGxvY2F0aW9uIHsgMCB9OworICAgIGJvb2wgcmVwZWF0IHsgZmFsc2UgfTsK IH07CiAKIGNsYXNzIEtleWJvYXJkRXZlbnQgZmluYWwgOiBwdWJsaWMgVUlFdmVudFdpdGhLZXlT dGF0ZSB7CkBAIC04MCw2ICs4MSw3IEBAIHB1YmxpYzoKICAgICAKICAgICBjb25zdCBTdHJpbmcm IGtleUlkZW50aWZpZXIoKSBjb25zdCB7IHJldHVybiBtX2tleUlkZW50aWZpZXI7IH0KICAgICB1 bnNpZ25lZCBsb2NhdGlvbigpIGNvbnN0IHsgcmV0dXJuIG1fbG9jYXRpb247IH0KKyAgICBib29s IHJlcGVhdCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVwZWF0OyB9CiAKICAgICBXRUJDT1JFX0VYUE9S VCBib29sIGdldE1vZGlmaWVyU3RhdGUoY29uc3QgU3RyaW5nJiBrZXlJZGVudGlmaWVyKSBjb25z dDsKIApAQCAtMTEzLDYgKzExNSw3IEBAIHByaXZhdGU6CiAgICAgc3RkOjp1bmlxdWVfcHRyPFBs YXRmb3JtS2V5Ym9hcmRFdmVudD4gbV9rZXlFdmVudDsKICAgICBTdHJpbmcgbV9rZXlJZGVudGlm aWVyOwogICAgIHVuc2lnbmVkIG1fbG9jYXRpb247CisgICAgYm9vbCBtX3JlcGVhdCA6IDE7CiAg ICAgYm9vbCBtX2FsdEdyYXBoS2V5IDogMTsKIAogI2lmIFBMQVRGT1JNKENPQ09BKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0tleWJvYXJkRXZlbnQuaWRsIGIvU291cmNlL1dlYkNv cmUvZG9tL0tleWJvYXJkRXZlbnQuaWRsCmluZGV4IDg1MmU1YzJmNWVlYjlkMTY5NjcxNTEzYjVi YzI3ZjEyMWNjMmRkMzkuLjJjODA4NmY0MDFkODVlMjRmZTNjNzVlOTU4YWY2MWY5NmIzMjY3NGYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmlkbAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vS2V5Ym9hcmRFdmVudC5pZGwKQEAgLTM3LDYgKzM3LDggQEAKICAg ICBbSW5pdGlhbGl6ZWRCeUV2ZW50Q29uc3RydWN0b3JdIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29s ZWFuIG1ldGFLZXk7CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gYWx0R3JhcGhLZXk7 CiAKKyAgICBbSW5pdGlhbGl6ZWRCeUV2ZW50Q29uc3RydWN0b3JdIHJlYWRvbmx5IGF0dHJpYnV0 ZSBib29sZWFuIHJlcGVhdDsKKwogICAgIC8vIEZJWE1FOiB0aGlzIGRvZXMgbm90IG1hdGNoIHRo ZSB2ZXJzaW9uIGluIHRoZSBET00gc3BlYy4KICAgICAvLyBGSVhNRTogVXNpbmcgInVuZGVmaW5l ZCIgYXMgZGVmYXVsdCBwYXJhbWV0ZXIgdmFsdWUgaXMgd3JvbmcuCiAgICAgdm9pZCBpbml0S2V5 Ym9hcmRFdmVudChvcHRpb25hbCBET01TdHJpbmcgdHlwZSA9ICJ1bmRlZmluZWQiLCBvcHRpb25h bCBib29sZWFuIGNhbkJ1YmJsZSA9IGZhbHNlLCBvcHRpb25hbCBib29sZWFuIGNhbmNlbGFibGUg PSBmYWxzZSwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwppbmRleCA4Njk1ZWNlYzg5MDFlNGVmMmI1NDA0ZWVhNGU2YjE0ODVjOTc0MWRi Li42MDQwMTc1NTM2MTVmYzE4M2JkYmRkMGMzYWQxM2Q3MzQ5YmI4NWRkIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUg KzEsMTcgQEAKIDIwMTYtMTAtMDIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAor ICAgICAgICBBZGQgc3VwcG9ydCBmb3IgS2V5Ym9hcmRFdmVudC5yZXBlYXQgYXR0cmlidXRlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI4NTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHRlbmQgbGF5 b3V0IHRlc3QgY292ZXJhZ2UuCisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMv a2V5Ym9hcmQtZXZlbnQtY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3Qv ZXZlbnRzL2NvbnN0cnVjdG9ycy9rZXlib2FyZC1ldmVudC1jb25zdHJ1Y3Rvci5odG1sOgorCisy MDE2LTEwLTAyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIwNjY5MiBhbmQgcjIwNjcxOC4KIAogICAgICAgICBTZWVt cyB0byBoYXZlIGNhdXNlZCA+MjAwIGZhaWx1cmVzIG9uIFNpZXJyYQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9ldmVudHMvY29uc3RydWN0b3JzL2tleWJvYXJkLWV2ZW50LWNvbnN0cnVj dG9yLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NvbnN0cnVjdG9ycy9r ZXlib2FyZC1ldmVudC1jb25zdHJ1Y3Rvci1leHBlY3RlZC50eHQKaW5kZXggNzExNmMxYzE4NGI5 YzNkM2I3ZDM4ZjEwODFlMDk2MTg5YjA3ODk4OS4uM2Y5OTczNTFhYzk2NDRiMjJiODA4MWUxMDFm Njg2ZGRhMjFjYjc4NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY29uc3Ry dWN0b3JzL2tleWJvYXJkLWV2ZW50LWNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4dAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMva2V5Ym9hcmQtZXZlbnQtY29uc3RydWN0 b3ItZXhwZWN0ZWQudHh0CkBAIC0xOSw2ICsxOSw5IEBAIFBBU1MgbmV3IEtleWJvYXJkRXZlbnQo J2V2ZW50VHlwZScsIHsgY2FuY2VsYWJsZTogZmFsc2UgfSkuY2FuY2VsYWJsZSBpcyBmYWxzZQog UEFTUyBuZXcgS2V5Ym9hcmRFdmVudCgnZXZlbnRUeXBlJywgeyBjYW5jZWxhYmxlOiB0cnVlIH0p LmNhbmNlbGFibGUgaXMgdHJ1ZQogUEFTUyBuZXcgS2V5Ym9hcmRFdmVudCgnZXZlbnRUeXBlJywg eyB2aWV3OiB3aW5kb3cgfSkudmlldyBpcyB3aW5kb3cKIFBBU1MgbmV3IEtleWJvYXJkRXZlbnQo J2V2ZW50VHlwZScsIHsgdmlldzogdGhpcyB9KS52aWV3IGlzIHRoaXMKK1BBU1MgbmV3IEtleWJv YXJkRXZlbnQoJ2V2ZW50VHlwZScsIHsgfSkucmVwZWF0IGlzIGZhbHNlCitQQVNTIG5ldyBLZXli b2FyZEV2ZW50KCdldmVudFR5cGUnLCB7IHJlcGVhdDogZmFsc2UgfSkucmVwZWF0IGlzIGZhbHNl CitQQVNTIG5ldyBLZXlib2FyZEV2ZW50KCdldmVudFR5cGUnLCB7IHJlcGVhdDogdHJ1ZSB9KS5y ZXBlYXQgaXMgdHJ1ZQogUEFTUyBuZXcgS2V5Ym9hcmRFdmVudCgnZXZlbnRUeXBlJywgeyB2aWV3 OiB0ZXN0T2JqZWN0IH0pLnZpZXcgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogRGljdGlvbmFy eSBtZW1iZXIgaXMgbm90IG9mIHR5cGUgV2luZG93LgogUEFTUyBuZXcgS2V5Ym9hcmRFdmVudCgn ZXZlbnRUeXBlJywgeyB2aWV3OiBkb2N1bWVudCB9KS52aWV3IHRocmV3IGV4Y2VwdGlvbiBUeXBl RXJyb3I6IERpY3Rpb25hcnkgbWVtYmVyIGlzIG5vdCBvZiB0eXBlIFdpbmRvdy4KIFBBU1MgbmV3 IEtleWJvYXJkRXZlbnQoJ2V2ZW50VHlwZScsIHsgdmlldzogdW5kZWZpbmVkIH0pLnZpZXcgaXMg bnVsbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY29uc3RydWN0b3JzL2tl eWJvYXJkLWV2ZW50LWNvbnN0cnVjdG9yLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9j b25zdHJ1Y3RvcnMva2V5Ym9hcmQtZXZlbnQtY29uc3RydWN0b3IuaHRtbAppbmRleCBkYzE2OWM2 MjY0NzE2NDAwNjZjNDUwOTQyNjFjMzdjNDRhYmI2ZWVkLi44YTRkZjAwNmQyYzg3MmY1ZjcyY2Rm MGFhM2VhYTgyYTc5NTM3MGNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9j b25zdHJ1Y3RvcnMva2V5Ym9hcmQtZXZlbnQtY29uc3RydWN0b3IuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMva2V5Ym9hcmQtZXZlbnQtY29uc3RydWN0b3Iu aHRtbApAQCAtMzUsNiArMzUsMTEgQEAgc2hvdWxkQmUoIm5ldyBLZXlib2FyZEV2ZW50KCdldmVu dFR5cGUnLCB7IGNhbmNlbGFibGU6IHRydWUgfSkuY2FuY2VsYWJsZSIsICJ0cnUKIHNob3VsZEJl KCJuZXcgS2V5Ym9hcmRFdmVudCgnZXZlbnRUeXBlJywgeyB2aWV3OiB3aW5kb3cgfSkudmlldyIs ICJ3aW5kb3ciKTsKIHNob3VsZEJlKCJuZXcgS2V5Ym9hcmRFdmVudCgnZXZlbnRUeXBlJywgeyB2 aWV3OiB0aGlzIH0pLnZpZXciLCAidGhpcyIpOwogCisvLyByZXBlYXQgaXMgcGFzc2VkLgorc2hv dWxkQmUoIm5ldyBLZXlib2FyZEV2ZW50KCdldmVudFR5cGUnLCB7IH0pLnJlcGVhdCIsICJmYWxz ZSIpOworc2hvdWxkQmUoIm5ldyBLZXlib2FyZEV2ZW50KCdldmVudFR5cGUnLCB7IHJlcGVhdDog ZmFsc2UgfSkucmVwZWF0IiwgImZhbHNlIik7CitzaG91bGRCZSgibmV3IEtleWJvYXJkRXZlbnQo J2V2ZW50VHlwZScsIHsgcmVwZWF0OiB0cnVlIH0pLnJlcGVhdCIsICJ0cnVlIik7CisKIC8vIE5v bi13aW5kb3cgb2JqZWN0cy4KIHNob3VsZFRocm93RXJyb3JOYW1lKCJuZXcgS2V5Ym9hcmRFdmVu dCgnZXZlbnRUeXBlJywgeyB2aWV3OiB0ZXN0T2JqZWN0IH0pLnZpZXciLCAiVHlwZUVycm9yIik7 CiBzaG91bGRUaHJvd0Vycm9yTmFtZSgibmV3IEtleWJvYXJkRXZlbnQoJ2V2ZW50VHlwZScsIHsg dmlldzogZG9jdW1lbnQgfSkudmlldyIsICJUeXBlRXJyb3IiKTsK