162850 2016-10-01 18:07:45 -0700 Web Inspector: Exception thrown when hovering network waterfall graphs during reload 2016-10-02 14:01:35 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1235675 0 mattbaker 2016-10-01 18:07:45 -0700 Summary: Exception thrown when hovering network waterfall graphs during reload. Steps to Reproduce: 1. Goto Network tab, reload inspected page 2. Hover over a record bar element in the grid 3. ⌘R to reload inspected page, while moving cursor in and out of the graph element => TypeError:​ null is not an object (evaluating 'this.dataGrid')​ (at ResourceTimelineDataGridNode.js:​377:​26)​ Note: The record bar's mouseleave event listener doesn't check that the node's grid reference is valid before using it. The node's grid reference is set to null when a node is removed from the grid, but before it's removed from the DOM. This occurs during page load as resources are reordered in the grid. 1235676 1 webkit-bug-importer 2016-10-01 18:07:56 -0700 <rdar://problem/28579653> 1235680 2 290457 mattbaker 2016-10-01 18:12:19 -0700 Created attachment 290457 Patch 1235738 3 290457 bburg 2016-10-02 13:40:29 -0700 Comment on attachment 290457 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290457&action=review rs=me > Source/WebInspectorUI/ChangeLog:12 > + (WebInspector.ResourceTimelineDataGridNode): This line seems unnecessary. 1235739 4 290457 commit-queue 2016-10-02 14:01:32 -0700 Comment on attachment 290457 Patch Clearing flags on attachment: 290457 Committed r206722: <http://trac.webkit.org/changeset/206722> 1235740 5 commit-queue 2016-10-02 14:01:35 -0700 All reviewed patches have been landed. Closing bug. 290457 2016-10-01 18:12:19 -0700 2016-10-02 14:01:32 -0700 Patch bug-162850-20161001180913.patch text/plain 1848 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 MDg1ZWEwNWEwZGEyNWFjODRjZTU5ZGNkZjU4ZmNiNGRjMzBiYzBiLi5kYjkwNWU4MDMzMTUxMDJk YzNkZDA2MzFkYTU4Zjk5YmE5NWIzZmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNi0xMC0wMSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRXhjZXB0aW9uIHRocm93biB3aGVuIGhvdmVyaW5n IG5ldHdvcmsgd2F0ZXJmYWxsIGdyYXBocyBkdXJpbmcgcmVsb2FkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI4NTAKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzI4NTc5NjUzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVRpbWVsaW5lRGF0YUdyaWRO b2RlLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlVGltZWxpbmVEYXRhR3JpZE5v ZGUucHJvdG90eXBlLl9tb3VzZW92ZXJSZWNvcmRCYXIpOgorICAgICAgICBDaGVjayB0aGF0IHRo ZSBub2RlJ3MgZGF0YSBncmlkIHJlZmVyZW5jZSBpcyB2YWxpZCBiZWZvcmUgdXNlLgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlJlc291cmNlVGltZWxpbmVEYXRhR3JpZE5vZGUpOgorCiAyMDE2LTA5 LTMwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogTWFrZSBkZWJ1Z2dlciBzdGVwcGluZyBoaWdobGlnaHRzIHdvcmsgaW4gaW5s aW5lIDxzY3JpcHQ+cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvUmVzb3VyY2VUaW1lbGluZURhdGFHcmlkTm9kZS5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlVGltZWxpbmVEYXRhR3JpZE5v ZGUuanMKaW5kZXggZmE2ZWQwYjI2YWVlZDRiYjgzZmUxYTc2MzhiNGFlY2MzNGJmZGUxMi4uMmUw NDBkZjI4N2E3NGNlMWIxNDg4YzkxZDkxNjFmOTMxZmI2MzliNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VUaW1lbGluZURhdGFH cmlkTm9kZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9SZXNvdXJjZVRpbWVsaW5lRGF0YUdyaWROb2RlLmpzCkBAIC0zNzQsNiArMzc0LDggQEAgV2Vi SW5zcGVjdG9yLlJlc291cmNlVGltZWxpbmVEYXRhR3JpZE5vZGUgPSBjbGFzcyBSZXNvdXJjZVRp bWVsaW5lRGF0YUdyaWROb2RlIGUKICAgICAgICAgfTsKIAogICAgICAgICByZWNvcmRCYXIuZWxl bWVudC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZWxlYXZlIiwgKCkgPT4geworICAgICAgICAgICAg aWYgKCF0aGlzLmRhdGFHcmlkKQorICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAg IHRoaXMuZGF0YUdyaWQuX2Rpc21pc3NQb3BvdmVyVGltZW91dCA9IHNldFRpbWVvdXQoKCkgPT4g dGhpcy5kYXRhR3JpZC5fcG9wb3Zlci5kaXNtaXNzKCksIFdlYkluc3BlY3Rvci5SZXNvdXJjZVRp bWVsaW5lRGF0YUdyaWROb2RlLkRlbGF5ZWRQb3BvdmVyRGlzbWlzc2FsVGltZW91dCk7CiAgICAg ICAgIH0sIHtvbmNlOiB0cnVlfSk7CiAK