162832 2016-09-30 19:33:36 -0700 [ListItems] Render tree should be all clean by the end of FrameView::layout(). 2016-10-03 20:36:28 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 162834 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1235567 0 zalan 2016-09-30 19:33:36 -0700 We fail to clean all the renderers while running the following test: LayoutTests/imported/blink/fast/lists/list-item-without-list-reparented-crash.html 1235701 1 290461 zalan 2016-10-01 21:14:46 -0700 Created attachment 290461 Test reduction This happens when we start mutating the renderer tree while laying it out. <body> <li> 1. floating <li> is being laid out by the body ( is the direct parent but the containing block is the body) 2. we insert a new renderer (list marker) and dirty the ancestor chain 3. we never get to lay out the 1235926 2 zalan 2016-10-03 14:42:33 -0700 (In reply to comment #1) > Created attachment 290461 [details] > Test reduction > > This happens when we start mutating the renderer tree while laying it out. > <body> > > <li> > 1. floating <li> is being laid out by the body ( is the direct parent > but the containing block is the body) > 2. we insert a new renderer (list marker) and dirty the ancestor chain > 3. we never get to lay out the Scratch the containing block part, it's just a floating renderer and not an out of flow positioned one. 1235980 3 290534 zalan 2016-10-03 16:21:38 -0700 Created attachment 290534 Patch 1235981 4 zalan 2016-10-03 16:23:25 -0700 Alternatively we could make RenderObject::markContainingBlocksForLayout smarter and figure out the floating case, but I am sure we don't have all the information at this point to make that decision. 1235982 5 290534 simon.fraser 2016-10-03 16:24:11 -0700 Comment on attachment 290534 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290534&action=review > Source/WebCore/rendering/RenderListItem.cpp:290 > + // FIXME: We should stop mutating the renderer tree during layout. I think this comment would be better if it described why you added these lines. Something like "mark the parent dirty so that when the marker dirties ancestors, it stops at the parent." 1236049 6 290558 zalan 2016-10-03 20:02:39 -0700 Created attachment 290558 Patch 1236050 7 290559 zalan 2016-10-03 20:03:31 -0700 Created attachment 290559 Patch 1236055 8 290559 commit-queue 2016-10-03 20:36:24 -0700 Comment on attachment 290559 Patch Clearing flags on attachment: 290559 Committed r206765: <http://trac.webkit.org/changeset/206765> 1236056 9 commit-queue 2016-10-03 20:36:28 -0700 All reviewed patches have been landed. Closing bug. 290461 2016-10-01 21:14:46 -0700 2016-10-01 21:14:46 -0700 Test reduction list-item-without-list-reparented-crash.html text/html 226 zalan PCFET0NUWVBFIGh0bWw+CjxzdHlsZT4KbGkgewogICAgZmxvYXQ6IGxlZnQ7CiAgfQo8L3N0eWxl PgoKPHNjcmlwdD4Kc2V0VGltZW91dChmdW5jdGlvbigpIHsKICB2YXIgc3BhbiA9IGRvY3VtZW50 LmJvZHkucXVlcnlTZWxlY3Rvcignc3BhbicpOwogIHNwYW4uYXBwZW5kQ2hpbGQoZG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgnbGknKSk7Cn0sIDMwMCk7Cjwvc2NyaXB0PgoKPHNwYW4+PC9zcGFuPg== 290534 2016-10-03 16:21:38 -0700 2016-10-03 20:02:35 -0700 Patch bug-162832-20161003161829.patch text/plain 2524 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDFjZmI2NjViYTZlY2Yz NmE2MTBiZDU0YzEyMGM3NzljZDcxNTZmNi4uYTY2NTBlMjE5MjVjMTFhOGM4YjU1NGI0MGQxM2Ux ODlkMmM5MDVmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE2LTEwLTAzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xpc3RJdGVtc10gUmVuZGVy IHRyZWUgc2hvdWxkIGJlIGFsbCBjbGVhbiBieSB0aGUgZW5kIG9mIEZyYW1lVmlldzo6bGF5b3V0 KCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI4 MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMaXN0 IGl0ZW0gbWFya2VycyBhcmUgaW5zZXJ0ZWQgaW50byB0aGUgdHJlZSBkdXJpbmcgbGF5b3V0LCBy aWdodCBiZWZvcmUgbGF5aW5nIG91dAorICAgICAgICB0aGUgbGlzdCBpdGVtICh0aGF0J3MgYSBi aWcgRklYTUUpLiBBdCB0aGlzIHBvaW50IHdlIGFscmVhZHkga25vdyB3aGF0IHBhcnQgb2YgdGhl IHRyZWUKKyAgICAgICAgbmVlZHMgdG8gYmUgbGFpZCBvdXQuIEluc2VydGluZyBhIGxpc3QgaXRl bSBtYXJrZXIgZG9lcyBub3QgZXhwYW5kIHRoaXMgZGlydHkgYXJlYS4KKyAgICAgICAgSG93ZXZl ciB3aGVuZXZlciB3ZSBpbnNlcnQgYSBuZXcgcmVuZGVyZXIgaW50byB0aGUgdHJlZSwgd2UgY2Fs bCBzZXROZWVkc0xheW91dCBvbiB0aGUgY29udGluaW5nIGJsb2NrIGNoYWluLgorICAgICAgICBJ biBjZXJ0YWluIGNhc2VzIChmbG9hdGluZyByZW5kZXJlcnMpLCBpdCBjb3VsZCBwb3RlbnRpYWxs eSB0cmlnZ2VyIHNvbWUgdW5pbnRlbnRpb25hbCBtYXJraW5ncworICAgICAgICBhbmQgd2UgcmV0 dXJuIGZyb20gRnJhbWVWaWV3OjpsYXlvdXQoKSB3aXRoIGEgZGlydHkgc3VidHJlZS4KKworICAg ICAgICBUaGlzIHBhdGNoIHByZWVtcHRpdmVseSBtYXJrcyB0aGUgbGlzdCBpdGVtIGFuZCBpdHMg bWFya2VyIGRpcnR5IHNvIHRoYXQKKyAgICAgICAgd2hlbiB0aGUgbWFya2VyIGlzIGdldHRpbmcg aW5zZXJ0ZWQgaW50byB0aGUgdHJlZSwgd2Ugc3RvcCB0aGUgbWFya2luZyBhdCB0aGUgcGFyZW50 LgorCisgICAgICAgIE5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckxpc3RJdGVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxpc3RJ dGVtOjppbnNlcnRPck1vdmVNYXJrZXJSZW5kZXJlcklmTmVlZGVkKToKKwogMjAxNi0wOS0zMCAg RGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04g KHIyMDM0MjQpOiBXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6Y3JlYXRlQ29tcGF0aWJsZUJ1ZmZlcigp IGluIEltYWdlQnVmZmVyQ0cuY3BwIG92ZXItcmVsZWFzZXMgQ0dDb2xvclNwYWNlUmVmIG9iamVj dHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3BwCmluZGV4IGM4 MWM1ZTg3YzY4YTM0OGEzMDZmY2UyMjBiZDFiNzA3NWVhODcyM2MuLmY4YzIxNmMzNTdlOGJlMGZk M2RiMzJiMGQ3NjRiODk0MDMwNzg3MTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMaXN0SXRlbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxpc3RJdGVtLmNwcApAQCAtMjg3LDYgKzI4NywxMCBAQCB2b2lkIFJlbmRlckxpc3RJdGVt OjppbnNlcnRPck1vdmVNYXJrZXJSZW5kZXJlcklmTmVlZGVkKCkKICAgICAgICAgLy8gUmVtb3Zp bmcgYW5kIGFkZGluZyB0aGUgbWFya2VyIGNhbiB0cmlnZ2VyIHJlcGFpbnRpbmcgaW4KICAgICAg ICAgLy8gY29udGFpbmVycyBvdGhlciB0aGFuIG91cnNlbHZlcywgc28gd2UgbmVlZCB0byBkaXNh YmxlIExheW91dFN0YXRlLgogICAgICAgICBMYXlvdXRTdGF0ZURpc2FibGVyIGxheW91dFN0YXRl RGlzYWJsZXIodmlldygpKTsKKyAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBzdG9wIG11dGF0 aW5nIHRoZSByZW5kZXJlciB0cmVlIGR1cmluZyBsYXlvdXQuCisgICAgICAgIG5ld1BhcmVudC0+ c2V0Q2hpbGROZWVkc0xheW91dChNYXJrT25seVRoaXMpOworICAgICAgICBtX21hcmtlci0+c2V0 TmVlZHNMYXlvdXQoTWFya09ubHlUaGlzKTsKKwogICAgICAgICBtX21hcmtlci0+cmVtb3ZlRnJv bVBhcmVudCgpOwogICAgICAgICBuZXdQYXJlbnQtPmFkZENoaWxkKG1fbWFya2VyLCBmaXJzdE5v bk1hcmtlckNoaWxkKCpuZXdQYXJlbnQpKTsKICAgICAgICAgbV9tYXJrZXItPnVwZGF0ZU1hcmdp bnNBbmRDb250ZW50KCk7Cg== 290558 2016-10-03 20:02:39 -0700 2016-10-03 20:03:27 -0700 Patch bug-162832-20161003195930.patch text/plain 2591 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDFjZmI2NjViYTZlY2Yz NmE2MTBiZDU0YzEyMGM3NzljZDcxNTZmNi4uYTVkMjkzNmI1YTExNTI3ZmM5N2NlZGU5Y2ZjMzVi M2Q2NTk4ODU4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE2LTEwLTAzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xpc3RJdGVtc10gUmVuZGVy IHRyZWUgc2hvdWxkIGJlIGFsbCBjbGVhbiBieSB0aGUgZW5kIG9mIEZyYW1lVmlldzo6bGF5b3V0 KCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI4 MzIKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgTGlzdCBp dGVtIG1hcmtlcnMgYXJlIGluc2VydGVkIGludG8gdGhlIHRyZWUgZHVyaW5nIGxheW91dCwgcmln aHQgYmVmb3JlIGxheWluZyBvdXQKKyAgICAgICAgdGhlIGxpc3QgaXRlbSAodGhhdCdzIGEgYmln IEZJWE1FKS4gQXQgdGhpcyBwb2ludCB3ZSBhbHJlYWR5IGtub3cgd2hhdCBwYXJ0IG9mIHRoZSB0 cmVlCisgICAgICAgIG5lZWRzIHRvIGJlIGxhaWQgb3V0LiBJbnNlcnRpbmcgYSBsaXN0IGl0ZW0g bWFya2VyIGRvZXMgbm90IGV4cGFuZCB0aGlzIGRpcnR5IGFyZWEuCisgICAgICAgIEhvd2V2ZXIg d2hlbmV2ZXIgd2UgaW5zZXJ0IGEgbmV3IHJlbmRlcmVyIGludG8gdGhlIHRyZWUsIHdlIGNhbGwg c2V0TmVlZHNMYXlvdXQgb24gdGhlIGNvbnRpbmluZyBibG9jayBjaGFpbi4KKyAgICAgICAgSW4g Y2VydGFpbiBjYXNlcyAoZmxvYXRpbmcgcmVuZGVyZXJzKSwgaXQgY291bGQgcG90ZW50aWFsbHkg dHJpZ2dlciBzb21lIHVuaW50ZW50aW9uYWwgbWFya2luZ3MKKyAgICAgICAgYW5kIHdlIHJldHVy biBmcm9tIEZyYW1lVmlldzo6bGF5b3V0KCkgd2l0aCBhIGRpcnR5IHN1YnRyZWUuCisKKyAgICAg ICAgVGhpcyBwYXRjaCBwcmVlbXB0aXZlbHkgbWFya3MgdGhlIGxpc3QgaXRlbSBhbmQgaXRzIG1h cmtlciBkaXJ0eSBzbyB0aGF0CisgICAgICAgIHdoZW4gdGhlIG1hcmtlciBpcyBnZXR0aW5nIGlu c2VydGVkIGludG8gdGhlIHRyZWUsIHdlIHN0b3AgdGhlIG1hcmtpbmcgYXQgdGhlIHBhcmVudC4K KworICAgICAgICBObyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJMaXN0SXRlbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMaXN0SXRl bTo6aW5zZXJ0T3JNb3ZlTWFya2VyUmVuZGVyZXJJZk5lZWRlZCk6CisKIDIwMTYtMDktMzAgIERh dmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChy MjAzNDI0KTogV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OmNyZWF0ZUNvbXBhdGlibGVCdWZmZXIoKSBp biBJbWFnZUJ1ZmZlckNHLmNwcCBvdmVyLXJlbGVhc2VzIENHQ29sb3JTcGFjZVJlZiBvYmplY3Rz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJdGVtLmNwcAppbmRleCBjODFj NWU4N2M2OGEzNDhhMzA2ZmNlMjIwYmQxYjcwNzVlYTg3MjNjLi5kOWIzZDVhMjk3NDg0MGQzNzY0 ODY1M2YxOWE2M2FlMTk4ZTk3NjAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGlzdEl0ZW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMaXN0SXRlbS5jcHAKQEAgLTI4Nyw2ICsyODcsMTEgQEAgdm9pZCBSZW5kZXJMaXN0SXRlbTo6 aW5zZXJ0T3JNb3ZlTWFya2VyUmVuZGVyZXJJZk5lZWRlZCgpCiAgICAgICAgIC8vIFJlbW92aW5n IGFuZCBhZGRpbmcgdGhlIG1hcmtlciBjYW4gdHJpZ2dlciByZXBhaW50aW5nIGluCiAgICAgICAg IC8vIGNvbnRhaW5lcnMgb3RoZXIgdGhhbiBvdXJzZWx2ZXMsIHNvIHdlIG5lZWQgdG8gZGlzYWJs ZSBMYXlvdXRTdGF0ZS4KICAgICAgICAgTGF5b3V0U3RhdGVEaXNhYmxlciBsYXlvdXRTdGF0ZURp c2FibGVyKHZpZXcoKSk7CisgICAgICAgIC8vIE1hcmsgdGhlIHBhcmVudCBkaXJ0eSBzbyB0aGF0 IHdoZW4gdGhlIG1hcmtlciBnZXRzIGluc2VydGVkIGludG8gdGhlIHRyZWUKKyAgICAgICAgLy8g YW5kIGRpcnRpZXMgYW5jZXN0b3JzLCBpdCBzdG9wcyBhdCB0aGUgcGFyZW50LgorICAgICAgICBu ZXdQYXJlbnQtPnNldENoaWxkTmVlZHNMYXlvdXQoTWFya09ubHlUaGlzKTsKKyAgICAgICAgbV9t YXJrZXItPnNldE5lZWRzTGF5b3V0KE1hcmtPbmx5VGhpcyk7CisKICAgICAgICAgbV9tYXJrZXIt PnJlbW92ZUZyb21QYXJlbnQoKTsKICAgICAgICAgbmV3UGFyZW50LT5hZGRDaGlsZChtX21hcmtl ciwgZmlyc3ROb25NYXJrZXJDaGlsZCgqbmV3UGFyZW50KSk7CiAgICAgICAgIG1fbWFya2VyLT51 cGRhdGVNYXJnaW5zQW5kQ29udGVudCgpOwo= 290559 2016-10-03 20:03:31 -0700 2016-10-03 20:36:24 -0700 Patch bug-162832-20161003200021.patch text/plain 2577 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDFjZmI2NjViYTZlY2Yz NmE2MTBiZDU0YzEyMGM3NzljZDcxNTZmNi4uZGQ2NzFkNTE0MTc3ZmIxMjdlZmYxODdlMGY2MjQ3 YzU5Njg1ZDI5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE2LTEwLTAzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xpc3RJdGVtc10gUmVuZGVy IHRyZWUgc2hvdWxkIGJlIGFsbCBjbGVhbiBieSB0aGUgZW5kIG9mIEZyYW1lVmlldzo6bGF5b3V0 KCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI4 MzIKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgTGlzdCBp dGVtIG1hcmtlcnMgYXJlIGluc2VydGVkIGludG8gdGhlIHRyZWUgZHVyaW5nIGxheW91dCwgcmln aHQgYmVmb3JlIGxheWluZyBvdXQKKyAgICAgICAgdGhlIGxpc3QgaXRlbSAodGhhdCdzIGEgYmln IEZJWE1FKS4gQXQgdGhpcyBwb2ludCB3ZSBhbHJlYWR5IGtub3cgd2hhdCBwYXJ0IG9mIHRoZSB0 cmVlCisgICAgICAgIG5lZWRzIHRvIGJlIGxhaWQgb3V0LiBJbnNlcnRpbmcgYSBsaXN0IGl0ZW0g bWFya2VyIGRvZXMgbm90IGV4cGFuZCB0aGlzIGRpcnR5IGFyZWEuCisgICAgICAgIEhvd2V2ZXIg d2hlbmV2ZXIgd2UgaW5zZXJ0IGEgbmV3IHJlbmRlcmVyIGludG8gdGhlIHRyZWUsIHdlIGNhbGwg c2V0TmVlZHNMYXlvdXQgb24gdGhlIGNvbnRpbmluZyBibG9jayBjaGFpbi4KKyAgICAgICAgSW4g Y2VydGFpbiBjYXNlcyAoZmxvYXRpbmcgcmVuZGVyZXJzKSwgaXQgY291bGQgcG90ZW50aWFsbHkg dHJpZ2dlciBzb21lIHVuaW50ZW50aW9uYWwgbWFya2luZ3MKKyAgICAgICAgYW5kIHdlIHJldHVy biBmcm9tIEZyYW1lVmlldzo6bGF5b3V0KCkgd2l0aCBhIGRpcnR5IHN1YnRyZWUuCisKKyAgICAg ICAgVGhpcyBwYXRjaCBwcmVlbXB0aXZlbHkgbWFya3MgdGhlIGxpc3QgaXRlbSBhbmQgaXRzIG1h cmtlciBkaXJ0eSBzbyB0aGF0CisgICAgICAgIHdoZW4gdGhlIG1hcmtlciBpcyBnZXR0aW5nIGlu c2VydGVkIGludG8gdGhlIHRyZWUsIHdlIHN0b3AgdGhlIG1hcmtpbmcgYXQgdGhlIHBhcmVudC4K KworICAgICAgICBOb3QgdGVzdGFibGUuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGlz dEl0ZW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGlzdEl0ZW06Omluc2VydE9yTW92 ZU1hcmtlclJlbmRlcmVySWZOZWVkZWQpOgorCiAyMDE2LTA5LTMwICBEYXZpZCBLaWx6ZXIgIDxk ZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIwMzQyNCk6IFdlYkNv cmU6OkltYWdlQnVmZmVyOjpjcmVhdGVDb21wYXRpYmxlQnVmZmVyKCkgaW4gSW1hZ2VCdWZmZXJD Ry5jcHAgb3Zlci1yZWxlYXNlcyBDR0NvbG9yU3BhY2VSZWYgb2JqZWN0cwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJdGVtLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5jcHAKaW5kZXggYzgxYzVlODdjNjhhMzQ4YTMw NmZjZTIyMGJkMWI3MDc1ZWE4NzIzYy4uZDliM2Q1YTI5NzQ4NDBkMzc2NDg2NTNmMTlhNjNhZTE5 OGU5NzYwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJ dGVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3Bw CkBAIC0yODcsNiArMjg3LDExIEBAIHZvaWQgUmVuZGVyTGlzdEl0ZW06Omluc2VydE9yTW92ZU1h cmtlclJlbmRlcmVySWZOZWVkZWQoKQogICAgICAgICAvLyBSZW1vdmluZyBhbmQgYWRkaW5nIHRo ZSBtYXJrZXIgY2FuIHRyaWdnZXIgcmVwYWludGluZyBpbgogICAgICAgICAvLyBjb250YWluZXJz IG90aGVyIHRoYW4gb3Vyc2VsdmVzLCBzbyB3ZSBuZWVkIHRvIGRpc2FibGUgTGF5b3V0U3RhdGUu CiAgICAgICAgIExheW91dFN0YXRlRGlzYWJsZXIgbGF5b3V0U3RhdGVEaXNhYmxlcih2aWV3KCkp OworICAgICAgICAvLyBNYXJrIHRoZSBwYXJlbnQgZGlydHkgc28gdGhhdCB3aGVuIHRoZSBtYXJr ZXIgZ2V0cyBpbnNlcnRlZCBpbnRvIHRoZSB0cmVlCisgICAgICAgIC8vIGFuZCBkaXJ0aWVzIGFu Y2VzdG9ycywgaXQgc3RvcHMgYXQgdGhlIHBhcmVudC4KKyAgICAgICAgbmV3UGFyZW50LT5zZXRD aGlsZE5lZWRzTGF5b3V0KE1hcmtPbmx5VGhpcyk7CisgICAgICAgIG1fbWFya2VyLT5zZXROZWVk c0xheW91dChNYXJrT25seVRoaXMpOworCiAgICAgICAgIG1fbWFya2VyLT5yZW1vdmVGcm9tUGFy ZW50KCk7CiAgICAgICAgIG5ld1BhcmVudC0+YWRkQ2hpbGQobV9tYXJrZXIsIGZpcnN0Tm9uTWFy a2VyQ2hpbGQoKm5ld1BhcmVudCkpOwogICAgICAgICBtX21hcmtlci0+dXBkYXRlTWFyZ2luc0Fu ZENvbnRlbnQoKTsK