162808 2016-09-30 14:17:08 -0700 JSStringRef should define JSChar without platform checks 2016-10-03 10:35:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 Nicolas.Breidinger webkit-unassigned annulen commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1235410 0 Nicolas.Breidinger 2016-09-30 14:17:08 -0700 JSChar is typedef'd as either "unsigned short" or "wchar_t" based on a number of platform checks. This is problematic for non-standard ports. To solve this, a way to determine which typedef to use without platform checks is required. 1235419 1 290384 Nicolas.Breidinger 2016-09-30 14:26:16 -0700 Created attachment 290384 JSStringRef change 1235478 2 290384 ggaren 2016-09-30 15:57:17 -0700 Comment on attachment 290384 JSStringRef change View in context: https://bugs.webkit.org/attachment.cgi?id=290384&action=review > Source/JavaScriptCore/API/JSStringRef.h:40 > +#if __WCHAR_MAX__ > 0x10000 Don't we need to check if __WCHAR_MAX__ is #defined? 1235501 3 Nicolas.Breidinger 2016-09-30 16:39:16 -0700 (In reply to comment #2) > Don't we need to check if __WCHAR_MAX__ is #defined? Looking more closely at gcc and msvc, a better check would be as follows: > #if !defined(_NATIVE_WCHAR_T_DEFINED) && (!defined(__WCHAR_MAX__) || (__WCHAR_MAX__ > 0xffffU)) _NATIVE_WCHAR_T_DEFINED being msvc specific __WCHAR_MAX__ being gcc specific However, I'm not familiar with mac implementation, it seems according to apple's libc (https://opensource.apple.com/source/Libc/Libc-825.24/include/_types.h) it is not guaranteed to exist: > #ifdef __WCHAR_MAX__ > #define __DARWIN_WCHAR_MAX __WCHAR_MAX__ > #else /* ! __WCHAR_MAX__ */ > #define __DARWIN_WCHAR_MAX 0x7fffffff > #endif /* __WCHAR_MAX__ */ 1235504 4 290405 Nicolas.Breidinger 2016-09-30 16:52:55 -0700 Created attachment 290405 updated patch 1235508 5 290405 ggaren 2016-09-30 17:19:16 -0700 Comment on attachment 290405 updated patch r=me 1235570 6 290419 Nicolas.Breidinger 2016-09-30 19:50:29 -0700 Created attachment 290419 updated patch Covers a missing case for RVCT. Adds description for each set of compiler options. 1235573 7 290420 Nicolas.Breidinger 2016-09-30 20:09:51 -0700 Created attachment 290420 updated patch 1235780 8 290420 mark.lam 2016-10-03 08:51:41 -0700 Comment on attachment 290420 updated patch r=me 1235790 9 290420 commit-queue 2016-10-03 09:45:30 -0700 Comment on attachment 290420 updated patch Clearing flags on attachment: 290420 Committed r206734: <http://trac.webkit.org/changeset/206734> 1235791 10 commit-queue 2016-10-03 09:45:34 -0700 All reviewed patches have been landed. Closing bug. 1235792 11 annulen 2016-10-03 09:46:58 -0700 ChangeLog entry does not match patch contents! 1235810 12 mark.lam 2016-10-03 10:35:55 -0700 (In reply to comment #11) > ChangeLog entry does not match patch contents! How so? 290384 2016-09-30 14:26:16 -0700 2016-09-30 16:52:55 -0700 JSStringRef change patch.diff text/plain 1127 Nicolas.Breidinger ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaAppbmRleCA5ZDJkZTg0Li5hZTRl YTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTU3RyaW5nUmVmLmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1N0cmluZ1JlZi5oCkBAIC0zNyw4ICsz Nyw3IEBACiBleHRlcm4gIkMiIHsKICNlbmRpZgogCi0jaWYgIWRlZmluZWQoV0lOMzIpICYmICFk ZWZpbmVkKF9XSU4zMikgXAotICAgICYmICEoKGRlZmluZWQoX19DQ19BUk0pIHx8IGRlZmluZWQo X19BUk1DQ19fKSkgJiYgIWRlZmluZWQoX19saW51eF9fKSkgLyogUlZDVCAqLworI2lmIF9fV0NI QVJfTUFYX18gPiAweDEwMDAwCiAvKiEKIEB0eXBlZGVmIEpTQ2hhcgogQGFic3RyYWN0IEEgVVRG LTE2IGNvZGUgdW5pdC4gT25lLCBvciBhIHNlcXVlbmNlIG9mIHR3bywgY2FuIGVuY29kZSBhbnkg VW5pY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZjJjYjk5ZS4uYjg1YzZmOCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTYtMDktMzAgIE5pY29s YXMgQnJlaWRpbmdlciAgPE5pY29sYXMuQnJlaWRpbmdlckBzb255LmNvbT4KKworICAgICAgICBK U1N0cmluZ1JlZiBzaG91bGQgZGVmaW5lIEpTQ2hhciB3aXRob3V0IHBsYXRmb3JtIGNoZWNrcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyODA4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBBUEkvSlNT dHJpbmdSZWYuaDoKKwogMjAxNi0wOS0zMCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmVtb3ZlIHRoZSBkdW1waW5nIG9mIHRoZSBzdGFjayBiYWNrIHRyYWNlIGlu IFZNOjp2ZXJpZnlFeGNlcHRpb25DaGVja05lZWRJc1NhdGlzZmllZCgpLgo= 290405 2016-09-30 16:52:55 -0700 2016-09-30 19:50:29 -0700 updated patch patch.diff text/plain 1195 Nicolas.Breidinger ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaAppbmRleCA5ZDJkZTg0Li5hMjE2 YWQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTU3RyaW5nUmVmLmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1N0cmluZ1JlZi5oCkBAIC0zNyw4ICsz Nyw3IEBACiBleHRlcm4gIkMiIHsKICNlbmRpZgogCi0jaWYgIWRlZmluZWQoV0lOMzIpICYmICFk ZWZpbmVkKF9XSU4zMikgXAotICAgICYmICEoKGRlZmluZWQoX19DQ19BUk0pIHx8IGRlZmluZWQo X19BUk1DQ19fKSkgJiYgIWRlZmluZWQoX19saW51eF9fKSkgLyogUlZDVCAqLworI2lmICFkZWZp bmVkKF9OQVRJVkVfV0NIQVJfVF9ERUZJTkVEKSAmJiAoIWRlZmluZWQoX19XQ0hBUl9NQVhfXykg fHwgKF9fV0NIQVJfTUFYX18gPiAweGZmZmZVKSkKIC8qIQogQHR5cGVkZWYgSlNDaGFyCiBAYWJz dHJhY3QgQSBVVEYtMTYgY29kZSB1bml0LiBPbmUsIG9yIGEgc2VxdWVuY2Ugb2YgdHdvLCBjYW4g ZW5jb2RlIGFueSBVbmljb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBmMmNiOTllLi5i ODVjNmY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNi0w OS0zMCAgTmljb2xhcyBCcmVpZGluZ2VyICA8Tmljb2xhcy5CcmVpZGluZ2VyQHNvbnkuY29tPgor CisgICAgICAgIEpTU3RyaW5nUmVmIHNob3VsZCBkZWZpbmUgSlNDaGFyIHdpdGhvdXQgcGxhdGZv cm0gY2hlY2tzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjI4MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEFQSS9KU1N0cmluZ1JlZi5oOgorCiAyMDE2LTA5LTMwICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdGhlIGR1bXBpbmcgb2YgdGhlIHN0YWNrIGJh Y2sgdHJhY2UgaW4gVk06OnZlcmlmeUV4Y2VwdGlvbkNoZWNrTmVlZElzU2F0aXNmaWVkKCkuCg== 290419 2016-09-30 19:50:29 -0700 2016-09-30 20:09:51 -0700 updated patch patch.diff text/plain 1269 Nicolas.Breidinger ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaAppbmRleCA5ZDJkZTg0Li5lMTFi ZmNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTU3RyaW5nUmVmLmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1N0cmluZ1JlZi5oCkBAIC0zNyw4ICsz Nyw5IEBACiBleHRlcm4gIkMiIHsKICNlbmRpZgogCi0jaWYgIWRlZmluZWQoV0lOMzIpICYmICFk ZWZpbmVkKF9XSU4zMikgXAotICAgICYmICEoKGRlZmluZWQoX19DQ19BUk0pIHx8IGRlZmluZWQo X19BUk1DQ19fKSkgJiYgIWRlZmluZWQoX19saW51eF9fKSkgLyogUlZDVCAqLworI2lmICFkZWZp bmVkKF9OQVRJVkVfV0NIQVJfVF9ERUZJTkVEKSAvKiBNU1ZDICovIFwKKyAgICAmJiAoIWRlZmlu ZWQoX19XQ0hBUl9NQVhfXykgfHwgKF9fV0NIQVJfTUFYX18gPiAweGZmZmZVKSkgLyogSVNPIEMv QysrICovIFwKKyAgICAmJiAhZGVmaW5lZChfV0NIQVJfVCkgLyogUlZDVCAqLwogLyohCiBAdHlw ZWRlZiBKU0NoYXIKIEBhYnN0cmFjdCBBIFVURi0xNiBjb2RlIHVuaXQuIE9uZSwgb3IgYSBzZXF1 ZW5jZSBvZiB0d28sIGNhbiBlbmNvZGUgYW55IFVuaWNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n CmluZGV4IGYyY2I5OWUuLmI4NWM2ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDE2LTA5LTMwICBOaWNvbGFzIEJyZWlkaW5nZXIgIDxOaWNvbGFzLkJyZWlk aW5nZXJAc29ueS5jb20+CisKKyAgICAgICAgSlNTdHJpbmdSZWYgc2hvdWxkIGRlZmluZSBKU0No YXIgd2l0aG91dCBwbGF0Zm9ybSBjaGVja3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2MjgwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogQVBJL0pTU3RyaW5nUmVmLmg6CisKIDIwMTYtMDktMzAgIE1h cmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB0aGUgZHVtcGlu ZyBvZiB0aGUgc3RhY2sgYmFjayB0cmFjZSBpbiBWTTo6dmVyaWZ5RXhjZXB0aW9uQ2hlY2tOZWVk SXNTYXRpc2ZpZWQoKS4K 290420 2016-09-30 20:09:51 -0700 2016-10-03 09:45:30 -0700 updated patch patch.diff text/plain 1297 Nicolas.Breidinger ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaAppbmRleCA5ZDJkZTg0Li5iYzAz ZWQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTU3RyaW5nUmVmLmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1N0cmluZ1JlZi5oCkBAIC0zNyw4ICsz Nyw5IEBACiBleHRlcm4gIkMiIHsKICNlbmRpZgogCi0jaWYgIWRlZmluZWQoV0lOMzIpICYmICFk ZWZpbmVkKF9XSU4zMikgXAotICAgICYmICEoKGRlZmluZWQoX19DQ19BUk0pIHx8IGRlZmluZWQo X19BUk1DQ19fKSkgJiYgIWRlZmluZWQoX19saW51eF9fKSkgLyogUlZDVCAqLworI2lmICFkZWZp bmVkKF9OQVRJVkVfV0NIQVJfVF9ERUZJTkVEKSAvKiBNU1ZDICovIFwKKyAgICAmJiAoIWRlZmlu ZWQoX19XQ0hBUl9NQVhfXykgfHwgKF9fV0NIQVJfTUFYX18gPiAweGZmZmZVKSkgLyogSVNPIEMv QysrICovIFwKKyAgICAmJiAoIWRlZmluZWQoV0NIQVJfTUFYKSB8fCAoV0NIQVJfTUFYID4gMHhm ZmZmVSkpIC8qIFJWQ1QgKi8KIC8qIQogQHR5cGVkZWYgSlNDaGFyCiBAYWJzdHJhY3QgQSBVVEYt MTYgY29kZSB1bml0LiBPbmUsIG9yIGEgc2VxdWVuY2Ugb2YgdHdvLCBjYW4gZW5jb2RlIGFueSBV bmljb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBmMmNiOTllLi5iODVjNmY4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNi0wOS0zMCAgTmljb2xh cyBCcmVpZGluZ2VyICA8Tmljb2xhcy5CcmVpZGluZ2VyQHNvbnkuY29tPgorCisgICAgICAgIEpT U3RyaW5nUmVmIHNob3VsZCBkZWZpbmUgSlNDaGFyIHdpdGhvdXQgcGxhdGZvcm0gY2hlY2tzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI4MDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEFQSS9KU1N0 cmluZ1JlZi5oOgorCiAyMDE2LTA5LTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4K IAogICAgICAgICBSZW1vdmUgdGhlIGR1bXBpbmcgb2YgdGhlIHN0YWNrIGJhY2sgdHJhY2UgaW4g Vk06OnZlcmlmeUV4Y2VwdGlvbkNoZWNrTmVlZElzU2F0aXNmaWVkKCkuCg==