162807 2016-09-30 14:00:51 -0700 Fix modules tests after r206653 handle breakpoint locations in import/export statements 2016-09-30 14:28:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue joepeck keith_miller mark.lam msaboff ryanhaddad saam oldest_to_newest 1235400 0 joepeck 2016-09-30 14:00:51 -0700 Summary: Fix modules tests after r206653 handle breakpoint locations in import/export statements Steps to Reproduce: 1. $ run-jsc-stress-tests --release JSTests/modules.yaml => Failures Notes: - RELEASE_ASSERT that contents of import/export statement need debug hooks - Only affects modules 1235402 1 290380 joepeck 2016-09-30 14:02:36 -0700 Created attachment 290380 [PATCH] Proposed Fix 1235417 2 290380 joepeck 2016-09-30 14:25:01 -0700 Comment on attachment 290380 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=290380&action=review > Source/JavaScriptCore/parser/ASTBuilder.h:756 > + // The export statement itself will get the breakpoint location, don't record another for the declaration statement. > + declaration->setNeedsDebugHook(); Mark reviewed this in person. He recommended clarifying this comment. 1235420 3 joepeck 2016-09-30 14:28:17 -0700 https://trac.webkit.org/changeset/206671 290380 2016-09-30 14:02:36 -0700 2016-09-30 14:25:01 -0700 [PATCH] Proposed Fix modules-1.patch text/plain 3211 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDIxMzc3N2EuLjJjMmFhOGQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE2LTA5LTMwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgRml4IG1vZHVsZXMgdGVzdHMgYWZ0 ZXIgcjIwNjY1MyBoYW5kbGUgYnJlYWtwb2ludCBsb2NhdGlvbnMgaW4gaW1wb3J0L2V4cG9ydCBz dGF0ZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjI4MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBhcnNlci9BU1RCdWlsZGVyLmg6CisgICAgICAgIChKU0M6OkFTVEJ1aWxkZXI6OmNyZWF0 ZUV4cG9ydERlZmF1bHREZWNsYXJhdGlvbik6CisgICAgICAgIChKU0M6OkFTVEJ1aWxkZXI6OmNy ZWF0ZUV4cG9ydExvY2FsRGVjbGFyYXRpb24pOgorICAgICAgICBEb24ndCByZWNvcmQgYW4gZXh0 cmEgYnJlYWtwb2ludCBsb2NhdGlvbiBmb3IgdGhlIHN0YXRlbWVudAorICAgICAgICB3aXRoaW4g YW4gZXhwb3J0IHN0YXRlbWVudC4KKworICAgICAgICAqIHBhcnNlci9QYXJzZXIuY3BwOgorICAg ICAgICAoSlNDOjpQYXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VNb2R1bGVTb3VyY2VFbGVtZW50cyk6 CisgICAgICAgIFJlY29yZCBhIHBhdXNlIGxvY2F0aW9uIGZvciBpbXBvcnQvZXhwb3J0IHN0YXRl bWVudHMuCisKKzIwMTYtMDktMzAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTdGVwcGluZyBvdmVyL291dCBvZiBhIGZ1bmN0 aW9uIHNvbWV0aW1lcyByZXN1bWVzIGluc3RlYWQgb2YgdGFraW5nIHlvdSB0byBjYWxsZXIKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjgwMgogICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjg1Njk5ODI+CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcGFyc2VyL0FTVEJ1aWxkZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJz ZXIvQVNUQnVpbGRlci5oCmluZGV4IDVjMDNmMTkuLmY0MTVlZTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvQVNUQnVpbGRlci5oCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9wYXJzZXIvQVNUQnVpbGRlci5oCkBAIC03NTIsMTEgKzc1MiwxNSBAQCBwdWJsaWM6 CiAKICAgICBTdGF0ZW1lbnROb2RlKiBjcmVhdGVFeHBvcnREZWZhdWx0RGVjbGFyYXRpb24oY29u c3QgSlNUb2tlbkxvY2F0aW9uJiBsb2NhdGlvbiwgU3RhdGVtZW50Tm9kZSogZGVjbGFyYXRpb24s IGNvbnN0IElkZW50aWZpZXImIGxvY2FsTmFtZSkKICAgICB7CisgICAgICAgIC8vIFRoZSBleHBv cnQgc3RhdGVtZW50IGl0c2VsZiB3aWxsIGdldCB0aGUgYnJlYWtwb2ludCBsb2NhdGlvbiwgZG9u J3QgcmVjb3JkIGFub3RoZXIgZm9yIHRoZSBkZWNsYXJhdGlvbiBzdGF0ZW1lbnQuCisgICAgICAg IGRlY2xhcmF0aW9uLT5zZXROZWVkc0RlYnVnSG9vaygpOwogICAgICAgICByZXR1cm4gbmV3ICht X3BhcnNlckFyZW5hKSBFeHBvcnREZWZhdWx0RGVjbGFyYXRpb25Ob2RlKGxvY2F0aW9uLCBkZWNs YXJhdGlvbiwgbG9jYWxOYW1lKTsKICAgICB9CiAKICAgICBTdGF0ZW1lbnROb2RlKiBjcmVhdGVF eHBvcnRMb2NhbERlY2xhcmF0aW9uKGNvbnN0IEpTVG9rZW5Mb2NhdGlvbiYgbG9jYXRpb24sIFN0 YXRlbWVudE5vZGUqIGRlY2xhcmF0aW9uKQogICAgIHsKKyAgICAgICAgLy8gVGhlIGV4cG9ydCBz dGF0ZW1lbnQgaXRzZWxmIHdpbGwgZ2V0IHRoZSBicmVha3BvaW50IGxvY2F0aW9uLCBkb24ndCBy ZWNvcmQgYW5vdGhlciBmb3IgdGhlIGRlY2xhcmF0aW9uIHN0YXRlbWVudC4KKyAgICAgICAgZGVj bGFyYXRpb24tPnNldE5lZWRzRGVidWdIb29rKCk7CiAgICAgICAgIHJldHVybiBuZXcgKG1fcGFy c2VyQXJlbmEpIEV4cG9ydExvY2FsRGVjbGFyYXRpb25Ob2RlKGxvY2F0aW9uLCBkZWNsYXJhdGlv bik7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1Bh cnNlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKaW5kZXgg NmMxYTFhOC4uYmUzZGNhOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNl ci9QYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNw cApAQCAtNDU5LDExICs0NTksMTUgQEAgdGVtcGxhdGUgPGNsYXNzIFRyZWVCdWlsZGVyPiBUcmVl U291cmNlRWxlbWVudHMgUGFyc2VyPExleGVyVHlwZT46OnBhcnNlTW9kdWxlU28KIAogICAgIHdo aWxlICh0cnVlKSB7CiAgICAgICAgIFRyZWVTdGF0ZW1lbnQgc3RhdGVtZW50ID0gMDsKLSAgICAg ICAgaWYgKG1hdGNoKElNUE9SVCkpCisgICAgICAgIGlmIChtYXRjaChJTVBPUlQpKSB7CiAgICAg ICAgICAgICBzdGF0ZW1lbnQgPSBwYXJzZUltcG9ydERlY2xhcmF0aW9uKGNvbnRleHQpOwotICAg ICAgICBlbHNlIGlmIChtYXRjaChFWFBPUlQpKQorICAgICAgICAgICAgaWYgKHN0YXRlbWVudCkK KyAgICAgICAgICAgICAgICByZWNvcmRQYXVzZUxvY2F0aW9uKGNvbnRleHQuYnJlYWtwb2ludExv Y2F0aW9uKHN0YXRlbWVudCkpOworICAgICAgICB9IGVsc2UgaWYgKG1hdGNoKEVYUE9SVCkpIHsK ICAgICAgICAgICAgIHN0YXRlbWVudCA9IHBhcnNlRXhwb3J0RGVjbGFyYXRpb24oY29udGV4dCk7 Ci0gICAgICAgIGVsc2UgeworICAgICAgICAgICAgaWYgKHN0YXRlbWVudCkKKyAgICAgICAgICAg ICAgICByZWNvcmRQYXVzZUxvY2F0aW9uKGNvbnRleHQuYnJlYWtwb2ludExvY2F0aW9uKHN0YXRl bWVudCkpOworICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgY29uc3QgSWRlbnRpZmllciog ZGlyZWN0aXZlID0gMDsKICAgICAgICAgICAgIHVuc2lnbmVkIGRpcmVjdGl2ZUxpdGVyYWxMZW5n dGggPSAwOwogICAgICAgICAgICAgaWYgKHBhcnNlTW9kZSA9PSBTb3VyY2VQYXJzZU1vZGU6Ok1v ZHVsZUFuYWx5emVNb2RlKSB7Cg==