162805 2016-09-30 13:52:25 -0700 Second time going into fullscreen using silverlight, will hide the menu bar and dock for Safari 2016-09-30 14:35:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1235389 0 andersca 2016-09-30 13:52:25 -0700 Second time going into fullscreen using silverlight, will hide the menu bar and dock for Safari 1235396 1 290378 andersca 2016-09-30 13:57:05 -0700 Created attachment 290378 Patch 1235412 2 290378 mitz 2016-09-30 14:20:05 -0700 Comment on attachment 290378 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290378&action=review > Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:118 > + if (!windowID) Not sure this is needed, because kCGSNullWindowID is not a valid value. > Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:142 > + if (!windowID) Ditto. 1235416 3 andersca 2016-09-30 14:22:02 -0700 (In reply to comment #2) > Comment on attachment 290378 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=290378&action=review > > > Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:118 > > + if (!windowID) > > Not sure this is needed, because kCGSNullWindowID is not a valid value. > > > Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:142 > > + if (!windowID) > > Ditto. I'm keeping them because -[NSWindow windowNumber] can return 0 according to https://developer.apple.com/reference/appkit/nswindow/1419068-windownumber 1235423 4 andersca 2016-09-30 14:35:18 -0700 Committed r206675: <http://trac.webkit.org/changeset/206675> 290378 2016-09-30 13:57:05 -0700 2016-09-30 14:20:05 -0700 Patch bug-162805-20160930135401.patch text/plain 3941 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDhjNDI0MWQ0N2JjZDE5 YWNkYjc1YmFlNDJhYzhlYjUxOWJlODU0ZS4uODZiNDk4MDkzNjQ0NDdhNDBhMGNjMWNkYTRjMjVl ODA3ZDZhNDdmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA5LTMwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU2Vjb25kIHRpbWUg Z29pbmcgaW50byBmdWxsc2NyZWVuIHVzaW5nIHNpbHZlcmxpZ2h0LCB3aWxsIGhpZGUgdGhlIG1l bnUgYmFyIGFuZCBkb2NrIGZvciBTYWZhcmkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2MjgwNQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yODIwODQ5 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1cm5z IG91dCB0aGF0IHRoZSBXaW5kb3dSZWYgd3JhcHBlcnMgZm9yIGZ1bGwgc2NyZWVuIE5TV2luZG93 cyBjYW4gZW5kIHVwIGluIHRoZSBtX3dpbmRvd3MgSGFzaFNldCwKKyAgICAgICAgYW5kIG5ldmVy IGdvIGF3YXkuIAorICAgICAgICAKKyAgICAgICAgRml4IHRoaXMgYnkgc3RvcmluZyB0aGUgY2Fu b25pY2FsIENHV2luZG93SURzIGluIHRoZSBoYXNoIG1hcCBpbnN0ZWFkLgorCisgICAgICAgICog UGx1Z2luUHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc01hYy5tbToKKyAgICAgICAgKFdlYktpdDo6 Y2dXaW5kb3dJRCk6CisgICAgICAgIChXZWJLaXQ6OndpbmRvd0NvdmVyc0FueVNjcmVlbik6Cisg ICAgICAgIChXZWJLaXQ6OkZ1bGxzY3JlZW5XaW5kb3dUcmFja2VyOjp3aW5kb3dTaG93bik6Cisg ICAgICAgIChXZWJLaXQ6OkZ1bGxzY3JlZW5XaW5kb3dUcmFja2VyOjp3aW5kb3dIaWRkZW4pOgor CiAyMDE2LTA5LTI3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmVtb3ZlIGEgY291cGxlIG9mIHVudXNlZCBtZW1iZXJzIGZyb20gUGxhdGZvcm1LZXli b2FyZEV2ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL21hYy9Q bHVnaW5Qcm9jZXNzTWFjLm1tIGIvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9tYWMvUGx1 Z2luUHJvY2Vzc01hYy5tbQppbmRleCBjNDJlMjBkYTNhMzk4N2ViZTNlZWJiMmVhNTlmYzkzNmE1 MGFmZjZkLi44YTNlMDc5NzUyZTQ0MGMzOTZhNjMzOTc4MTA4ODRlZGI5YzE1MmEwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL21hYy9QbHVnaW5Qcm9jZXNzTWFjLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvbWFjL1BsdWdpblByb2Nlc3NNYWMu bW0KQEAgLTcwLDggKzcwLDcgQEAgcHVibGljOgogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IHZv aWQgd2luZG93SGlkZGVuKFQgd2luZG93KTsKIAogcHJpdmF0ZToKLSAgICB0eXBlZGVmIEhhc2hT ZXQ8dm9pZCo+IFdpbmRvd1NldDsKLSAgICBXaW5kb3dTZXQgbV93aW5kb3dzOworICAgIEhhc2hT ZXQ8Q0dXaW5kb3dJRD4gbV93aW5kb3dzOwogfTsKIAogc3RhdGljIGJvb2wgcmVjdENvdmVyc0Fu eVNjcmVlbihOU1JlY3QgcmVjdCkKQEAgLTk0LDE4ICs5MywzMyBAQCBzdGF0aWMgYm9vbCB3aW5k b3dDb3ZlcnNBbnlTY3JlZW4oV2luZG93UmVmIHdpbmRvdykKIAogICAgIHJldHVybiByZWN0Q292 ZXJzQW55U2NyZWVuKE5TUmVjdEZyb21DR1JlY3QoYm91bmRzKSk7CiB9CisKK3N0YXRpYyBDR1dp bmRvd0lEIGNnV2luZG93SUQoV2luZG93UmVmIHdpbmRvdykKK3sKKyAgICByZXR1cm4gcmVpbnRl cnByZXRfY2FzdDxDR1dpbmRvd0lEPihXS0dldE5hdGl2ZVdpbmRvd0Zyb21XaW5kb3dSZWYod2lu ZG93KSk7Cit9CisKICNlbmRpZgogCi1zdGF0aWMgYm9vbCB3aW5kb3dDb3ZlcnNBbnlTY3JlZW4o TlNXaW5kb3cqIHdpbmRvdykKK3N0YXRpYyBib29sIHdpbmRvd0NvdmVyc0FueVNjcmVlbihOU1dp bmRvdyAqd2luZG93KQoreworICAgIHJldHVybiByZWN0Q292ZXJzQW55U2NyZWVuKHdpbmRvdy5m cmFtZSk7Cit9CisKK3N0YXRpYyBDR1dpbmRvd0lEIGNnV2luZG93SUQoTlNXaW5kb3cgKndpbmRv dykKIHsKLSAgICByZXR1cm4gcmVjdENvdmVyc0FueVNjcmVlbihbd2luZG93IGZyYW1lXSk7Cisg ICAgcmV0dXJuIHdpbmRvdy53aW5kb3dOdW1iZXI7CiB9CiAKLXRlbXBsYXRlPHR5cGVuYW1lIFQ+ IHZvaWQgRnVsbHNjcmVlbldpbmRvd1RyYWNrZXI6OndpbmRvd1Nob3duKFQgd2luZG93KQordGVt cGxhdGU8dHlwZW5hbWUgVD4KK3ZvaWQgRnVsbHNjcmVlbldpbmRvd1RyYWNrZXI6OndpbmRvd1No b3duKFQgd2luZG93KQogeworICAgIENHV2luZG93SUQgd2luZG93SUQgPSBjZ1dpbmRvd0lEKHdp bmRvdyk7CisgICAgaWYgKCF3aW5kb3dJRCkKKyAgICAgICAgcmV0dXJuOworCiAgICAgLy8gSWYg dGhpcyB3aW5kb3cgaXMgYWxyZWFkeSB2aXNpYmxlIHRoZW4gdGhlcmUgaXMgbm90aGluZyB0byBk by4KLSAgICBXaW5kb3dTZXQ6Oml0ZXJhdG9yIGl0ID0gbV93aW5kb3dzLmZpbmQod2luZG93KTsK LSAgICBpZiAoaXQgIT0gbV93aW5kb3dzLmVuZCgpKQorICAgIGlmIChtX3dpbmRvd3MuY29udGFp bnMod2luZG93SUQpKQogICAgICAgICByZXR1cm47CiAgICAgCiAgICAgLy8gSWYgdGhlIHdpbmRv dyBpcyBub3QgZnVsbC1zY3JlZW4gdGhlbiB3ZSdyZSBub3QgaW50ZXJlc3RlZCBpbiBpdC4KQEAg LTExNCwyMSArMTI4LDIzIEBAIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IHZvaWQgRnVsbHNjcmVlbldp bmRvd1RyYWNrZXI6OndpbmRvd1Nob3duKFQgd2luZG93KQogCiAgICAgYm9vbCB3aW5kb3dTZXRX YXNFbXB0eSA9IG1fd2luZG93cy5pc0VtcHR5KCk7CiAKLSAgICBtX3dpbmRvd3MuYWRkKHdpbmRv dyk7CisgICAgbV93aW5kb3dzLmFkZCh3aW5kb3dJRCk7CiAgICAgCiAgICAgLy8gSWYgdGhpcyBp cyB0aGUgZmlyc3QgZnVsbCBzY3JlZW4gd2luZG93IHRvIGJlIHNob3duLCBub3RpZnkgdGhlIFVJ IHByb2Nlc3MuCiAgICAgaWYgKHdpbmRvd1NldFdhc0VtcHR5KQogICAgICAgICBQbHVnaW5Qcm9j ZXNzOjpzaW5nbGV0b24oKS5zZXRGdWxsc2NyZWVuV2luZG93SXNTaG93aW5nKHRydWUpOwogfQog Ci10ZW1wbGF0ZTx0eXBlbmFtZSBUPiB2b2lkIEZ1bGxzY3JlZW5XaW5kb3dUcmFja2VyOjp3aW5k b3dIaWRkZW4oVCB3aW5kb3cpCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPgordm9pZCBGdWxsc2NyZWVu V2luZG93VHJhY2tlcjo6d2luZG93SGlkZGVuKFQgd2luZG93KQogewotICAgIC8vIElmIHRoaXMg aXMgbm90IGEgd2luZG93IHRoYXQgd2UncmUgdHJhY2tpbmcgdGhlbiB0aGVyZSBpcyBub3RoaW5n IHRvIGRvLgotICAgIFdpbmRvd1NldDo6aXRlcmF0b3IgaXQgPSBtX3dpbmRvd3MuZmluZCh3aW5k b3cpOwotICAgIGlmIChpdCA9PSBtX3dpbmRvd3MuZW5kKCkpCisgICAgQ0dXaW5kb3dJRCB3aW5k b3dJRCA9IGNnV2luZG93SUQod2luZG93KTsKKyAgICBpZiAoIXdpbmRvd0lEKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBtX3dpbmRvd3MucmVtb3ZlKGl0KTsKKyAgICAvLyBJZiB0aGlzIGlzIG5v dCBhIHdpbmRvdyB0aGF0IHdlJ3JlIHRyYWNraW5nIHRoZW4gdGhlcmUgaXMgbm90aGluZyB0byBk by4KKyAgICBpZiAoIW1fd2luZG93cy5yZW1vdmUod2luZG93SUQpKQorICAgICAgICByZXR1cm47 CiAKICAgICAvLyBJZiB0aGlzIHdhcyB0aGUgbGFzdCBmdWxsIHNjcmVlbiB3aW5kb3cgdGhhdCB3 YXMgdmlzaWJsZSwgbm90aWZ5IHRoZSBVSSBwcm9jZXNzLgogICAgIGlmIChtX3dpbmRvd3MuaXNF bXB0eSgpKQo=