162797 2016-09-30 11:32:30 -0700 Remove the dumping of the stack back trace in VM::verifyExceptionCheckNeedIsSatisfied(). 2016-09-30 12:50:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 162351 1 mark.lam mark.lam commit-queue keith_miller msaboff saam oldest_to_newest 1235307 0 mark.lam 2016-09-30 11:32:30 -0700 This is because the RELEASE_ASSERT() that follows immediately after will also dump the stack back trace. Hence, the first dump will be redundant. 1235308 1 290356 mark.lam 2016-09-30 11:36:00 -0700 Created attachment 290356 proposed patch. 1235352 2 290356 ggaren 2016-09-30 12:47:23 -0700 Comment on attachment 290356 proposed patch. r=me 1235357 3 mark.lam 2016-09-30 12:50:59 -0700 Thanks for the review. Landed in r206658: <http://trac.webkit.org/r206658>. 290356 2016-09-30 11:36:00 -0700 2016-09-30 12:47:23 -0700 proposed patch. bug-162797.patch text/plain 1886 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA2NjQzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE2LTA5LTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgdGhlIGR1bXBpbmcgb2YgdGhlIHN0YWNrIGJhY2sgdHJhY2UgaW4gVk06OnZlcmlmeUV4 Y2VwdGlvbkNoZWNrTmVlZElzU2F0aXNmaWVkKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI3OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGJlY2F1c2UgdGhlIFJFTEVBU0VfQVNTRVJU KCkgdGhhdCBmb2xsb3dzIGltbWVkaWF0ZWx5IGFmdGVyIHdpbGwgYWxzbworICAgICAgICBkdW1w IHRoZSBzdGFjayBiYWNrIHRyYWNlLiAgSGVuY2UsIHRoZSBmaXJzdCBkdW1wIHdpbGwgYmUgcmVk dW5kYW50LgorCisgICAgICAgIEFsc28gcmVtb3ZlZCBhbiBleHRyYSBzcGFjZSBpbiB0aGUgZGF0 YUxvZyBvdXRwdXQuCisKKyAgICAgICAgKiBydW50aW1lL1ZNLmNwcDoKKyAgICAgICAgKEpTQzo6 Vk06OnZlcmlmeUV4Y2VwdGlvbkNoZWNrTmVlZElzU2F0aXNmaWVkKToKKwogMjAxNi0wOS0zMCAg TWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIHRvcFZNRW50cnlG cmFtZSB0byBkZXRlcm1pbmUgd2hldGhlciB0byBza2lwIHRoZSByZS10aHJvdyBvZiBhIHNpbXVs YXRlZCB0aHJvdy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAJKHJldmlz aW9uIDIwNjY0MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAkod29y a2luZyBjb3B5KQpAQCAtOTA2LDExICs5MDYsMTAgQEAgdm9pZCBWTTo6dmVyaWZ5RXhjZXB0aW9u Q2hlY2tOZWVkSXNTYXRpcwogICAgICAgICBkYXRhTG9nKAogICAgICAgICAgICAgIkVSUk9SOiBV bmNoZWNrZWQgSlMgZXhjZXB0aW9uOlxuIgogICAgICAgICAgICAgIiAgICBUaGlzIHNjb3BlIGNh biB0aHJvdyBhIEpTIGV4Y2VwdGlvbjogIiwgdGhyb3dMb2NhdGlvbiwgIlxuIgotICAgICAgICAg ICAgIiAgICAgICAgKEV4Y2VwdGlvblNjb3BlOjptX3JlY3Vyc2lvbkRlcHRoIHdhcyAgIiwgdGhy b3dEZXB0aCwgIilcbiIKKyAgICAgICAgICAgICIgICAgICAgIChFeGNlcHRpb25TY29wZTo6bV9y ZWN1cnNpb25EZXB0aCB3YXMgIiwgdGhyb3dEZXB0aCwgIilcbiIKICAgICAgICAgICAgICIgICAg QnV0IHRoZSBleGNlcHRpb24gd2FzIHVuY2hlY2tlZCBhcyBvZiB0aGlzIHNjb3BlOiAiLCBsb2Nh dGlvbiwgIlxuIgotICAgICAgICAgICAgIiAgICAgICAgKEV4Y2VwdGlvblNjb3BlOjptX3JlY3Vy c2lvbkRlcHRoIHdhcyAgIiwgcmVjdXJzaW9uRGVwdGgsICIpXG4iCisgICAgICAgICAgICAiICAg ICAgICAoRXhjZXB0aW9uU2NvcGU6Om1fcmVjdXJzaW9uRGVwdGggd2FzICIsIHJlY3Vyc2lvbkRl cHRoLCAiKVxuIgogICAgICAgICAgICAgIlxuIik7Ci0gICAgICAgIFdURlJlcG9ydEJhY2t0cmFj ZSgpOwogCiAgICAgICAgIFJFTEVBU0VfQVNTRVJUKCFtX25lZWRFeGNlcHRpb25DaGVjayk7CiAg ICAgfQo=