162795 2016-09-30 11:06:16 -0700 URLParser: parsing a URL with an empty host and a colon should fail 2016-09-30 11:51:05 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen commit-queue oldest_to_newest 1235290 0 achristensen 2016-09-30 11:06:16 -0700 URLParser: parsing a URL with an empty host and a colon should fail 1235291 1 290351 achristensen 2016-09-30 11:06:45 -0700 Created attachment 290351 Patch 1235292 2 commit-queue 2016-09-30 11:08:58 -0700 Attachment 290351 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1235293 3 290351 achristensen 2016-09-30 11:09:12 -0700 Comment on attachment 290351 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290351&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Covered by new API tests. 1235320 4 achristensen 2016-09-30 11:51:05 -0700 http://trac.webkit.org/changeset/206649 290351 2016-09-30 11:06:45 -0700 2016-09-30 11:39:17 -0700 Patch bug-162795-20160930110340.patch text/plain 4606 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjYzMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTMwICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVVJMUGFyc2Vy OiBwYXJzaW5nIGEgVVJMIHdpdGggYW4gZW1wdHkgaG9zdCBhbmQgYSBjb2xvbiBzaG91bGQgZmFp bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNzk1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9VUkxQYXJzZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6VVJMUGFyc2VyOjpwYXJzZUhvc3RBbmRQb3J0KToKKwogMjAxNi0wOS0y OSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0 IGZvciBkb3dubG9hZCBhdHRyaWJ1dGUgb24gYXJlYSBlbGVtZW50cwpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9VUkxQYXJzZXIuY3BwCShyZXZpc2lvbiAyMDY2MzApCisrKyBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9VUkxQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDAzLDYgKzI0 MDMsOCBAQCBib29sIFVSTFBhcnNlcjo6cGFyc2VIb3N0QW5kUG9ydChDb2RlUG9pCiB7CiAgICAg aWYgKGl0ZXJhdG9yLmF0RW5kKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBpZiAoKml0 ZXJhdG9yID09ICc6JykKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGlmICgqaXRlcmF0b3Ig PT0gJ1snKSB7CiAgICAgICAgIGF1dG8gaXB2NkVuZCA9IGl0ZXJhdG9yOwogICAgICAgICB3aGls ZSAoIWlwdjZFbmQuYXRFbmQoKSAmJiAqaXB2NkVuZCAhPSAnXScpCkluZGV4OiBUb29scy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDY2NDIpCisr KyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNi0w OS0zMCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAg ICAgIFVSTFBhcnNlcjogcGFyc2luZyBhIFVSTCB3aXRoIGFuIGVtcHR5IGhvc3QgYW5kIGEgY29s b24gc2hvdWxkIGZhaWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2Mjc5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNlci5jcHA6CisgICAg ICAgIChUZXN0V2ViS2l0QVBJOjpURVNUX0YpOgorCiAyMDE2LTA5LTI5ICBKaWV3ZW4gVGFuICA8 amlld2VuX3RhbkBhcHBsZS5jb20+CiAKICAgICAgICAgRXhwb3NlIENyeXB0b0tleSB0byB3ZWIg d29ya2VycwpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VS TFBhcnNlci5jcHAJKHJldmlzaW9uIDIwNjYzMCkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViQ29yZS9VUkxQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTIsNiArMjkyLDEw IEBAIFRFU1RfRihVUkxQYXJzZXJUZXN0LCBCYXNpYykKICAgICBjaGVja1VSTCgiaHR0cDovLzEy Ny4wLjAuMSIsIHsiaHR0cCIsICIiLCAiIiwgIjEyNy4wLjAuMSIsIDAsICIvIiwgIiIsICIiLCAi aHR0cDovLzEyNy4wLjAuMS8ifSk7CiAgICAgY2hlY2tVUkwoImh0dHA6Ly8xMjcuMC4wLjEuIiwg eyJodHRwIiwgIiIsICIiLCAiMTI3LjAuMC4xLiIsIDAsICIvIiwgIiIsICIiLCAiaHR0cDovLzEy Ny4wLjAuMS4vIn0pOwogICAgIGNoZWNrVVJMKCJodHRwOi8vMTI3LjAuMC4xLi8iLCB7Imh0dHAi LCAiIiwgIiIsICIxMjcuMC4wLjEuIiwgMCwgIi8iLCAiIiwgIiIsICJodHRwOi8vMTI3LjAuMC4x Li8ifSk7CisgICAgY2hlY2tVUkwoImh0dHA6Ly9ob3N0OjEyMz8iLCB7Imh0dHAiLCAiIiwgIiIs ICJob3N0IiwgMTIzLCAiLyIsICIiLCAiIiwgImh0dHA6Ly9ob3N0OjEyMy8/In0pOworICAgIGNo ZWNrVVJMKCJodHRwOi8vaG9zdDoxMjM/cXVlcnkiLCB7Imh0dHAiLCAiIiwgIiIsICJob3N0Iiwg MTIzLCAiLyIsICJxdWVyeSIsICIiLCAiaHR0cDovL2hvc3Q6MTIzLz9xdWVyeSJ9KTsKKyAgICBj aGVja1VSTCgiaHR0cDovL2hvc3Q6MTIzIyIsIHsiaHR0cCIsICIiLCAiIiwgImhvc3QiLCAxMjMs ICIvIiwgIiIsICIiLCAiaHR0cDovL2hvc3Q6MTIzLyMifSk7CisgICAgY2hlY2tVUkwoImh0dHA6 Ly9ob3N0OjEyMyNmcmFnbWVudCIsIHsiaHR0cCIsICIiLCAiIiwgImhvc3QiLCAxMjMsICIvIiwg IiIsICJmcmFnbWVudCIsICJodHRwOi8vaG9zdDoxMjMvI2ZyYWdtZW50In0pOwogCiAgICAgLy8g VGhpcyBkaXNhZ3JlZXMgd2l0aCB0aGUgd2ViIHBsYXRmb3JtIHRlc3QgZm9yIGh0dHA6Ly86QHd3 dy5leGFtcGxlLmNvbSBidXQgYWdyZWVzIHdpdGggQ2hyb21lIGFuZCBVUkw6OnBhcnNlLAogICAg IC8vIGFuZCBGaXJlZm94IGZhaWxzIHRoZSB3ZWIgcGxhdGZvcm0gdGVzdCBkaWZmZXJlbnRseS4g TWF5YmUgdGhlIHdlYiBwbGF0Zm9ybSB0ZXN0IG91Z2h0IHRvIGJlIGNoYW5nZWQuCkBAIC03MDcs NiArNzExLDIxIEBAIFRFU1RfRihVUkxQYXJzZXJUZXN0LCBQYXJzZXJEaWZmZXJlbmNlcykKICAg ICBjaGVja1VSTERpZmZlcmVuY2VzKCJBOi8vIiwKICAgICAgICAgeyJhIiwgIiIsICIiLCAiIiwg MCwgIi8iLCAiIiwgIiIsICJhOi8vLyJ9LAogICAgICAgICB7ImEiLCAiIiwgIiIsICIiLCAwLCAi Ly8iLCAiIiwgIiIsICJhOi8vIn0pOworICAgIGNoZWNrVVJMRGlmZmVyZW5jZXMoImh0dHA6Ly86 Ly8iLAorICAgICAgICB7IiIsICIiLCAiIiwgIiIsIDAsICIiLCAiIiwgIiIsICJodHRwOi8vOi8v In0sCisgICAgICAgIHsiaHR0cCIsICIiLCAiIiwgIiIsIDAsICIvLyIsICIiLCAiIiwgImh0dHA6 Ly86Ly8ifSk7CisgICAgY2hlY2tVUkxEaWZmZXJlbmNlcygiaHR0cDovLzoxMjM/IiwKKyAgICAg ICAgeyIiLCAiIiwgIiIsICIiLCAwLCAiIiwgIiIsICIiLCAiaHR0cDovLzoxMjM/In0sCisgICAg ICAgIHsiaHR0cCIsICIiLCAiIiwgIiIsIDEyMywgIi8iLCAiIiwgIiIsICJodHRwOi8vOjEyMy8/ In0pOworICAgIGNoZWNrVVJMRGlmZmVyZW5jZXMoImh0dHA6LzoiLAorICAgICAgICB7IiIsICIi LCAiIiwgIiIsIDAsICIiLCAiIiwgIiIsICJodHRwOi86In0sCisgICAgICAgIHsiaHR0cCIsICIi LCAiIiwgIiIsIDAsICIvIiwgIiIsICIiLCAiaHR0cDovLzovIn0pOworICAgIGNoZWNrVVJMRGlm ZmVyZW5jZXMoImFzZGY6Ly86IiwKKyAgICAgICAgeyIiLCAiIiwgIiIsICIiLCAwLCAiIiwgIiIs ICIiLCAiYXNkZjovLzoifSwKKyAgICAgICAgeyJhc2RmIiwgIiIsICIiLCAiIiwgMCwgIiIsICIi LCAiIiwgImFzZGY6Ly86In0pOworICAgIGNoZWNrVVJMRGlmZmVyZW5jZXMoImh0dHA6Ly86IiwK KyAgICAgICAgeyIiLCAiIiwgIiIsICIiLCAwLCAiIiwgIiIsICIiLCAiaHR0cDovLzoifSwKKyAg ICAgICAgeyJodHRwIiwgIiIsICIiLCAiIiwgMCwgIi8iLCAiIiwgIiIsICJodHRwOi8vOi8ifSk7 CiAgICAgY2hlY2tSZWxhdGl2ZVVSTERpZmZlcmVuY2VzKCIvL0N8L2Zvby9iYXIiLCAiZmlsZTov Ly90bXAvbW9jay9wYXRoIiwKICAgICAgICAgeyJmaWxlIiwgIiIsICIiLCAiIiwgMCwgIi9DOi9m b28vYmFyIiwgIiIsICIiLCAiZmlsZTovLy9DOi9mb28vYmFyIn0sCiAgICAgICAgIHsiIiwgIiIs ICIiLCAiIiwgMCwgIiIsICIiLCAiIiwgIi8vQ3wvZm9vL2JhciJ9KTsKQEAgLTg4NSw2ICs5MDQs NyBAQCBURVNUX0YoVVJMUGFyc2VyVGVzdCwgUGFyc2VyRmFpbHVyZXMpCiAgICAgc2hvdWxkRmFp bChTdHJpbmcoKSwgImFib3V0OmJsYW5rIik7CiAgICAgc2hvdWxkRmFpbCgiaHR0cDovLzEyNy4w LjAuMTphYmMiKTsKICAgICBzaG91bGRGYWlsKCJodHRwOi8vaG9zdDphYmMiKTsKKyAgICBzaG91 bGRGYWlsKCJodHRwOi8vOmFiYyIpOwogICAgIHNob3VsZEZhaWwoImh0dHA6Ly9hOkAiLCAiYWJv dXQ6YmxhbmsiKTsKICAgICBzaG91bGRGYWlsKCJodHRwOi8vOmJAIiwgImFib3V0OmJsYW5rIik7 CiAgICAgc2hvdWxkRmFpbCgiaHR0cDovLzpAIiwgImFib3V0OmJsYW5rIik7Cg==