162792 2016-09-30 10:36:38 -0700 Inspector exception in `parseTextForRule()` when pasting into CSS rule selector 2016-10-06 16:13:35 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 rob hi bburg commit-queue hi joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1235280 0 rob 2016-09-30 10:36:38 -0700 ------- Inspected URL: http://localhost:8000/guides/anchor/index.html Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/603.1.8+ (KHTML, like Gecko) Uncaught Exceptions: - TypeError: null is not an object (evaluating 'parseTextForRule(data)') (at CSSStyleDeclarationSection.js:437:49) _handleSelectorPaste @ CSSStyleDeclarationSection.js:437:49 _handleSelectorPaste @ [native code] ------- * STEPS TO REPRODUCE 1. In the Elements panel, select an element with several CSS rules applying to it 2. In the Styles sidebar, select part of the selector for one of the rules and copy it (via keyboard, cmd+c) 3. Paste (via keyboard, cmd+v) the selected text at the start of a different selector 4. Inspector immediately flips to the "Web Inspector encountered an internal error" screen 1235707 1 290463 hi 2016-10-01 23:31:59 -0700 Created attachment 290463 Patch 1235708 2 webkit-bug-importer 2016-10-01 23:32:09 -0700 <rdar://problem/28580248> 1236457 3 mattbaker 2016-10-04 16:55:24 -0700 I can't reproduce this with the steps provided. Devin, do you have a reduction? 1236790 4 hi 2016-10-05 14:27:56 -0700 (In reply to comment #3) > I can't reproduce this with the steps provided. Devin, do you have a > reduction? The reproduction works just fine for me. Either way, the logic still doesn't work correctly with strings that contain newlines. 1237388 5 290463 mattbaker 2016-10-06 15:51:20 -0700 Comment on attachment 290463 Patch Was able to repro, r=me. 1237391 6 290463 commit-queue 2016-10-06 16:13:32 -0700 Comment on attachment 290463 Patch Clearing flags on attachment: 290463 Committed r206888: <http://trac.webkit.org/changeset/206888> 1237392 7 commit-queue 2016-10-06 16:13:35 -0700 All reviewed patches have been landed. Closing bug. 290463 2016-10-01 23:31:59 -0700 2016-10-06 16:13:32 -0700 Patch bug-162792-20161001232853.patch text/plain 2002 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDBmYmE0NGMwNGI5ZmVlOTg0YzIzMjgyMTQ3MTNk OTI4YWRjMjVjYzYuLjg4ZTMyM2EwNTAyNjgxZWQ5YjJmMzVhNmZjNWNmZjc5NDYyYzcwNjEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTEwLTAxICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIEluc3BlY3Rv ciBleGNlcHRpb24gaW4gYHBhcnNlVGV4dEZvclJ1bGUoKWAgd2hlbiBwYXN0aW5nIGludG8gQ1NT IHJ1bGUgc2VsZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2Mjc5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbi5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbi5wcm90 b3R5cGUuX2hhbmRsZVNlbGVjdG9yUGFzdGUucGFyc2VUZXh0Rm9yUnVsZSk6CisgICAgICAgIENo YW5nZWQgcmVndWxhciBleHByZXNzaW9uIGZvciBtYXRjaGluZyBDU1MgcnVsZXMgdG8gYWxsb3cg bmV3bGluZXMgaW4gcGFzdGVkIHRleHQuCisKIDIwMTYtMDktMjkgIEFhcm9uIENodSAgPGFhcm9u X2NodUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQVhJOiBsaW5raWZpZWQg cmVmcyB0byAjZG9jdW1lbnQgYW5kICN0ZXh0IGFyZSBub3QgdXN1YWxseSBuYXZpZ2FibGUgbm9k ZXM7IGNvbnNpZGVyIGRlbGlua2lmeWluZyB0aGVtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbi5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVj bGFyYXRpb25TZWN0aW9uLmpzCmluZGV4IDFhYjhiNzZkMTNiYzBkNDViZDViMDRiOGVmMmQ1M2U5 MWI0Mzc1NDQuLmJkYjBlMDkzYzUyNDRjYWZiNzcyOWIyYTJjZjRiZmNmMGZiNmVjMGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxl RGVjbGFyYXRpb25TZWN0aW9uLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzCkBAIC00MjMsMTEgKzQy MywxMSBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24gPSBjbGFzcyBD U1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbiBleHRlbgogICAgICAgICB7CiAgICAgICAgICAgICBs ZXQgY29udGFpbnNCcmFjZXMgPSAvW1x7XH1dLzsKICAgICAgICAgICAgIGlmICghY29udGFpbnNC cmFjZXMudGVzdCh0ZXh0KSkKLSAgICAgICAgICAgICAgICByZXR1cm4gbnVsbDsKKyAgICAgICAg ICAgICAgICByZXR1cm4gW107CiAKLSAgICAgICAgICAgIGxldCBtYXRjaCA9IHRleHQubWF0Y2go LyhbXntdKyl7KC4qKX0vKTsKKyAgICAgICAgICAgIGxldCBtYXRjaCA9IHRleHQubWF0Y2goLyhb XntdKyl7KFtcc1xTXSopfS8pOwogICAgICAgICAgICAgaWYgKCFtYXRjaCkKLSAgICAgICAgICAg ICAgICByZXR1cm4gbnVsbDsKKyAgICAgICAgICAgICAgICByZXR1cm4gW107CiAKICAgICAgICAg ICAgIC8vIElmIHRoZSBtYXRjaCAiYm9keSIgY29udGFpbnMgYnJhY2VzLCBwYXJzZSB0aGF0IGJv ZHkgYXMgaWYgaXQgd2VyZSBhIHJ1bGUuCiAgICAgICAgICAgICAvLyBUaGlzIHdpbGwgdXN1YWxs eSBoYXBwZW4gaWYgdGhlIHVzZXIgaW5jbHVkZXMgYSBtZWRpYSBxdWVyeSBpbiB0aGUgY29waWVk IHRleHQuCg==