162776 2016-09-30 02:21:24 -0700 REGRESSION(r206505) [GTK] Build broken with GTK+ 3.14 2016-10-26 00:50:06 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 162603 1 clopez webkit-unassigned bugs-noreply cgarcia mcatanzaro oldest_to_newest 1235169 0 clopez 2016-09-30 02:21:24 -0700 Trying to build current trunk (r206631) of WebKitGTK+ on Debian stable (GTK+ 3.14.5) without the internal jhbuild results in this: [.... compiler parameters .... ] -o Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/gtk/WebContextMenuProxyGtk.cpp.o -c ../../Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp ../../Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:69:93: error: use of undeclared identifier 'gtk_widget_get_action_group'; did you mean 'gtk_widget_set_margin_top'? g_action_map_add_action(((((GActionMap*) g_type_check_instance_cast ((GTypeInstance*) ((gtk_widget_get_action_group(((((GtkWidget*) g_type_check_instance_cast ((GTypeInstance*) ((m_menu)), ((gtk_widget_get_type ())))))), gContextMenuItemGroup))), ((g_action_map_get_type ())))))), action); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ gtk_widget_set_margin_top /usr/include/gtk-3.0/gtk/gtkwidget.h:1115:6: note: 'gtk_widget_set_margin_top' declared here void gtk_widget_set_margin_top (GtkWidget *widget, ^ ../../Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:69:226: error: cannot initialize a parameter of type 'gint' (aka 'int') with an lvalue of type 'const char *' g_action_map_add_action(((((GActionMap*) g_type_check_instance_cast ((GTypeInstance*) ((gtk_widget_get_action_group(((((GtkWidget*) g_type_check_instance_cast ((GTypeInstance*) ((m_menu)), ((gtk_widget_get_type ())))))), gContextMenuItemGroup))), ((g_action_map_get_type ())))))), action); ^~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/gtkwidget.h:1116:45: note: passing argument to parameter 'margin' here gint margin); ^ 2 errors generated. 1235773 1 cgarcia 2016-10-03 04:03:00 -0700 I'm sorry about this, I checked the Since tag of gtk_widget_set_action_group() and assumed it was the same for the getter. I guess we can simply save the action group somewhere to fix this instead of querying the widget. 1244660 2 292884 cgarcia 2016-10-26 00:43:46 -0700 Created attachment 292884 Patch 1244661 3 cgarcia 2016-10-26 00:48:14 -0700 Committed r207870: <http://trac.webkit.org/changeset/207870> 292884 2016-10-26 00:43:46 -0700 2016-10-26 00:50:06 -0700 Patch wk2-build-fix.diff text/plain 2708 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3MTExZjE0Li45YWQ5MTE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTYtMTAtMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjIwNjUwNSkgW0dUS10gQnVpbGQgYnJva2VuIHdpdGgg R1RLKyAzLjE0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjI3NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBEbyBub3QgdXNlIGd0a193aWRnZXRfZ2V0X2FjdGlvbl9ncm91cCgpIHdoZW4gR1RLKyA8IDMu MTYsIHVzZSBnX29iamVjdF9zZXQgaW5zdGVhZCB0byBhdHRhY2ggdGhlIGFjdGlvbiBncm91cAor ICAgICAgICB0byB0aGUgbWVudSB3aWRnZXQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1dl YkNvbnRleHRNZW51UHJveHlHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0TWVu dVByb3h5R3RrOjphcHBlbmQpOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0TWVudVByb3h5 R3RrOjpXZWJDb250ZXh0TWVudVByb3h5R3RrKToKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4 dE1lbnVQcm94eUd0azo6fldlYkNvbnRleHRNZW51UHJveHlHdGspOgorCiAyMDE2LTEwLTI1ICBB bGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ01h a2UgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9X ZWJDb250ZXh0TWVudVByb3h5R3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsv V2ViQ29udGV4dE1lbnVQcm94eUd0ay5jcHAKaW5kZXggZjc4MWJjMy4uNWM2YThhMCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0TWVudVByb3h5R3Rr LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRNZW51UHJv eHlHdGsuY3BwCkBAIC02Niw3ICs2NiwxMSBAQCB2b2lkIFdlYkNvbnRleHRNZW51UHJveHlHdGs6 OmFwcGVuZChHTWVudSogbWVudSwgY29uc3QgV2ViQ29udGV4dE1lbnVJdGVtR3RrJiBtZQogICAg IEdSZWZQdHI8R01lbnVJdGVtPiBnTWVudUl0ZW07CiAgICAgR0FjdGlvbiogYWN0aW9uID0gbWVu dUl0ZW0uZ0FjdGlvbigpOwogICAgIEFTU0VSVChhY3Rpb24pOworI2lmIEdUS19DSEVDS19WRVJT SU9OKDMsIDE2LCAwKQogICAgIGdfYWN0aW9uX21hcF9hZGRfYWN0aW9uKEdfQUNUSU9OX01BUChn dGtfd2lkZ2V0X2dldF9hY3Rpb25fZ3JvdXAoR1RLX1dJREdFVChtX21lbnUpLCBnQ29udGV4dE1l bnVJdGVtR3JvdXApKSwgYWN0aW9uKTsKKyNlbHNlCisgICAgZ19hY3Rpb25fbWFwX2FkZF9hY3Rp b24oR19BQ1RJT05fTUFQKGdfb2JqZWN0X2dldF9kYXRhKEdfT0JKRUNUKG1fbWVudSksIGdDb250 ZXh0TWVudUl0ZW1Hcm91cCkpLCBhY3Rpb24pOworI2VuZGlmCiAKICAgICBzd2l0Y2ggKG1lbnVJ dGVtLnR5cGUoKSkgewogICAgIGNhc2UgQWN0aW9uVHlwZToKQEAgLTE3OSw2ICsxODMsOSBAQCBX ZWJDb250ZXh0TWVudVByb3h5R3RrOjpXZWJDb250ZXh0TWVudVByb3h5R3RrKEd0a1dpZGdldCog d2ViVmlldywgV2ViUGFnZVByb3h5JgogewogICAgIEdSZWZQdHI8R1NpbXBsZUFjdGlvbkdyb3Vw PiBncm91cCA9IGFkb3B0R1JlZihnX3NpbXBsZV9hY3Rpb25fZ3JvdXBfbmV3KCkpOwogICAgIGd0 a193aWRnZXRfaW5zZXJ0X2FjdGlvbl9ncm91cChHVEtfV0lER0VUKG1fbWVudSksIGdDb250ZXh0 TWVudUl0ZW1Hcm91cCwgR19BQ1RJT05fR1JPVVAoZ3JvdXAuZ2V0KCkpKTsKKyNpZiAhR1RLX0NI RUNLX1ZFUlNJT04oMywgMTYsIDApCisgICAgZ19vYmplY3Rfc2V0X2RhdGEoR19PQkpFQ1QobV9t ZW51KSwgZ0NvbnRleHRNZW51SXRlbUdyb3VwLCBncm91cC5nZXQoKSk7CisjZW5kaWYKICAgICB3 ZWJraXRXZWJWaWV3QmFzZVNldEFjdGl2ZUNvbnRleHRNZW51UHJveHkoV0VCS0lUX1dFQl9WSUVX X0JBU0UobV93ZWJWaWV3KSwgdGhpcyk7CiB9CiAKQEAgLTE5MCw3ICsxOTcsMTAgQEAgV2ViQ29u dGV4dE1lbnVQcm94eUd0azo6fldlYkNvbnRleHRNZW51UHJveHlHdGsoKQogICAgICAgICBnX3Np Z25hbF9oYW5kbGVyX2Rpc2Nvbm5lY3QoaGFuZGxlci52YWx1ZSwgaGFuZGxlci5rZXkpOwogICAg IG1fc2lnbmFsSGFuZGxlcnMuY2xlYXIoKTsKIAotICAgIGd0a193aWRnZXRfaW5zZXJ0X2FjdGlv bl9ncm91cChHVEtfV0lER0VUKG1fbWVudSksICJ3ZWJraXRDb250ZXh0TWVudSIsIG51bGxwdHIp OworICAgIGd0a193aWRnZXRfaW5zZXJ0X2FjdGlvbl9ncm91cChHVEtfV0lER0VUKG1fbWVudSks IGdDb250ZXh0TWVudUl0ZW1Hcm91cCwgbnVsbHB0cik7CisjaWYgIUdUS19DSEVDS19WRVJTSU9O KDMsIDE2LCAwKQorICAgIGdfb2JqZWN0X3NldF9kYXRhKEdfT0JKRUNUKG1fbWVudSksIGdDb250 ZXh0TWVudUl0ZW1Hcm91cCwgbnVsbHB0cik7CisjZW5kaWYKICAgICBndGtfd2lkZ2V0X2Rlc3Ry b3koR1RLX1dJREdFVChtX21lbnUpKTsKIH0KIAo=