162757 2016-09-29 14:56:25 -0700 [iOS] Update Touch constructor test to cover clientX / clientY attributes 2016-09-30 08:59:25 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 147740 1 cdumez cdumez lforschler rbyers rniwa oldest_to_newest 1234993 0 cdumez 2016-09-29 14:56:25 -0700 Update Touch constructor test to cover clientX / clientY attributes. 1234994 1 290249 cdumez 2016-09-29 14:58:15 -0700 Created attachment 290249 Patch 1235007 2 cdumez 2016-09-29 15:19:28 -0700 Committed r206619: <http://trac.webkit.org/changeset/206619> 1235232 3 290249 rbyers 2016-09-30 08:54:56 -0700 Comment on attachment 290249 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290249&action=review > LayoutTests/fast/events/touch/touch-constructor.html:48 > + if (init.hasOwnProperty("clientX")) Looks like there was just a typo above - screenX is tested 3 times, 2 of those were probably supposed to be changed to be clientX and clientY. > LayoutTests/fast/events/touch/touch-constructor.html:71 > +shouldNotThrow("touch = new Touch({ identifier: 1, target: document.body, clientX: 1.5, clientY: 2.5, screenX: 3.5, screenY: 4.5, pageX: 5.5, pageY: 6.5, force: 7.5, clientX: 8.5, clientY: 9.5 })"); clientX and clientY were already in the dictionary here and below. 1235234 4 rbyers 2016-09-30 08:56:57 -0700 Also, in case there is some confusion here - my comment in https://bugs.webkit.org/show_bug.cgi?id=147740#c11 was about Safari's non-standard (and not well documented) TouchEvent.clientX/TouchEvent.clientY properties. clientX/clientY on _Touch_ (in contrast) makes perfect sense, already works and is standardized. 1235235 5 cdumez 2016-09-30 08:59:25 -0700 (In reply to comment #3) > Comment on attachment 290249 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=290249&action=review > > > LayoutTests/fast/events/touch/touch-constructor.html:48 > > + if (init.hasOwnProperty("clientX")) > > Looks like there was just a typo above - screenX is tested 3 times, 2 of > those were probably supposed to be changed to be clientX and clientY. > > > LayoutTests/fast/events/touch/touch-constructor.html:71 > > +shouldNotThrow("touch = new Touch({ identifier: 1, target: document.body, clientX: 1.5, clientY: 2.5, screenX: 3.5, screenY: 4.5, pageX: 5.5, pageY: 6.5, force: 7.5, clientX: 8.5, clientY: 9.5 })"); > > clientX and clientY were already in the dictionary here and below. Thanks for pointing this out. I'll fix the test. 290249 2016-09-29 14:58:15 -0700 2016-09-29 15:06:34 -0700 Patch bug-162757-20160929145513.patch text/plain 2779 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NjEzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTJlNmRiNTU3MWVmZjlkMjk4ODc4 MDhjMjg5NmYyZmRlYTY0M2EwNy4uZTIxNWMyYTIxOWY0NWExODQxNDJjNTdhOTEwNDg0MmY2Y2Jl MTVlYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTA5LTI5ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgW2lPU10gVXBkYXRlIFRvdWNoIGNvbnN0cnVjdG9y IHRlc3QgdG8gY292ZXIgY2xpZW50WCAvIGNsaWVudFkgYXR0cmlidXRlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNzU3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIFRvdWNoIGNvbnN0cnVj dG9yIHRlc3QgdG8gY292ZXIgY2xpZW50WCAvIGNsaWVudFkgYXR0cmlidXRlcy4KKworICAgICAg ICAqIGZhc3QvZXZlbnRzL3RvdWNoL3RvdWNoLWNvbnN0cnVjdG9yLmh0bWw6CisKKzIwMTYtMDkt MjkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAgICBbaU9TXSBBZGQg dGVzdCBmb3IgVG91Y2ggY29uc3RydWN0b3IKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2MjczNgogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjg1MjAw MDc+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC90b3VjaC1jb25z dHJ1Y3Rvci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvdG91Y2gtY29uc3Ry dWN0b3IuaHRtbAppbmRleCBmODA5NWVjNmZhNTAyNDM0MDVhODczYzliZmQ3NzUzNTk3ZWJiZjQ5 Li44MWUxZjM4NjM2NTdiNzE3ZjJmMmU2OGI5OTQ1YWYxYjdhOTgzYjFlIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC90b3VjaC1jb25zdHJ1Y3Rvci5odG1sCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL3RvdWNoLWNvbnN0cnVjdG9yLmh0bWwKQEAg LTQ1LDYgKzQ1LDE0IEBAIGZ1bmN0aW9uIHZhbGlkYXRlVG91Y2godG91Y2gsIGRpY3Rpb25hcnkp CiAgICAgICAgIHNob3VsZEJlKCJjcmVhdGVkVG91Y2gucGFnZVkiLCAiaW5pdC5wYWdlWSIpOwog ICAgIGVsc2UKICAgICAgICAgc2hvdWxkQmUoImNyZWF0ZWRUb3VjaC5wYWdlWSIsICIwIik7Cisg ICAgaWYgKGluaXQuaGFzT3duUHJvcGVydHkoImNsaWVudFgiKSkKKyAgICAgICAgc2hvdWxkQmUo ImNyZWF0ZWRUb3VjaC5jbGllbnRYIiwgImluaXQuY2xpZW50WCIpOworICAgIGVsc2UKKyAgICAg ICAgc2hvdWxkQmUoImNyZWF0ZWRUb3VjaC5jbGllbnRYIiwgIjAiKTsKKyAgICBpZiAoaW5pdC5o YXNPd25Qcm9wZXJ0eSgiY2xpZW50WSIpKQorICAgICAgICBzaG91bGRCZSgiY3JlYXRlZFRvdWNo LmNsaWVudFkiLCAiaW5pdC5jbGllbnRZIik7CisgICAgZWxzZQorICAgICAgICBzaG91bGRCZSgi Y3JlYXRlZFRvdWNoLmNsaWVudFkiLCAiMCIpOwogICAgIGlmIChpbml0Lmhhc093blByb3BlcnR5 KCJmb3JjZSIpKQogICAgICAgICBzaG91bGRCZSgiY3JlYXRlZFRvdWNoLmZvcmNlIiwgImluaXQu Zm9yY2UiKTsKICAgICBlbHNlCkBAIC02MCw4ICs2OCw4IEBAIHNob3VsZE5vdFRocm93KCJ0b3Vj aCA9IG5ldyBUb3VjaCh7IGlkZW50aWZpZXI6IDEsIHRhcmdldDogZG9jdW1lbnQuYm9keSwgY2xp ZW50CiB2YWxpZGF0ZVRvdWNoKHRvdWNoLCB7IGlkZW50aWZpZXI6IDEsIHRhcmdldDogZG9jdW1l bnQuYm9keSwgY2xpZW50WDogMSwgY2xpZW50WTogMiwgc2NyZWVuWDogMywgc2NyZWVuWTogNCwg cGFnZVg6IDUsIHBhZ2VZOiA2LCBmb3JjZTogNyB9KTsKIAogZGVidWcoIiIpOwotc2hvdWxkTm90 VGhyb3coInRvdWNoID0gbmV3IFRvdWNoKHsgaWRlbnRpZmllcjogMSwgdGFyZ2V0OiBkb2N1bWVu dC5ib2R5LCBjbGllbnRYOiAxLjUsIGNsaWVudFk6IDIuNSwgc2NyZWVuWDogMy41LCBzY3JlZW5Z OiA0LjUsIHBhZ2VYOiA1LjUsIHBhZ2VZOiA2LjUsIGZvcmNlOiA3LjUgfSkiKTsKLXZhbGlkYXRl VG91Y2godG91Y2gsIHsgaWRlbnRpZmllcjogMSwgdGFyZ2V0OiBkb2N1bWVudC5ib2R5LCBjbGll bnRYOiAxLjUsIGNsaWVudFk6IDIuNSwgc2NyZWVuWDogMy41LCBzY3JlZW5ZOiA0LjUsIHBhZ2VY OiA1LjUsIHBhZ2VZOiA2LjUsIGZvcmNlOiA3LjUgfSk7CitzaG91bGROb3RUaHJvdygidG91Y2gg PSBuZXcgVG91Y2goeyBpZGVudGlmaWVyOiAxLCB0YXJnZXQ6IGRvY3VtZW50LmJvZHksIGNsaWVu dFg6IDEuNSwgY2xpZW50WTogMi41LCBzY3JlZW5YOiAzLjUsIHNjcmVlblk6IDQuNSwgcGFnZVg6 IDUuNSwgcGFnZVk6IDYuNSwgZm9yY2U6IDcuNSwgY2xpZW50WDogOC41LCBjbGllbnRZOiA5LjUg fSkiKTsKK3ZhbGlkYXRlVG91Y2godG91Y2gsIHsgaWRlbnRpZmllcjogMSwgdGFyZ2V0OiBkb2N1 bWVudC5ib2R5LCBjbGllbnRYOiAxLjUsIGNsaWVudFk6IDIuNSwgc2NyZWVuWDogMy41LCBzY3Jl ZW5ZOiA0LjUsIHBhZ2VYOiA1LjUsIHBhZ2VZOiA2LjUsIGZvcmNlOiA3LjUsIGNsaWVudFg6IDgu NSwgY2xpZW50WTogOS41IH0pOwogPC9zY3JpcHQ+CiA8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVz b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CiA8L2JvZHk+Cg==