162756 2016-09-29 14:54:32 -0700 Fix syntax violation handling in IPv4 address handling 2016-09-29 15:04:41 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1234991 0 achristensen 2016-09-29 14:54:32 -0700 Fix syntax violation handling in IPv4 address handling 1234992 1 290248 achristensen 2016-09-29 14:55:41 -0700 Created attachment 290248 Patch 1234995 2 290248 thorton 2016-09-29 15:01:05 -0700 Comment on attachment 290248 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290248&action=review > Source/WebCore/ChangeLog:3 > + Fix syntax violation handling in IPv4 address handling handling handling > Source/WebCore/ChangeLog:14 > + * platform/URLParser.h: What is happening? Where is the changelog? 1235001 3 achristensen 2016-09-29 15:04:41 -0700 http://trac.webkit.org/changeset/206617 290248 2016-09-29 14:55:41 -0700 2016-09-29 15:01:05 -0700 Patch bug-162756-20160929145239.patch text/plain 5179 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjYxNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA5LTI5ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHN5bnRh eCB2aW9sYXRpb24gaGFuZGxpbmcgaW4gSVB2NCBhZGRyZXNzIGhhbmRsaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI3NTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGEgbmV3IEFQ SSB0ZXN0IGFuZCBleGlzdGluZyBBUEkgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9VUkxQ YXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VVJMUGFyc2VyOjpVUkxQYXJzZXIpOgorICAg ICAgICAoV2ViQ29yZTo6VVJMUGFyc2VyOjpwYXJzZUlQdjROdW1iZXIpOgorICAgICAgICAoV2Vi Q29yZTo6VVJMUGFyc2VyOjpwYXJzZUlQdjRIb3N0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9VUkxQ YXJzZXIuaDoKKwogMjAxNi0wOS0yOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVSTFBhcnNlciBzaG91bGQgY29ycmVjdGx5IHBhcnNlIHBv cnRzIHdpdGggbGVhZGluZyAwJ3MKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTFBh cnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFyc2Vy LmNwcAkocmV2aXNpb24gMjA2NjE1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFy c2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjAyNyw3ICsyMDI3LDcgQEAgdm9pZCBVUkxQYXJz ZXI6OnNlcmlhbGl6ZUlQdjYoVVJMUGFyc2VyOgogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBDaGFy YWN0ZXJUeXBlPgotT3B0aW9uYWw8dWludDMyX3Q+IFVSTFBhcnNlcjo6cGFyc2VJUHY0TnVtYmVy KENvZGVQb2ludEl0ZXJhdG9yPENoYXJhY3RlclR5cGU+JiBpdGVyYXRvciwgY29uc3QgQ29kZVBv aW50SXRlcmF0b3I8Q2hhcmFjdGVyVHlwZT4mIGl0ZXJhdG9yRm9yU3ludGF4VmlvbGF0aW9uUG9z aXRpb24pCitPcHRpb25hbDx1aW50MzJfdD4gVVJMUGFyc2VyOjpwYXJzZUlQdjROdW1iZXIoQ29k ZVBvaW50SXRlcmF0b3I8Q2hhcmFjdGVyVHlwZT4mIGl0ZXJhdG9yLCBib29sJiBkaWRTZWVTeW50 YXhWaW9sYXRpb24pCiB7CiAgICAgZW51bSBjbGFzcyBTdGF0ZSA6IHVpbnQ4X3QgewogICAgICAg ICBVbmtub3duQmFzZSwKQEAgLTIwNDAsNyArMjA0MCw2IEBAIE9wdGlvbmFsPHVpbnQzMl90PiBV UkxQYXJzZXI6OnBhcnNlSVB2NE4KICAgICBDaGVja2VkPHVpbnQzMl90LCBSZWNvcmRPdmVyZmxv dz4gdmFsdWUgPSAwOwogICAgIGlmICghaXRlcmF0b3IuYXRFbmQoKSAmJiAqaXRlcmF0b3IgPT0g Jy4nKQogICAgICAgICByZXR1cm4gTnVsbG9wdDsKLSAgICBib29sIGRpZFNlZVN5bnRheFZpb2xh dGlvbiA9IGZhbHNlOwogICAgIHdoaWxlICghaXRlcmF0b3IuYXRFbmQoKSkgewogICAgICAgICBp ZiAoKml0ZXJhdG9yID09ICcuJykgewogICAgICAgICAgICAgQVNTRVJUKCF2YWx1ZS5oYXNPdmVy Zmxvd2VkKCkpOwpAQCAtMjA5NSw4ICsyMDk0LDYgQEAgT3B0aW9uYWw8dWludDMyX3Q+IFVSTFBh cnNlcjo6cGFyc2VJUHY0TgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICB9Ci0g ICAgaWYgKGRpZFNlZVN5bnRheFZpb2xhdGlvbikKLSAgICAgICAgc3ludGF4VmlvbGF0aW9uKGl0 ZXJhdG9yRm9yU3ludGF4VmlvbGF0aW9uUG9zaXRpb24pOwogICAgIEFTU0VSVCghdmFsdWUuaGFz T3ZlcmZsb3dlZCgpKTsKICAgICByZXR1cm4gdmFsdWUudW5zYWZlR2V0KCk7CiB9CkBAIC0yMTE1 LDEwICsyMTEyLDExIEBAIE9wdGlvbmFsPFVSTFBhcnNlcjo6SVB2NEFkZHJlc3M+IFVSTFBhcnMK IAogICAgIFZlY3Rvcjx1aW50MzJfdCwgND4gaXRlbXM7CiAgICAgaXRlbXMucmVzZXJ2ZUluaXRp YWxDYXBhY2l0eSg0KTsKKyAgICBib29sIGRpZFNlZVN5bnRheFZpb2xhdGlvbiA9IGZhbHNlOwog ICAgIHdoaWxlICghaXRlcmF0b3IuYXRFbmQoKSkgewogICAgICAgICBpZiAoaXRlbXMuc2l6ZSgp ID49IDQpCiAgICAgICAgICAgICByZXR1cm4gTnVsbG9wdDsKLSAgICAgICAgaWYgKGF1dG8gaXRl bSA9IHBhcnNlSVB2NE51bWJlcihpdGVyYXRvciwgaG9zdEJlZ2luKSkKKyAgICAgICAgaWYgKGF1 dG8gaXRlbSA9IHBhcnNlSVB2NE51bWJlcihpdGVyYXRvciwgZGlkU2VlU3ludGF4VmlvbGF0aW9u KSkKICAgICAgICAgICAgIGl0ZW1zLmFwcGVuZChpdGVtLnZhbHVlKCkpOwogICAgICAgICBlbHNl CiAgICAgICAgICAgICByZXR1cm4gTnVsbG9wdDsKQEAgLTIxNDEsNiArMjEzOSw5IEBAIE9wdGlv bmFsPFVSTFBhcnNlcjo6SVB2NEFkZHJlc3M+IFVSTFBhcnMKICAgICB9CiAgICAgaWYgKGl0ZW1z W2l0ZW1zLnNpemUoKSAtIDFdID49IHBvdzI1Nig1IC0gaXRlbXMuc2l6ZSgpKSkKICAgICAgICAg cmV0dXJuIE51bGxvcHQ7CisKKyAgICBpZiAoZGlkU2VlU3ludGF4VmlvbGF0aW9uKQorICAgICAg ICBzeW50YXhWaW9sYXRpb24oaG9zdEJlZ2luKTsKICAgICBmb3IgKGF1dG8gaXRlbSA6IGl0ZW1z KSB7CiAgICAgICAgIGlmIChpdGVtID4gMjU1KQogICAgICAgICAgICAgc3ludGF4VmlvbGF0aW9u KGhvc3RCZWdpbik7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkxQYXJzZXIuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkxQYXJzZXIuaAkocmV2aXNp b24gMjA2NTkyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmgJKHdvcmtp bmcgY29weSkKQEAgLTk5LDcgKzk5LDcgQEAgcHJpdmF0ZToKICAgICB1c2luZyBJUHY0QWRkcmVz cyA9IHVpbnQzMl90OwogICAgIHZvaWQgc2VyaWFsaXplSVB2NChJUHY0QWRkcmVzcyk7CiAgICAg dGVtcGxhdGU8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4gT3B0aW9uYWw8SVB2NEFkZHJlc3M+IHBh cnNlSVB2NEhvc3QoQ29kZVBvaW50SXRlcmF0b3I8Q2hhcmFjdGVyVHlwZT4pOwotICAgIHRlbXBs YXRlPHR5cGVuYW1lIENoYXJhY3RlclR5cGU+IE9wdGlvbmFsPHVpbnQzMl90PiBwYXJzZUlQdjRO dW1iZXIoQ29kZVBvaW50SXRlcmF0b3I8Q2hhcmFjdGVyVHlwZT4mLCBjb25zdCBDb2RlUG9pbnRJ dGVyYXRvcjxDaGFyYWN0ZXJUeXBlPiYgaXRlcmF0b3JGb3JTeW50YXhWaW9sYXRpb25Qb3NpdGlv bik7CisgICAgdGVtcGxhdGU8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4gT3B0aW9uYWw8dWludDMy X3Q+IHBhcnNlSVB2NE51bWJlcihDb2RlUG9pbnRJdGVyYXRvcjxDaGFyYWN0ZXJUeXBlPiYsIGJv b2wmIHN5bnRheFZpb2xhdGlvbik7CiAgICAgdXNpbmcgSVB2NkFkZHJlc3MgPSBzdGQ6OmFycmF5 PHVpbnQxNl90LCA4PjsKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBDaGFyYWN0ZXJUeXBlPiBPcHRp b25hbDxJUHY2QWRkcmVzcz4gcGFyc2VJUHY2SG9zdChDb2RlUG9pbnRJdGVyYXRvcjxDaGFyYWN0 ZXJUeXBlPik7CiAgICAgdm9pZCBzZXJpYWxpemVJUHY2UGllY2UodWludDE2X3QgcGllY2UpOwpJ bmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2 aXNpb24gMjA2NjE2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTYtMDktMjkgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Vi a2l0Lm9yZz4KKworICAgICAgICBGaXggc3ludGF4IHZpb2xhdGlvbiBoYW5kbGluZyBpbiBJUHY0 IGFkZHJlc3MgaGFuZGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2Mjc1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNlci5jcHA6Cisg ICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUX0YpOgorCiAyMDE2LTA5LTI5ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVVJMUGFyc2VyIHNo b3VsZCBjb3JyZWN0bHkgcGFyc2UgcG9ydHMgd2l0aCBsZWFkaW5nIDAncwpJbmRleDogVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNlci5jcHAJKHJldmlzaW9u IDIwNjYxNCkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9VUkxQYXJzZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NzMsNiArNzczLDcgQEAgVEVTVF9GKFVSTFBhcnNlclRl c3QsIFBhcnNlckRpZmZlcmVuY2VzKQogICAgIGNoZWNrUmVsYXRpdmVVUkxEaWZmZXJlbmNlcygi aHR0cDovL2Y6MDEwL2MiLCAiaHR0cDovL2V4YW1wbGUub3JnL2Zvby9iYXIiLAogICAgICAgICB7 Imh0dHAiLCAiIiwgIiIsICJmIiwgMTAsICIvYyIsICIiLCAiIiwgImh0dHA6Ly9mOjEwL2MifSwK ICAgICAgICAgeyJodHRwIiwgIiIsICIiLCAiZiIsIDEwLCAiL2MiLCAiIiwgIiIsICJodHRwOi8v ZjowMTAvYyJ9KTsKKyAgICBjaGVja1VSTCgiaHR0cDovLzAuMC4wLjB4MTAwLyIsIHsiaHR0cCIs ICIiLCAiIiwgIjAuMC4wLjB4MTAwIiwgMCwgIi8iLCAiIiwgIiIsICJodHRwOi8vMC4wLjAuMHgx MDAvIn0pOwogfQogCiBURVNUX0YoVVJMUGFyc2VyVGVzdCwgRGVmYXVsdFBvcnQpCg==