162752 2016-09-29 14:18:45 -0700 URLParser should correctly parse ports with leading 0's 2016-09-29 14:27:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1234970 0 achristensen 2016-09-29 14:18:45 -0700 URLParser should correctly parse ports with leading 0's 1234971 1 290243 achristensen 2016-09-29 14:19:32 -0700 Created attachment 290243 Patch 1234972 2 achristensen 2016-09-29 14:23:16 -0700 http://trac.webkit.org/changeset/206614 1234973 3 290243 ggaren 2016-09-29 14:23:38 -0700 Comment on attachment 290243 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290243&action=review > Source/WebCore/platform/URLParser.cpp:2365 > + bool seenDigit = false; > + bool seenMultipleDigits = false; size_t digitCount Then there's no need to branch. Computers like counting things. 1234977 4 achristensen 2016-09-29 14:27:48 -0700 http://trac.webkit.org/changeset/206615 290243 2016-09-29 14:19:32 -0700 2016-09-29 14:21:46 -0700 Patch bug-162752-20160929141630.patch text/plain 4484 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjYwOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTI5ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVVJMUGFyc2Vy IHNob3VsZCBjb3JyZWN0bHkgcGFyc2UgcG9ydHMgd2l0aCBsZWFkaW5nIDAncworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNzUyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBuZXcgQVBJ IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vVVJMUGFyc2VyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlVSTFBhcnNlcjo6cGFyc2VQb3J0KToKKwogMjAxNi0wOS0yOSAgQWxleCBDaHJpc3Rl bnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFVSTFBhcnNlcjogbWFr ZSBwYXJzaW5nIGludmFsaWQgSVB2NCBhZGRyZXNzZXMgbW9yZSByb2J1c3QgYW5kIGNvcnJlY3QK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTFBhcnNlci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcAkocmV2aXNpb24gMjA2NjA5 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjM2MSwxMiArMjM2MSwyMCBAQCBib29sIFVSTFBhcnNlcjo6cGFyc2VQb3J0KENvZGVQ b2ludEl0ZXJhCiAgICAgICAgIHN5bnRheFZpb2xhdGlvbihjb2xvbkl0ZXJhdG9yKTsKICAgICAg ICAgcmV0dXJuIHRydWU7CiAgICAgfQorICAgIGJvb2wgc2VlbkRpZ2l0ID0gZmFsc2U7CisgICAg Ym9vbCBzZWVuTXVsdGlwbGVEaWdpdHMgPSBmYWxzZTsKKyAgICBib29sIGxlYWRpbmdaZXJvcyA9 IGZhbHNlOwogICAgIGZvciAoOyAhaXRlcmF0b3IuYXRFbmQoKTsgKytpdGVyYXRvcikgewogICAg ICAgICBpZiAoVU5MSUtFTFkoaXNUYWJPck5ld2xpbmUoKml0ZXJhdG9yKSkpIHsKICAgICAgICAg ICAgIHN5bnRheFZpb2xhdGlvbihjb2xvbkl0ZXJhdG9yKTsKICAgICAgICAgICAgIGNvbnRpbnVl OwogICAgICAgICB9CiAgICAgICAgIGlmIChpc0FTQ0lJRGlnaXQoKml0ZXJhdG9yKSkgeworICAg ICAgICAgICAgaWYgKCppdGVyYXRvciA9PSAnMCcgJiYgIXNlZW5EaWdpdCkKKyAgICAgICAgICAg ICAgICBsZWFkaW5nWmVyb3MgPSB0cnVlOworICAgICAgICAgICAgaWYgKHNlZW5EaWdpdCkKKyAg ICAgICAgICAgICAgICBzZWVuTXVsdGlwbGVEaWdpdHMgPSB0cnVlOworICAgICAgICAgICAgc2Vl bkRpZ2l0ID0gdHJ1ZTsKICAgICAgICAgICAgIHBvcnQgPSBwb3J0ICogMTAgKyAqaXRlcmF0b3Ig LSAnMCc7CiAgICAgICAgICAgICBpZiAocG9ydCA+IHN0ZDo6bnVtZXJpY19saW1pdHM8dWludDE2 X3Q+OjptYXgoKSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CkBAIC0yMzc0LDYgKzIz ODIsMTIgQEAgYm9vbCBVUkxQYXJzZXI6OnBhcnNlUG9ydChDb2RlUG9pbnRJdGVyYQogICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAorICAgIGlmIChwb3J0ICYmIGxlYWRpbmdaZXJv cykKKyAgICAgICAgc3ludGF4VmlvbGF0aW9uKGNvbG9uSXRlcmF0b3IpOworICAgIAorICAgIGlm ICghcG9ydCAmJiBzZWVuTXVsdGlwbGVEaWdpdHMpCisgICAgICAgIHN5bnRheFZpb2xhdGlvbihj b2xvbkl0ZXJhdG9yKTsKKwogICAgIGlmIChVTkxJS0VMWShpc0RlZmF1bHRQb3J0KHBhcnNlZERh dGFWaWV3KDAsIG1fdXJsLm1fc2NoZW1lRW5kKSwgcG9ydCkpKQogICAgICAgICBzeW50YXhWaW9s YXRpb24oY29sb25JdGVyYXRvcik7CiAgICAgZWxzZSB7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDY2MTMpCisrKyBUb29s cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNi0wOS0yOSAg QWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIFVS TFBhcnNlciBzaG91bGQgY29ycmVjdGx5IHBhcnNlIHBvcnRzIHdpdGggbGVhZGluZyAwJ3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Mjc1MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNlci5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJ OjpURVNUX0YpOgorCiAyMDE2LTA5LTI5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2Vu QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVVJMUGFyc2VyOiBtYWtlIHBhcnNpbmcgaW52YWxpZCBJ UHY0IGFkZHJlc3NlcyBtb3JlIHJvYnVzdCBhbmQgY29ycmVjdApJbmRleDogVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNlci5jcHAJKHJldmlzaW9uIDIwNjYw OSkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9VUkxQYXJzZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zOTYsNiArMzk2LDcgQEAgVEVTVF9GKFVSTFBhcnNlclRlc3QsIFBh cnNlUmVsYXRpdmUpCiAgICAgY2hlY2tSZWxhdGl2ZVVSTCgiOi8vOjAvIiwgImh0dHA6Ly93ZWJr aXQub3JnLyIsIHsiaHR0cCIsICIiLCAiIiwgIndlYmtpdC5vcmciLCAwLCAiLzovLzowLyIsICIi LCAiIiwgImh0dHA6Ly93ZWJraXQub3JnLzovLzowLyJ9KTsKICAgICBjaGVja1JlbGF0aXZlVVJM KFN0cmluZygpLCAiaHR0cDovL3dlYmtpdC5vcmcvIiwgeyJodHRwIiwgIiIsICIiLCAid2Via2l0 Lm9yZyIsIDAsICIvIiwgIiIsICIiLCAiaHR0cDovL3dlYmtpdC5vcmcvIn0pOwogICAgIGNoZWNr UmVsYXRpdmVVUkwoImh0dHBzOi8vQHRlc3RAdGVzdEBleGFtcGxlOjgwMFxccGF0aEBlbmQiLCAi aHR0cDovL2RvZXNub3RtYXR0ZXIvIiwgeyIiLCAiIiwgIiIsICIiLCAwLCAiIiwgIiIsICIiLCAi aHR0cHM6Ly9AdGVzdEB0ZXN0QGV4YW1wbGU6ODAwXFxwYXRoQGVuZCJ9KTsKKyAgICBjaGVja1Jl bGF0aXZlVVJMKCJodHRwOi8vZjowL2MiLCAiaHR0cDovL2V4YW1wbGUub3JnL2Zvby9iYXIiLCB7 Imh0dHAiLCAiIiwgIiIsICJmIiwgMCwgIi9jIiwgIiIsICIiLCAiaHR0cDovL2Y6MC9jIn0pOwog CiAgICAgLy8gVGhlIGNoZWNraW5nIG9mIHNsYXNoZXMgaW4gU3BlY2lhbEF1dGhvcml0eVNsYXNo ZXMgbmVlZGVkIHRvIGdldCB0aGlzIHRvIHBhc3MgY29udHJhZGljdHMgd2hhdCBpcyBpbiB0aGUg c3BlYywKICAgICAvLyBidXQgaXQgaXMgaW5jbHVkZWQgaW4gdGhlIHdlYiBwbGF0Zm9ybSB0ZXN0 cy4KQEAgLTc2Niw2ICs3NjcsMTIgQEAgVEVTVF9GKFVSTFBhcnNlclRlc3QsIFBhcnNlckRpZmZl cmVuY2VzKQogICAgIGNoZWNrVVJMRGlmZmVyZW5jZXMoImh0dHA6Ly8xMjcuMC4xLn4iLAogICAg ICAgICB7Imh0dHAiLCAiIiwgIiIsICIxMjcuMC4xLn4iLCAwLCAiLyIsICIiLCAiIiwgImh0dHA6 Ly8xMjcuMC4xLn4vIn0sCiAgICAgICAgIHsiIiwgIiIsICIiLCAiIiwgMCwgIiIsICIiLCAiIiwg Imh0dHA6Ly8xMjcuMC4xLn4ifSk7CisgICAgY2hlY2tSZWxhdGl2ZVVSTERpZmZlcmVuY2VzKCJo dHRwOi8vZjowMDAvYyIsICJodHRwOi8vZXhhbXBsZS5vcmcvZm9vL2JhciIsCisgICAgICAgIHsi aHR0cCIsICIiLCAiIiwgImYiLCAwLCAiL2MiLCAiIiwgIiIsICJodHRwOi8vZjowL2MifSwKKyAg ICAgICAgeyJodHRwIiwgIiIsICIiLCAiZiIsIDAsICIvYyIsICIiLCAiIiwgImh0dHA6Ly9mOjAw MC9jIn0pOworICAgIGNoZWNrUmVsYXRpdmVVUkxEaWZmZXJlbmNlcygiaHR0cDovL2Y6MDEwL2Mi LCAiaHR0cDovL2V4YW1wbGUub3JnL2Zvby9iYXIiLAorICAgICAgICB7Imh0dHAiLCAiIiwgIiIs ICJmIiwgMTAsICIvYyIsICIiLCAiIiwgImh0dHA6Ly9mOjEwL2MifSwKKyAgICAgICAgeyJodHRw IiwgIiIsICIiLCAiZiIsIDEwLCAiL2MiLCAiIiwgIiIsICJodHRwOi8vZjowMTAvYyJ9KTsKIH0K IAogVEVTVF9GKFVSTFBhcnNlclRlc3QsIERlZmF1bHRQb3J0KQo=