162723 2016-09-29 04:21:35 -0700 [SOUP] Remove WebCoreSynchronousLoader from ResourceHandleSoup 2016-09-29 08:31:23 -0700 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned achristensen berto bugs-noreply commit-queue danw gustavo mcatanzaro mrobinson oldest_to_newest 1234774 0 cgarcia 2016-09-29 04:21:35 -0700 Since all soup based ports switched to NetworkProcess this is dead code. 1234775 1 290196 cgarcia 2016-09-29 04:24:01 -0700 Created attachment 290196 Patch 1234791 2 290196 svillar 2016-09-29 07:01:12 -0700 Comment on attachment 290196 Patch \o/ awesome cleanup 1234803 3 cgarcia 2016-09-29 08:31:23 -0700 Committed r206582: <http://trac.webkit.org/changeset/206582> 290196 2016-09-29 04:24:01 -0700 2016-09-29 07:01:12 -0700 Patch wcore-soup-sync.diff text/plain 7500 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZGM3Y2YwLi5hN2JjOGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTYtMDktMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtTT1VQXSBSZW1vdmUgV2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyIGZyb20g UmVzb3VyY2VIYW5kbGVTb3VwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjI3MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTaW5jZSBhbGwgc291cCBiYXNlZCBwb3J0cyBzd2l0Y2hlZCB0byBOZXR3b3Jr UHJvY2VzcyB0aGlzIGlzIGRlYWQgY29kZS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsv c291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VI YW5kbGU6OnBsYXRmb3JtTG9hZFJlc291cmNlU3luY2hyb25vdXNseSk6CisKIDIwMTYtMDktMjgg IFJvbWFpbiBCZWxsZXNzb3J0ICA8cm9tYWluLmJlbGxlc3NvcnRAY3JmLmNhbm9uLmZyPgogCiAg ICAgICAgIFtTdHJlYW1zIEFQSV0gQWxpZ24gY2FuY2VsUmVhZGFibGVTdHJlYW0oKSB3aXRoIHNw ZWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNv dXJjZUhhbmRsZVNvdXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3Vw L1Jlc291cmNlSGFuZGxlU291cC5jcHAKaW5kZXggZTE5MDUyOC4uNTdhMTAxZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291 cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNl SGFuZGxlU291cC5jcHAKQEAgLTcyLDEzMyArNzIsOCBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKLXN0YXRpYyBib29sIGxvYWRpbmdTeW5jaHJvbm91c1JlcXVlc3QgPSBmYWxzZTsKIHN0YXRp YyBjb25zdCBzaXplX3QgZ0RlZmF1bHRSZWFkQnVmZmVyU2l6ZSA9IDgxOTI7CiAKLWNsYXNzIFdl YkNvcmVTeW5jaHJvbm91c0xvYWRlciBmaW5hbCA6IHB1YmxpYyBSZXNvdXJjZUhhbmRsZUNsaWVu dCB7Ci0gICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoV2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyKTsK LXB1YmxpYzoKLQotICAgIFdlYkNvcmVTeW5jaHJvbm91c0xvYWRlcihSZXNvdXJjZUVycm9yJiBl cnJvciwgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UsIFNvdXBTZXNzaW9uKiBzZXNzaW9uLCBW ZWN0b3I8Y2hhcj4mIGRhdGEsIFN0b3JlZENyZWRlbnRpYWxzIHN0b3JlZENyZWRlbnRpYWxzKQot ICAgICAgICA6IG1fZXJyb3IoZXJyb3IpCi0gICAgICAgICwgbV9yZXNwb25zZShyZXNwb25zZSkK LSNpZiAhU09VUF9DSEVDS19WRVJTSU9OKDIsIDQ5LCA5MSkKLSAgICAgICAgLCBtX3Nlc3Npb24o c2Vzc2lvbikKLSNlbmRpZgotICAgICAgICAsIG1fZGF0YShkYXRhKQotICAgICAgICAsIG1fZmlu aXNoZWQoZmFsc2UpCi0gICAgICAgICwgbV9zdG9yZWRDcmVkZW50aWFscyhzdG9yZWRDcmVkZW50 aWFscykKLSAgICB7Ci0gICAgICAgIC8vIFdlIGRvbid0IHdhbnQgYW55IHRpbWVycyB0byBmaXJl IHdoaWxlIHdlIGFyZSBkb2luZyBvdXIgc3luY2hyb25vdXMgbG9hZAotICAgICAgICAvLyBzbyB3 ZSByZXBsYWNlIHRoZSB0aHJlYWQgZGVmYXVsdCBtYWluIGNvbnRleHQuIFRoZSBtYWluIGxvb3Ag aXRlcmF0aW9ucwotICAgICAgICAvLyB3aWxsIG9ubHkgcHJvY2VzcyBHU291cmNlcyBhc3NvY2lh dGVkIHdpdGggdGhpcyBpbm5lciBjb250ZXh0LgotICAgICAgICBsb2FkaW5nU3luY2hyb25vdXNS ZXF1ZXN0ID0gdHJ1ZTsKLSAgICAgICAgR1JlZlB0cjxHTWFpbkNvbnRleHQ+IGlubmVyTWFpbkNv bnRleHQgPSBhZG9wdEdSZWYoZ19tYWluX2NvbnRleHRfbmV3KCkpOwotICAgICAgICBnX21haW5f Y29udGV4dF9wdXNoX3RocmVhZF9kZWZhdWx0KGlubmVyTWFpbkNvbnRleHQuZ2V0KCkpOwotICAg ICAgICBtX21haW5Mb29wID0gYWRvcHRHUmVmKGdfbWFpbl9sb29wX25ldyhpbm5lck1haW5Db250 ZXh0LmdldCgpLCBmYWxzZSkpOwotCi0jaWYgIVNPVVBfQ0hFQ0tfVkVSU0lPTigyLCA0OSwgOTEp Ci0gICAgICAgIGFkanVzdE1heENvbm5lY3Rpb25zKDEpOwotI2Vsc2UKLSAgICAgICAgVU5VU0VE X1BBUkFNKHNlc3Npb24pOwotI2VuZGlmCi0gICAgfQotCi0gICAgfldlYkNvcmVTeW5jaHJvbm91 c0xvYWRlcigpCi0gICAgewotI2lmICFTT1VQX0NIRUNLX1ZFUlNJT04oMiwgNDksIDkxKQotICAg ICAgICBhZGp1c3RNYXhDb25uZWN0aW9ucygtMSk7Ci0jZW5kaWYKLQotICAgICAgICBHTWFpbkNv bnRleHQqIGNvbnRleHQgPSBnX21haW5fY29udGV4dF9nZXRfdGhyZWFkX2RlZmF1bHQoKTsKLSAg ICAgICAgd2hpbGUgKGdfbWFpbl9jb250ZXh0X3BlbmRpbmcoY29udGV4dCkpCi0gICAgICAgICAg ICBnX21haW5fY29udGV4dF9pdGVyYXRpb24oY29udGV4dCwgRkFMU0UpOwotCi0gICAgICAgIGdf bWFpbl9jb250ZXh0X3BvcF90aHJlYWRfZGVmYXVsdChjb250ZXh0KTsKLSAgICAgICAgbG9hZGlu Z1N5bmNocm9ub3VzUmVxdWVzdCA9IGZhbHNlOwotICAgIH0KLQotI2lmICFTT1VQX0NIRUNLX1ZF UlNJT04oMiwgNDksIDkxKQotICAgIHZvaWQgYWRqdXN0TWF4Q29ubmVjdGlvbnMoaW50IGFkanVz dG1lbnQpCi0gICAgewotICAgICAgICBpbnQgbWF4Q29ubmVjdGlvbnMsIG1heENvbm5lY3Rpb25z UGVySG9zdDsKLSAgICAgICAgZ19vYmplY3RfZ2V0KG1fc2Vzc2lvbiwKLSAgICAgICAgICAgICAg ICAgICAgIFNPVVBfU0VTU0lPTl9NQVhfQ09OTlMsICZtYXhDb25uZWN0aW9ucywKLSAgICAgICAg ICAgICAgICAgICAgIFNPVVBfU0VTU0lPTl9NQVhfQ09OTlNfUEVSX0hPU1QsICZtYXhDb25uZWN0 aW9uc1Blckhvc3QsCi0gICAgICAgICAgICAgICAgICAgICBOVUxMKTsKLSAgICAgICAgbWF4Q29u bmVjdGlvbnMgKz0gYWRqdXN0bWVudDsKLSAgICAgICAgbWF4Q29ubmVjdGlvbnNQZXJIb3N0ICs9 IGFkanVzdG1lbnQ7Ci0gICAgICAgIGdfb2JqZWN0X3NldChtX3Nlc3Npb24sCi0gICAgICAgICAg ICAgICAgICAgICBTT1VQX1NFU1NJT05fTUFYX0NPTk5TLCBtYXhDb25uZWN0aW9ucywKLSAgICAg ICAgICAgICAgICAgICAgIFNPVVBfU0VTU0lPTl9NQVhfQ09OTlNfUEVSX0hPU1QsIG1heENvbm5l Y3Rpb25zUGVySG9zdCwKLSAgICAgICAgICAgICAgICAgICAgIE5VTEwpOwotCi0gICAgfQotI2Vu ZGlmIC8vIFNPVVBfQ0hFQ0tfVkVSU0lPTigyLCA0OSwgOTEpCi0KLSAgICB2b2lkIGRpZFJlY2Vp dmVSZXNwb25zZShSZXNvdXJjZUhhbmRsZSosIFJlc291cmNlUmVzcG9uc2UmJiByZXNwb25zZSkg b3ZlcnJpZGUKLSAgICB7Ci0gICAgICAgIG1fcmVzcG9uc2UgPSByZXNwb25zZTsKLSAgICB9Ci0K LSAgICB2b2lkIGRpZFJlY2VpdmVEYXRhKFJlc291cmNlSGFuZGxlKiwgY29uc3QgY2hhciogLyog ZGF0YSAqLywgdW5zaWduZWQgLyogbGVuZ3RoICovLCBpbnQpIG92ZXJyaWRlCi0gICAgewotICAg ICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICB9Ci0KLSAgICB2b2lkIGRpZFJlY2VpdmVC dWZmZXIoUmVzb3VyY2VIYW5kbGUqLCBSZWY8U2hhcmVkQnVmZmVyPiYmIGJ1ZmZlciwgaW50IC8q IGVuY29kZWRMZW5ndGggKi8pIG92ZXJyaWRlCi0gICAgewotICAgICAgICAvLyBUaGlzIHBhdHRl cm4gaXMgc3VnZ2VzdGVkIGJ5IFNoYXJlZEJ1ZmZlci5oLgotICAgICAgICBjb25zdCBjaGFyKiBz ZWdtZW50OwotICAgICAgICB1bnNpZ25lZCBwb3NpdGlvbiA9IDA7Ci0gICAgICAgIHdoaWxlICh1 bnNpZ25lZCBsZW5ndGggPSBidWZmZXItPmdldFNvbWVEYXRhKHNlZ21lbnQsIHBvc2l0aW9uKSkg ewotICAgICAgICAgICAgbV9kYXRhLmFwcGVuZChzZWdtZW50LCBsZW5ndGgpOwotICAgICAgICAg ICAgcG9zaXRpb24gKz0gbGVuZ3RoOwotICAgICAgICB9Ci0gICAgfQotCi0gICAgdm9pZCBkaWRG aW5pc2hMb2FkaW5nKFJlc291cmNlSGFuZGxlKiwgZG91YmxlKSBvdmVycmlkZQotICAgIHsKLSAg ICAgICAgaWYgKGdfbWFpbl9sb29wX2lzX3J1bm5pbmcobV9tYWluTG9vcC5nZXQoKSkpCi0gICAg ICAgICAgICBnX21haW5fbG9vcF9xdWl0KG1fbWFpbkxvb3AuZ2V0KCkpOwotICAgICAgICBtX2Zp bmlzaGVkID0gdHJ1ZTsKLSAgICB9Ci0KLSAgICB2b2lkIGRpZEZhaWwoUmVzb3VyY2VIYW5kbGUq IGhhbmRsZSwgY29uc3QgUmVzb3VyY2VFcnJvciYgZXJyb3IpIG92ZXJyaWRlCi0gICAgewotICAg ICAgICBtX2Vycm9yID0gZXJyb3I7Ci0gICAgICAgIGRpZEZpbmlzaExvYWRpbmcoaGFuZGxlLCAw KTsKLSAgICB9Ci0KLSAgICB2b2lkIGRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZShS ZXNvdXJjZUhhbmRsZSosIGNvbnN0IEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJiBjaGFsbGVuZ2Up IG92ZXJyaWRlCi0gICAgewotICAgICAgICAvLyBXZSBkbyBub3QgaGFuZGxlIGF1dGhlbnRpY2F0 aW9uIGZvciBzeW5jaHJvbm91cyBYTUxIdHRwUmVxdWVzdHMuCi0gICAgICAgIGNoYWxsZW5nZS5h dXRoZW50aWNhdGlvbkNsaWVudCgpLT5yZWNlaXZlZFJlcXVlc3RUb0NvbnRpbnVlV2l0aG91dENy ZWRlbnRpYWwoY2hhbGxlbmdlKTsKLSAgICB9Ci0KLSAgICBib29sIHNob3VsZFVzZUNyZWRlbnRp YWxTdG9yYWdlKFJlc291cmNlSGFuZGxlKikgb3ZlcnJpZGUKLSAgICB7Ci0gICAgICAgIHJldHVy biBtX3N0b3JlZENyZWRlbnRpYWxzID09IEFsbG93U3RvcmVkQ3JlZGVudGlhbHM7Ci0gICAgfQot Ci0gICAgdm9pZCBydW4oKQotICAgIHsKLSAgICAgICAgaWYgKCFtX2ZpbmlzaGVkKQotICAgICAg ICAgICAgZ19tYWluX2xvb3BfcnVuKG1fbWFpbkxvb3AuZ2V0KCkpOwotICAgIH0KLQotcHJpdmF0 ZToKLSAgICBSZXNvdXJjZUVycm9yJiBtX2Vycm9yOwotICAgIFJlc291cmNlUmVzcG9uc2UmIG1f cmVzcG9uc2U7Ci0jaWYgIVNPVVBfQ0hFQ0tfVkVSU0lPTigyLCA0OSwgOTEpCi0gICAgU291cFNl c3Npb24qIG1fc2Vzc2lvbjsKLSNlbmRpZgotICAgIFZlY3RvcjxjaGFyPiYgbV9kYXRhOwotICAg IGJvb2wgbV9maW5pc2hlZDsKLSAgICBHUmVmUHRyPEdNYWluTG9vcD4gbV9tYWluTG9vcDsKLSAg ICBTdG9yZWRDcmVkZW50aWFscyBtX3N0b3JlZENyZWRlbnRpYWxzOwotfTsKLQogY2xhc3MgSG9z dFRMU0NlcnRpZmljYXRlU2V0IHsKIHB1YmxpYzoKICAgICB2b2lkIGFkZChHVGxzQ2VydGlmaWNh dGUqIGNlcnRpZmljYXRlKQpAQCAtOTUyLDEyICs4MjcsNiBAQCBzdGF0aWMgYm9vbCBjcmVhdGVT b3VwTWVzc2FnZUZvckhhbmRsZUFuZFJlcXVlc3QoUmVzb3VyY2VIYW5kbGUqIGhhbmRsZSwgY29u c3QgUgogICAgIGdfc2lnbmFsX2Nvbm5lY3QoZC0+bV9zb3VwTWVzc2FnZS5nZXQoKSwgIndyb3Rl LWJvZHktZGF0YSIsIEdfQ0FMTEJBQ0sod3JvdGVCb2R5RGF0YUNhbGxiYWNrKSwgaGFuZGxlKTsK IAogICAgIHVuc2lnbmVkIGZsYWdzID0gU09VUF9NRVNTQUdFX05PX1JFRElSRUNUOwotI2lmIFNP VVBfQ0hFQ0tfVkVSU0lPTigyLCA0OSwgOTEpCi0gICAgLy8gSWdub3JlIHRoZSBjb25uZWN0aW9u IGxpbWl0cyBpbiBzeW5jaHJvbm91cyBsb2FkcyB0byBhdm9pZCBmcmVlemluZyB0aGUgbmV0d29y a2luZyBwcm9jZXNzLgotICAgIC8vIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQxNTA4LgotICAgIGlmIChsb2FkaW5nU3luY2hyb25vdXNSZXF1ZXN0KQotICAg ICAgICBmbGFncyB8PSBTT1VQX01FU1NBR0VfSUdOT1JFX0NPTk5FQ1RJT05fTElNSVRTOwotI2Vu ZGlmCiAgICAgc291cF9tZXNzYWdlX3NldF9mbGFncyhkLT5tX3NvdXBNZXNzYWdlLmdldCgpLCBz dGF0aWNfY2FzdDxTb3VwTWVzc2FnZUZsYWdzPihzb3VwX21lc3NhZ2VfZ2V0X2ZsYWdzKGQtPm1f c291cE1lc3NhZ2UuZ2V0KCkpIHwgZmxhZ3MpKTsKIAogI2lmIEVOQUJMRShXRUJfVElNSU5HKQpA QCAtMTI4OCwyMiArMTE1Nyw5IEBAIHZvaWQgUmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0RGVm ZXJzTG9hZGluZyhib29sIGRlZmVyc0xvYWRpbmcpCiAgICAgfQogfQogCi12b2lkIFJlc291cmNl SGFuZGxlOjpwbGF0Zm9ybUxvYWRSZXNvdXJjZVN5bmNocm9ub3VzbHkoTmV0d29ya2luZ0NvbnRl eHQqIGNvbnRleHQsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgU3RvcmVkQ3JlZGVu dGlhbHMgc3RvcmVkQ3JlZGVudGlhbHMsIFJlc291cmNlRXJyb3ImIGVycm9yLCBSZXNvdXJjZVJl c3BvbnNlJiByZXNwb25zZSwgVmVjdG9yPGNoYXI+JiBkYXRhKQordm9pZCBSZXNvdXJjZUhhbmRs ZTo6cGxhdGZvcm1Mb2FkUmVzb3VyY2VTeW5jaHJvbm91c2x5KE5ldHdvcmtpbmdDb250ZXh0Kiwg Y29uc3QgUmVzb3VyY2VSZXF1ZXN0JiwgU3RvcmVkQ3JlZGVudGlhbHMsIFJlc291cmNlRXJyb3Im LCBSZXNvdXJjZVJlc3BvbnNlJiwgVmVjdG9yPGNoYXI+JikKIHsKLSAgICBBU1NFUlQoIWxvYWRp bmdTeW5jaHJvbm91c1JlcXVlc3QpOwotICAgIGlmIChsb2FkaW5nU3luY2hyb25vdXNSZXF1ZXN0 KSAvLyBJbiBwcmFjdGljZSB0aGlzIGNhbm5vdCBoYXBwZW4sIGJ1dCBpZiBmb3Igc29tZSByZWFz b24gaXQgZG9lcywKLSAgICAgICAgcmV0dXJuOyAgICAgICAgICAgICAgICAgICAgLy8gd2Ugd2Fu dCB0byBhdm9pZCBhY2NpZGVudGFsbHkgZ29pbmcgaW50byBhbiBpbmZpbml0ZSBsb29wIG9mIHJl cXVlc3RzLgotCi0gICAgV2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyIHN5bmNMb2FkZXIoZXJyb3Is IHJlc3BvbnNlLCBzZXNzaW9uRnJvbUNvbnRleHQoY29udGV4dCksIGRhdGEsIHN0b3JlZENyZWRl bnRpYWxzKTsKLSAgICBSZWZQdHI8UmVzb3VyY2VIYW5kbGU+IGhhbmRsZSA9IGNyZWF0ZShjb250 ZXh0LCByZXF1ZXN0LCAmc3luY0xvYWRlciwgZmFsc2UgLypkZWZlcnNMb2FkaW5nKi8sIGZhbHNl IC8qc2hvdWxkQ29udGVudFNuaWZmKi8pOwotICAgIGlmICghaGFuZGxlKQotICAgICAgICByZXR1 cm47Ci0KLSAgICAvLyBJZiB0aGUgcmVxdWVzdCBoYXMgYWxyZWFkeSBmYWlsZWQsIGRvIG5vdCBy dW4gdGhlIG1haW4gbG9vcCwgb3IgZWxzZSB3ZSdsbCBibG9jayBpbmRlZmluaXRlbHkuCi0gICAg aWYgKGhhbmRsZS0+ZC0+bV9zY2hlZHVsZWRGYWlsdXJlVHlwZSAhPSBOb0ZhaWx1cmUpCi0gICAg ICAgIHJldHVybjsKLQotICAgIHN5bmNMb2FkZXIucnVuKCk7CisgICAgQVNTRVJUX05PVF9SRUFD SEVEKCk7CiB9CiAKIHN0YXRpYyB2b2lkIHJlYWRDYWxsYmFjayhHT2JqZWN0KiwgR0FzeW5jUmVz dWx0KiBhc3luY1Jlc3VsdCwgZ3BvaW50ZXIgZGF0YSkK