162720 2016-09-29 02:57:38 -0700 Arrow functions do not infer name from computed property but normal functions do 2016-09-29 13:36:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck joepeck saam oldest_to_newest 1234762 0 joepeck 2016-09-29 02:57:38 -0700 Summary: Arrow functions do not infer name from computed property but normal functions do Test: js> function funcName() { return "funcName" } ... js> ({"func": function(){}}).func.name "func" js> ({["func"]: function(){}}).func.name "func" js> ({[funcName()]: function(){}}).func.name "func" js> ({func: ()=>{}}).func.name "func" js> ({["func"]: ()=>{}}).func.name "" js> ({[funcName()]: ()=>{}}).func.name "" Why is this? And is this actually specced anywhere? Maybe this is runtime, since evaluating funcName() must happen at runtime. 1234896 1 290227 joepeck 2016-09-29 11:49:50 -0700 Created attachment 290227 [PATCH] Proposed Fix Waiting on the other change to land. 1234897 2 290227 saam 2016-09-29 11:55:15 -0700 Comment on attachment 290227 [PATCH] Proposed Fix r=me 1234944 3 joepeck 2016-09-29 13:36:24 -0700 <https://trac.webkit.org/changeset/206610> 290227 2016-09-29 11:49:50 -0700 2016-09-29 11:55:15 -0700 [PATCH] Proposed Fix yay.patch text/plain 3136 joepeck ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg NTViNWEwYy4uZDI1ZmMwYyAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxNi0wOS0yOSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIEFycm93IGZ1bmN0aW9ucyBkbyBu b3QgaW5mZXIgbmFtZSBmcm9tIGNvbXB1dGVkIHByb3BlcnR5IGJ1dCBub3JtYWwgZnVuY3Rpb25z IGRvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI3 MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0 cmVzcy9pbmZlcnJlZC1uYW1lcy5qczoKKworMjAxNi0wOS0yOSAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIHRlc3QyNjI6IGNsYXNzIGFuZCBmdW5jdGlv biBuYW1lcyBzaG91bGQgYmUgaW5mZXJyZWQgaW4gYXNzaWdubWVudAogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MjYyCiAKZGlmZiAtLWdpdCBhL0pT VGVzdHMvc3RyZXNzL2luZmVycmVkLW5hbWVzLmpzIGIvSlNUZXN0cy9zdHJlc3MvaW5mZXJyZWQt bmFtZXMuanMKaW5kZXggNmY3ZTNlMC4uYzY5ZjlhZSAxMDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJl c3MvaW5mZXJyZWQtbmFtZXMuanMKKysrIGIvSlNUZXN0cy9zdHJlc3MvaW5mZXJyZWQtbmFtZXMu anMKQEAgLTcwLDkgKzcwLDggQEAgYXNzZXJ0KCAoeypbZnVuY05hbWUoKV0oKXt9fSkuZnVuYy5u YW1lID09PSAiZnVuYyIgKTsKIAogYXNzZXJ0KCAoeyJmdW5jIjogKCk9Pnt9fSkuZnVuYy5uYW1l ID09PSAiZnVuYyIgKTsKIGFzc2VydCggKHtmdW5jOiAoKT0+e319KS5mdW5jLm5hbWUgPT09ICJm dW5jIiApOwotLy8gRklYTUU6IDxodHRwczovL3dlYmtpdC5vcmcvYi8xNjI3MjA+IEFycm93IGZ1 bmN0aW9ucyBkbyBub3QgaW5mZXIgbmFtZSBmcm9tIGNvbXB1dGVkIHByb3BlcnR5IGJ1dCBub3Jt YWwgZnVuY3Rpb25zIGRvCi0vLyBhc3NlcnQoICh7WyJmdW5jIl06ICgpPT57fX0pLmZ1bmMubmFt ZSA9PT0gImZ1bmMiICk7Ci0vLyBhc3NlcnQoICh7W2Z1bmNOYW1lKCldOiAoKT0+e319KS5mdW5j Lm5hbWUgPT09ICJmdW5jIiApOworYXNzZXJ0KCAoe1siZnVuYyJdOiAoKT0+e319KS5mdW5jLm5h bWUgPT09ICJmdW5jIiApOworYXNzZXJ0KCAoe1tmdW5jTmFtZSgpXTogKCk9Pnt9fSkuZnVuYy5u YW1lID09PSAiZnVuYyIgKTsKIAogYXNzZXJ0KCAoeyJrbGFzcyI6IGNsYXNze319KS5rbGFzcy5u YW1lID09PSAia2xhc3MiICk7CiBhc3NlcnQoICh7a2xhc3M6IGNsYXNze319KS5rbGFzcy5uYW1l ID09PSAia2xhc3MiICk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2OGZmMDMxLi5iY2Ez NWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxNi0wOS0y OSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIEFycm93 IGZ1bmN0aW9ucyBkbyBub3QgaW5mZXIgbmFtZSBmcm9tIGNvbXB1dGVkIHByb3BlcnR5IGJ1dCBu b3JtYWwgZnVuY3Rpb25zIGRvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjI3MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHA6CisgICAgICAg IChKU0M6OkJ5dGVjb2RlR2VuZXJhdG9yOjplbWl0U2V0RnVuY3Rpb25OYW1lSWZOZWVkZWQpOgor ICAgICAgICBTZXQgZnVuY3Rpb24gbmFtZSBvbiBhcnJvdyBmdW5jdGlvbnMgYXMgd2VsbC4KKwor MjAxNi0wOS0yOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAg ICAgIHRlc3QyNjI6IGNsYXNzIGFuZCBmdW5jdGlvbiBuYW1lcyBzaG91bGQgYmUgaW5mZXJyZWQg aW4gYXNzaWdubWVudAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ2MjYyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29t cGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAKaW5kZXggY2M3MTcyMy4uMzkxMTlkNCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVy YXRvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29k ZUdlbmVyYXRvci5jcHAKQEAgLTMwNDQsOCArMzA0NCw4IEBAIFJlZ2lzdGVySUQqIEJ5dGVjb2Rl R2VuZXJhdG9yOjplbWl0TmV3RnVuY3Rpb24oUmVnaXN0ZXJJRCogZHN0LCBGdW5jdGlvbk1ldGFk YXRhCiAKIHZvaWQgQnl0ZWNvZGVHZW5lcmF0b3I6OmVtaXRTZXRGdW5jdGlvbk5hbWVJZk5lZWRl ZChFeHByZXNzaW9uTm9kZSogdmFsdWVOb2RlLCBSZWdpc3RlcklEKiB2YWx1ZSwgUmVnaXN0ZXJJ RCogbmFtZSkKIHsKLSAgICBpZiAodmFsdWVOb2RlLT5pc0Z1bmNFeHByTm9kZSgpKSB7Ci0gICAg ICAgIEZ1bmN0aW9uTWV0YWRhdGFOb2RlKiBtZXRhZGF0YSA9IHN0YXRpY19jYXN0PEZ1bmNFeHBy Tm9kZSo+KHZhbHVlTm9kZSktPm1ldGFkYXRhKCk7CisgICAgaWYgKHZhbHVlTm9kZS0+aXNCYXNl RnVuY0V4cHJOb2RlKCkpIHsKKyAgICAgICAgRnVuY3Rpb25NZXRhZGF0YU5vZGUqIG1ldGFkYXRh ID0gc3RhdGljX2Nhc3Q8QmFzZUZ1bmNFeHByTm9kZSo+KHZhbHVlTm9kZSktPm1ldGFkYXRhKCk7 CiAgICAgICAgIGlmICghbWV0YWRhdGEtPmVjbWFOYW1lKCkuaXNOdWxsKCkpCiAgICAgICAgICAg ICByZXR1cm47CiAgICAgfSBlbHNlIGlmICh2YWx1ZU5vZGUtPmlzQ2xhc3NFeHByTm9kZSgpKSB7 Cg==