<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>162719</bug_id>
          
          <creation_ts>2016-09-29 01:02:48 -0700</creation_ts>
          <short_desc>[GTK] Upgrade HarfBuzz to version 1.3.3</short_desc>
          <delta_ts>2016-10-28 13:40:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>164022</dependson>
          <blocked>162671</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Frédéric Wang Nélar">fred.wang</reporter>
          <assigned_to name="Frédéric Wang Nélar">fred.wang</assigned_to>
          <cc>annulen</cc>
    
    <cc>behdad</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dr.khaled.hosny</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1234743</commentid>
    <comment_count>0</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2016-09-29 01:02:48 -0700</bug_when>
    <thetext>The next version of HarfBuzz will contain a new API to access data from the OpenType MATH table. When it is released, we should update Tools/gtk/jhbuild.modules to use that version, so that the MathML code can rely on that new API (bug 162671).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1238763</commentid>
    <comment_count>1</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2016-10-10 23:40:19 -0700</bug_when>
    <thetext>OpenType MATH support will be in version 1.3.3
https://github.com/behdad/harfbuzz/commit/d1c62370a0c2bdb365a1468dc8d782b9a7245946</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244799</commentid>
    <comment_count>2</comment_count>
      <attachid>292930</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2016-10-26 08:42:38 -0700</bug_when>
    <thetext>Created attachment 292930
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244827</commentid>
    <comment_count>3</comment_count>
      <attachid>292930</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-10-26 10:17:54 -0700</bug_when>
    <thetext>Comment on attachment 292930
Patch

OK if and only if you&apos;re ready to check the release bots when this lands, and update test expectations to get the failure rate to be the same as it was before this landed. Otherwise this will have to wait until we can get the release bot green, as I don&apos;t want to add extra layout test failures now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1245027</commentid>
    <comment_count>4</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-10-26 22:33:10 -0700</bug_when>
    <thetext>Now it&apos;s impossible to check the bots because of bug #164022, so please wait until the release bot is no longer exiting early before landing this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1245676</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-10-28 11:26:23 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Now it&apos;s impossible to check the bots because of bug #164022, so please wait
&gt; until the release bot is no longer exiting early before landing this.

This is fixed, you can go ahead if you want. Let me know if you have questions about how to do the gardening that will be required after this lands.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1245693</commentid>
    <comment_count>6</comment_count>
      <attachid>292930</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-10-28 12:01:15 -0700</bug_when>
    <thetext>Comment on attachment 292930
Patch

Clearing flags on attachment: 292930

Committed r208061: &lt;http://trac.webkit.org/changeset/208061&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1245694</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-10-28 12:01:19 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1245738</commentid>
    <comment_count>8</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-10-28 13:40:06 -0700</bug_when>
    <thetext>Seems it caused no or almost no new failures, yay!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>292930</attachid>
            <date>2016-10-26 08:42:38 -0700</date>
            <delta_ts>2016-10-28 12:01:15 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-162719-20161026173849.patch</filename>
            <type>text/plain</type>
            <size>1572</size>
            <attacher name="Frédéric Wang Nélar">fred.wang</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3ODk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTRiY2IyMDllMGZiNGRhZWZhMmYyYmFlNTc4NGZhN2My
ZmY3YzAxMS4uZDQ4MzRlYWNlZGJlMjgyZGU4NTA1MjI0M2Q3YmFhMmY0ZWJkOTYwZCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy
IEBACisyMDE2LTEwLTI2ICBGcmVkZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAg
ICAgICBbR1RLXSBVcGdyYWRlIEhhcmZCdXp6IHRvIHZlcnNpb24gMS4zLjMKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjcxOQorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZ3RrL2poYnVpbGQubW9kdWxl
czoKKwogMjAxNi0xMC0yNiAgRW5yaXF1ZSBPY2HDsWEgR29uesOhbGV6ICA8ZW9jYW5oYUBpZ2Fs
aWEuY29tPgogCiAgICAgICAgIFtjbWFrZV1bR1N0cmVhbWVyXVtNU0VdW0VNRV0gQnVpbGQgTVNF
IGFuZCBFTUUgY29kZSBhZnRlciByZWZhY3RvcmluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2po
YnVpbGQubW9kdWxlcyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggYTgzN2RkYTg4
ZDY1NDk5NzAwNzkxMDM5MWMzM2ViNDNiODdkNWJmYy4uZTRlZWYyYTRmNjk5MTEyODAyMTEzM2E3
ZTAzNjk5ZDAwNzliMTNiMiAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwor
KysgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCkBAIC0xMzEsMTIgKzEzMSwxMiBAQAogICAg
IDxkZXBlbmRlbmNpZXM+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImljdSIvPgogICAgIDwvZGVwZW5k
ZW5jaWVzPgotICAgIDxicmFuY2ggbW9kdWxlPSJzb2Z0d2FyZS9oYXJmYnV6ei9yZWxlYXNlL2hh
cmZidXp6LTAuOS4zNS50YXIuYnoyIgotICAgICAgICAgICAgdmVyc2lvbj0iMC45LjM1IgotICAg
ICAgICAgICAgY2hlY2tvdXRkaXI9ImhhcmZidXp6LTAuOS4zNSIKKyAgICA8YnJhbmNoIG1vZHVs
ZT0ic29mdHdhcmUvaGFyZmJ1enovcmVsZWFzZS9oYXJmYnV6ei0xLjMuMy50YXIuYnoyIgorICAg
ICAgICAgICAgdmVyc2lvbj0iMS4zLjMiCisgICAgICAgICAgICBjaGVja291dGRpcj0iaGFyZmJ1
enotMS4zLjMiCiAgICAgICAgICAgICByZXBvPSJmcmVlZGVza3RvcC5vcmciCi0gICAgICAgICAg
ICBoYXNoPSJzaGEyNTY6MGFhMWE4YWJhNmY1MDIzMjFjZjZmZWYzYzlkMmM3M2RkZTQ4Mzg5YzVl
ZDFkMzYxNWE3NjkxOTQ0YzJhMDZlZCIKLSAgICAgICAgICAgIG1kNXN1bT0iNTMxZWU4NjUwNjI2
ZWNkZGNkOTBiMmE0NjM3ZTMxZDQiPgorICAgICAgICAgICAgaGFzaD0ic2hhMjU2OjI2MjA5ODcx
MTVhNDEyMmI0NzMyMTYxMGRjY2JjYzE4ZjdmMTIxMTE1ZmQ3Yjg4ZGM4YTY5NWM4YjY2Y2IzYzki
CisgICAgICAgICAgICBtZDVzdW09Ijk3YWUxNWE3MmE5M2YxZjI3MzI0YTJiOGQ5YmQzYjFkIj4K
ICAgICA8L2JyYW5jaD4KICAgPC9hdXRvdG9vbHM+CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>