162681 2016-09-28 09:06:30 -0700 Mark NetworkLoad as final 2016-09-29 16:08:03 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates achristensen oldest_to_newest 1234400 0 dbates 2016-09-28 09:06:30 -0700 We should mark class NetworkLoad as final as we do not have any derived classes at the moment and it is unclear if it would make sense to subclass NetworkLoad. 1234401 1 290089 dbates 2016-09-28 09:08:54 -0700 Created attachment 290089 Patch 1235022 2 dbates 2016-09-29 16:08:03 -0700 Committed r206621: <http://trac.webkit.org/changeset/206621> 290089 2016-09-28 09:08:54 -0700 2016-09-28 12:09:59 -0700 Patch bug-162681-20160928090554.patch text/plain 4767 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWU3YTdiNTIxYzIwNmQy NzQ5NGY4OGQ0NTIzN2VkOTU0MTc3NjIyNy4uOTEzZWMzZmNjZjhiODI1MGI2N2NiZGIwM2IzOTgz Yjk4MTY3ZGZhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA5LTI4ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBNYXJrIE5ldHdvcmtMb2Fk IGFzIGZpbmFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjI2ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBNYXJrIGNsYXNzIE5ldHdvcmtMb2FkIGFzIGZpbmFsIGFzIHdlIGRvIG5vdCBoYXZlIGFueSBk ZXJpdmVkIGNsYXNzZXMgYXQgdGhlIG1vbWVudCBhbmQgaXQKKyAgICAgICAgaXMgdW5jbGVhciBp ZiBpdCB3b3VsZCBtYWtlIHNlbnNlIHRvIHN1YmNsYXNzIGl0LiBXZSBjYW4gYWx3YXlzIHVubWFy ayB0aGUgY2xhc3MgaWYgaXQgdHVybnMKKyAgICAgICAgb3V0IHRoYXQgaXQgbWFrZXMgc2Vuc2Ug dG8gc3ViY2xhc3MgaXQuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5o OgorCiAyMDE2LTA5LTI3ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAg ICAgICBOZXR3b3JrTG9hZCBhbmQgUGluZ0xvYWQgc2hvdWxkIHVzZSBwcml2YXRlIGluaGVyaXRh bmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9h ZC5oIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuaAppbmRleCBk MWViMTJmYTgyMWJjZGY4NjA5NzI4MTFkNjBlNGQ4ZjAxYzlmMDA3Li5iMDE2MDNmZTQ1MWMxMGMx M2ExYWY3YjM5NWZjOTEwZmQ0MDExZTAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL05ldHdvcmtMb2FkLmgKQEAgLTQwLDcgKzQwLDcgQEAKIAogbmFtZXNwYWNlIFdlYktpdCB7 CiAKLWNsYXNzIE5ldHdvcmtMb2FkIDogcHJpdmF0ZSBXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZUNs aWVudAorY2xhc3MgTmV0d29ya0xvYWQgZmluYWwgOiBwcml2YXRlIFdlYkNvcmU6OlJlc291cmNl SGFuZGxlQ2xpZW50CiAjaWYgVVNFKE5FVFdPUktfU0VTU0lPTikKICAgICAsIHByaXZhdGUgTmV0 d29ya0RhdGFUYXNrQ2xpZW50CiAjZW5kaWYKQEAgLTk5LDIwICs5OSwyMCBAQCBwcml2YXRlOgog ICAgIHZvaWQgc2hhcmVkV2lsbFNlbmRSZWRpcmVjdGVkUmVxdWVzdChXZWJDb3JlOjpSZXNvdXJj ZVJlcXVlc3QmJiwgV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZSYmKTsKIAogICAgIC8vIFJlc291 cmNlSGFuZGxlQ2xpZW50Ci0gICAgdm9pZCB3aWxsU2VuZFJlcXVlc3RBc3luYyhXZWJDb3JlOjpS ZXNvdXJjZUhhbmRsZSosIFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYmLCBXZWJDb3JlOjpSZXNv dXJjZVJlc3BvbnNlJiYgcmVkaXJlY3RSZXNwb25zZSkgb3ZlcnJpZGU7Ci0gICAgdm9pZCBkaWRT ZW5kRGF0YShXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZSosIHVuc2lnbmVkIGxvbmcgbG9uZyBieXRl c1NlbnQsIHVuc2lnbmVkIGxvbmcgbG9uZyB0b3RhbEJ5dGVzVG9CZVNlbnQpIG92ZXJyaWRlOwot ICAgIHZvaWQgZGlkUmVjZWl2ZVJlc3BvbnNlQXN5bmMoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUq LCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJiYpIG92ZXJyaWRlOwotICAgIHZvaWQgZGlkUmVj ZWl2ZURhdGEoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqLCBjb25zdCBjaGFyKiwgdW5zaWduZWQs IGludCBlbmNvZGVkRGF0YUxlbmd0aCkgb3ZlcnJpZGU7Ci0gICAgdm9pZCBkaWRSZWNlaXZlQnVm ZmVyKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKiwgUmVmPFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcj4m JiwgaW50IHJlcG9ydGVkRW5jb2RlZERhdGFMZW5ndGgpIG92ZXJyaWRlOwotICAgIHZvaWQgZGlk RmluaXNoTG9hZGluZyhXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZSosIGRvdWJsZSBmaW5pc2hUaW1l KSBvdmVycmlkZTsKLSAgICB2b2lkIGRpZEZhaWwoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqLCBj b25zdCBXZWJDb3JlOjpSZXNvdXJjZUVycm9yJikgb3ZlcnJpZGU7Ci0gICAgdm9pZCB3YXNCbG9j a2VkKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKikgb3ZlcnJpZGU7Ci0gICAgdm9pZCBjYW5ub3RT aG93VVJMKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKikgb3ZlcnJpZGU7Ci0gICAgYm9vbCBzaG91 bGRVc2VDcmVkZW50aWFsU3RvcmFnZShXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZSopIG92ZXJyaWRl OwotICAgIHZvaWQgZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKFdlYkNvcmU6OlJl c291cmNlSGFuZGxlKiwgY29uc3QgV2ViQ29yZTo6QXV0aGVudGljYXRpb25DaGFsbGVuZ2UmKSBv dmVycmlkZTsKLSAgICB2b2lkIHJlY2VpdmVkQ2FuY2VsbGF0aW9uKFdlYkNvcmU6OlJlc291cmNl SGFuZGxlKiwgY29uc3QgV2ViQ29yZTo6QXV0aGVudGljYXRpb25DaGFsbGVuZ2UmKSBvdmVycmlk ZTsKLSAgICBib29sIHVzZXNBc3luY0NhbGxiYWNrcygpIG92ZXJyaWRlIHsgcmV0dXJuIHRydWU7 IH0KLSAgICBib29sIGxvYWRpbmdTeW5jaHJvbm91c1hIUigpIG92ZXJyaWRlIHsgcmV0dXJuIG1f Y2xpZW50LmlzU3luY2hyb25vdXMoKTsgfQorICAgIHZvaWQgd2lsbFNlbmRSZXF1ZXN0QXN5bmMo V2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqLCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmJiwgV2Vi Q29yZTo6UmVzb3VyY2VSZXNwb25zZSYmIHJlZGlyZWN0UmVzcG9uc2UpIGZpbmFsOworICAgIHZv aWQgZGlkU2VuZERhdGEoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqLCB1bnNpZ25lZCBsb25nIGxv bmcgYnl0ZXNTZW50LCB1bnNpZ25lZCBsb25nIGxvbmcgdG90YWxCeXRlc1RvQmVTZW50KSBmaW5h bDsKKyAgICB2b2lkIGRpZFJlY2VpdmVSZXNwb25zZUFzeW5jKFdlYkNvcmU6OlJlc291cmNlSGFu ZGxlKiwgV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZSYmKSBmaW5hbDsKKyAgICB2b2lkIGRpZFJl Y2VpdmVEYXRhKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKiwgY29uc3QgY2hhciosIHVuc2lnbmVk LCBpbnQgZW5jb2RlZERhdGFMZW5ndGgpIGZpbmFsOworICAgIHZvaWQgZGlkUmVjZWl2ZUJ1ZmZl cihXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZSosIFJlZjxXZWJDb3JlOjpTaGFyZWRCdWZmZXI+JiYs IGludCByZXBvcnRlZEVuY29kZWREYXRhTGVuZ3RoKSBmaW5hbDsKKyAgICB2b2lkIGRpZEZpbmlz aExvYWRpbmcoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqLCBkb3VibGUgZmluaXNoVGltZSkgZmlu YWw7CisgICAgdm9pZCBkaWRGYWlsKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKiwgY29uc3QgV2Vi Q29yZTo6UmVzb3VyY2VFcnJvciYpIGZpbmFsOworICAgIHZvaWQgd2FzQmxvY2tlZChXZWJDb3Jl OjpSZXNvdXJjZUhhbmRsZSopIGZpbmFsOworICAgIHZvaWQgY2Fubm90U2hvd1VSTChXZWJDb3Jl OjpSZXNvdXJjZUhhbmRsZSopIGZpbmFsOworICAgIGJvb2wgc2hvdWxkVXNlQ3JlZGVudGlhbFN0 b3JhZ2UoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqKSBmaW5hbDsKKyAgICB2b2lkIGRpZFJlY2Vp dmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZShXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZSosIGNvbnN0 IFdlYkNvcmU6OkF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJikgZmluYWw7CisgICAgdm9pZCByZWNl aXZlZENhbmNlbGxhdGlvbihXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZSosIGNvbnN0IFdlYkNvcmU6 OkF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJikgZmluYWw7CisgICAgYm9vbCB1c2VzQXN5bmNDYWxs YmFja3MoKSBmaW5hbCB7IHJldHVybiB0cnVlOyB9CisgICAgYm9vbCBsb2FkaW5nU3luY2hyb25v dXNYSFIoKSBmaW5hbCB7IHJldHVybiBtX2NsaWVudC5pc1N5bmNocm9ub3VzKCk7IH0KIAogI2lm IFVTRShORVRXT1JLX1NFU1NJT04pCiAgICAgLy8gTmV0d29ya0RhdGFUYXNrQ2xpZW50CkBAIC0x MjIsOSArMTIyLDkgQEAgcHJpdmF0ZToKICAgICB2b2lkIGRpZFJlY2VpdmVEYXRhKFJlZjxXZWJD b3JlOjpTaGFyZWRCdWZmZXI+JiYpIGZpbmFsOwogICAgIHZvaWQgZGlkQ29tcGxldGVXaXRoRXJy b3IoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYpIGZpbmFsOwogICAgIHZvaWQgZGlkQmVj b21lRG93bmxvYWQoKSBmaW5hbDsKLSAgICB2b2lkIGRpZFNlbmREYXRhKHVpbnQ2NF90IHRvdGFs Qnl0ZXNTZW50LCB1aW50NjRfdCB0b3RhbEJ5dGVzRXhwZWN0ZWRUb1NlbmQpIG92ZXJyaWRlOwot ICAgIHZvaWQgd2FzQmxvY2tlZCgpIG92ZXJyaWRlOwotICAgIHZvaWQgY2Fubm90U2hvd1VSTCgp IG92ZXJyaWRlOworICAgIHZvaWQgZGlkU2VuZERhdGEodWludDY0X3QgdG90YWxCeXRlc1NlbnQs IHVpbnQ2NF90IHRvdGFsQnl0ZXNFeHBlY3RlZFRvU2VuZCkgZmluYWw7CisgICAgdm9pZCB3YXNC bG9ja2VkKCkgZmluYWw7CisgICAgdm9pZCBjYW5ub3RTaG93VVJMKCkgZmluYWw7CiAjZW5kaWYK IAogICAgIE5ldHdvcmtMb2FkQ2xpZW50JiBtX2NsaWVudDsK