162678 2016-09-28 08:44:04 -0700 woff2 upgrade introduces compiler warnings 2016-09-29 01:36:29 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=162608 P2 Minor --- 1 mcatanzaro mcatanzaro annulen bugs-noreply commit-queue mcatanzaro oldest_to_newest 1234389 0 mcatanzaro 2016-09-28 08:44:04 -0700 Please fix compiler warnings before submitting patches! It seems unlikely that your compiler didn't warn about these: [22/78] Building CXX object Source/Thi...MakeFiles/woff2.dir/src/woff2_dec.cc.o ../../Source/ThirdParty/woff2/src/woff2_dec.cc: In function ‘bool woff2::{anonymous}::ReadWOFF2Header(const uint8_t*, size_t, woff2::{anonymous}::WOFF2Header*)’: ../../Source/ThirdParty/woff2/src/woff2_dec.cc:1140:12: warning: unused variable ‘dst_offset’ [-Wunused-variable] uint64_t dst_offset = first_table_offset; ^~~~~~~~~~ ../../Source/ThirdParty/woff2/src/woff2_dec.cc: In function ‘bool woff2::{anonymous}::WriteHeaders(const uint8_t*, size_t, woff2::{anonymous}::RebuildMetadata*, woff2::{anonymous}::WOFF2Header*, woff2::WOFF2Out*)’: ../../Source/ThirdParty/woff2/src/woff2_dec.cc:1179:34: warning: unused parameter ‘data’ [-Wunused-parameter] bool WriteHeaders(const uint8_t* data, size_t length, RebuildMetadata* metadata, ^~~~ ../../Source/ThirdParty/woff2/src/woff2_dec.cc:1179:47: warning: unused parameter ‘length’ [-Wunused-parameter] bool WriteHeaders(const uint8_t* data, size_t length, RebuildMetadata* metadata, ^~~~~~ 1234390 1 290085 mcatanzaro 2016-09-28 08:47:38 -0700 Created attachment 290085 Patch 1234480 2 290085 commit-queue 2016-09-28 12:34:58 -0700 Comment on attachment 290085 Patch Clearing flags on attachment: 290085 Committed r206532: <http://trac.webkit.org/changeset/206532> 1234481 3 commit-queue 2016-09-28 12:35:01 -0700 All reviewed patches have been landed. Closing bug. 1234490 4 290085 annulen 2016-09-28 12:38:39 -0700 Comment on attachment 290085 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290085&action=review > Source/ThirdParty/woff2/CMakeLists.txt:22 > + ADD_TARGET_PROPERTIES(woff2 COMPILE_FLAGS "-Wno-sign-compare -Wunused-variable -Wunused-parameter") I think you've meant -Wno-unused-variable -Wno-unused-parameter 1234499 5 annulen 2016-09-28 12:50:23 -0700 Committed r206535: <http://trac.webkit.org/changeset/206535> 1234747 6 mcatanzaro 2016-09-29 01:36:29 -0700 Sigh, thanks... I guess I must not have tested it at all.... 290085 2016-09-28 08:47:38 -0700 2016-09-28 12:34:58 -0700 Patch bug-162678-20160928174437.patch text/plain 1238 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggZDA0YjdhYzNi YTU1OWM3NGJkZmI5YTgyYzJmNDJmZGMzMWE5YjJjYy4uYzc3YjAwOTkyZDMwZmE1MzgzNDBkYzg1 MjkwNzMwMjljMGM0ZmQyMCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2 LTA5LTI4ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAg ICAgICB3b2ZmMiB1cGdyYWRlIGludHJvZHVjZXMgY29tcGlsZXIgd2FybmluZ3MKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjY3OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd29mZjIvQ01ha2VMaXN0 cy50eHQ6CisKIDIwMTYtMDktMjggIEtoYWxlZCBIb3NueSAgPGtoYWxlZGhvc255QGVnbHVnLm9y Zz4KIAogICAgICAgICBVcGRhdGUgd29mZjIgdG8gbGF0ZXN0IHJldmlzaW9uCmRpZmYgLS1naXQg YS9Tb3VyY2UvVGhpcmRQYXJ0eS93b2ZmMi9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9UaGlyZFBh cnR5L3dvZmYyL0NNYWtlTGlzdHMudHh0CmluZGV4IGMyZDlkMTgyN2ZmYzI0ZTk2ZDJjNDAyMzdk MTU1YTU0Y2NmODA5NzAuLmIwYTYyZWQxMjYxODMzODcyZDE5NjJkZDA5OGNkODg1NDc2N2QyOTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L3dvZmYyL0NNYWtlTGlzdHMudHh0CisrKyBi L1NvdXJjZS9UaGlyZFBhcnR5L3dvZmYyL0NNYWtlTGlzdHMudHh0CkBAIC0xOSw3ICsxOSw3IEBA IHRhcmdldF9saW5rX2xpYnJhcmllcyh3b2ZmMiBicm90bGkpCiBXRUJLSVRfU0VUX0VYVFJBX0NP TVBJTEVSX0ZMQUdTKHdvZmYyKQogCiBpZiAoQ09NUElMRVJfSVNfR0NDX09SX0NMQU5HKQotICAg IEFERF9UQVJHRVRfUFJPUEVSVElFUyh3b2ZmMiBDT01QSUxFX0ZMQUdTICItV25vLXNpZ24tY29t cGFyZSIpCisgICAgQUREX1RBUkdFVF9QUk9QRVJUSUVTKHdvZmYyIENPTVBJTEVfRkxBR1MgIi1X bm8tc2lnbi1jb21wYXJlIC1XdW51c2VkLXZhcmlhYmxlIC1XdW51c2VkLXBhcmFtZXRlciIpCiBl bmRpZiAoKQogCiBpZiAoQ01BS0VfQ09NUElMRVJfSVNfR05VQ1hYKQo=