162670 2016-09-28 04:36:05 -0700 [Win] Compile fix. 2016-09-28 09:32:42 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue lforschler ossy oldest_to_newest 1234332 0 pvollan 2016-09-28 04:36:05 -0700 There are currently some compile errors on Windows: C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\heap\GCIncomingRefCounted.h(109): error C2953: 'JSC::GCIncomingRefCounted': class template has already been defined (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Tools\DumpRenderTree\TestRunner.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\heap\GCIncomingRefCounted.h(42): note: see declaration of 'JSC::GCIncomingRefCounted' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Tools\DumpRenderTree\TestRunner.cpp) 1234334 1 290074 pvollan 2016-09-28 04:46:32 -0700 Created attachment 290074 Patch 1234368 2 290074 bfulgham 2016-09-28 07:09:04 -0700 Comment on attachment 290074 Patch R=me 1234409 3 pvollan 2016-09-28 09:29:50 -0700 (In reply to comment #2) > Comment on attachment 290074 [details] > Patch > > R=me Thanks for reviewing! 1234414 4 290074 commit-queue 2016-09-28 09:32:39 -0700 Comment on attachment 290074 Patch Clearing flags on attachment: 290074 Committed r206521: <http://trac.webkit.org/changeset/206521> 1234415 5 commit-queue 2016-09-28 09:32:42 -0700 All reviewed patches have been landed. Closing bug. 290074 2016-09-28 04:46:32 -0700 2016-09-28 09:32:39 -0700 Patch bug-162670-20160928044332.patch text/plain 1847 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNjUxMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE2LTA5LTI4ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBDb21waWxlIGZpeC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjY3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSB3ZSBpbmNsdWRlIEphdmFTY3JpcHRD b3JlIGZpbGVzIGZyb20gdGhlIGZvcndhcmRpbmcgaGVhZGVycyBmb2xkZXIuCisgICAgICAgIE90 aGVyd2lzZSB3ZSBtaWdodCBnZXQgbXVsdGlwbGUgZGVmaW5pdGlvbnMgaWYgYSBKU0MgZmlsZSBp cyBpbmNsdWRlZCBib3RoCisgICAgICAgIGZyb20gdGhlIGZvcndhcmRpbmcgaGVhZGVycyBmb2xk ZXIgYW5kIHRoZSBKU0Mgc291cmNlIGZvbGRlciwgc2luY2UKKyAgICAgICAgI3ByYWdtYSBvbmNl IGlzIHVzZWQgaW4gdGhlIGhlYWRlciBmaWxlcy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVl L1Rlc3RSdW5uZXIuY3BwOgorCiAyMDE2LTA5LTI4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBTd2l0Y2ggdG8gdXNlIEdNZW51IGlu dGVybmFsbHkgaW4gdGhlIGNvbnRleHQgbWVudSBpbXBsZW1lbnRhdGlvbgpJbmRleDogVG9vbHMv RHVtcFJlbmRlclRyZWUvVGVzdFJ1bm5lci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJl bmRlclRyZWUvVGVzdFJ1bm5lci5jcHAJKHJldmlzaW9uIDIwNjUwOSkKKysrIFRvb2xzL0R1bXBS ZW5kZXJUcmVlL1Rlc3RSdW5uZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCwxNyArMzQsMTcg QEAKICNpbmNsdWRlICJXb3JrUXVldWUuaCIKICNpbmNsdWRlICJXb3JrUXVldWVJdGVtLmgiCiAj aW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvQVBJQ2FzdC5oPgorI2luY2x1ZGUgPEphdmFTY3JpcHRD b3JlL0FycmF5QnVmZmVyVmlldy5oPgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0hlYXBJbmxp bmVzLmg+Ci0jaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvSlNDb250ZXh0UmVmLmg+CisjaW5jbHVk ZSA8SmF2YVNjcmlwdENvcmUvSlNBcnJheUJ1ZmZlclZpZXcuaD4KICNpbmNsdWRlIDxKYXZhU2Ny aXB0Q29yZS9KU0NUZXN0UnVubmVyVXRpbHMuaD4KKyNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9K U0NvbnRleHRSZWYuaD4KICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU09iamVjdFJlZi5oPgog I2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTUmV0YWluUHRyLmg+CisjaW5jbHVkZSA8SmF2YVNj cmlwdENvcmUvVHlwZWRBcnJheUlubGluZXMuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0xvZ0luaXRp YWxpemF0aW9uLmg+CiAjaW5jbHVkZSA8Y3N0cmluZz4KICNpbmNsdWRlIDxsb2NhbGUuaD4KLSNp bmNsdWRlIDxydW50aW1lL0FycmF5QnVmZmVyVmlldy5oPgotI2luY2x1ZGUgPHJ1bnRpbWUvSlNB cnJheUJ1ZmZlclZpZXcuaD4KLSNpbmNsdWRlIDxydW50aW1lL1R5cGVkQXJyYXlJbmxpbmVzLmg+ CiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgogI2luY2x1 ZGUgPHd0Zi9DdXJyZW50VGltZS5oPgo=