162669 2016-09-28 04:18:04 -0700 [GStreamer] Can't play any video with GSTREAMER_GL enabled 2016-10-06 03:25:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build All Linux RESOLVED FIXED P2 Normal --- 1 mario mario jana magomez pnormand yoon oldest_to_newest 1234330 0 mario 2016-09-28 04:18:04 -0700 In a recent build of WebKitGTK 2.14 for armv7hl with -DUSE_GSTREAMER_GL=ON, I can't play any video at all, neither using MiniBrowser or any other WebKit-based app (like our modified version of Yelp, which plays webM videos). The output dumped by MiniBrowser when running with GST_DEBUG=3 GST_DEBUG_NO_COLOR=1 is as follows: 0:00:00.557686608 29453 0xb8f75a20 WARN basesrc gstbasesrc.c:3489:gst_base_src_start_complete:<source> pad not activated yet 0:00:00.560178646 29453 0xb8f75a20 WARN basesrc gstbasesrc.c:3489:gst_base_src_start_complete:<source> pad not activated yet 0:00:00.637388838 29453 0xae627780 WARN qtdemux qtdemux_types.c:222:qtdemux_type_get: unknown QuickTime node type iods 0:00:00.637875846 29453 0xae627780 WARN qtdemux qtdemux.c:2651:qtdemux_parse_trex:<qtdemux0> failed to find fragment defaults for stream 1 0:00:00.638603857 29453 0xae627780 WARN qtdemux qtdemux.c:2651:qtdemux_parse_trex:<qtdemux0> failed to find fragment defaults for stream 2 0:00:00.639172866 29453 0xae627780 WARN basesrc gstbasesrc.c:2396:gst_base_src_update_length:<source> processing at or past EOS 0:00:00.724505183 29453 0xaf00cc00 FIXME videodecoder gstvideodecoder.c:1057:gst_video_decoder_drain_out:<avdec_h264-0> Sub-class should implement drain() 0:00:00.743410475 29453 0xaf00cc00 FIXME videodecoder gstvideodecoder.c:1057:gst_video_decoder_drain_out:<avdec_h264-0> Sub-class should implement drain() 0:00:01.165169985 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.166186000 29453 0xad952230 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl0> Failed to create context 0:00:01.166328002 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<glcolorconvertelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.166678008 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.170955074 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<glcolorconvertelement0> Subclass failed to decide allocation 0:00:01.172883104 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.173991121 29453 0xad94a8f0 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl1> Failed to create context 0:00:01.174338126 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<glcolorconvertelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.174726132 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<glcolorconvertelement0> Subclass failed to decide allocation 0:00:01.174831134 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.174998136 29453 0xb0202120 WARN GST_PADS gstpad.c:4081:gst_pad_peer_query:<gluploadelement0:src> could not send sticky events 0:00:01.175822149 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.176707163 29453 0xad952320 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl2> Failed to create context 0:00:01.177243171 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<gluploadelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.177642177 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<gluploadelement0> Subclass failed to decide allocation 0:00:01.177795179 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.183616269 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.185748302 29453 0xad8046c0 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl3> Failed to create context 0:00:01.186478314 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<glcolorconvertelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.186809319 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<glcolorconvertelement0> Subclass failed to decide allocation 0:00:01.186910320 29453 0xb0202120 WARN GST_PADS gstpad.c:4081:gst_pad_peer_query:<gluploadelement0:src> could not send sticky events 0:00:01.187162324 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.187637331 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.188510345 29453 0xad9521b0 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl4> Failed to create context 0:00:01.188700348 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<gluploadelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.188996352 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<gluploadelement0> Subclass failed to decide allocation 0:00:01.189086354 29453 0xb0202120 WARN GST_PADS gstpad.c:4081:gst_pad_peer_query:<sink:proxypad1> could not send sticky events 0:00:01.189094354 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.350633847 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.354764911 29453 0xad94a860 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl5> Failed to create context 0:00:01.355304919 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<glcolorconvertelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.355566923 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<glcolorconvertelement0> Subclass failed to decide allocation 0:00:01.355661925 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.356194933 29453 0xb0202120 WARN GST_PADS gstpad.c:4081:gst_pad_peer_query:<gluploadelement0:src> could not send sticky events 0:00:01.356944945 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.364994069 29453 0xad9522c0 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl6> Failed to create context 0:00:01.365847082 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<gluploadelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.367240104 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.368498123 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<gluploadelement0> Subclass failed to decide allocation 0:00:01.368992131 29453 0xb0202120 WARN GST_PADS gstpad.c:4081:gst_pad_peer_query:<sink:proxypad1> could not send sticky events 0:00:01.388301429 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.394701527 29453 0xad94a950 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl7> Failed to create context 0:00:01.395614542 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<glcolorconvertelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.396488555 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<glcolorconvertelement0> Subclass failed to decide allocation 0:00:01.396577556 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.397180566 29453 0xb0202120 WARN GST_PADS gstpad.c:4081:gst_pad_peer_query:<gluploadelement0:src> could not send sticky events 0:00:01.398266582 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.399893608 29453 0xad952150 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl8> Failed to create context 0:00:01.400729621 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<gluploadelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.401557633 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<gluploadelement0> Subclass failed to decide allocation 0:00:01.401646635 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.409099750 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.422741960 29453 0xad952180 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl9> Failed to create context 0:00:01.423179967 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<glcolorconvertelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.423685975 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.424215983 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<glcolorconvertelement0> Subclass failed to decide allocation 0:00:01.424453987 29453 0xb0202120 WARN GST_PADS gstpad.c:4081:gst_pad_peer_query:<gluploadelement0:src> could not send sticky events 0:00:01.425236999 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.427399032 29453 0xad9522f0 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl10> Failed to create context 0:00:01.427899040 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<gluploadelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.428306046 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.428616051 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<gluploadelement0> Subclass failed to decide allocation 0:00:01.433323124 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.444512296 29453 0xad952000 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl11> Failed to create context 0:00:01.445367310 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<glcolorconvertelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.445900318 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<glcolorconvertelement0> Subclass failed to decide allocation 0:00:01.446120321 29453 0xb0202120 WARN GST_PADS gstpad.c:4081:gst_pad_peer_query:<gluploadelement0:src> could not send sticky events 0:00:01.446995335 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.447862348 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.450015381 29453 0xad952030 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl12> Failed to create context 0:00:01.450757393 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<gluploadelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.451192399 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<gluploadelement0> Subclass failed to decide allocation 0:00:01.451711407 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.457470496 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.459535528 29453 0xad94a800 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl13> Failed to create context 0:00:01.459993535 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<glcolorconvertelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.460431542 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<glcolorconvertelement0> Subclass failed to decide allocation 0:00:01.460510543 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.460701546 29453 0xb0202120 WARN GST_PADS gstpad.c:4081:gst_pad_peer_query:<gluploadelement0:src> could not send sticky events 0:00:01.461317556 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.462409573 29453 0xad94a830 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl14> Failed to create context 0:00:01.462876580 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<gluploadelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.463082583 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<gluploadelement0> Subclass failed to decide allocation 0:00:01.463151584 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.467959658 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.469724685 29453 0xad94a8c0 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl15> Failed to create context 0:00:01.470407696 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<glcolorconvertelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.470706701 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<glcolorconvertelement0> Subclass failed to decide allocation 0:00:01.470785702 29453 0xb0202120 WARN GST_PADS gstpad.c:4081:gst_pad_peer_query:<gluploadelement0:src> could not send sticky events 0:00:01.470807702 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.471382711 29453 0xb0202120 WARN glwindow gstglwindow.c:308:gst_gl_window_new: Could not create window. user specified (null), creating dummy window 0:00:01.473137738 29453 0xb03098c0 WARN glcontext gstglcontext.c:1161:gst_gl_context_create_thread:<glcontextegl16> Failed to create context 0:00:01.473667746 29453 0xb0202120 WARN glbasefilter gstglbasefilter.c:445:gst_gl_base_filter_decide_allocation:<gluploadelement0> error: Failed to initialize egl: EGL_BAD_DISPLAY 0:00:01.474068753 29453 0xb0202120 WARN basetransform gstbasetransform.c:1042:gst_base_transform_do_bufferpool:<gluploadelement0> Subclass failed to decide allocation 0:00:01.474284756 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 3: Failed to initialize egl: EGL_BAD_DISPLAY (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) 0:00:01.479597838 29453 0xae627780 WARN qtdemux qtdemux.c:5520:gst_qtdemux_loop:<qtdemux0> error: streaming stopped, reason not-negotiated 0:00:01.479937843 29453 0xb8f75a20 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:908:handleMessage: Error 1: GStreamer encountered a general stream error. (url=file:///home/mario/samples/The%20Bourne%20Ultimatum%20-%20Trailer.mp4) Looks like it's having trouble to optain the platform display, but this seems to be specific to ARM since the same code compiled for x86_64 works just fine. 1235242 1 290334 mario 2016-09-30 09:13:15 -0700 Created attachment 290334 Patch proposal It seems this was my fault after all, since I passed a X11 display type to gst_gl_display_egl_new_with_egl_display() instead of an EGLDisplay[1], because I (naively) took the code from the Wayland codepath without realizing that PlatformDisplayWayland::native() returns a valid EGLDisplay, while PlatformDisplayX11::native() does not. Thus, simply passing the result of PlatformDisplay::eglDisplay() instead of PlatformDisplayX11::native() fixes the issue and I can now play video on my ARM device with GStreamerGL enabled \o/ Please review the attached patch, thanks! [1] https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L265 [2] https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L271 1236116 2 jana 2016-10-04 02:39:52 -0700 I tried to get GSTREAMER_GL running with the webkitgtk-2.14.0 release last weekend under wayland. Which was pretty successful, except for running into this bug which was resolved by doing the exact same replacement for the wayland case a few lines below. (native display is the wayland display, but it needs the egl display too) 1236909 3 pnormand 2016-10-05 23:39:10 -0700 Mario, do you plan to update the patch? 1236977 4 mario 2016-10-06 02:51:40 -0700 (In reply to comment #2) > I tried to get GSTREAMER_GL running with the webkitgtk-2.14.0 release last > weekend under wayland. Which was pretty successful, except for running into > this bug which was resolved by doing the exact same replacement for the > wayland case a few lines below. Interesting, I actually asked on IRC about how they wayland patch could actually work but got no answer and the, talking to someone else locally, I was told (and trusted it) that wayland display was actually an EGLDisplay, so I did forgot about that and assumed it would just work.(In reply to comment #3) > Mario, do you plan to update the patch? Yes, I'm doing it now 1236981 5 290804 mario 2016-10-06 03:03:03 -0700 Created attachment 290804 Patch proposal Patch updated, please review. Thanks 1236989 6 mario 2016-10-06 03:25:39 -0700 Committed r206859: <http://trac.webkit.org/changeset/206859> 290334 2016-09-30 09:13:15 -0700 2016-10-06 03:02:44 -0700 Patch proposal 0001-2016-09-30-Mario-Sanchez-Prada-mario-endlessm.com.patch text/plain 2799 mario RnJvbSAyMTM1OTk4ZmJjYTRkN2RhMDZiOWQwYTJhNmJkMGQ4NGVlZDU1ODQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpb0B3ZWJraXQub3Jn PgpEYXRlOiBGcmksIDMwIFNlcCAyMDE2IDE3OjA0OjI4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g MjAxNi0wOS0zMCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvQGVuZGxlc3NtLmNvbT4KCiAg ICAgICAgW0dTdHJlYW1lcl0gQ2FuJ3QgcGxheSBhbnkgdmlkZW8gd2l0aCBHU1RSRUFNRVJfR0wg ZW5hYmxlZAogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjI2NjkKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIE1ha2Ug c3VyZSBhbiBFR0xEaXNwbGF5IHR5cGUgaXMgcGFzc2VkIHdoZW4gY3JlYXRpbmcgdGhlIEdzdEds RGlzcGxheQogICAgICAgIGZvciB0aGUgWDExK0VHTCBjb2RlIHBhdGgsIGluc3RlYWQgb2YgYSBu YXRpdmUgWDExIGRpc3BsYXkgdHlwZSwgc28KICAgICAgICB0aGF0IHdlIGdldCBhIHZhbGlkIEdz dEdsRGlzcGxheSBhcyBhIHJlc3VsdCwgbm90IGEgZHVtbXkgb25lLgoKICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNw cDoKICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6ZW5z dXJlR3N0R0xDb250ZXh0KToKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTQgKysrKysrKysrKysrKysKIC4uLi9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAgfCAgMiArLQog MiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IDY1MWVmZDAuLmM3Y2FjN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx Ni0wOS0zMCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvQGVuZGxlc3NtLmNvbT4KKworICAg ICAgICBbR1N0cmVhbWVyXSBDYW4ndCBwbGF5IGFueSB2aWRlbyB3aXRoIEdTVFJFQU1FUl9HTCBl bmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjI2NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN YWtlIHN1cmUgYW4gRUdMRGlzcGxheSB0eXBlIGlzIHBhc3NlZCB3aGVuIGNyZWF0aW5nIHRoZSBH c3RHbERpc3BsYXkKKyAgICAgICAgZm9yIHRoZSBYMTErRUdMIGNvZGUgcGF0aCwgaW5zdGVhZCBv ZiBhIG5hdGl2ZSBYMTEgZGlzcGxheSB0eXBlLCBzbworICAgICAgICB0aGF0IHdlIGdldCBhIHZh bGlkIEdzdEdsRGlzcGxheSBhcyBhIHJlc3VsdCwgbm90IGEgZHVtbXkgb25lLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy QmFzZTo6ZW5zdXJlR3N0R0xDb250ZXh0KToKKwogMjAxNi0wOS0zMCAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBJbWFnZURhdGEuZGF0 YSBhdHRyaWJ1dGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXJCYXNlLmNwcAppbmRleCBiMmZlZGIwLi41MjdmNmIxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyQmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCkBAIC0yNjIsNyArMjYy LDcgQEAgYm9vbCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjplbnN1cmVHc3RHTENv bnRleHQoKQogICAgICAgICAgICAgbV9nbERpc3BsYXkgPSBHU1RfR0xfRElTUExBWShnc3RfZ2xf ZGlzcGxheV94MTFfbmV3X3dpdGhfZGlzcGxheShkb3duY2FzdDxQbGF0Zm9ybURpc3BsYXlYMTE+ KHNoYXJlZERpc3BsYXkpLm5hdGl2ZSgpKSk7CiAjZWxpZiBVU0UoRUdMKQogICAgICAgICBpZiAo aXM8UGxhdGZvcm1EaXNwbGF5WDExPihzaGFyZWREaXNwbGF5KSkKLSAgICAgICAgICAgIG1fZ2xE aXNwbGF5ID0gR1NUX0dMX0RJU1BMQVkoZ3N0X2dsX2Rpc3BsYXlfZWdsX25ld193aXRoX2VnbF9k aXNwbGF5KGRvd25jYXN0PFBsYXRmb3JtRGlzcGxheVgxMT4oc2hhcmVkRGlzcGxheSkubmF0aXZl KCkpKTsKKyAgICAgICAgICAgIG1fZ2xEaXNwbGF5ID0gR1NUX0dMX0RJU1BMQVkoZ3N0X2dsX2Rp c3BsYXlfZWdsX25ld193aXRoX2VnbF9kaXNwbGF5KGRvd25jYXN0PFBsYXRmb3JtRGlzcGxheVgx MT4oc2hhcmVkRGlzcGxheSkuZWdsRGlzcGxheSgpKSk7CiAjZW5kaWYKICNlbmRpZgogCi0tIAoy LjkuMwoK 290804 2016-10-06 03:03:03 -0700 2016-10-06 03:04:43 -0700 Patch proposal bug-162669-20161006105948.patch text/plain 2442 mario U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2ODU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDU0ZGM5ZTBmZDUyY2I0 NzRkZmJkNzU3OTkxNzVhOTE1NzY0NmZiNi4uNmZmYzE4ZWFmYWI5ZmVhNDc5MjY4ZDZhMDg0MGZk NzY0YzFlY2NlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEwLTA2ICBNYXJp byBTYW5jaGV6IFByYWRhICA8bWFyaW9AZW5kbGVzc20uY29tPgorCisgICAgICAgIFtHU3RyZWFt ZXJdIENhbid0IHBsYXkgYW55IHZpZGVvIHdpdGggR1NUUkVBTUVSX0dMIGVuYWJsZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjY2OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSBhbiBF R0xEaXNwbGF5IHR5cGUgaXMgcGFzc2VkIHdoZW4gY3JlYXRpbmcgdGhlIEdzdEdsRGlzcGxheQor ICAgICAgICBmb3IgdGhlIEVHTCBjb2RlIHBhdGgsIGluc3RlYWQgb2YgYSBuYXRpdmUgWDExIGRp c3BsYXkgdHlwZSwgc28KKyAgICAgICAgdGhhdCB3ZSBnZXQgYSB2YWxpZCBHc3RHbERpc3BsYXkg YXMgYSByZXN1bHQsIG5vdCBhIGR1bW15IG9uZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmVuc3VyZUdzdEdM Q29udGV4dCk6CisKIDIwMTYtMTAtMDYgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RA ZXJpY3Nzb24uY29tPgogCiAgICAgICAgIFdlYlJUQzogQWRkIHN1cHBvcnQgZm9yIHRoZSBpY2Vj YW5kaWRhdGUgZXZlbnQgaW4gTWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyQmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKaW5kZXggYjJm ZWRiMGI2N2RiZmQ0ZjMyZmRkZjI1OTEyZWZjNWMyNWRkZTVjZC4uNGIzMzE3MDkwZDVlMzdmNDg4 NmNhY2YyMWIwMTEwNTAzMzcyMWQ2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcApAQCAtMjYyLDEzICsyNjIsMTMgQEAgYm9vbCBN ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjplbnN1cmVHc3RHTENvbnRleHQoKQogICAg ICAgICAgICAgbV9nbERpc3BsYXkgPSBHU1RfR0xfRElTUExBWShnc3RfZ2xfZGlzcGxheV94MTFf bmV3X3dpdGhfZGlzcGxheShkb3duY2FzdDxQbGF0Zm9ybURpc3BsYXlYMTE+KHNoYXJlZERpc3Bs YXkpLm5hdGl2ZSgpKSk7CiAjZWxpZiBVU0UoRUdMKQogICAgICAgICBpZiAoaXM8UGxhdGZvcm1E aXNwbGF5WDExPihzaGFyZWREaXNwbGF5KSkKLSAgICAgICAgICAgIG1fZ2xEaXNwbGF5ID0gR1NU X0dMX0RJU1BMQVkoZ3N0X2dsX2Rpc3BsYXlfZWdsX25ld193aXRoX2VnbF9kaXNwbGF5KGRvd25j YXN0PFBsYXRmb3JtRGlzcGxheVgxMT4oc2hhcmVkRGlzcGxheSkubmF0aXZlKCkpKTsKKyAgICAg ICAgICAgIG1fZ2xEaXNwbGF5ID0gR1NUX0dMX0RJU1BMQVkoZ3N0X2dsX2Rpc3BsYXlfZWdsX25l d193aXRoX2VnbF9kaXNwbGF5KGRvd25jYXN0PFBsYXRmb3JtRGlzcGxheVgxMT4oc2hhcmVkRGlz cGxheSkuZWdsRGlzcGxheSgpKSk7CiAjZW5kaWYKICNlbmRpZgogCiAjaWYgUExBVEZPUk0oV0FZ TEFORCkKICAgICAgICAgaWYgKGlzPFBsYXRmb3JtRGlzcGxheVdheWxhbmQ+KHNoYXJlZERpc3Bs YXkpKQotICAgICAgICAgICAgbV9nbERpc3BsYXkgPSBHU1RfR0xfRElTUExBWShnc3RfZ2xfZGlz cGxheV9lZ2xfbmV3X3dpdGhfZWdsX2Rpc3BsYXkoZG93bmNhc3Q8UGxhdGZvcm1EaXNwbGF5V2F5 bGFuZD4oc2hhcmVkRGlzcGxheSkubmF0aXZlKCkpKTsKKyAgICAgICAgICAgIG1fZ2xEaXNwbGF5 ID0gR1NUX0dMX0RJU1BMQVkoZ3N0X2dsX2Rpc3BsYXlfZWdsX25ld193aXRoX2VnbF9kaXNwbGF5 KGRvd25jYXN0PFBsYXRmb3JtRGlzcGxheVdheWxhbmQ+KHNoYXJlZERpc3BsYXkpLmVnbERpc3Bs YXkoKSkpOwogI2VuZGlmCiAKICAgICAgICAgQVNTRVJUKG1fZ2xEaXNwbGF5KTsK