162649 2016-09-27 17:40:48 -0700 NetworkLoad and PingLoad should use private inheritance 2016-09-27 18:03:54 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates achristensen andersca beidson oldest_to_newest 1234170 0 dbates 2016-09-27 17:40:48 -0700 It is sufficient to have NetworkLoad and PingLoad privately inherit from ResourceHandleClient. Currently they publicly inherit from ResourceHandleClient. 1234172 1 dbates 2016-09-27 17:42:21 -0700 (In reply to comment #0) > It is sufficient to have NetworkLoad and PingLoad privately inherit from > ResourceHandleClient. This should read: It is sufficient to have NetworkLoad and PingLoad privately inherit from ResourceHandleClient and NetworkDataTaskClient, respectively. 1234189 2 290039 dbates 2016-09-27 17:57:14 -0700 Created attachment 290039 Patch 1234192 3 290039 dbates 2016-09-27 18:03:50 -0700 Comment on attachment 290039 Patch Clearing flags on attachment: 290039 Committed r206479: <http://trac.webkit.org/changeset/206479> 1234193 4 dbates 2016-09-27 18:03:54 -0700 All reviewed patches have been landed. Closing bug. 290039 2016-09-27 17:57:14 -0700 2016-09-27 18:03:50 -0700 Patch bug-162649-20160927175415.patch text/plain 7099 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzkyMGZmODUzMDMxMmM5 NTg3Nzk5NThiMWFjNGQwNTNmNGVjZDI4OC4uNWU3YTdiNTIxYzIwNmQyNzQ5NGY4OGQ0NTIzN2Vk OTU0MTc3NjIyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE2LTA5LTI3ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBOZXR3b3JrTG9hZCBhbmQg UGluZ0xvYWQgc2hvdWxkIHVzZSBwcml2YXRlIGluaGVyaXRhbmNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI2NDkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIE5ldHdvcmtMb2FkIHByaXZhdGVs eSBpbmhlcml0IGZyb20gTmV0d29ya0RhdGFUYXNrQ2xpZW50IGFuZCBSZXNvdXJjZUhhbmRsZUNs aWVudCwKKyAgICAgICAgYW5kIG1ha2UgdGhlIGNsaWVudCBjYWxsYmFja3MgZnJvbSB0aGVzZSBp bnRlcmZhY2VzIHByaXZhdGUgYXMgdGhpcyBjbGFzcyBpbXBsZW1lbnRzCisgICAgICAgIHRoZXNl IGludGVyZmFjZXMuCisKKyAgICAgICAgU2ltaWxhcmx5LCBtYWtlIFBpbmdMb2FkIHByaXZhdGVs eSBpbmhlcml0IGZyb20gUmVzb3VyY2VIYW5kbGVDbGllbnQuCisKKyAgICAgICAgKiBOZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrTG9hZC5oOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL1BpbmdMb2Fk Lmg6CisKKzIwMTYtMDktMjcgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCiAg ICAgICAgIFtXSzJdW05ldHdvcmtTZXNzaW9uXSBQaW5nIHJlcXVlc3RzIHNob3VsZCBmb2xsb3cg cmVkaXJlY3RzIGlmIGFwcGxpY2FibGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2MjU4MAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5oIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mv TmV0d29ya0xvYWQuaAppbmRleCAzODNmZDE4ODk0NDk5YTY3ODUwMGI4MTk1MjAzMDc4YzA1MWM3 Yjk5Li5kMWViMTJmYTgyMWJjZGY4NjA5NzI4MTFkNjBlNGQ4ZjAxYzlmMDA3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5oCisrKyBiL1NvdXJj ZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmgKQEAgLTQwLDkgKzQwLDkgQEAK IAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLWNsYXNzIE5ldHdvcmtMb2FkIDogcHVibGljIFdlYkNv cmU6OlJlc291cmNlSGFuZGxlQ2xpZW50CitjbGFzcyBOZXR3b3JrTG9hZCA6IHByaXZhdGUgV2Vi Q29yZTo6UmVzb3VyY2VIYW5kbGVDbGllbnQKICNpZiBVU0UoTkVUV09SS19TRVNTSU9OKQotICAg ICwgcHVibGljIE5ldHdvcmtEYXRhVGFza0NsaWVudAorICAgICwgcHJpdmF0ZSBOZXR3b3JrRGF0 YVRhc2tDbGllbnQKICNlbmRpZgogewogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwpAQCAt NjksMzMgKzY5LDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0U3VnZ2VzdGVkRmlsZW5hbWUoY29u c3QgU3RyaW5nJik7CiAgICAgdm9pZCBzZXRQZW5kaW5nRG93bmxvYWQoUGVuZGluZ0Rvd25sb2Fk Jik7CiAgICAgRG93bmxvYWRJRCBwZW5kaW5nRG93bmxvYWRJRCgpIHsgcmV0dXJuIG1fdGFzay0+ cGVuZGluZ0Rvd25sb2FkSUQoKTsgfQotICAgIAotICAgIC8vIE5ldHdvcmtEYXRhVGFza0NsaWVu dAotICAgIHZvaWQgd2lsbFBlcmZvcm1IVFRQUmVkaXJlY3Rpb24oV2ViQ29yZTo6UmVzb3VyY2VS ZXNwb25zZSYmLCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmJiwgUmVkaXJlY3RDb21wbGV0aW9u SGFuZGxlciYmKSBmaW5hbDsKLSAgICB2b2lkIGRpZFJlY2VpdmVDaGFsbGVuZ2UoY29uc3QgV2Vi Q29yZTo6QXV0aGVudGljYXRpb25DaGFsbGVuZ2UmLCBDaGFsbGVuZ2VDb21wbGV0aW9uSGFuZGxl ciYmKSBmaW5hbDsKLSAgICB2b2lkIGRpZFJlY2VpdmVSZXNwb25zZU5ldHdvcmtTZXNzaW9uKFdl YkNvcmU6OlJlc291cmNlUmVzcG9uc2UmJiwgUmVzcG9uc2VDb21wbGV0aW9uSGFuZGxlciYmKSBm aW5hbDsKLSAgICB2b2lkIGRpZFJlY2VpdmVEYXRhKFJlZjxXZWJDb3JlOjpTaGFyZWRCdWZmZXI+ JiYpIGZpbmFsOwotICAgIHZvaWQgZGlkQ29tcGxldGVXaXRoRXJyb3IoY29uc3QgV2ViQ29yZTo6 UmVzb3VyY2VFcnJvciYpIGZpbmFsOwotICAgIHZvaWQgZGlkQmVjb21lRG93bmxvYWQoKSBmaW5h bDsKLSAgICB2b2lkIGRpZFNlbmREYXRhKHVpbnQ2NF90IHRvdGFsQnl0ZXNTZW50LCB1aW50NjRf dCB0b3RhbEJ5dGVzRXhwZWN0ZWRUb1NlbmQpIG92ZXJyaWRlOwotICAgIHZvaWQgd2FzQmxvY2tl ZCgpIG92ZXJyaWRlOwotICAgIHZvaWQgY2Fubm90U2hvd1VSTCgpIG92ZXJyaWRlOwogI2VuZGlm Ci0gICAgLy8gUmVzb3VyY2VIYW5kbGVDbGllbnQKLSAgICB2b2lkIHdpbGxTZW5kUmVxdWVzdEFz eW5jKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKiwgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiYs IFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmJiByZWRpcmVjdFJlc3BvbnNlKSBvdmVycmlkZTsK LSAgICB2b2lkIGRpZFNlbmREYXRhKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKiwgdW5zaWduZWQg bG9uZyBsb25nIGJ5dGVzU2VudCwgdW5zaWduZWQgbG9uZyBsb25nIHRvdGFsQnl0ZXNUb0JlU2Vu dCkgb3ZlcnJpZGU7Ci0gICAgdm9pZCBkaWRSZWNlaXZlUmVzcG9uc2VBc3luYyhXZWJDb3JlOjpS ZXNvdXJjZUhhbmRsZSosIFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmJikgb3ZlcnJpZGU7Ci0g ICAgdm9pZCBkaWRSZWNlaXZlRGF0YShXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZSosIGNvbnN0IGNo YXIqLCB1bnNpZ25lZCwgaW50IGVuY29kZWREYXRhTGVuZ3RoKSBvdmVycmlkZTsKLSAgICB2b2lk IGRpZFJlY2VpdmVCdWZmZXIoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqLCBSZWY8V2ViQ29yZTo6 U2hhcmVkQnVmZmVyPiYmLCBpbnQgcmVwb3J0ZWRFbmNvZGVkRGF0YUxlbmd0aCkgb3ZlcnJpZGU7 Ci0gICAgdm9pZCBkaWRGaW5pc2hMb2FkaW5nKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKiwgZG91 YmxlIGZpbmlzaFRpbWUpIG92ZXJyaWRlOwotICAgIHZvaWQgZGlkRmFpbChXZWJDb3JlOjpSZXNv dXJjZUhhbmRsZSosIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlRXJyb3ImKSBvdmVycmlkZTsKLSAg ICB2b2lkIHdhc0Jsb2NrZWQoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqKSBvdmVycmlkZTsKLSAg ICB2b2lkIGNhbm5vdFNob3dVUkwoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqKSBvdmVycmlkZTsK LSAgICBib29sIHNob3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdlKFdlYkNvcmU6OlJlc291cmNlSGFu ZGxlKikgb3ZlcnJpZGU7Ci0gICAgdm9pZCBkaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVu Z2UoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqLCBjb25zdCBXZWJDb3JlOjpBdXRoZW50aWNhdGlv bkNoYWxsZW5nZSYpIG92ZXJyaWRlOwotICAgIHZvaWQgcmVjZWl2ZWRDYW5jZWxsYXRpb24oV2Vi Q29yZTo6UmVzb3VyY2VIYW5kbGUqLCBjb25zdCBXZWJDb3JlOjpBdXRoZW50aWNhdGlvbkNoYWxs ZW5nZSYpIG92ZXJyaWRlOwotICAgIGJvb2wgdXNlc0FzeW5jQ2FsbGJhY2tzKCkgb3ZlcnJpZGUg eyByZXR1cm4gdHJ1ZTsgfQotICAgIGJvb2wgbG9hZGluZ1N5bmNocm9ub3VzWEhSKCkgb3ZlcnJp ZGUgeyByZXR1cm4gbV9jbGllbnQuaXNTeW5jaHJvbm91cygpOyB9CiAKICNpZiBVU0UoUFJPVEVD VElPTl9TUEFDRV9BVVRIX0NBTExCQUNLKQogICAgIHZvaWQgY2FuQXV0aGVudGljYXRlQWdhaW5z dFByb3RlY3Rpb25TcGFjZUFzeW5jKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKiwgY29uc3QgV2Vi Q29yZTo6UHJvdGVjdGlvblNwYWNlJikgb3ZlcnJpZGU7CkBAIC0xMjQsNiArOTgsMzUgQEAgcHJp dmF0ZToKICAgICBOZXR3b3JrTG9hZENsaWVudDo6U2hvdWxkQ29udGludWVEaWRSZWNlaXZlUmVz cG9uc2Ugc2hhcmVkRGlkUmVjZWl2ZVJlc3BvbnNlKFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2Um Jik7CiAgICAgdm9pZCBzaGFyZWRXaWxsU2VuZFJlZGlyZWN0ZWRSZXF1ZXN0KFdlYkNvcmU6OlJl c291cmNlUmVxdWVzdCYmLCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJiYpOwogCisgICAgLy8g UmVzb3VyY2VIYW5kbGVDbGllbnQKKyAgICB2b2lkIHdpbGxTZW5kUmVxdWVzdEFzeW5jKFdlYkNv cmU6OlJlc291cmNlSGFuZGxlKiwgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiYsIFdlYkNvcmU6 OlJlc291cmNlUmVzcG9uc2UmJiByZWRpcmVjdFJlc3BvbnNlKSBvdmVycmlkZTsKKyAgICB2b2lk IGRpZFNlbmREYXRhKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKiwgdW5zaWduZWQgbG9uZyBsb25n IGJ5dGVzU2VudCwgdW5zaWduZWQgbG9uZyBsb25nIHRvdGFsQnl0ZXNUb0JlU2VudCkgb3ZlcnJp ZGU7CisgICAgdm9pZCBkaWRSZWNlaXZlUmVzcG9uc2VBc3luYyhXZWJDb3JlOjpSZXNvdXJjZUhh bmRsZSosIFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmJikgb3ZlcnJpZGU7CisgICAgdm9pZCBk aWRSZWNlaXZlRGF0YShXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZSosIGNvbnN0IGNoYXIqLCB1bnNp Z25lZCwgaW50IGVuY29kZWREYXRhTGVuZ3RoKSBvdmVycmlkZTsKKyAgICB2b2lkIGRpZFJlY2Vp dmVCdWZmZXIoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqLCBSZWY8V2ViQ29yZTo6U2hhcmVkQnVm ZmVyPiYmLCBpbnQgcmVwb3J0ZWRFbmNvZGVkRGF0YUxlbmd0aCkgb3ZlcnJpZGU7CisgICAgdm9p ZCBkaWRGaW5pc2hMb2FkaW5nKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKiwgZG91YmxlIGZpbmlz aFRpbWUpIG92ZXJyaWRlOworICAgIHZvaWQgZGlkRmFpbChXZWJDb3JlOjpSZXNvdXJjZUhhbmRs ZSosIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlRXJyb3ImKSBvdmVycmlkZTsKKyAgICB2b2lkIHdh c0Jsb2NrZWQoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqKSBvdmVycmlkZTsKKyAgICB2b2lkIGNh bm5vdFNob3dVUkwoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqKSBvdmVycmlkZTsKKyAgICBib29s IHNob3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdlKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKikgb3Zl cnJpZGU7CisgICAgdm9pZCBkaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoV2ViQ29y ZTo6UmVzb3VyY2VIYW5kbGUqLCBjb25zdCBXZWJDb3JlOjpBdXRoZW50aWNhdGlvbkNoYWxsZW5n ZSYpIG92ZXJyaWRlOworICAgIHZvaWQgcmVjZWl2ZWRDYW5jZWxsYXRpb24oV2ViQ29yZTo6UmVz b3VyY2VIYW5kbGUqLCBjb25zdCBXZWJDb3JlOjpBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYpIG92 ZXJyaWRlOworICAgIGJvb2wgdXNlc0FzeW5jQ2FsbGJhY2tzKCkgb3ZlcnJpZGUgeyByZXR1cm4g dHJ1ZTsgfQorICAgIGJvb2wgbG9hZGluZ1N5bmNocm9ub3VzWEhSKCkgb3ZlcnJpZGUgeyByZXR1 cm4gbV9jbGllbnQuaXNTeW5jaHJvbm91cygpOyB9CisKKyNpZiBVU0UoTkVUV09SS19TRVNTSU9O KQorICAgIC8vIE5ldHdvcmtEYXRhVGFza0NsaWVudAorICAgIHZvaWQgd2lsbFBlcmZvcm1IVFRQ UmVkaXJlY3Rpb24oV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZSYmLCBXZWJDb3JlOjpSZXNvdXJj ZVJlcXVlc3QmJiwgUmVkaXJlY3RDb21wbGV0aW9uSGFuZGxlciYmKSBmaW5hbDsKKyAgICB2b2lk IGRpZFJlY2VpdmVDaGFsbGVuZ2UoY29uc3QgV2ViQ29yZTo6QXV0aGVudGljYXRpb25DaGFsbGVu Z2UmLCBDaGFsbGVuZ2VDb21wbGV0aW9uSGFuZGxlciYmKSBmaW5hbDsKKyAgICB2b2lkIGRpZFJl Y2VpdmVSZXNwb25zZU5ldHdvcmtTZXNzaW9uKFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmJiwg UmVzcG9uc2VDb21wbGV0aW9uSGFuZGxlciYmKSBmaW5hbDsKKyAgICB2b2lkIGRpZFJlY2VpdmVE YXRhKFJlZjxXZWJDb3JlOjpTaGFyZWRCdWZmZXI+JiYpIGZpbmFsOworICAgIHZvaWQgZGlkQ29t cGxldGVXaXRoRXJyb3IoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYpIGZpbmFsOworICAg IHZvaWQgZGlkQmVjb21lRG93bmxvYWQoKSBmaW5hbDsKKyAgICB2b2lkIGRpZFNlbmREYXRhKHVp bnQ2NF90IHRvdGFsQnl0ZXNTZW50LCB1aW50NjRfdCB0b3RhbEJ5dGVzRXhwZWN0ZWRUb1NlbmQp IG92ZXJyaWRlOworICAgIHZvaWQgd2FzQmxvY2tlZCgpIG92ZXJyaWRlOworICAgIHZvaWQgY2Fu bm90U2hvd1VSTCgpIG92ZXJyaWRlOworI2VuZGlmCisKICAgICBOZXR3b3JrTG9hZENsaWVudCYg bV9jbGllbnQ7CiAgICAgY29uc3QgTmV0d29ya0xvYWRQYXJhbWV0ZXJzIG1fcGFyYW1ldGVyczsK ICNpZiBVU0UoTkVUV09SS19TRVNTSU9OKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0 d29ya1Byb2Nlc3MvUGluZ0xvYWQuaCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL1Bp bmdMb2FkLmgKaW5kZXggMGVhYjI5N2E5NmQ1ZTQ2NzhhNTE4NmQ3NzZiZmYzYTQzZGQxOWRiZS4u N2E3YTNhZGYxNDIwZjM1MDMyOGQ3MjJhNGVlMzc5NjFiZTUyZDQ3NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvUGluZ0xvYWQuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9OZXR3b3JrUHJvY2Vzcy9QaW5nTG9hZC5oCkBAIC0zMSw3ICszMSw3IEBACiAKIG5hbWVzcGFj ZSBXZWJLaXQgewogCi1jbGFzcyBQaW5nTG9hZCBmaW5hbCA6IHB1YmxpYyBOZXR3b3JrRGF0YVRh c2tDbGllbnQgeworY2xhc3MgUGluZ0xvYWQgZmluYWwgOiBwcml2YXRlIE5ldHdvcmtEYXRhVGFz a0NsaWVudCB7CiBwdWJsaWM6CiAgICAgUGluZ0xvYWQoY29uc3QgTmV0d29ya1Jlc291cmNlTG9h ZFBhcmFtZXRlcnMmIHBhcmFtZXRlcnMpCiAgICAgICAgIDogbV90aW1lb3V0VGltZXIoKnRoaXMs ICZQaW5nTG9hZDo6dGltZW91dFRpbWVyRmlyZWQpCg==