162644 2016-09-27 16:47:06 -0700 B3::lowerMacros forgets to before->updatePredecessorsAfter() when lowering ChillMod on ARM64 2016-09-27 16:57:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1234129 0 fpizlo 2016-09-27 16:47:06 -0700 Patch forthcoming. 1234131 1 290023 fpizlo 2016-09-27 16:49:04 -0700 Created attachment 290023 the patch 1234134 2 commit-queue 2016-09-27 16:50:59 -0700 Attachment 290023 did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3LowerMacros.cpp:150: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1234135 3 290024 fpizlo 2016-09-27 16:51:36 -0700 Created attachment 290024 the patch 1234136 4 290024 keith_miller 2016-09-27 16:52:45 -0700 Comment on attachment 290024 the patch r=me. 1234138 5 fpizlo 2016-09-27 16:57:10 -0700 Landed in https://trac.webkit.org/changeset/206472 290023 2016-09-27 16:49:04 -0700 2016-09-27 16:51:36 -0700 the patch blah.patch text/plain 2507 fpizlo SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDY0NzEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE2LTA5LTI3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CisKKyAgICAgICAgQjM6Omxvd2VyTWFjcm9zIGZvcmdldHMgdG8gYmVmb3JlLT51cGRhdGVQ cmVkZWNlc3NvcnNBZnRlcigpIHdoZW4gbG93ZXJpbmcgQ2hpbGxNb2Qgb24gQVJNNjQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjY0NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2NoaWxs LW1vZC1jaGlsbC1tb2QuanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKwogMjAxNi0wOS0yNiAg Q3NhYmEgT3N6dHJvZ29uw6FjICA8b3N6aUBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgU2tp cCBzdHJlc3Mvc3RyaW5nLWpvaW5pbmctbG9uZy1zdHJpbmdzLXNob3VsZC1ub3QtY3Jhc2guanMg b24gbWVtb3J5IGxpbWl0ZWQgZGV2aWNlcwpJbmRleDogSlNUZXN0cy9zdHJlc3MvY2hpbGwtbW9k LWNoaWxsLW1vZC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9jaGlsbC1tb2QtY2hp bGwtbW9kLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2NoaWxsLW1vZC1jaGls bC1tb2QuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAorZnVuY3Rpb24gZm9vKGEs IGIpCit7CisgICAgcmV0dXJuICh+fihhICUgYikpICsgKH5+KGIgJSBhKSk7Cit9CisKK25vSW5s aW5lKGZvbyk7CisKK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDA7ICsraSkKKyAgICBmb28oMSwg Mik7CisKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA2NDUxKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE2IEBACisyMDE2LTA5LTI3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAg ICAgICAgQjM6Omxvd2VyTWFjcm9zIGZvcmdldHMgdG8gYmVmb3JlLT51cGRhdGVQcmVkZWNlc3Nv cnNBZnRlcigpIHdoZW4gbG93ZXJpbmcgQ2hpbGxNb2Qgb24gQVJNNjQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjY0NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIHlvdSBmb3JnZXQgdG8gdXBkYXRl IHRoZSBwcmVkZWNlc3NvcnMgb2YgeW91ciBzdWNjZXNzb3JzLCB0aGVuIGJhZCB0aGluZ3Mgd2ls bCBoYXBwZW4gaWYgeW91CisgICAgICAgIGRvIHNvbWV0aGluZyB0aGF0IHJlcXVpcmVzIGFjY3Vy YXRlIHByZWRlY2Vzc29ycyBmb3IgY29ycmVjdG5lc3MuIGxvd2VyTWFjcm9zKCkgdXNlcworICAg ICAgICBCbG9ja0luc2VydGlvblNldCwgd2hpY2ggcmVsaWVzIG9uIGFjY3VyYXRlIHByZWRlY2Vz c29ycy4KKworICAgICAgICAqIGIzL0IzTG93ZXJNYWNyb3MuY3BwOgorCiAyMDE2LTA5LTI3ICBK ZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBkZXByZWNh dGVkIEVOQ1JZUFRFRF9NRURJQSBpbXBsZW1lbnRhdGlvbi4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9iMy9CM0xvd2VyTWFjcm9zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYjMvQjNMb3dlck1hY3Jvcy5jcHAJKHJldmlzaW9uIDIwNjQ1MSkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9iMy9CM0xvd2VyTWFjcm9zLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTQ3LDYgKzE0Nyw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgICAgIG5vcm1hbFJlc3Vs dC0+c2V0UGhpKHBoaSk7CiAgICAgICAgICAgICAgICAgICAgIHplcm9SZXN1bHQtPnNldFBoaShw aGkpOwogICAgICAgICAgICAgICAgICAgICBtX3ZhbHVlLT5yZXBsYWNlV2l0aElkZW50aXR5KHBo aSk7CisgICAgICAgICAgICAgICAgICAgIC8vYmVmb3JlLT51cGRhdGVQcmVkZWNlc3NvcnNBZnRl cigpOwogICAgICAgICAgICAgICAgICAgICBtX2NoYW5nZWQgPSB0cnVlOwogICAgICAgICAgICAg ICAgIH0gZWxzZQogICAgICAgICAgICAgICAgICAgICBtYWtlRGl2aXNpb25DaGlsbChNb2QpOwo= 290024 2016-09-27 16:51:36 -0700 2016-09-27 16:52:45 -0700 the patch blah.patch text/plain 2505 fpizlo SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDY0NzEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE2LTA5LTI3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CisKKyAgICAgICAgQjM6Omxvd2VyTWFjcm9zIGZvcmdldHMgdG8gYmVmb3JlLT51cGRhdGVQ cmVkZWNlc3NvcnNBZnRlcigpIHdoZW4gbG93ZXJpbmcgQ2hpbGxNb2Qgb24gQVJNNjQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjY0NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2NoaWxs LW1vZC1jaGlsbC1tb2QuanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKwogMjAxNi0wOS0yNiAg Q3NhYmEgT3N6dHJvZ29uw6FjICA8b3N6aUBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgU2tp cCBzdHJlc3Mvc3RyaW5nLWpvaW5pbmctbG9uZy1zdHJpbmdzLXNob3VsZC1ub3QtY3Jhc2guanMg b24gbWVtb3J5IGxpbWl0ZWQgZGV2aWNlcwpJbmRleDogSlNUZXN0cy9zdHJlc3MvY2hpbGwtbW9k LWNoaWxsLW1vZC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9jaGlsbC1tb2QtY2hp bGwtbW9kLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2NoaWxsLW1vZC1jaGls bC1tb2QuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAorZnVuY3Rpb24gZm9vKGEs IGIpCit7CisgICAgcmV0dXJuICh+fihhICUgYikpICsgKH5+KGIgJSBhKSk7Cit9CisKK25vSW5s aW5lKGZvbyk7CisKK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDA7ICsraSkKKyAgICBmb28oMSwg Mik7CisKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA2NDUxKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE2IEBACisyMDE2LTA5LTI3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAg ICAgICAgQjM6Omxvd2VyTWFjcm9zIGZvcmdldHMgdG8gYmVmb3JlLT51cGRhdGVQcmVkZWNlc3Nv cnNBZnRlcigpIHdoZW4gbG93ZXJpbmcgQ2hpbGxNb2Qgb24gQVJNNjQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjY0NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIHlvdSBmb3JnZXQgdG8gdXBkYXRl IHRoZSBwcmVkZWNlc3NvcnMgb2YgeW91ciBzdWNjZXNzb3JzLCB0aGVuIGJhZCB0aGluZ3Mgd2ls bCBoYXBwZW4gaWYgeW91CisgICAgICAgIGRvIHNvbWV0aGluZyB0aGF0IHJlcXVpcmVzIGFjY3Vy YXRlIHByZWRlY2Vzc29ycyBmb3IgY29ycmVjdG5lc3MuIGxvd2VyTWFjcm9zKCkgdXNlcworICAg ICAgICBCbG9ja0luc2VydGlvblNldCwgd2hpY2ggcmVsaWVzIG9uIGFjY3VyYXRlIHByZWRlY2Vz c29ycy4KKworICAgICAgICAqIGIzL0IzTG93ZXJNYWNyb3MuY3BwOgorCiAyMDE2LTA5LTI3ICBK ZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBkZXByZWNh dGVkIEVOQ1JZUFRFRF9NRURJQSBpbXBsZW1lbnRhdGlvbi4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9iMy9CM0xvd2VyTWFjcm9zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYjMvQjNMb3dlck1hY3Jvcy5jcHAJKHJldmlzaW9uIDIwNjQ1MSkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9iMy9CM0xvd2VyTWFjcm9zLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTQ3LDYgKzE0Nyw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgICAgIG5vcm1hbFJlc3Vs dC0+c2V0UGhpKHBoaSk7CiAgICAgICAgICAgICAgICAgICAgIHplcm9SZXN1bHQtPnNldFBoaShw aGkpOwogICAgICAgICAgICAgICAgICAgICBtX3ZhbHVlLT5yZXBsYWNlV2l0aElkZW50aXR5KHBo aSk7CisgICAgICAgICAgICAgICAgICAgIGJlZm9yZS0+dXBkYXRlUHJlZGVjZXNzb3JzQWZ0ZXIo KTsKICAgICAgICAgICAgICAgICAgICAgbV9jaGFuZ2VkID0gdHJ1ZTsKICAgICAgICAgICAgICAg ICB9IGVsc2UKICAgICAgICAgICAgICAgICAgICAgbWFrZURpdmlzaW9uQ2hpbGwoTW9kKTsK