162637 2016-09-27 15:13:14 -0700 createError() and JSObject::calculatedClassName() should not throw any exceptions. 2016-09-29 12:35:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 162351 1 mark.lam mark.lam benjamin fpizlo ggaren jfbastien keith_miller msaboff saam oldest_to_newest 1234088 0 mark.lam 2016-09-27 15:13:14 -0700 Patch coming. 1234092 1 290014 mark.lam 2016-09-27 15:18:10 -0700 Created attachment 290014 proposed patch. 1234093 2 290014 ggaren 2016-09-27 15:20:46 -0700 Comment on attachment 290014 proposed patch. r=me 1234156 3 mark.lam 2016-09-27 17:29:07 -0700 Thanks for the review. All tests are happy. Landed in r206476: <http://trac.webkit.org/r206476>. 290014 2016-09-27 15:18:10 -0700 2016-09-27 15:20:46 -0700 proposed patch. bug-162637.patch text/plain 3692 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA2NDY2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE2LTA5LTI3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBj cmVhdGVFcnJvcigpIGFuZCBKU09iamVjdDo6Y2FsY3VsYXRlZENsYXNzTmFtZSgpIHNob3VsZCBu b3QgdGhyb3cgYW55IGV4Y2VwdGlvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjI2MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5jcHA6CisgICAgICAg IChKU0M6OmNyZWF0ZUVycm9yKToKKyAgICAgICAgLSBhc3NlcnQgdGhhdCBlcnJvckRlc2NyaXB0 aW9uRm9yVmFsdWUoKSBkaWQgbm90IHRocm93IGFuIGV4Y2VwdGlvbi4KKworICAgICAgICAqIHJ1 bnRpbWUvSlNPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6Y2FsY3VsYXRlZENs YXNzTmFtZSk6CisgICAgICAgIC0gdGhlIGNvZGUgYWxyZWFkeSBlbnN1cmVzIHRoYXQgd2UgYWx3 YXlzIHJldHVybiBhIG5vbi1udWxsIFN0cmluZy4gIEp1c3QgbmVlZCB0bworICAgICAgICAgIG1h a2Ugc3VyZSB0aGF0IGl0IGNhdGNoZXMgaXRzIG93biBleGNlcHRpb25zLgorCiAyMDE2LTA5LTI3 ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc29tZSBuZWVk ZWQgQ2F0Y2hTY29wZXMgaW4gY29kZSB0aGF0IHNob3VsZCBub3QgdGhyb3cuCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcAko cmV2aXNpb24gMjA2NDU4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhjZXB0 aW9uSGVscGVycy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzNiw3ICsyMzYsMTEgQEAgc3RhdGlj IFN0cmluZyBpbnZhbGlkUGFyYW1ldGVySW5zdGFuY2VvZgogCiBKU09iamVjdCogY3JlYXRlRXJy b3IoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIHZhbHVlLCBjb25zdCBTdHJpbmcmIG1lc3NhZ2Us IEVycm9ySW5zdGFuY2U6OlNvdXJjZUFwcGVuZGVyIGFwcGVuZGVyKQogeworICAgIFZNJiB2bSA9 IGV4ZWMtPnZtKCk7CisgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfQ0FUQ0hfU0NPUEUodm0pOwor CiAgICAgU3RyaW5nIGVycm9yTWVzc2FnZSA9IG1ha2VTdHJpbmcoZXJyb3JEZXNjcmlwdGlvbkZv clZhbHVlKGV4ZWMsIHZhbHVlKS0+dmFsdWUoZXhlYyksICcgJywgbWVzc2FnZSk7CisgICAgQVNT RVJUX1VOVVNFRChzY29wZSwgIXNjb3BlLmV4Y2VwdGlvbigpKTsKICAgICBKU09iamVjdCogZXhj ZXB0aW9uID0gY3JlYXRlVHlwZUVycm9yKGV4ZWMsIGVycm9yTWVzc2FnZSwgYXBwZW5kZXIsIHJ1 bnRpbWVUeXBlRm9yVmFsdWUodmFsdWUpKTsKICAgICBBU1NFUlQoZXhjZXB0aW9uLT5pc0Vycm9y SW5zdGFuY2UoKSk7CiAgICAgcmV0dXJuIGV4Y2VwdGlvbjsKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAJKHJldmlzaW9uIDIwNjQ1OCkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjMwLDcgKzIzMCwxMSBAQCBTdHJpbmcgSlNPYmplY3Q6OnRvU3RyaW5nTmFtZShjb25zdCBKU09i CiBTdHJpbmcgSlNPYmplY3Q6OmNhbGN1bGF0ZWRDbGFzc05hbWUoSlNPYmplY3QqIG9iamVjdCkK IHsKICAgICBTdHJpbmcgcHJvdG90eXBlRnVuY3Rpb25OYW1lOwotICAgIEV4ZWNTdGF0ZSogZXhl YyA9IG9iamVjdC0+Z2xvYmFsT2JqZWN0KCktPmdsb2JhbEV4ZWMoKTsKKyAgICBhdXRvIGdsb2Jh bE9iamVjdCA9IG9iamVjdC0+Z2xvYmFsT2JqZWN0KCk7CisgICAgVk0mIHZtID0gZ2xvYmFsT2Jq ZWN0LT52bSgpOworICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX0NBVENIX1NDT1BFKHZtKTsKKwor ICAgIEV4ZWNTdGF0ZSogZXhlYyA9IGdsb2JhbE9iamVjdC0+Z2xvYmFsRXhlYygpOwogICAgIFBy b3BlcnR5U2xvdCBzbG90KG9iamVjdC0+Z2V0UHJvdG90eXBlRGlyZWN0KCksIFByb3BlcnR5U2xv dDo6SW50ZXJuYWxNZXRob2RUeXBlOjpWTUlucXVpcnkpOwogICAgIFByb3BlcnR5TmFtZSBjb25z dHJ1Y3RvcihleGVjLT5wcm9wZXJ0eU5hbWVzKCkuY29uc3RydWN0b3IpOwogICAgIGlmIChvYmpl Y3QtPmdldFByb3BlcnR5U2xvdChleGVjLCBjb25zdHJ1Y3Rvciwgc2xvdCkpIHsKQEAgLTIzOSw3 ICsyNDMsNiBAQCBTdHJpbmcgSlNPYmplY3Q6OmNhbGN1bGF0ZWRDbGFzc05hbWUoSlNPCiAgICAg ICAgICAgICBpZiAoY29uc3RydWN0b3JWYWx1ZS5pc0NlbGwoKSkgewogICAgICAgICAgICAgICAg IGlmIChKU0NlbGwqIGNvbnN0cnVjdG9yQ2VsbCA9IGNvbnN0cnVjdG9yVmFsdWUuYXNDZWxsKCkp IHsKICAgICAgICAgICAgICAgICAgICAgaWYgKEpTT2JqZWN0KiBjdG9yT2JqZWN0ID0gY29uc3Ry dWN0b3JDZWxsLT5nZXRPYmplY3QoKSkgewotICAgICAgICAgICAgICAgICAgICAgICAgVk0mIHZt ID0gZXhlYy0+dm0oKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChKU0Z1bmN0aW9uKiBj b25zdHJ1Y3RvckZ1bmN0aW9uID0ganNEeW5hbWljQ2FzdDxKU0Z1bmN0aW9uKj4oY3Rvck9iamVj dCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHJvdG90eXBlRnVuY3Rpb25OYW1lID0g Y29uc3RydWN0b3JGdW5jdGlvbi0+Y2FsY3VsYXRlZERpc3BsYXlOYW1lKHZtKTsKICAgICAgICAg ICAgICAgICAgICAgICAgIGVsc2UgaWYgKEludGVybmFsRnVuY3Rpb24qIGNvbnN0cnVjdG9yRnVu Y3Rpb24gPSBqc0R5bmFtaWNDYXN0PEludGVybmFsRnVuY3Rpb24qPihjdG9yT2JqZWN0KSkKQEAg LTI0OSw2ICsyNTIsOSBAQCBTdHJpbmcgSlNPYmplY3Q6OmNhbGN1bGF0ZWRDbGFzc05hbWUoSlNP CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CisgICAgQVNTRVJUKCFzY29wZS5leGNl cHRpb24oKSB8fCBwcm90b3R5cGVGdW5jdGlvbk5hbWUuaXNOdWxsKCkpOworICAgIGlmIChVTkxJ S0VMWShzY29wZS5leGNlcHRpb24oKSkpCisgICAgICAgIHNjb3BlLmNsZWFyRXhjZXB0aW9uKCk7 CiAKICAgICBpZiAocHJvdG90eXBlRnVuY3Rpb25OYW1lLmlzTnVsbCgpIHx8IHByb3RvdHlwZUZ1 bmN0aW9uTmFtZSA9PSAiT2JqZWN0IikgewogICAgICAgICBTdHJpbmcgdGFibGVDbGFzc05hbWUg PSBvYmplY3QtPm1ldGhvZFRhYmxlKCktPmNsYXNzTmFtZShvYmplY3QpOwo=