162636 2016-09-27 15:06:33 -0700 [CMake] Add HAVE_LOCALTIME_R definition 2016-09-27 21:55:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead commit-queue lforschler oldest_to_newest 1234087 0 don.olmstead 2016-09-27 15:06:33 -0700 There should be a check for whether localtime_r is present. If not then localtime_s should be used. 1234089 1 290012 don.olmstead 2016-09-27 15:14:36 -0700 Created attachment 290012 Patch This patch will search for localtime_r through CMake. If its there then it will attempt to use it. If its not there then it defaults to localtime_s which is a C++11 extension to time.h. The difference between the two seems to be that localtime_r is thread safe. If that's not a concern then maybe it should just be localtime_s across the board. MINGW appears to have the extension so I removed that. Windows still has its own localtime_s which reverses the parameters. 1234150 2 290012 achristensen 2016-09-27 17:19:03 -0700 Comment on attachment 290012 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290012&action=review > Source/WTF/wtf/DateMath.cpp:126 > +#if COMPILER(MSVC) This is inconsistent. In GregorianDateTime.cpp we only check HAVE(LOCALTIME_R) and here we check both. I think this check is unneeded. 1234154 3 don.olmstead 2016-09-27 17:28:08 -0700 In DateMath.cpp getLocalTime is called from calculateUTCOffset, calculateDSTOffset and calculateLocalTimeOffset. In the first two they are not called for Windows because there's an #if OS(WINDOWS) guard. In GregorianDateTime.cpp localtime is not called by Windows because of the #if OS(WINDOWS) guard. Any particular way you want this resolved? I could do another header that can be used from both files. Happy to approach it however you like. 1234253 4 290012 commit-queue 2016-09-27 21:55:13 -0700 Comment on attachment 290012 Patch Clearing flags on attachment: 290012 Committed r206496: <http://trac.webkit.org/changeset/206496> 1234254 5 commit-queue 2016-09-27 21:55:17 -0700 All reviewed patches have been landed. Closing bug. 290012 2016-09-27 15:14:36 -0700 2016-09-27 21:55:13 -0700 Patch bug162636.diff text/plain 3293 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4NzdhYjA4Li4xNDQ5N2M0 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAK IDIwMTYtMDktMjcgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBhbS5zb255LmNvbT4KIAor ICAgICAgICBbQ01ha2VdIEFkZCBIQVZFX0xPQ0FMVElNRV9SIGRlZmluaXRpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjYzNgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09w dGlvbnNDb21tb24uY21ha2U6CisKKzIwMTYtMDktMjcgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1z dGVhZEBhbS5zb255LmNvbT4KKwogICAgICAgICBbQ01ha2VdIFVzZSBDTWFrZSB0byBkZXRlcm1p bmUgSEFWRV8qIGRlZmluZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2MjM2OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1Nv dXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDhlNjlmMWUuLjY0ZmFjY2EgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs MTggQEAKIDIwMTYtMDktMjcgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBhbS5zb255LmNv bT4KIAorICAgICAgICBbQ01ha2VdIEFkZCBIQVZFX0xPQ0FMVElNRV9SIGRlZmluaXRpb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjYzNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0RhdGVN YXRoLmNwcDoKKyAgICAgICAgKFdURjo6Z2V0TG9jYWxUaW1lKToKKyAgICAgICAgKiB3dGYvR3Jl Z29yaWFuRGF0ZVRpbWUuY3BwOgorICAgICAgICAoV1RGOjpHcmVnb3JpYW5EYXRlVGltZTo6c2V0 VG9DdXJyZW50TG9jYWxUaW1lKToKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKworMjAxNi0w OS0yNyAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQGFtLnNvbnkuY29tPgorCiAgICAgICAg IFtDTWFrZV0gVXNlIENNYWtlIHRvIGRldGVybWluZSBIQVZFXyogZGVmaW5lcwogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMzY4CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL0RhdGVNYXRoLmNwcCBiL1NvdXJjZS9XVEYvd3RmL0RhdGVNYXRo LmNwcAppbmRleCBjOTkyYjYwLi4xMzUwZTMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9E YXRlTWF0aC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvRGF0ZU1hdGguY3BwCkBAIC0xMjMsMTIg KzEyMywxMiBAQCBzdGF0aWMgY29uc3QgaW50IGZpcnN0RGF5T2ZNb250aFsyXVsxMl0gPSB7CiAK IHN0YXRpYyBpbmxpbmUgdm9pZCBnZXRMb2NhbFRpbWUoY29uc3QgdGltZV90KiBsb2NhbFRpbWUs IHN0cnVjdCB0bSogbG9jYWxUTSkKIHsKLSNpZiBDT01QSUxFUihNSU5HVykKLSAgICAqbG9jYWxU TSA9ICpsb2NhbHRpbWUobG9jYWxUaW1lKTsKLSNlbGlmIENPTVBJTEVSKE1TVkMpCisjaWYgQ09N UElMRVIoTVNWQykKICAgICBsb2NhbHRpbWVfcyhsb2NhbFRNLCBsb2NhbFRpbWUpOwotI2Vsc2UK KyNlbGlmIEhBVkUoTE9DQUxUSU1FX1IpCiAgICAgbG9jYWx0aW1lX3IobG9jYWxUaW1lLCBsb2Nh bFRNKTsKKyNlbHNlCisgICAgbG9jYWx0aW1lX3MobG9jYWxUaW1lLCBsb2NhbFRNKTsKICNlbmRp ZgogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9HcmVnb3JpYW5EYXRlVGltZS5jcHAg Yi9Tb3VyY2UvV1RGL3d0Zi9HcmVnb3JpYW5EYXRlVGltZS5jcHAKaW5kZXggYmQ0ODg0MC4uZDYz MTdiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvR3JlZ29yaWFuRGF0ZVRpbWUuY3BwCisr KyBiL1NvdXJjZS9XVEYvd3RmL0dyZWdvcmlhbkRhdGVUaW1lLmNwcApAQCAtNjcsNyArNjcsMTEg QEAgdm9pZCBHcmVnb3JpYW5EYXRlVGltZTo6c2V0VG9DdXJyZW50TG9jYWxUaW1lKCkKICNlbHNl CiAgICAgdG0gbG9jYWxUTTsKICAgICB0aW1lX3QgbG9jYWxUaW1lID0gdGltZSgwKTsKKyNpZiBI QVZFKExPQ0FMVElNRV9SKQogICAgIGxvY2FsdGltZV9yKCZsb2NhbFRpbWUsICZsb2NhbFRNKTsK KyNlbHNlCisgICAgbG9jYWx0aW1lX3MoJmxvY2FsVGltZSwgJmxvY2FsVE0pOworI2VuZGlmCiAK ICAgICBtX3llYXIgPSBsb2NhbFRNLnRtX3llYXIgKyAxOTAwOwogICAgIG1fbW9udGggPSBsb2Nh bFRNLnRtX21vbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3Vy Y2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDM0ZTA2Y2MuLjgzZDI0OTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0u aApAQCAtNjA5LDYgKzYwOSw3IEBACiAjaWYgT1MoREFSV0lOKQogI2RlZmluZSBIQVZFX0VSUk5P X0ggMQogI2RlZmluZSBIQVZFX0xBTkdJTkZPX0ggMQorI2RlZmluZSBIQVZFX0xPQ0FMVElNRV9S IDEKICNkZWZpbmUgSEFWRV9NTUFQIDEKICNkZWZpbmUgSEFWRV9TSUdOQUxfSCAxCiAjZGVmaW5l IEhBVkVfU1RBVF9CSVJUSFRJTUUgMQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnND b21tb24uY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQppbmRleCAyMzNm OTY4Li43MjFkMDUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFr ZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQpAQCAtMjQ2LDYgKzI0Niw3 IEBAIF9IQVZFX0NIRUNLX0lOQ0xVREUoSEFWRV9TWVNfVElNRUJfSCBzeXMvdGltZWIuaCkKICMg Q2hlY2sgZm9yIGZ1bmN0aW9ucwogX0hBVkVfQ0hFQ0tfRlVOQ1RJT04oSEFWRV9BTElHTkVEX01B TExPQyBfYWxpZ25lZF9tYWxsb2MpCiBfSEFWRV9DSEVDS19GVU5DVElPTihIQVZFX0lTREVCVUdH RVJQUkVTRU5UIElzRGVidWdnZXJQcmVzZW50KQorX0hBVkVfQ0hFQ0tfRlVOQ1RJT04oSEFWRV9M T0NBTFRJTUVfUiBsb2NhbHRpbWVfcikKIF9IQVZFX0NIRUNLX0ZVTkNUSU9OKEhBVkVfU1RSTlNU UiBzdHJuc3RyKQogX0hBVkVfQ0hFQ0tfRlVOQ1RJT04oSEFWRV9USU1FR00gdGltZWdtKQogX0hB VkVfQ0hFQ0tfRlVOQ1RJT04oSEFWRV9WQVNQUklOVEYgdmFzcHJpbnRmKQo=