162635 2016-09-27 15:01:32 -0700 URLs with @ in the user should only search for the last @ until the end of the authority and host 2016-09-27 17:29:39 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1234083 0 achristensen 2016-09-27 15:01:32 -0700 URLs with @ in the user should only search for the last @ until the end of the authority and host 1234084 1 290010 achristensen 2016-09-27 15:02:46 -0700 Created attachment 290010 Patch 1234094 2 290010 ggaren 2016-09-27 15:21:48 -0700 Comment on attachment 290010 Patch r=me 1234157 3 achristensen 2016-09-27 17:29:23 -0700 https://trac.webkit.org/changeset/206475 1234158 4 290010 achristensen 2016-09-27 17:29:39 -0700 Comment on attachment 290010 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290010&action=review > Source/WebCore/platform/URLParser.cpp:1331 > - if (UNLIKELY(!isSlash)) { > + if (UNLIKELY(!isSlash || *c == '\\')) { This was wrong. 290010 2016-09-27 15:02:46 -0700 2016-09-27 15:21:48 -0700 Patch bug-162635-20160927145948.patch text/plain 5933 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjQ1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTI3ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVVJMcyB3aXRo IEAgaW4gdGhlIHVzZXIgc2hvdWxkIG9ubHkgc2VhcmNoIGZvciB0aGUgbGFzdCBAIHVudGlsIHRo ZSBlbmQgb2YgdGhlIGF1dGhvcml0eSBhbmQgaG9zdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBuZXcgQVBJIHRlc3RzLgorCisgICAg ICAgICogcGxhdGZvcm0vVVJMUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlVSTFBhcnNl cjo6cGFyc2UpOgorCiAyMDE2LTA5LTI3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2Vu QHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IFVSTFBhcnNlcjo6c3ludGF4VmlvbGF0 aW9uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkxQYXJzZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTFBhcnNlci5jcHAJKHJldmlzaW9uIDIw NjQ1NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTFBhcnNlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEzMDcsNiArMTMwNyw5IEBAIHZvaWQgVVJMUGFyc2VyOjpwYXJzZShjb25zdCBD aGFyYWN0ZXJUeXAKICAgICAgICAgICAgICAgICAgICAgd2hpbGUgKCFmaW5kTGFzdEF0LmF0RW5k KCkpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIGlmICgqZmluZExhc3RBdCA9PSAnQCcpCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgbGFzdEF0ID0gZmluZExhc3RBdDsKKyAgICAgICAg ICAgICAgICAgICAgICAgIGJvb2wgaXNTbGFzaCA9ICpmaW5kTGFzdEF0ID09ICcvJyB8fCAobV91 cmxJc1NwZWNpYWwgJiYgKmZpbmRMYXN0QXQgPT0gJ1xcJyk7CisgICAgICAgICAgICAgICAgICAg ICAgICBpZiAoaXNTbGFzaCB8fCAqZmluZExhc3RBdCA9PSAnPycgfHwgKmZpbmRMYXN0QXQgPT0g JyMnKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAg ICAgICAgICAgKytmaW5kTGFzdEF0OwogICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAg ICAgICAgICAgIHBhcnNlQXV0aG9yaXR5KENvZGVQb2ludEl0ZXJhdG9yPENoYXJhY3RlclR5cGU+ KGF1dGhvcml0eU9ySG9zdEJlZ2luLCBsYXN0QXQpKTsKQEAgLTEzMjUsNyArMTMyOCw3IEBAIHZv aWQgVVJMUGFyc2VyOjpwYXJzZShjb25zdCBDaGFyYWN0ZXJUeXAKICAgICAgICAgICAgICAgICAg ICAgICAgIGZhaWx1cmUoKTsKICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgICAgICBpZiAoVU5MSUtFTFkoIWlzU2xh c2gpKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChVTkxJS0VMWSghaXNTbGFzaCB8fCAqYyA9 PSAnXFwnKSkgewogICAgICAgICAgICAgICAgICAgICAgICAgc3ludGF4VmlvbGF0aW9uKGMpOwog ICAgICAgICAgICAgICAgICAgICAgICAgYXBwZW5kVG9BU0NJSUJ1ZmZlcignLycpOwogICAgICAg ICAgICAgICAgICAgICAgICAgbV91cmwubV9wYXRoQWZ0ZXJMYXN0U2xhc2ggPSBjdXJyZW50UG9z aXRpb24oYyk7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMDY0NjYpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNi0wOS0yNyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJp c3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIFVSTHMgd2l0aCBAIGluIHRoZSB1c2VyIHNo b3VsZCBvbmx5IHNlYXJjaCBmb3IgdGhlIGxhc3QgQCB1bnRpbCB0aGUgZW5kIG9mIHRoZSBhdXRo b3JpdHkgYW5kIGhvc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2MjYzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNlci5jcHA6CisgICAg ICAgIChUZXN0V2ViS2l0QVBJOjpURVNUX0YpOgorCiAyMDE2LTA5LTI2ICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IFVSTFBh cnNlcjo6c3ludGF4VmlvbGF0aW9uCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YkNvcmUvVVJMUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYkNvcmUvVVJMUGFyc2VyLmNwcAkocmV2aXNpb24gMjA2NDU3KQorKysgVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTI0OCw2ICsyNDgsNyBAQCBURVNUX0YoVVJMUGFyc2VyVGVzdCwgQmFzaWMpCiAgICAgY2hlY2tV UkwoImRhdGE6aW1hZ2UvcG5nO2Jhc2U2NCxlbmNvZGVkLWRhdGEtZm9sbG93cy1oZXJlIiwgeyJk YXRhIiwgIiIsICIiLCAiIiwgMCwgImltYWdlL3BuZztiYXNlNjQsZW5jb2RlZC1kYXRhLWZvbGxv d3MtaGVyZSIsICIiLCAiIiwgImRhdGE6aW1hZ2UvcG5nO2Jhc2U2NCxlbmNvZGVkLWRhdGEtZm9s bG93cy1oZXJlIn0pOwogICAgIGNoZWNrVVJMKCJkYXRhOmltYWdlL3BuZztiYXNlNjQsZW5jb2Rl ZC9kYXRhLXdpdGgtc2xhc2giLCB7ImRhdGEiLCAiIiwgIiIsICIiLCAwLCAiaW1hZ2UvcG5nO2Jh c2U2NCxlbmNvZGVkL2RhdGEtd2l0aC1zbGFzaCIsICIiLCAiIiwgImRhdGE6aW1hZ2UvcG5nO2Jh c2U2NCxlbmNvZGVkL2RhdGEtd2l0aC1zbGFzaCJ9KTsKICAgICBjaGVja1VSTCgiYWJvdXQ6fiIs IHsiYWJvdXQiLCAiIiwgIiIsICIiLCAwLCAifiIsICIiLCAiIiwgImFib3V0On4ifSk7CisgICAg Y2hlY2tVUkwoImh0dHBzOi8vQHRlc3RAdGVzdEBleGFtcGxlOjgwMFxccGF0aEBlbmQiLCB7IiIs ICIiLCAiIiwgIiIsIDAsICIiLCAiIiwgIiIsICJodHRwczovL0B0ZXN0QHRlc3RAZXhhbXBsZTo4 MDBcXHBhdGhAZW5kIn0pOwogCiAgICAgLy8gVGhpcyBkaXNhZ3JlZXMgd2l0aCB0aGUgd2ViIHBs YXRmb3JtIHRlc3QgZm9yIGh0dHA6Ly86QHd3dy5leGFtcGxlLmNvbSBidXQgYWdyZWVzIHdpdGgg Q2hyb21lIGFuZCBVUkw6OnBhcnNlLAogICAgIC8vIGFuZCBGaXJlZm94IGZhaWxzIHRoZSB3ZWIg cGxhdGZvcm0gdGVzdCBkaWZmZXJlbnRseS4gTWF5YmUgdGhlIHdlYiBwbGF0Zm9ybSB0ZXN0IG91 Z2h0IHRvIGJlIGNoYW5nZWQuCkBAIC0zNDMsNiArMzQ0LDcgQEAgVEVTVF9GKFVSTFBhcnNlclRl c3QsIFBhcnNlUmVsYXRpdmUpCiAgICAgY2hlY2tSZWxhdGl2ZVVSTCgiZm9vOi8iLCAiaHR0cDov L2V4YW1wbGUub3JnL2Zvby9iYXIiLCB7ImZvbyIsICIiLCAiIiwgIiIsIDAsICIvIiwgIiIsICIi LCAiZm9vOi8ifSk7CiAgICAgY2hlY2tSZWxhdGl2ZVVSTCgiOi8vOjAvIiwgImh0dHA6Ly93ZWJr aXQub3JnLyIsIHsiaHR0cCIsICIiLCAiIiwgIndlYmtpdC5vcmciLCAwLCAiLzovLzowLyIsICIi LCAiIiwgImh0dHA6Ly93ZWJraXQub3JnLzovLzowLyJ9KTsKICAgICBjaGVja1JlbGF0aXZlVVJM KFN0cmluZygpLCAiaHR0cDovL3dlYmtpdC5vcmcvIiwgeyJodHRwIiwgIiIsICIiLCAid2Via2l0 Lm9yZyIsIDAsICIvIiwgIiIsICIiLCAiaHR0cDovL3dlYmtpdC5vcmcvIn0pOworICAgIGNoZWNr UmVsYXRpdmVVUkwoImh0dHBzOi8vQHRlc3RAdGVzdEBleGFtcGxlOjgwMFxccGF0aEBlbmQiLCAi aHR0cDovL2RvZXNub3RtYXR0ZXIvIiwgeyIiLCAiIiwgIiIsICIiLCAwLCAiIiwgIiIsICIiLCAi aHR0cHM6Ly9AdGVzdEB0ZXN0QGV4YW1wbGU6ODAwXFxwYXRoQGVuZCJ9KTsKIAogICAgIC8vIFRo ZSBjaGVja2luZyBvZiBzbGFzaGVzIGluIFNwZWNpYWxBdXRob3JpdHlTbGFzaGVzIG5lZWRlZCB0 byBnZXQgdGhpcyB0byBwYXNzIGNvbnRyYWRpY3RzIHdoYXQgaXMgaW4gdGhlIHNwZWMsCiAgICAg Ly8gYnV0IGl0IGlzIGluY2x1ZGVkIGluIHRoZSB3ZWIgcGxhdGZvcm0gdGVzdHMuCkBAIC02MTAs NiArNjEyLDE1IEBAIFRFU1RfRihVUkxQYXJzZXJUZXN0LCBQYXJzZXJEaWZmZXJlbmNlcykKICAg ICBjaGVja1JlbGF0aXZlVVJMRGlmZmVyZW5jZXMoImh0dHBzOi8vQHRlc3RAdGVzdEBleGFtcGxl OjgwMC8iLCAiaHR0cDovL2RvZXNub3RtYXR0ZXIvIiwKICAgICAgICAgeyJodHRwcyIsICJAdGVz dEB0ZXN0IiwgIiIsICJleGFtcGxlIiwgODAwLCAiLyIsICIiLCAiIiwgImh0dHBzOi8vJTQwdGVz dCU0MHRlc3RAZXhhbXBsZTo4MDAvIn0sCiAgICAgICAgIHsiIiwgIiIsICIiLCAiIiwgMCwgIiIs ICIiLCAiIiwgImh0dHBzOi8vQHRlc3RAdGVzdEBleGFtcGxlOjgwMC8ifSk7CisgICAgY2hlY2tS ZWxhdGl2ZVVSTERpZmZlcmVuY2VzKCJodHRwczovL0B0ZXN0QHRlc3RAZXhhbXBsZTo4MDAvcGF0 aEBlbmQiLCAiaHR0cDovL2RvZXNub3RtYXR0ZXIvIiwKKyAgICAgICAgeyJodHRwcyIsICJAdGVz dEB0ZXN0IiwgIiIsICJleGFtcGxlIiwgODAwLCAiL3BhdGhAZW5kIiwgIiIsICIiLCAiaHR0cHM6 Ly8lNDB0ZXN0JTQwdGVzdEBleGFtcGxlOjgwMC9wYXRoQGVuZCJ9LAorICAgICAgICB7IiIsICIi LCAiIiwgIiIsIDAsICIiLCAiIiwgIiIsICJodHRwczovL0B0ZXN0QHRlc3RAZXhhbXBsZTo4MDAv cGF0aEBlbmQifSk7CisgICAgY2hlY2tVUkxEaWZmZXJlbmNlcygibm90c3BlY2lhbDovL0B0ZXN0 QHRlc3RAZXhhbXBsZTo4MDAvcGF0aEBlbmQiLAorICAgICAgICB7Im5vdHNwZWNpYWwiLCAiQHRl c3RAdGVzdCIsICIiLCAiZXhhbXBsZSIsIDgwMCwgIi9wYXRoQGVuZCIsICIiLCAiIiwgIm5vdHNw ZWNpYWw6Ly8lNDB0ZXN0JTQwdGVzdEBleGFtcGxlOjgwMC9wYXRoQGVuZCJ9LAorICAgICAgICB7 IiIsICIiLCAiIiwgIiIsIDAsICIiLCAiIiwgIiIsICJub3RzcGVjaWFsOi8vQHRlc3RAdGVzdEBl eGFtcGxlOjgwMC9wYXRoQGVuZCJ9KTsKKyAgICBjaGVja1VSTERpZmZlcmVuY2VzKCJub3RzcGVj aWFsOi8vQHRlc3RAdGVzdEBleGFtcGxlOjgwMFxccGF0aEBlbmQiLAorICAgICAgICB7Im5vdHNw ZWNpYWwiLCAiQHRlc3RAdGVzdEBleGFtcGxlIiwgIjgwMFxccGF0aCIsICJlbmQiLCAwLCAiLyIs ICIiLCAiIiwgIm5vdHNwZWNpYWw6Ly8lNDB0ZXN0JTQwdGVzdCU0MGV4YW1wbGU6ODAwJTVDcGF0 aEBlbmQvIn0sCisgICAgICAgIHsiIiwgIiIsICIiLCAiIiwgMCwgIiIsICIiLCAiIiwgIm5vdHNw ZWNpYWw6Ly9AdGVzdEB0ZXN0QGV4YW1wbGU6ODAwXFxwYXRoQGVuZCJ9KTsKICAgICBjaGVja1Jl bGF0aXZlVVJMRGlmZmVyZW5jZXMoImZvbzovLyIsICJodHRwOi8vZXhhbXBsZS5vcmcvZm9vL2Jh ciIsCiAgICAgICAgIHsiZm9vIiwgIiIsICIiLCAiIiwgMCwgIi8iLCAiIiwgIiIsICJmb286Ly8v In0sCiAgICAgICAgIHsiZm9vIiwgIiIsICIiLCAiIiwgMCwgIi8vIiwgIiIsICIiLCAiZm9vOi8v In0pOwo=