162633 2016-09-27 14:16:28 -0700 Update style guide for #pragma once 2016-09-27 21:37:52 -0700 1 1 1 Unclassified WebKit WebKit Website WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck andersca commit-queue joepeck jond mitz timothy oldest_to_newest 1234073 0 joepeck 2016-09-27 14:16:28 -0700 Update style guide for #pragma once 1234074 1 290006 joepeck 2016-09-27 14:17:43 -0700 Created attachment 290006 [PATCH] Proposed Fix 1234075 2 joepeck 2016-09-27 14:18:42 -0700 As discussed on webkit-dev: https://lists.webkit.org/pipermail/webkit-dev/2016-March/thread.html#28058 1234110 3 290006 mitz 2016-09-27 16:10:10 -0700 Comment on attachment 290006 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=290006&action=review > Websites/webkit.org/code-style.md:698 > +[](#names-header-guards) Use `#pragma once` instead of `#define` and `#ifdef` for header guards. Should the anchor name change to something else? Does the style-checking script reference this anchor? 1234113 4 290006 joepeck 2016-09-27 16:19:43 -0700 Comment on attachment 290006 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=290006&action=review >> Websites/webkit.org/code-style.md:698 >> +[](#names-header-guards) Use `#pragma once` instead of `#define` and `#ifdef` for header guards. > > Should the anchor name change to something else? Does the style-checking script reference this anchor? We can change this, there are no references in WebKit to this anchor. 1234116 5 290019 joepeck 2016-09-27 16:22:52 -0700 Created attachment 290019 [PATCH] Proposed Fix 1234249 6 290019 commit-queue 2016-09-27 21:37:48 -0700 Comment on attachment 290019 [PATCH] Proposed Fix Clearing flags on attachment: 290019 Committed r206495: <http://trac.webkit.org/changeset/206495> 1234250 7 commit-queue 2016-09-27 21:37:52 -0700 All reviewed patches have been landed. Closing bug. 290006 2016-09-27 14:17:43 -0700 2016-09-27 16:22:52 -0700 [PATCH] Proposed Fix style-guide-1.patch text/plain 2479 joepeck ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvd2Vi a2l0Lm9yZy9DaGFuZ2VMb2cKaW5kZXggMjAxNjkxOS4uNDU2ZWJmOSAxMDA2NDQKLS0tIGEvV2Vi c2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNi0wOS0yNyAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBzdHlsZSBndWlkZSBmb3IgI3ByYWdt YSBvbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjI2MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGNvZGUtc3R5bGUubWQ6CisgICAgICAgIFVwZGF0ZSBzdHlsZSBndWlkZSBmb3IgI3ByYWdtYSBv bmNlIGFzIGRpc2N1c3NlZCBvbiB3ZWJraXQtZGV2LgorCiAyMDE2LTA5LTIxICBGaWxpcCBQaXps byAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgRmVuY2Ugb3Bjb2RlIHRvIEIz CmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQub3JnL2NvZGUtc3R5bGUubWQgYi9XZWJzaXRl cy93ZWJraXQub3JnL2NvZGUtc3R5bGUubWQKaW5kZXggZDhkZjhiOS4uY2RhYWQ5ZSAxMDA2NDQK LS0tIGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RlLXN0eWxlLm1kCisrKyBiL1dlYnNpdGVzL3dl YmtpdC5vcmcvY29kZS1zdHlsZS5tZApAQCAtMTE0LDggKzExNCw4IEBAIHN3aXRjaCAoY29uZGl0 aW9uKSB7CiAKIGBgYGNwcAogcmV0dXJuIGF0dHJpYnV0ZS5uYW1lKCkgPT0gc3JjQXR0cgotICAg ICAgICB8fCBhdHRyaWJ1dGUubmFtZSgpID09IGxvd3NyY0F0dHIKLSAgICAgICAgfHwgKGF0dHJp YnV0ZS5uYW1lKCkgPT0gdXNlbWFwQXR0ciAmJiBhdHRyaWJ1dGUudmFsdWUoKS5zdHJpbmcoKVsw XSAhPSAnIycpOworICAgIHx8IGF0dHJpYnV0ZS5uYW1lKCkgPT0gbG93c3JjQXR0cgorICAgIHx8 IChhdHRyaWJ1dGUubmFtZSgpID09IHVzZW1hcEF0dHIgJiYgYXR0cmlidXRlLnZhbHVlKCkuc3Ry aW5nKClbMF0gIT0gJyMnKTsKIGBgYAogCiAKQEAgLTEyMyw4ICsxMjMsOCBAQCByZXR1cm4gYXR0 cmlidXRlLm5hbWUoKSA9PSBzcmNBdHRyCiAKIGBgYGNwcAogcmV0dXJuIGF0dHJpYnV0ZS5uYW1l KCkgPT0gc3JjQXR0ciB8fAotICAgICAgICBhdHRyaWJ1dGUubmFtZSgpID09IGxvd3NyY0F0dHIg fHwKLSAgICAgICAgKGF0dHJpYnV0ZS5uYW1lKCkgPT0gdXNlbWFwQXR0ciAmJiBhdHRyLT52YWx1 ZSgpLnN0cmluZygpWzBdICE9ICcjJyk7CisgICAgYXR0cmlidXRlLm5hbWUoKSA9PSBsb3dzcmNB dHRyIHx8CisgICAgKGF0dHJpYnV0ZS5uYW1lKCkgPT0gdXNlbWFwQXR0ciAmJiBhdHRyLT52YWx1 ZSgpLnN0cmluZygpWzBdICE9ICcjJyk7CiBgYGAKIAogCkBAIC02OTUsMjQgKzY5NSwyMyBAQCBz ZXRSZXNpemFibGUoTm90UmVzaXphYmxlKTsKICAgICAgICAgTlNMb2NhbGl6ZWRTdHJpbmcoQCJT dG9wIiwgQCJTdG9wIGJ1dHRvbiB0aXRsZSIpCiBgYGAKIAotW10oI25hbWVzLWhlYWRlci1ndWFy ZHMpIGAjZGVmaW5lYCwgYCNpZmRlZmAgImhlYWRlciBndWFyZHMiIHNob3VsZCBiZSBuYW1lZCBl eGFjdGx5IHRoZSBzYW1lIGFzIHRoZSBmaWxlIChpbmNsdWRpbmcgY2FzZSksIHJlcGxhY2luZyB0 aGUgYC5gIHdpdGggYSBgX2AuCitbXSgjbmFtZXMtaGVhZGVyLWd1YXJkcykgVXNlIGAjcHJhZ21h IG9uY2VgIGluc3RlYWQgb2YgYCNkZWZpbmVgIGFuZCBgI2lmZGVmYCBmb3IgaGVhZGVyIGd1YXJk cy4KIAogIyMjIyMjIFJpZ2h0OgogCiBgYGBjcHAKIC8vIEhUTUxEb2N1bWVudC5oCisjcHJhZ21h IG9uY2UKK2BgYAorCisjIyMjIyMgV3Jvbmc6CisKK2BgYGNwcAorLy8gSFRNTERvY3VtZW50LmgK ICNpZm5kZWYgSFRNTERvY3VtZW50X2gKICNkZWZpbmUgSFRNTERvY3VtZW50X2gKIGBgYAogCi0j IyMjIyMgV3Jvbmc6Ci0KLWBgYGNwcAotLy8gSFRNTERvY3VtZW50LmgKLSNpZm5kZWYgX0hUTUxf RE9DVU1FTlRfSF8KLSNkZWZpbmUgX0hUTUxfRE9DVU1FTlRfSF8KLWBgYAotCiBbXSgjbmFtZXMt cHJvdGVjdG9ycy10aGlzKSBSZWYgYW5kIFJlZlB0ciBvYmplY3RzIG1lYW50IHRvIHByb3RlY3Qg YHRoaXNgIGZyb20gZGVsZXRpb24gc2hvdWxkIGJlIG5hbWVkICJwcm90ZWN0ZWRUaGlzIi4KIAog IyMjIyMjIFJpZ2h0OgpAQCAtNzkxLDcgKzc5MCw3IEBAIE15T3RoZXJDbGFzczo6TXlPdGhlckNs YXNzKCkgOiBNeVN1cGVyQ2xhc3MoKSB7fQogCiBgYGBjcHAKIGZvciAoYXV0byYgZnJhbWVWaWV3 IDogZnJhbWVWaWV3cykKLSAgICAgICAgZnJhbWVWaWV3LT51cGRhdGVMYXlvdXRBbmRTdHlsZUlm TmVlZGVkUmVjdXJzaXZlKCk7CisgICAgZnJhbWVWaWV3LT51cGRhdGVMYXlvdXRBbmRTdHlsZUlm TmVlZGVkUmVjdXJzaXZlKCk7CiBgYGAKIAogCg== 290019 2016-09-27 16:22:52 -0700 2016-09-27 21:37:48 -0700 [PATCH] Proposed Fix style-guide-2.patch text/plain 2473 joepeck ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvd2Vi a2l0Lm9yZy9DaGFuZ2VMb2cKaW5kZXggMjAxNjkxOS4uNDU2ZWJmOSAxMDA2NDQKLS0tIGEvV2Vi c2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNi0wOS0yNyAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBzdHlsZSBndWlkZSBmb3IgI3ByYWdt YSBvbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjI2MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGNvZGUtc3R5bGUubWQ6CisgICAgICAgIFVwZGF0ZSBzdHlsZSBndWlkZSBmb3IgI3ByYWdtYSBv bmNlIGFzIGRpc2N1c3NlZCBvbiB3ZWJraXQtZGV2LgorCiAyMDE2LTA5LTIxICBGaWxpcCBQaXps byAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgRmVuY2Ugb3Bjb2RlIHRvIEIz CmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQub3JnL2NvZGUtc3R5bGUubWQgYi9XZWJzaXRl cy93ZWJraXQub3JnL2NvZGUtc3R5bGUubWQKaW5kZXggZDhkZjhiOS4uZDdjODYyMiAxMDA2NDQK LS0tIGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RlLXN0eWxlLm1kCisrKyBiL1dlYnNpdGVzL3dl YmtpdC5vcmcvY29kZS1zdHlsZS5tZApAQCAtMTE0LDggKzExNCw4IEBAIHN3aXRjaCAoY29uZGl0 aW9uKSB7CiAKIGBgYGNwcAogcmV0dXJuIGF0dHJpYnV0ZS5uYW1lKCkgPT0gc3JjQXR0cgotICAg ICAgICB8fCBhdHRyaWJ1dGUubmFtZSgpID09IGxvd3NyY0F0dHIKLSAgICAgICAgfHwgKGF0dHJp YnV0ZS5uYW1lKCkgPT0gdXNlbWFwQXR0ciAmJiBhdHRyaWJ1dGUudmFsdWUoKS5zdHJpbmcoKVsw XSAhPSAnIycpOworICAgIHx8IGF0dHJpYnV0ZS5uYW1lKCkgPT0gbG93c3JjQXR0cgorICAgIHx8 IChhdHRyaWJ1dGUubmFtZSgpID09IHVzZW1hcEF0dHIgJiYgYXR0cmlidXRlLnZhbHVlKCkuc3Ry aW5nKClbMF0gIT0gJyMnKTsKIGBgYAogCiAKQEAgLTEyMyw4ICsxMjMsOCBAQCByZXR1cm4gYXR0 cmlidXRlLm5hbWUoKSA9PSBzcmNBdHRyCiAKIGBgYGNwcAogcmV0dXJuIGF0dHJpYnV0ZS5uYW1l KCkgPT0gc3JjQXR0ciB8fAotICAgICAgICBhdHRyaWJ1dGUubmFtZSgpID09IGxvd3NyY0F0dHIg fHwKLSAgICAgICAgKGF0dHJpYnV0ZS5uYW1lKCkgPT0gdXNlbWFwQXR0ciAmJiBhdHRyLT52YWx1 ZSgpLnN0cmluZygpWzBdICE9ICcjJyk7CisgICAgYXR0cmlidXRlLm5hbWUoKSA9PSBsb3dzcmNB dHRyIHx8CisgICAgKGF0dHJpYnV0ZS5uYW1lKCkgPT0gdXNlbWFwQXR0ciAmJiBhdHRyLT52YWx1 ZSgpLnN0cmluZygpWzBdICE9ICcjJyk7CiBgYGAKIAogCkBAIC02OTUsMjQgKzY5NSwyMyBAQCBz ZXRSZXNpemFibGUoTm90UmVzaXphYmxlKTsKICAgICAgICAgTlNMb2NhbGl6ZWRTdHJpbmcoQCJT dG9wIiwgQCJTdG9wIGJ1dHRvbiB0aXRsZSIpCiBgYGAKIAotW10oI25hbWVzLWhlYWRlci1ndWFy ZHMpIGAjZGVmaW5lYCwgYCNpZmRlZmAgImhlYWRlciBndWFyZHMiIHNob3VsZCBiZSBuYW1lZCBl eGFjdGx5IHRoZSBzYW1lIGFzIHRoZSBmaWxlIChpbmNsdWRpbmcgY2FzZSksIHJlcGxhY2luZyB0 aGUgYC5gIHdpdGggYSBgX2AuCitbXSgjaGVhZGVyLWd1YXJkcykgVXNlIGAjcHJhZ21hIG9uY2Vg IGluc3RlYWQgb2YgYCNkZWZpbmVgIGFuZCBgI2lmZGVmYCBmb3IgaGVhZGVyIGd1YXJkcy4KIAog IyMjIyMjIFJpZ2h0OgogCiBgYGBjcHAKIC8vIEhUTUxEb2N1bWVudC5oCisjcHJhZ21hIG9uY2UK K2BgYAorCisjIyMjIyMgV3Jvbmc6CisKK2BgYGNwcAorLy8gSFRNTERvY3VtZW50LmgKICNpZm5k ZWYgSFRNTERvY3VtZW50X2gKICNkZWZpbmUgSFRNTERvY3VtZW50X2gKIGBgYAogCi0jIyMjIyMg V3Jvbmc6Ci0KLWBgYGNwcAotLy8gSFRNTERvY3VtZW50LmgKLSNpZm5kZWYgX0hUTUxfRE9DVU1F TlRfSF8KLSNkZWZpbmUgX0hUTUxfRE9DVU1FTlRfSF8KLWBgYAotCiBbXSgjbmFtZXMtcHJvdGVj dG9ycy10aGlzKSBSZWYgYW5kIFJlZlB0ciBvYmplY3RzIG1lYW50IHRvIHByb3RlY3QgYHRoaXNg IGZyb20gZGVsZXRpb24gc2hvdWxkIGJlIG5hbWVkICJwcm90ZWN0ZWRUaGlzIi4KIAogIyMjIyMj IFJpZ2h0OgpAQCAtNzkxLDcgKzc5MCw3IEBAIE15T3RoZXJDbGFzczo6TXlPdGhlckNsYXNzKCkg OiBNeVN1cGVyQ2xhc3MoKSB7fQogCiBgYGBjcHAKIGZvciAoYXV0byYgZnJhbWVWaWV3IDogZnJh bWVWaWV3cykKLSAgICAgICAgZnJhbWVWaWV3LT51cGRhdGVMYXlvdXRBbmRTdHlsZUlmTmVlZGVk UmVjdXJzaXZlKCk7CisgICAgZnJhbWVWaWV3LT51cGRhdGVMYXlvdXRBbmRTdHlsZUlmTmVlZGVk UmVjdXJzaXZlKCk7CiBgYGAKIAogCg==