162614 2016-09-27 08:30:11 -0700 [GTK] Simplify platformForUAString 2016-09-28 05:57:15 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 142074 1 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro oldest_to_newest 1233864 0 mcatanzaro 2016-09-27 08:30:11 -0700 It's not possible to build WebKitGTK+ on Windows, this code is all dead. Not looking likely that this will change anytime soon. It's slightly broken currently (the UA includes two semicolons in a row). This code can always be restored later if adding Windows support. 1233875 1 mcatanzaro 2016-09-27 08:52:59 -0700 Also DirectFB is silly. And we have to claim to be X11 no matter what, as websites expect it. The only time we should risk not including X11 is when running on a Mac, and I'm not even sure about that. 1233877 2 289948 mcatanzaro 2016-09-27 08:55:16 -0700 Created attachment 289948 Patch 1234354 3 289948 commit-queue 2016-09-28 05:57:12 -0700 Comment on attachment 289948 Patch Clearing flags on attachment: 289948 Committed r206513: <http://trac.webkit.org/changeset/206513> 1234355 4 commit-queue 2016-09-28 05:57:15 -0700 All reviewed patches have been landed. Closing bug. 289948 2016-09-27 08:55:16 -0700 2016-09-28 05:57:12 -0700 Patch bug-162614-20160927175217.patch text/plain 1704 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWM3ZjNmZTQyZjcxNzI1 OGQ2YTRkMTY0YjNmZWI3Yjk0YWQ4NjI4MC4uMDlmMjk5NWY2ZTIyZmE4NjQ3NzNhNDMxNTI0MjJk OTM2NjhhMzU3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTA5LTI3ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBT aW1wbGlmeSBwbGF0Zm9ybUZvclVBU3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI2MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBOb3RlIGluIHBhcnRpY3VsYXIgdGhhdCB0aGUgcHJldmlvdXMg UExBVEZPUk0oTUFDKSBjaGVjayB3YXMgd3JvbmcgaGVyZSwgYXMgdGhhdCBpcyBuZXZlcgorICAg ICAgICB0cnVlIGZvciBHVEs7IHRoaXMgcGF0Y2ggcmlza3MgY2hhbmdpbmcgaXQgdG8gT1MoTUFD X09TX1gpLCBvbiB0aGUgaG9wZSB0aGF0IGFkdmVydGlzaW5nIE1hYworICAgICAgICB3aGVuIHJ1 bm5pbmcgb24gTWFjIG1pZ2h0IG5vdCBicmVhayBhbnl0aGluZy4gSWYgaXQgZG9lcywgdGhlbiB3 ZSBzaG91bGQgcmVtb3ZlIGl0IGFuZCBqdXN0CisgICAgICAgIGFsd2F5cyBwcmV0ZW5kIHRvIGJl IG9uIFgxMS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6cGxhdGZvcm1Gb3JVQVN0cmluZyk6CisKKzIwMTYtMDktMjcgIE1pY2hh ZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFVucmV2aWV3 ZWQgdHlwbyBmaXgKIAogICAgICAgICAqIHBsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwOgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcAppbmRleCA3NDNl YmEwMDExY2NiNTQ4NGZmNmY2MzZiNjVlMmQ1ZWIyYWY3OTM4Li5mOWQ5ZmY3MmIwM2UxNTA1MzU4 YzVhOTFjZDdmMGJjYjcyNmNhNWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ndGsvVXNlckFnZW50R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv VXNlckFnZW50R3RrLmNwcApAQCAtODQsMTYgKzg0LDEwIEBAIHN0YXRpYyBjb25zdCBjaGFyKiBj cHVEZXNjcmlwdGlvbkZvclVBU3RyaW5nKCkKIAogc3RhdGljIGNvbnN0IGNoYXIqIHBsYXRmb3Jt Rm9yVUFTdHJpbmcoKQogewotI2lmIFBMQVRGT1JNKFgxMSkKLSAgICByZXR1cm4gIlgxMSI7Ci0j ZWxpZiBPUyhXSU5ET1dTKQotICAgIHJldHVybiAiIjsKLSNlbGlmIFBMQVRGT1JNKE1BQykKKyNp ZiBPUyhNQUNfT1NfWCkKICAgICByZXR1cm4gIk1hY2ludG9zaCI7Ci0jZWxpZiBkZWZpbmVkKEdE S19XSU5ET1dJTkdfRElSRUNURkIpCi0gICAgcmV0dXJuICJEaXJlY3RGQiI7CiAjZWxzZQotICAg IHJldHVybiAiVW5rbm93biI7CisgICAgcmV0dXJuICJYMTEiOwogI2VuZGlmCiB9CiAK