162609 2016-09-27 06:42:13 -0700 [cmake] Simplify Clang checks and prepare for compiler ID split 2016-09-27 09:04:35 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen achristensen commit-queue gyuyoung.kim lforschler mcatanzaro oldest_to_newest 1233838 0 annulen 2016-09-27 06:42:13 -0700 CMake 3.x introduces separate compiler id for AppleClang, making condition if (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang") inappropriate as a test for any clang version. Introduce COMPILER_IS_CLANG instead, which is also shorter that CMAKE_CXX_COMPILER_ID comparison. 1233842 1 289939 annulen 2016-09-27 06:45:38 -0700 Created attachment 289939 Patch 1233883 2 289939 commit-queue 2016-09-27 09:04:31 -0700 Comment on attachment 289939 Patch Clearing flags on attachment: 289939 Committed r206437: <http://trac.webkit.org/changeset/206437> 1233884 3 commit-queue 2016-09-27 09:04:35 -0700 All reviewed patches have been landed. Closing bug. 289939 2016-09-27 06:45:38 -0700 2016-09-27 09:04:31 -0700 Patch bug-162609-20160927164239.patch text/plain 5387 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9ndGVzdC9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtlTGlz dHMudHh0CmluZGV4IGNlYTM1NmYxZWRiODdkZmFmMDVmMWVhNTE5MmM3MGViNmUyMGY5YjMuLjUx YzhmOTFjYTdjYzFiMTY3ZjVkYmI5NDliZjdjNmMxN2I4MGNkZmUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5 L2d0ZXN0L0NNYWtlTGlzdHMudHh0CkBAIC0zOSw3ICszOSw3IEBAIGFkZF9kZWZpbml0aW9ucygt REdURVNUX0hBU19SVFRJPTApCiAKICMgRklYTUU6IFRoaXMgd29ya3MgYXJvdW5kIGNvbXBhdGli aWxpdHkgcHJvYmxlbXMgaW4gdGhlIG9sZCB2ZXJzaW9uIG9mIHRoZSB0aGlyZC1wYXJ5CiAjIGdv b2dsZXRlc3Qgc291cmNlIGNvZGUgY2hlY2tvdXQuIEl0IHNob3VsZCBiZSByZW1vdmVkIG9uY2Ug d2UgdXBncmFkZSB0byBhIG5ld2VyIHZlcnNpb24uCi1pZiAoIiR7Q01BS0VfQ1hYX0NPTVBJTEVS X0lEfSIgU1RSRVFVQUwgIkNsYW5nIikKK2lmIChDT01QSUxFUl9JU19DTEFORykKICAgICBhZGRf ZGVmaW5pdGlvbnMoLURHVEVTVF9IQVNfVFIxX1RVUExFPTApCiBlbmRpZiAoKQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtl TGlzdHMudHh0CmluZGV4IGFmMTU3Y2Y3ZDhhNWFlMTUxY2E3MWYzMWVmZGQ2ZGM4ZDJiMWQzMjQu LjQ3NmQxMjcyN2UzZjM0YjJiZTYzZTdjNGU2ZmRmMWQxNGY1OWI4MGIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlz dHMudHh0CkBAIC0zODM5LDcgKzM4MzksNyBAQCBpZiAoRU5BQkxFX0dSQVBISUNTX0NPTlRFWFRf M0QgQU5EIE5PVCBXSU4zMikKICAgICBhZGRfbGlicmFyeShBTkdMRVN1cHBvcnQgU1RBVElDICR7 QU5HTEVTdXBwb3J0X1NPVVJDRVN9KQogCiAgICAgIyBTdXBwcmVzcyBudWxsIGNvbnZlcnNpb24g d2FybmluZ3MgZm9yIHNvdXJjZXMgaW4gU291cmNlL1RoaXJkUGFydHkvQU5HTEUKLSAgICBpZiAo IiR7Q01BS0VfQ1hYX0NPTVBJTEVSX0lEfSIgU1RSRVFVQUwgIkNsYW5nIikKKyAgICBpZiAoQ09N UElMRVJfSVNfQ0xBTkcpCiAgICAgICAgIEFERF9UQVJHRVRfUFJPUEVSVElFUyhBTkdMRVN1cHBv cnQgQ09NUElMRV9GTEFHUyAiLVduby1udWxsLWNvbnZlcnNpb24iKQogICAgIGVuZGlmICgpCiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlIGIvU291cmNlL2Nt YWtlL09wdGlvbnNDb21tb24uY21ha2UKaW5kZXggMDRiYWU2MmZjOGYzMjQxOTIxZmI3MWIyYzU2 YWM5YzJhY2NhNmM3Ny4uYzE3ZDVlYTlkYTlkMzgwMWI0OTliN2NlNTc4Yzc0ODJlNDEzY2JkZiAx MDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UKKysrIGIvU291cmNl L2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UKQEAgLTM1LDcgKzM1LDcgQEAgaWYgKENPTVBJTEVS X0lTX0dDQ19PUl9DTEFORykKICAgICBzZXQoQ01BS0VfQ1hYX0ZMQUdTICIke0NNQUtFX0NYWF9G TEFHU30gLXN0ZD1jKysxeSIpCiBlbmRpZiAoKQogCi1pZiAoIiR7Q01BS0VfQ1hYX0NPTVBJTEVS X0lEfSIgU1RSRVFVQUwgIkNsYW5nIiBBTkQgQ01BS0VfR0VORVJBVE9SIFNUUkVRVUFMICJOaW5q YSIpCitpZiAoQ09NUElMRVJfSVNfQ0xBTkcgQU5EIENNQUtFX0dFTkVSQVRPUiBTVFJFUVVBTCAi TmluamEiKQogICAgIHNldChDTUFLRV9DX0ZMQUdTICIke0NNQUtFX0NfRkxBR1N9IC1mY29sb3It ZGlhZ25vc3RpY3MiKQogICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdT fSAtZmNvbG9yLWRpYWdub3N0aWNzIikKIGVuZGlmICgpCkBAIC0xNTQsNyArMTU0LDcgQEAgaWYg KERFQlVHX0ZJU1NJT04pCiAgICAgc2V0KENNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1MgIiR7Q01B S0VfRVhFX0xJTktFUl9GTEFHU30gLVdsLC0tZ2RiLWluZGV4IikKIGVuZGlmICgpCiAKLWlmICgi JHtDTUFLRV9DWFhfQ09NUElMRVJfSUR9IiBTVFJFUVVBTCAiQ2xhbmciKQoraWYgKENPTVBJTEVS X0lTX0NMQU5HKQogICAgIHNldChDTUFLRV9DX0ZMQUdTICIke0NNQUtFX0NfRkxBR1N9IC1RdW51 c2VkLWFyZ3VtZW50cyIpCiAgICAgc2V0KENNQUtFX0NYWF9GTEFHUyAiJHtDTUFLRV9DWFhfRkxB R1N9IC1RdW51c2VkLWFyZ3VtZW50cyIpCiBlbmRpZiAoKQpkaWZmIC0tZ2l0IGEvU291cmNlL2Nt YWtlL09wdGlvbnNFZmwuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQppbmRl eCBkZjY0YTZmYjJjOGNiZWY0MmZkYWFlYjI0YTk1ZjYyNWQ5YWRjMjg4Li5iNmRjYTJmOGIyZmE0 ZGNhOGUzODQ3NWRhM2M0OWFkMjk0YjM2MTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQpAQCAtNyw3 ICs3LDcgQEAgc2V0KEVOQUJMRV9XRUJLSVQgT0ZGKQogc2V0KEVOQUJMRV9XRUJLSVQyIE9OKQog CiAjIEZJWE1FOiBEaXNhYmxlIFdFUlJPUiBpbiBjbGFuZyBidWlsZCBiZWNhdXNlIG9mIG1hbnkg d2FybmluZ3MuCi1pZiAoTk9UICIke0NNQUtFX0NYWF9DT01QSUxFUl9JRH0iIFNUUkVRVUFMICJD bGFuZyIpCitpZiAoQ01BS0VfQ09NUElMRVJfSVNfR05VQ1hYKQogICAgIHNldChBRERJVElPTkFM X0NPTVBJTEVSX0ZMQUdTIEVOQUJMRV9XRVJST1IgIi1Xbm8tZXJyb3I9bWlzc2luZy1maWVsZC1p bml0aWFsaXplcnMiKQogZW5kaWYgKCkKIApkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktp dEhlbHBlcnMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQppbmRleCBl ZjUzNTY1ODY3NWY1MWM2ZGNkZTgwZjQ5MjM2Y2U2OTI4NGNjZmM2Li4zOGZmYmQ1NDlmM2ZjOGQ0 M2VlYzg5ODk3YzY3ZDExNjU4OWIzMDFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 SGVscGVycy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQpAQCAt MTYsNyArMTYsNyBAQCBtYWNybyhXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTIF90YXJn ZXQpCiAgICAgICAgIGVuZGlmICgpCiAKICAgICAgICAgIyBTdXBwcmVzcyAtV3BhcmVudGhlc2Vz LWVxdWFsaXR5IHdhcm5pbmcgb2YgQ2xhbmcKLSAgICAgICAgaWYgKCIke0NNQUtFX0NYWF9DT01Q SUxFUl9JRH0iIFNUUkVRVUFMICJDbGFuZyIpCisgICAgICAgIGlmIChDT01QSUxFUl9JU19DTEFO RykKICAgICAgICAgICAgIHNldChPTERfQ09NUElMRV9GTEFHUyAiLVduby1wYXJlbnRoZXNlcy1l cXVhbGl0eSAke09MRF9DT01QSUxFX0ZMQUdTfSIpCiAgICAgICAgIGVuZGlmICgpCiAKZGlmZiAt LWdpdCBhL0NNYWtlTGlzdHMudHh0IGIvQ01ha2VMaXN0cy50eHQKaW5kZXggNmU3MzliMzJmYjdj Njg2MDU5NTAwN2I4OGVkYTIxNGVhYzhlOWRiMi4uNzlhMTdiYWNhMGRmNTMyOGU3YjNkMTE5NzJi YjZiN2I0N2UyZTZmYSAxMDA2NDQKLS0tIGEvQ01ha2VMaXN0cy50eHQKKysrIGIvQ01ha2VMaXN0 cy50eHQKQEAgLTQxLDcgKzQxLDExIEBAIHN0cmluZyhUT0xPV0VSICR7UE9SVH0gV0VCS0lUX1BP UlRfRElSKQogIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogIyBEZXRlcm1pbmUgdGhlIGNvbXBpbGVy CiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCi1pZiAoQ01BS0VfQ09NUElMRVJfSVNfR05VQ1hYIE9S ICR7Q01BS0VfQ1hYX0NPTVBJTEVSX0lEfSBTVFJFUVVBTCAiQ2xhbmciKQoraWYgKCR7Q01BS0Vf Q1hYX0NPTVBJTEVSX0lEfSBTVFJFUVVBTCAiQ2xhbmciIE9SICR7Q01BS0VfQ1hYX0NPTVBJTEVS X0lEfSBTVFJFUVVBTCAiQXBwbGVDbGFuZyIpCisgICAgc2V0KENPTVBJTEVSX0lTX0NMQU5HIE9O KQorZW5kaWYgKCkKKworaWYgKENNQUtFX0NPTVBJTEVSX0lTX0dOVUNYWCBPUiBDT01QSUxFUl9J U19DTEFORykKICAgICBzZXQoQ09NUElMRVJfSVNfR0NDX09SX0NMQU5HIE9OKQogZW5kaWYgKCkK IApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDRjZjRiYTQwMWI2MjM0 MDE4NmE2Yzk4Mzc3Mjc3ZGU0MmRiODdlNGQuLjgzZTU0OGFhYjJlZGFiODJjMTQyNzJlYzhiNWUx ZmZkZjcwY2YzNmMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMyBAQAogMjAxNi0wOS0yNyAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CiAKKyAgICAgICAgW2NtYWtlXSBTaW1wbGlmeSBDbGFuZyBjaGVja3MgYW5kIHByZXBh cmUgZm9yIGNvbXBpbGVyIElEIHNwbGl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjI2MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDTWFrZSAzLnggaW50cm9kdWNlcyBzZXBhcmF0ZSBjb21waWxlciBp ZCBmb3IgQXBwbGVDbGFuZywgbWFraW5nIGNvbmRpdGlvbgorICAgICAgICAoJHtDTUFLRV9DWFhf Q09NUElMRVJfSUR9IFNUUkVRVUFMICJDbGFuZyIpIGluYXBwcm9wcmlhdGUgYXMgY2hlY2sgZm9y CisgICAgICAgIGFueSBjbGFuZyB2ZXJzaW9uLiBJbnRyb2R1Y2UgQ09NUElMRVJfSVNfQ0xBTkcg aW5zdGVhZCwgd2hpY2ggaXMgYWxzbworICAgICAgICBzaG9ydGVyIHRoYXQgQ01BS0VfQ1hYX0NP TVBJTEVSX0lEIGNvbXBhcmlzb24uCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAgICAg ICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZToKKyAgICAgICAgKiBTb3VyY2Uv Y21ha2UvV2ViS2l0SGVscGVycy5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9u c0VmbC5jbWFrZTogVXNlIENNQUtFX0NPTVBJTEVSX0lTX0dOVUNYWCBpbnN0ZWFkIG9mCisgICAg ICAgICFDbGFuZyBjaGVjayBiZWNhdXNlIHRoaXMgaXMgd2hhdCB3YXMgcmVhbGx5IG1lYW50IGhl cmUuCisKKzIwMTYtMDktMjcgIEtvbnN0YW50aW4gVG9rYXJldiAgPGFubnVsZW5AeWFuZGV4LnJ1 PgorCiAgICAgICAgIFtjbWFrZV0gQWRkZWQgQ09NUElMRVJfSVNfR0NDX09SX0NMQU5HIHZhcmlh YmxlIHRvIHNpbXBsaWZ5IGNvbmRpdGlvbnMuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI2MDUKIAo=