162605 2016-09-27 04:49:59 -0700 [cmake] Added COMPILER_IS_GCC_OR_CLANG variable to simplify conditions. 2016-09-27 05:34:22 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen commit-queue lforschler mcatanzaro ossy oldest_to_newest 1233815 0 annulen 2016-09-27 04:49:59 -0700 Added COMPILER_IS_GCC_OR_CLANG variable to be used instead of (CMAKE_COMPILER_IS_GNUCXX OR ${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang") BTW, Clang detection will break when upgrading to CMake 3.0 as CMAKE_CXX_COMPILER_ID will become AppleClang for Clang supplied by Apple. This will be addressed in the following patch. 1233816 1 289934 annulen 2016-09-27 04:51:23 -0700 Created attachment 289934 Patch 1233821 2 289934 commit-queue 2016-09-27 05:34:18 -0700 Comment on attachment 289934 Patch Clearing flags on attachment: 289934 Committed r206430: <http://trac.webkit.org/changeset/206430> 1233822 3 commit-queue 2016-09-27 05:34:22 -0700 All reviewed patches have been landed. Closing bug. 289934 2016-09-27 04:51:23 -0700 2016-09-27 05:34:18 -0700 Patch bug-162605-20160927144824.patch text/plain 2997 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IGRhNzBhYjU5NzQ1Yzk5NzFhNjI5ZjczOTA5YjQzYzQ4NGI3ZjQ1YTcuLjA0YmFlNjJmYzhmMzI0 MTkyMWZiNzFiMmM1NmFjOWMyYWNjYTZjNzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0yOSw3ICsyOSw3IEBAIGVuZGlmICgpCiBzZXRfcHJvcGVydHkoR0xPQkFMIFBST1BFUlRZIFVT RV9GT0xERVJTIE9OKQogZGVmaW5lX3Byb3BlcnR5KFRBUkdFVCBQUk9QRVJUWSBGT0xERVIgSU5I RVJJVEVEIEJSSUVGX0RPQ1MgImZvbGRlciIgRlVMTF9ET0NTICJJREUgZm9sZGVyIG5hbWUiKQog Ci1pZiAoQ01BS0VfQ09NUElMRVJfSVNfR05VQ1hYIE9SICIke0NNQUtFX0NYWF9DT01QSUxFUl9J RH0iIFNUUkVRVUFMICJDbGFuZyIpCitpZiAoQ09NUElMRVJfSVNfR0NDX09SX0NMQU5HKQogICAg IHNldChDTUFLRV9DX0ZMQUdTX1JFTEVBU0UgIiR7Q01BS0VfQ19GTEFHU19SRUxFQVNFfSAtZm5v LWV4Y2VwdGlvbnMgLWZuby1zdHJpY3QtYWxpYXNpbmciKQogICAgIHNldChDTUFLRV9DWFhfRkxB R1NfUkVMRUFTRSAiJHtDTUFLRV9DWFhfRkxBR1NfUkVMRUFTRX0gLWZuby1leGNlcHRpb25zIC1m bm8tc3RyaWN0LWFsaWFzaW5nIC1mbm8tcnR0aSIpCiAgICAgc2V0KENNQUtFX0NYWF9GTEFHUyAi JHtDTUFLRV9DWFhfRkxBR1N9IC1zdGQ9YysrMXkiKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtl L1dlYktpdEhlbHBlcnMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQpp bmRleCAwZGI3ODI2MzIwYmFjNjZkODM1ZDVhYTkzNDI2ODY4MDk0N2U0ZDY5Li5lZjUzNTY1ODY3 NWY1MWM2ZGNkZTgwZjQ5MjM2Y2U2OTI4NGNjZmM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Uv V2ViS2l0SGVscGVycy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFr ZQpAQCAtNCw3ICs0LDcgQEAgaW5jbHVkZShDTWFrZVBhcnNlQXJndW1lbnRzKQogbWFjcm8oV0VC S0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFHUyBfdGFyZ2V0KQogICAgIHNldChvcHRpb25zIEVO QUJMRV9XRVJST1IgSUdOT1JFQ1hYX1dBUk5JTkdTKQogICAgIENNQUtFX1BBUlNFX0FSR1VNRU5U UygiT1BUSU9OIiAiJHtvcHRpb25zfSIgIiIgIiIgJHtBUkdOfSkKLSAgICBpZiAoQ01BS0VfQ09N UElMRVJfSVNfR05VQ1hYIE9SICIke0NNQUtFX0NYWF9DT01QSUxFUl9JRH0iIFNUUkVRVUFMICJD bGFuZyIpCisgICAgaWYgKENPTVBJTEVSX0lTX0dDQ19PUl9DTEFORykKICAgICAgICAgZ2V0X3Rh cmdldF9wcm9wZXJ0eShPTERfQ09NUElMRV9GTEFHUyAke190YXJnZXR9IENPTVBJTEVfRkxBR1Mp CiAgICAgICAgIGlmICgke09MRF9DT01QSUxFX0ZMQUdTfSBTVFJFUVVBTCAiT0xEX0NPTVBJTEVf RkxBR1MtTk9URk9VTkQiKQogICAgICAgICAgICAgc2V0KE9MRF9DT01QSUxFX0ZMQUdTICIiKQpk aWZmIC0tZ2l0IGEvQ01ha2VMaXN0cy50eHQgYi9DTWFrZUxpc3RzLnR4dAppbmRleCAzODViZDVm MDFmMWNlZGZiMDAyYjc5OTNjMjAyZTUzOTBlYzk3OTMyLi42ZTczOWIzMmZiN2M2ODYwNTk1MDA3 Yjg4ZWRhMjE0ZWFjOGU5ZGIyIDEwMDY0NAotLS0gYS9DTWFrZUxpc3RzLnR4dAorKysgYi9DTWFr ZUxpc3RzLnR4dApAQCAtMzgsNiArMzgsMTMgQEAgZW5kaWYgKCkKIAogc3RyaW5nKFRPTE9XRVIg JHtQT1JUfSBXRUJLSVRfUE9SVF9ESVIpCiAKKyMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyMgRGV0 ZXJtaW5lIHRoZSBjb21waWxlcgorIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQoraWYgKENNQUtFX0NP TVBJTEVSX0lTX0dOVUNYWCBPUiAke0NNQUtFX0NYWF9DT01QSUxFUl9JRH0gU1RSRVFVQUwgIkNs YW5nIikKKyAgICBzZXQoQ09NUElMRVJfSVNfR0NDX09SX0NMQU5HIE9OKQorZW5kaWYgKCkKKwog IyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogIyBEZXRlcm1pbmUgdGhlIHRhcmdldCBwcm9jZXNzb3IK ICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxv ZwppbmRleCAyZWVlMWMxNjI1OTgyYTE1ODYzMzdiZDRmNDI1MGJhOWM4MGFiNTYxLi40Y2Y0YmE0 MDFiNjIzNDAxODZhNmM5ODM3NzI3N2RlNDJkYjg3ZTRkIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cK KysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDktMjcgIEtvbnN0YW50aW4g VG9rYXJldiAgPGFubnVsZW5AeWFuZGV4LnJ1PgorCisgICAgICAgIFtjbWFrZV0gQWRkZWQgQ09N UElMRVJfSVNfR0NDX09SX0NMQU5HIHZhcmlhYmxlIHRvIHNpbXBsaWZ5IGNvbmRpdGlvbnMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI2MDUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENNYWtlTGlz dHMudHh0OgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgorICAg ICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlOgorCiAyMDE2LTA5LTI2ICBE YW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgSU9TX1RF WFRfQVVUT1NJWklORyB0byBURVhUX0FVVE9TSVpJTkcK