162602 2016-09-27 03:13:55 -0700 [GTK] Install binaries to pkglibexecdir rather than bindir 2016-09-27 06:53:07 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro berto bugs-noreply commit-queue mcatanzaro oldest_to_newest 1233791 0 mcatanzaro 2016-09-27 03:13:55 -0700 We currently install MiniBrowser and jsc to bindir, which is problematic because it is not possible to parallel-install them. Need to fix this so that we can have parallel-installed GTK+ 3 and GTK+ 4 versions. 1233798 1 mcatanzaro 2016-09-27 03:29:09 -0700 Note that LIBEXEC_INSTALL_DIR and EXEC_INSTALL_DIR are the same on all ports except GTK, so this won't break anything for other ports. 1233799 2 289930 mcatanzaro 2016-09-27 03:33:17 -0700 Created attachment 289930 Patch 1233807 3 289930 cgarcia 2016-09-27 04:13:27 -0700 Comment on attachment 289930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289930&action=review > Source/JavaScriptCore/shell/CMakeLists.txt:36 > - install(TARGETS jsc DESTINATION "${EXEC_INSTALL_DIR}") > + install(TARGETS jsc DESTINATION "${LIBEXEC_INSTALL_DIR}") So, this makes jsc no longer available in path, not sure that's a problem though. > Tools/MiniBrowser/gtk/CMakeLists.txt:65 > -install(TARGETS MiniBrowser DESTINATION "${EXEC_INSTALL_DIR}") > +install(TARGETS MiniBrowser DESTINATION "${LIBEXEC_INSTALL_DIR}") Ditto. 1233819 4 mcatanzaro 2016-09-27 05:15:03 -0700 (In reply to comment #3) > So, this makes jsc no longer available in path It's intended, so that they can be parallel-installable. 1233843 5 289930 commit-queue 2016-09-27 06:53:03 -0700 Comment on attachment 289930 Patch Clearing flags on attachment: 289930 Committed r206434: <http://trac.webkit.org/changeset/206434> 1233844 6 commit-queue 2016-09-27 06:53:07 -0700 All reviewed patches have been landed. Closing bug. 289930 2016-09-27 03:33:17 -0700 2016-09-27 06:53:03 -0700 Patch bug-162602-20160927123018.patch text/plain 2535 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 ZmFjYTk1OGQ0YzdiMWViMWE1MjFiYjEwNjQwNDMxZTQ4NjVjOTRkLi5kYzJjMTkzNGIwNWYxZjM3 ODliNmNlOWQ0MTI2M2MxNjExNGY2MmVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEg KzEsMTQgQEAKKzIwMTYtMDktMjcgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIEluc3RhbGwgYmluYXJpZXMgdG8gcGtnbGliZXhlY2Rp ciByYXRoZXIgdGhhbiBiaW5kaXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MjYwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEluc3RhbGwganNjIHNoZWxsIHRvIExJQkVYRUNfSU5TVEFMTF9ESVIgcmF0 aGVyIHRoYW4gRVhFQ19JTlNUQUxMX0RJUi4KKworICAgICAgICBOb3RlIHRoZXNlIGxvY2F0aW9u cyBhcmUgdGhlIHNhbWUgb24gbm9uLUdUSyBwb3J0cy4KKworICAgICAgICAqIHNoZWxsL0NNYWtl TGlzdHMudHh0OgorCiA9PSBSb2xsZWQgb3ZlciB0byBDaGFuZ2VMb2ctMjAxNi0wOS0yNiA9PQpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3NoZWxsL0NNYWtlTGlzdHMudHh0IGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3NoZWxsL0NNYWtlTGlzdHMudHh0CmluZGV4IGY0ZTlhNzMy NGJmMjkyZDcyZTBkZWIyZTM4NDFlZTE5YjYwZmE1NjguLjE1NWM3OTc2NDQ0NjNmMGU0ODZmMjlh YWUxYmViMTkzODRlNTI4YTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9zaGVs bC9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvc2hlbGwvQ01ha2VM aXN0cy50eHQKQEAgLTMzLDcgKzMzLDcgQEAgaWYgKEpTQ19MSU5LX0ZMQUdTKQogZW5kaWYgKCkK IAogaWYgKFNIT1VMRF9JTlNUQUxMX0pTX1NIRUxMKQotICAgIGluc3RhbGwoVEFSR0VUUyBqc2Mg REVTVElOQVRJT04gIiR7RVhFQ19JTlNUQUxMX0RJUn0iKQorICAgIGluc3RhbGwoVEFSR0VUUyBq c2MgREVTVElOQVRJT04gIiR7TElCRVhFQ19JTlNUQUxMX0RJUn0iKQogZW5kaWYgKCkKIAogaWYg KFdJTjMyKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IDliNzU2YTdmNjE2ZTM0NGIxYWJhYzYxZGZlZDJhMWViODZmN2U0NGQuLjU0MTE0Y2VjZDI2 NGQ0YjJkYTIyNWVmYzdkY2JhMDA0ODNhZTZiZDkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNi0wOS0yNyAgTWlj aGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g SW5zdGFsbCBiaW5hcmllcyB0byBwa2dsaWJleGVjZGlyIHJhdGhlciB0aGFuIGJpbmRpcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNjAyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGFsbCBNaW5p QnJvd3NlciB0byBMSUJFWEVDX0lOU1RBTExfRElSIHJhdGhlciB0aGFuIEVYRUNfSU5TVEFMTF9E SVIuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvQ01ha2VMaXN0cy50eHQ6CisKIDIwMTYt MDktMjUgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUB3ZWJraXQub3JnPgogCiAgICAgICAg IFtFRkxdIEFkanVzdCBFRkwgaW5kZW50YXRpb24gdG8gRUZMIE1pbmlCcm93c2VyCmRpZmYgLS1n aXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQ01ha2VMaXN0cy50eHQgYi9Ub29scy9NaW5pQnJv d3Nlci9ndGsvQ01ha2VMaXN0cy50eHQKaW5kZXggMjZkMmJmOTU3YTc0OTBiMjVhNTFkZjAwZTA4 OGFiYTI4NGExYzljOS4uMDcwNGJjNjhlNjJkODI3ODVhZTg0MTY3NTg2YzhmNjZiOGU1NjFmMCAx MDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0NNYWtlTGlzdHMudHh0CisrKyBiL1Rv b2xzL01pbmlCcm93c2VyL2d0ay9DTWFrZUxpc3RzLnR4dApAQCAtNjIsNCArNjIsNCBAQCBpbmNs dWRlX2RpcmVjdG9yaWVzKFNZU1RFTSAke01pbmlCcm93c2VyX1NZU1RFTV9JTkNMVURFX0RJUkVD VE9SSUVTfSkKIGFkZF9leGVjdXRhYmxlKE1pbmlCcm93c2VyICR7TWluaUJyb3dzZXJfU09VUkNF U30pCiB0YXJnZXRfbGlua19saWJyYXJpZXMoTWluaUJyb3dzZXIgJHtNaW5pQnJvd3Nlcl9MSUJS QVJJRVN9KQogCi1pbnN0YWxsKFRBUkdFVFMgTWluaUJyb3dzZXIgREVTVElOQVRJT04gIiR7RVhF Q19JTlNUQUxMX0RJUn0iKQoraW5zdGFsbChUQVJHRVRTIE1pbmlCcm93c2VyIERFU1RJTkFUSU9O ICIke0xJQkVYRUNfSU5TVEFMTF9ESVJ9IikK