162601 2016-09-27 03:02:43 -0700 Clean-up CachedImage constructor 2016-09-27 07:34:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf cdumez commit-queue dbates japhet oldest_to_newest 1233788 0 youennf 2016-09-27 03:02:43 -0700 Some of CachedImage constructors are redundant/not used 1233790 1 289929 youennf 2016-09-27 03:07:51 -0700 Created attachment 289929 Patch 1233851 2 289929 commit-queue 2016-09-27 07:34:22 -0700 Comment on attachment 289929 Patch Clearing flags on attachment: 289929 Committed r206435: <http://trac.webkit.org/changeset/206435> 1233852 3 commit-queue 2016-09-27 07:34:26 -0700 All reviewed patches have been landed. Closing bug. 289929 2016-09-27 03:07:51 -0700 2016-09-27 07:34:22 -0700 Patch bug-162601-20160927120452.patch text/plain 5087 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWJkNzUzNTZhOTYxYmY3 ZjQxODcwNDMwOTkwMzVjNmEyYjhhOGIyMS4uN2FjM2ZjNGU4Y2I2YzFmNGQxYmZhNjNhNmU0Njgz YjBiY2U4YWQzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE2LTA5LTI3ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBDbGVhbi11cCBDYWNoZWRJ bWFnZSBjb25zdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTYyNjAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gY2hhbmdlIG9mIGJlaGF2aW9yLgorICAgICAgICBSZW1vdmluZyBhbiB1bnVz ZWQgY29uc3RydWN0b3IuCisgICAgICAgIFNwZWNpYWxpemluZyBvbmUgY29uc3RydWN0b3IgZm9y IG1hbnVhbGx5IGNhY2hlZCBpbWFnZXMuCisgICAgICAgIENsZWFuaW5nIGluaXRpYWxpemF0aW9u IG9mIHNvbWUgQ2FjaGVkSW1hZ2UgZmllbGRzLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0Nh Y2hlZEltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZEltYWdlOjpDYWNoZWRJbWFn ZSk6CisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZEltYWdlLmg6CisgICAgICAgICogbG9h ZGVyL2NhY2hlL01lbW9yeUNhY2hlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lbW9yeUNhY2hl OjphZGRJbWFnZVRvQ2FjaGUpOgorCisyMDE2LTA5LTI3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5u QGFwcGxlLmNvbT4KKwogICAgICAgICBbRmV0Y2ggQVBJXSBVc2UgUmVmPGNvbnN0IFQ+IGluIEZl dGNoQm9keTo6bV9kYXRhIHZhcmlhbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2MjU5OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvY2FjaGUvQ2FjaGVkSW1hZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0Nh Y2hlZEltYWdlLmNwcAppbmRleCBkMGM5YTExMzMxNzJlZDdkZDNlNjdjOWRjN2E3MTBhMjEyNzZj OGFhLi40NmY5ZGQ0NzExNGY2NGUxYWJjNGJlNWIwYWUzY2ExZTFlYTNkNGE4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkSW1hZ2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRJbWFnZS5jcHAKQEAgLTU4LDkgKzU4LDYgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogCiBDYWNoZWRJbWFnZTo6Q2FjaGVkSW1hZ2UoQ2FjaGVkUmVz b3VyY2VSZXF1ZXN0JiYgcmVxdWVzdCwgU2Vzc2lvbklEIHNlc3Npb25JRCkKICAgICA6IENhY2hl ZFJlc291cmNlKFdURk1vdmUocmVxdWVzdCksIEltYWdlUmVzb3VyY2UsIHNlc3Npb25JRCkKLSAg ICAsIG1faW1hZ2UobnVsbHB0cikKLSAgICAsIG1faXNNYW51YWxseUNhY2hlZChmYWxzZSkKLSAg ICAsIG1fc2hvdWxkUGFpbnRCcm9rZW5JbWFnZSh0cnVlKQogewogICAgIHNldFN0YXR1cyhVbmtu b3duKTsKIH0KQEAgLTY4LDMzICs2NSwxNyBAQCBDYWNoZWRJbWFnZTo6Q2FjaGVkSW1hZ2UoQ2Fj aGVkUmVzb3VyY2VSZXF1ZXN0JiYgcmVxdWVzdCwgU2Vzc2lvbklEIHNlc3Npb25JRCkKIENhY2hl ZEltYWdlOjpDYWNoZWRJbWFnZShJbWFnZSogaW1hZ2UsIFNlc3Npb25JRCBzZXNzaW9uSUQpCiAg ICAgOiBDYWNoZWRSZXNvdXJjZShVUkwoKSwgSW1hZ2VSZXNvdXJjZSwgc2Vzc2lvbklEKQogICAg ICwgbV9pbWFnZShpbWFnZSkKLSAgICAsIG1faXNNYW51YWxseUNhY2hlZChmYWxzZSkKLSAgICAs IG1fc2hvdWxkUGFpbnRCcm9rZW5JbWFnZSh0cnVlKQogewogfQogCiBDYWNoZWRJbWFnZTo6Q2Fj aGVkSW1hZ2UoY29uc3QgVVJMJiB1cmwsIEltYWdlKiBpbWFnZSwgU2Vzc2lvbklEIHNlc3Npb25J RCkKICAgICA6IENhY2hlZFJlc291cmNlKHVybCwgSW1hZ2VSZXNvdXJjZSwgc2Vzc2lvbklEKQog ICAgICwgbV9pbWFnZShpbWFnZSkKLSAgICAsIG1faXNNYW51YWxseUNhY2hlZChmYWxzZSkKLSAg ICAsIG1fc2hvdWxkUGFpbnRCcm9rZW5JbWFnZSh0cnVlKQorICAgICwgbV9pc01hbnVhbGx5Q2Fj aGVkKHRydWUpCiB7Ci19Ci0KLUNhY2hlZEltYWdlOjpDYWNoZWRJbWFnZShjb25zdCBVUkwmIHVy bCwgSW1hZ2UqIGltYWdlLCBDYWNoZWRJbWFnZTo6Q2FjaGVCZWhhdmlvclR5cGUgdHlwZSwgU2Vz c2lvbklEIHNlc3Npb25JRCkKLSAgICA6IENhY2hlZFJlc291cmNlKHVybCwgSW1hZ2VSZXNvdXJj ZSwgc2Vzc2lvbklEKQotICAgICwgbV9pbWFnZShpbWFnZSkKLSAgICAsIG1faXNNYW51YWxseUNh Y2hlZCh0eXBlID09IENhY2hlZEltYWdlOjpNYW51YWxseUNhY2hlZCkKLSAgICAsIG1fc2hvdWxk UGFpbnRCcm9rZW5JbWFnZSh0cnVlKQotewotICAgIHNldFN0YXR1cyhDYWNoZWQpOwotICAgIHNl dExvYWRpbmcoZmFsc2UpOwotICAgIGlmIChVTkxJS0VMWShpc01hbnVhbGx5Q2FjaGVkKCkpKSB7 Ci0gICAgICAgIC8vIFVzZSB0aGUgaW5jb21pbmcgVVJMIGluIHRoZSByZXNwb25zZSBmaWVsZC4g VGhpcyBlbnN1cmVzIHRoYXQgY29kZQotICAgICAgICAvLyB1c2luZyB0aGUgcmVzcG9uc2UgZGly ZWN0bHksIHN1Y2ggYXMgb3JpZ2luIGNoZWNrcyBmb3Igc2VjdXJpdHksCi0gICAgICAgIC8vIGFj dHVhbGx5IHNlZSBzb21ldGhpbmcuCi0gICAgICAgIG1fcmVzcG9uc2Uuc2V0VVJMKHVybCk7Ci0g ICAgfQorICAgIC8vIFVzZSB0aGUgaW5jb21pbmcgVVJMIGluIHRoZSByZXNwb25zZSBmaWVsZC4g VGhpcyBlbnN1cmVzIHRoYXQgY29kZSB1c2luZyB0aGUgcmVzcG9uc2UgZGlyZWN0bHksCisgICAg Ly8gc3VjaCBhcyBvcmlnaW4gY2hlY2tzIGZvciBzZWN1cml0eSwgYWN0dWFsbHkgc2VlIHNvbWV0 aGluZy4KKyAgICBtX3Jlc3BvbnNlLnNldFVSTCh1cmwpOwogfQogCiBDYWNoZWRJbWFnZTo6fkNh Y2hlZEltYWdlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNo ZWRJbWFnZS5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZEltYWdlLmgKaW5k ZXggMDhkZWJiYTEwYTQyNjAxNzM1ZmI2MDMxOWY5NDhjYWYyNTIzMzkxMS4uOGU4MjM5NGRmYzI5 ZmU0MGE3MjY3ODIyMWUzNWI3YWU3OTU3MzJmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bG9hZGVyL2NhY2hlL0NhY2hlZEltYWdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2Nh Y2hlL0NhY2hlZEltYWdlLmgKQEAgLTQ4LDEyICs0OCwxMCBAQCBjbGFzcyBDYWNoZWRJbWFnZSBm aW5hbCA6IHB1YmxpYyBDYWNoZWRSZXNvdXJjZSwgcHVibGljIEltYWdlT2JzZXJ2ZXIgewogICAg IGZyaWVuZCBjbGFzcyBNZW1vcnlDYWNoZTsKIAogcHVibGljOgotICAgIGVudW0gQ2FjaGVCZWhh dmlvclR5cGUgeyBBdXRvbWF0aWNhbGx5Q2FjaGVkLCBNYW51YWxseUNhY2hlZCB9OwotCiAgICAg Q2FjaGVkSW1hZ2UoQ2FjaGVkUmVzb3VyY2VSZXF1ZXN0JiYsIFNlc3Npb25JRCk7CiAgICAgQ2Fj aGVkSW1hZ2UoSW1hZ2UqLCBTZXNzaW9uSUQpOworICAgIC8vIENvbnN0cnVjdG9yIHRvIHVzZSBm b3IgbWFudWFsbHkgY2FjaGVkIGltYWdlcy4KICAgICBDYWNoZWRJbWFnZShjb25zdCBVUkwmLCBJ bWFnZSosIFNlc3Npb25JRCk7Ci0gICAgQ2FjaGVkSW1hZ2UoY29uc3QgVVJMJiwgSW1hZ2UqLCBD YWNoZUJlaGF2aW9yVHlwZSwgU2Vzc2lvbklEKTsKICAgICB2aXJ0dWFsIH5DYWNoZWRJbWFnZSgp OwogCiAgICAgV0VCQ09SRV9FWFBPUlQgSW1hZ2UqIGltYWdlKCk7IC8vIFJldHVybnMgdGhlIG51 bGxJbWFnZSgpIGlmIHRoZSBpbWFnZSBpcyBub3QgYXZhaWxhYmxlIHlldC4KQEAgLTEzNiw4ICsx MzQsOCBAQCBwcml2YXRlOgogCiAgICAgUmVmUHRyPEltYWdlPiBtX2ltYWdlOwogICAgIHN0ZDo6 dW5pcXVlX3B0cjxTVkdJbWFnZUNhY2hlPiBtX3N2Z0ltYWdlQ2FjaGU7Ci0gICAgdW5zaWduZWQg bV9pc01hbnVhbGx5Q2FjaGVkIDogMTsKLSAgICB1bnNpZ25lZCBtX3Nob3VsZFBhaW50QnJva2Vu SW1hZ2UgOiAxOworICAgIGJvb2wgbV9pc01hbnVhbGx5Q2FjaGVkIHsgZmFsc2UgfTsKKyAgICBi b29sIG1fc2hvdWxkUGFpbnRCcm9rZW5JbWFnZSB7IHRydWUgfTsKIH07CiAKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9NZW1v cnlDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvTWVtb3J5Q2FjaGUuY3Bw CmluZGV4IDY5MzUwMWU0YjI5ZjZiODI5YTYyNTE4YTg1ZDg1MGIxZWYwNDZkZmMuLjYzMzM0YzVk NTYwODI4MDdlOWYxMjc1MzIwODBhODZkNWZmMTRiM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9jYWNoZS9NZW1vcnlDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL01lbW9yeUNhY2hlLmNwcApAQCAtMjIwLDcgKzIyMCw3IEBAIGJvb2wgTWVtb3J5 Q2FjaGU6OmFkZEltYWdlVG9DYWNoZShOYXRpdmVJbWFnZVB0ciYmIGltYWdlLCBjb25zdCBVUkwm IHVybCwgY29uc3QKICAgICBpZiAoIWJpdG1hcEltYWdlKQogICAgICAgICByZXR1cm4gZmFsc2U7 CiAKLSAgICBzdGQ6OnVuaXF1ZV9wdHI8Q2FjaGVkSW1hZ2U+IGNhY2hlZEltYWdlID0gc3RkOjpt YWtlX3VuaXF1ZTxDYWNoZWRJbWFnZT4odXJsLCBiaXRtYXBJbWFnZS5nZXQoKSwgQ2FjaGVkSW1h Z2U6Ok1hbnVhbGx5Q2FjaGVkLCBzZXNzaW9uSUQpOworICAgIGF1dG8gY2FjaGVkSW1hZ2UgPSBz dGQ6Om1ha2VfdW5pcXVlPENhY2hlZEltYWdlPih1cmwsIGJpdG1hcEltYWdlLmdldCgpLCBzZXNz aW9uSUQpOwogCiAgICAgY2FjaGVkSW1hZ2UtPmFkZENsaWVudCgmZHVtbXlDYWNoZWRJbWFnZUNs aWVudCgpKTsKICAgICBjYWNoZWRJbWFnZS0+c2V0RGVjb2RlZFNpemUoYml0bWFwSW1hZ2UtPmRl Y29kZWRTaXplKCkpOwo=