162597 2016-09-27 00:06:31 -0700 WKSharedAPICast should not warn about acceptable custom context menu tag values 2016-09-28 13:38:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck andersca commit-queue joepeck mitz thorton webkit-bug-importer oldest_to_newest 1233753 0 joepeck 2016-09-27 00:06:31 -0700 Summary: WKSharedAPICast should not warn about acceptable custom context menu tag values Steps to Reproduce: 1. Launch MiniBrowser in a Debug build 2. Open a WK2 window. 3. Right click, Inspect Element. 4. Right click on the <body> tag. => LOG_ERROR spew Output: ERROR: ContextMenuAction 5000 is an unknown tag but is below the allowable custom tag value of 10000 Source/WebKit2/Shared/API/c/WKSharedAPICast.h(511) : WKContextMenuItemTag WebKit::toAPI(WebCore::ContextMenuAction) ERROR: ContextMenuAction 5005 is an unknown tag but is below the allowable custom tag value of 10000 Source/WebKit2/Shared/API/c/WKSharedAPICast.h(511) : WKContextMenuItemTag WebKit::toAPI(WebCore::ContextMenuAction) ... 1233754 1 joepeck 2016-09-27 00:06:43 -0700 <rdar://problem/28487627> 1233757 2 289922 joepeck 2016-09-27 00:16:01 -0700 Created attachment 289922 [PATCH] Proposed Fix 1234245 3 290056 joepeck 2016-09-27 21:20:05 -0700 Created attachment 290056 [PATCH] Proposed Fix 1234510 4 290056 thorton 2016-09-28 13:16:28 -0700 Comment on attachment 290056 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=290056&action=review > Source/WebKit2/Shared/API/c/WKSharedAPICast.h:511 > + if (action < WebCore::ContextMenuItemBaseApplicationTag && !(action >= WebCore::ContextMenuItemBaseCustomTag && action <= WebCore::ContextMenuItemLastCustomTag)) > + LOG_ERROR("ContextMenuAction %i is an unknown tag but is below the allowable custom tag value of %i", action, WebCore::ContextMenuItemBaseApplicationTag); It's kind of weird that the naming in the error message disagrees with the naming in WebCore ("custom" vs. "application") 1234527 5 290056 commit-queue 2016-09-28 13:38:13 -0700 Comment on attachment 290056 [PATCH] Proposed Fix Clearing flags on attachment: 290056 Committed r206540: <http://trac.webkit.org/changeset/206540> 1234528 6 commit-queue 2016-09-28 13:38:17 -0700 All reviewed patches have been landed. Closing bug. 289922 2016-09-27 00:16:01 -0700 2016-09-27 21:20:05 -0700 [PATCH] Proposed Fix log-error-1.patch text/plain 2484 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3YWQzNjAwLi4yOWNiZjBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTYtMDktMjcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXS1NoYXJlZEFQSUNhc3Qgc2hvdWxkIG5vdCB3YXJuIGFib3V0IGFjY2VwdGFibGUg Y3VzdG9tIGNvbnRleHQgbWVudSB0YWcgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI1OTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI4 NDg3NjI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5oOgorICAgICAgICAoV2ViS2l0Ojp0b0FQ SSk6CisgICAgICAgIChXZWJLaXQ6OnRvSW1wbCk6CisgICAgICAgIERvbid0IGxvZyBhbiBlcnJv ciB3aGVuIGNhc3RpbmcgQ29udGV4dE1lbnUgdHlwZXMgaWYgaXQgaXMgd2l0aGluCisgICAgICAg IHRoZSBDdXN0b20gQ29udGV4dE1lbnUgdGFnIHJhbmdlLgorCiAyMDE2LTA5LTI2ICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gQmxvYkRvd25sb2FkQ2xp ZW50IHNob3VsZCB1c2UgYXN5bmNocm9ub3VzIElQQyB0byBkZWNpZGUgZGVzdGluYXRpb24gcGF0 aApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2Fz dC5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5oCmluZGV4 IGVjNDBkOGQuLmFiNzEwMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkv Yy9XS1NoYXJlZEFQSUNhc3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tT aGFyZWRBUElDYXN0LmgKQEAgLTUwNyw4ICs1MDcsOCBAQCBpbmxpbmUgV0tDb250ZXh0TWVudUl0 ZW1UYWcgdG9BUEkoV2ViQ29yZTo6Q29udGV4dE1lbnVBY3Rpb24gYWN0aW9uKQogICAgIGNhc2Ug V2ViQ29yZTo6Q29udGV4dE1lbnVJdGVtVGFnU2hhcmVNZW51OgogICAgICAgICByZXR1cm4ga1dL Q29udGV4dE1lbnVJdGVtVGFnU2hhcmVNZW51OwogICAgIGRlZmF1bHQ6Ci0gICAgICAgIGlmIChh Y3Rpb24gPCBXZWJDb3JlOjpDb250ZXh0TWVudUl0ZW1CYXNlQXBwbGljYXRpb25UYWcpCi0gICAg ICAgICAgICBMT0dfRVJST1IoIkNvbnRleHRNZW51QWN0aW9uICVpIGlzIGFuIHVua25vd24gdGFn IGJ1dCBpcyBiZWxvdyB0aGUgYWxsb3dhYmxlIGN1c3RvbSB0YWcgdmFsdWUgb2YgJWkiLCBhY3Rp b24sIFdlYkNvcmU6OiAgQ29udGV4dE1lbnVJdGVtQmFzZUFwcGxpY2F0aW9uVGFnKTsKKyAgICAg ICAgaWYgKGFjdGlvbiA8IGtXS0NvbnRleHRNZW51SXRlbUJhc2VBcHBsaWNhdGlvblRhZyAmJiAh KGFjdGlvbiA+PSBXZWJDb3JlOjpDb250ZXh0TWVudUl0ZW1CYXNlQ3VzdG9tVGFnICYmIGFjdGlv biA8PSBXZWJDb3JlOjpDb250ZXh0TWVudUl0ZW1MYXN0Q3VzdG9tVGFnKSkKKyAgICAgICAgICAg IExPR19FUlJPUigiQ29udGV4dE1lbnVBY3Rpb24gJWkgaXMgYW4gdW5rbm93biB0YWcgYnV0IGlz IGJlbG93IHRoZSBhbGxvd2FibGUgY3VzdG9tIHRhZyB2YWx1ZSBvZiAlaSIsIGFjdGlvbiwgV2Vi Q29yZTo6Q29udGV4dE1lbnVJdGVtQmFzZUFwcGxpY2F0aW9uVGFnKTsKICAgICAgICAgcmV0dXJu IHN0YXRpY19jYXN0PFdLQ29udGV4dE1lbnVJdGVtVGFnPihhY3Rpb24pOwogICAgIH0KIH0KQEAg LTcwMiw3ICs3MDIsNyBAQCBpbmxpbmUgV2ViQ29yZTo6Q29udGV4dE1lbnVBY3Rpb24gdG9JbXBs KFdLQ29udGV4dE1lbnVJdGVtVGFnIHRhZykKICNlbmRpZgogICAgIGNhc2Uga1dLQ29udGV4dE1l bnVJdGVtVGFnT3BlbkxpbmtJblRoaXNXaW5kb3c6CiAgICAgZGVmYXVsdDoKLSAgICAgICAgaWYg KHRhZyA8IGtXS0NvbnRleHRNZW51SXRlbUJhc2VBcHBsaWNhdGlvblRhZykKKyAgICAgICAgaWYg KHRhZyA8IGtXS0NvbnRleHRNZW51SXRlbUJhc2VBcHBsaWNhdGlvblRhZyAmJiAhKHRhZyA+PSBX ZWJDb3JlOjpDb250ZXh0TWVudUl0ZW1CYXNlQ3VzdG9tVGFnICYmIHRhZyA8PSBXZWJDb3JlOjpD b250ZXh0TWVudUl0ZW1MYXN0Q3VzdG9tVGFnKSkKICAgICAgICAgICAgIExPR19FUlJPUigiV0tD b250ZXh0TWVudUl0ZW1UYWcgJWkgaXMgYW4gdW5rbm93biB0YWcgYnV0IGlzIGJlbG93IHRoZSBh bGxvd2FibGUgY3VzdG9tIHRhZyB2YWx1ZSBvZiAlaSIsIHRhZywga1dLQ29udGV4dE1lbnVJdGVt QmFzZUFwcGxpY2F0aW9uVGFnKTsKICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFdlYkNvcmU6 OkNvbnRleHRNZW51QWN0aW9uPih0YWcpOwogICAgIH0K 290056 2016-09-27 21:20:05 -0700 2016-09-28 13:38:13 -0700 [PATCH] Proposed Fix log-error-2.patch text/plain 2490 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3YWQzNjAwLi4yOWNiZjBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTYtMDktMjcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXS1NoYXJlZEFQSUNhc3Qgc2hvdWxkIG5vdCB3YXJuIGFib3V0IGFjY2VwdGFibGUg Y3VzdG9tIGNvbnRleHQgbWVudSB0YWcgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI1OTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI4 NDg3NjI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5oOgorICAgICAgICAoV2ViS2l0Ojp0b0FQ SSk6CisgICAgICAgIChXZWJLaXQ6OnRvSW1wbCk6CisgICAgICAgIERvbid0IGxvZyBhbiBlcnJv ciB3aGVuIGNhc3RpbmcgQ29udGV4dE1lbnUgdHlwZXMgaWYgaXQgaXMgd2l0aGluCisgICAgICAg IHRoZSBDdXN0b20gQ29udGV4dE1lbnUgdGFnIHJhbmdlLgorCiAyMDE2LTA5LTI2ICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gQmxvYkRvd25sb2FkQ2xp ZW50IHNob3VsZCB1c2UgYXN5bmNocm9ub3VzIElQQyB0byBkZWNpZGUgZGVzdGluYXRpb24gcGF0 aApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2Fz dC5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5oCmluZGV4 IGVjNDBkOGQuLjg1MTZhMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkv Yy9XS1NoYXJlZEFQSUNhc3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tT aGFyZWRBUElDYXN0LmgKQEAgLTUwNyw4ICs1MDcsOCBAQCBpbmxpbmUgV0tDb250ZXh0TWVudUl0 ZW1UYWcgdG9BUEkoV2ViQ29yZTo6Q29udGV4dE1lbnVBY3Rpb24gYWN0aW9uKQogICAgIGNhc2Ug V2ViQ29yZTo6Q29udGV4dE1lbnVJdGVtVGFnU2hhcmVNZW51OgogICAgICAgICByZXR1cm4ga1dL Q29udGV4dE1lbnVJdGVtVGFnU2hhcmVNZW51OwogICAgIGRlZmF1bHQ6Ci0gICAgICAgIGlmIChh Y3Rpb24gPCBXZWJDb3JlOjpDb250ZXh0TWVudUl0ZW1CYXNlQXBwbGljYXRpb25UYWcpCi0gICAg ICAgICAgICBMT0dfRVJST1IoIkNvbnRleHRNZW51QWN0aW9uICVpIGlzIGFuIHVua25vd24gdGFn IGJ1dCBpcyBiZWxvdyB0aGUgYWxsb3dhYmxlIGN1c3RvbSB0YWcgdmFsdWUgb2YgJWkiLCBhY3Rp b24sIFdlYkNvcmU6OiAgQ29udGV4dE1lbnVJdGVtQmFzZUFwcGxpY2F0aW9uVGFnKTsKKyAgICAg ICAgaWYgKGFjdGlvbiA8IFdlYkNvcmU6OkNvbnRleHRNZW51SXRlbUJhc2VBcHBsaWNhdGlvblRh ZyAmJiAhKGFjdGlvbiA+PSBXZWJDb3JlOjpDb250ZXh0TWVudUl0ZW1CYXNlQ3VzdG9tVGFnICYm IGFjdGlvbiA8PSBXZWJDb3JlOjpDb250ZXh0TWVudUl0ZW1MYXN0Q3VzdG9tVGFnKSkKKyAgICAg ICAgICAgIExPR19FUlJPUigiQ29udGV4dE1lbnVBY3Rpb24gJWkgaXMgYW4gdW5rbm93biB0YWcg YnV0IGlzIGJlbG93IHRoZSBhbGxvd2FibGUgY3VzdG9tIHRhZyB2YWx1ZSBvZiAlaSIsIGFjdGlv biwgV2ViQ29yZTo6Q29udGV4dE1lbnVJdGVtQmFzZUFwcGxpY2F0aW9uVGFnKTsKICAgICAgICAg cmV0dXJuIHN0YXRpY19jYXN0PFdLQ29udGV4dE1lbnVJdGVtVGFnPihhY3Rpb24pOwogICAgIH0K IH0KQEAgLTcwMiw3ICs3MDIsNyBAQCBpbmxpbmUgV2ViQ29yZTo6Q29udGV4dE1lbnVBY3Rpb24g dG9JbXBsKFdLQ29udGV4dE1lbnVJdGVtVGFnIHRhZykKICNlbmRpZgogICAgIGNhc2Uga1dLQ29u dGV4dE1lbnVJdGVtVGFnT3BlbkxpbmtJblRoaXNXaW5kb3c6CiAgICAgZGVmYXVsdDoKLSAgICAg ICAgaWYgKHRhZyA8IGtXS0NvbnRleHRNZW51SXRlbUJhc2VBcHBsaWNhdGlvblRhZykKKyAgICAg ICAgaWYgKHRhZyA8IGtXS0NvbnRleHRNZW51SXRlbUJhc2VBcHBsaWNhdGlvblRhZyAmJiAhKHRh ZyA+PSBXZWJDb3JlOjpDb250ZXh0TWVudUl0ZW1CYXNlQ3VzdG9tVGFnICYmIHRhZyA8PSBXZWJD b3JlOjpDb250ZXh0TWVudUl0ZW1MYXN0Q3VzdG9tVGFnKSkKICAgICAgICAgICAgIExPR19FUlJP UigiV0tDb250ZXh0TWVudUl0ZW1UYWcgJWkgaXMgYW4gdW5rbm93biB0YWcgYnV0IGlzIGJlbG93 IHRoZSBhbGxvd2FibGUgY3VzdG9tIHRhZyB2YWx1ZSBvZiAlaSIsIHRhZywga1dLQ29udGV4dE1l bnVJdGVtQmFzZUFwcGxpY2F0aW9uVGFnKTsKICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFdl YkNvcmU6OkNvbnRleHRNZW51QWN0aW9uPih0YWcpOwogICAgIH0K