16259 2007-12-02 13:03:56 -0800 Inspector should display CDATA section data 2010-07-29 02:06:14 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 523.x (Safari 3) All All RESOLVED FIXED http://www.w3.org/2004/CDF/TestSuite/WICD_CDR_WP1/index.xhtml InRadar P2 Normal --- 1 eric apavlov aroben joepeck pfeldman timothy yurys oldest_to_newest 63016 0 eric 2007-12-02 13:03:56 -0800 Inspector should display CDATA section data Inspect "button-WICD.svg" at the attached link. Notice that none of the script is actually displayed for the <script> tags, since the inspector hides it under the "cdata section". It also shows 4 cdata sections, which makes no sense. 68645 1 aroben 2008-01-29 11:06:31 -0800 <rdar://problem/5712873> 256063 2 62580 apavlov 2010-07-26 09:10:23 -0700 Created attachment 62580 [PATCH] Suggested solution 256065 3 apavlov 2010-07-26 09:15:48 -0700 Once this issue is fixed, users are sure to hit https://bugs.webkit.org/show_bug.cgi?id=35284 when examining CDATA sections (especially long ones) in the DOM tree. This is fine, since Web Inspector just reports what it gets from the lower levels (the XML parser in this case). 256584 4 62580 abarth 2010-07-27 07:44:54 -0700 Comment on attachment 62580 [PATCH] Suggested solution LGTM. I'm not an inspector expert. Let me know if you'd rather I didn't review patches like this in the future. 256595 5 62580 pfeldman 2010-07-27 07:59:51 -0700 Comment on attachment 62580 [PATCH] Suggested solution Please test that editing is working - we are checking both for node type and style class in the context menu editing code. Also, could you update elements panel test to include new node type? 257089 6 62808 apavlov 2010-07-28 03:37:00 -0700 Created attachment 62808 [PATCH] Comments addressed Test augmented and rebaselined. Adding editing caps is non-trivial as it requires the modification of the DOM tree building procedure and doesn't seem to pay off, especially given the XML parsing bug in place. 257590 7 apavlov 2010-07-29 02:06:14 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/elements-panel-xhtml-structure-expected.txt M LayoutTests/inspector/elements-panel-xhtml-structure.xhtml M WebCore/ChangeLog M WebCore/inspector/InspectorDOMAgent.cpp M WebCore/inspector/front-end/ElementsTreeOutline.js Committed r64267 62580 2010-07-26 09:10:23 -0700 2010-07-28 03:37:00 -0700 [PATCH] Suggested solution cdata.patch text/plain 1988 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGU5YzUyNS4uZjRhNzEyNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNy0yNiAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluc3BlY3RvciBzaG91bGQgZGlzcGxheSBDREFUQSBzZWN0 aW9uIGRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2MjU5CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OmJ1aWxkT2JqZWN0Rm9yTm9kZSk6Cisg ICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzOgorICAg ICAgICAoKToKKwogMjAxMC0wNy0yNiAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTdGV2ZSBCbG9jay4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcCBiL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckRPTUFnZW50LmNwcAppbmRleCAzYTE0ODMwLi5hZDQwNDY0IDEwMDY0NAotLS0gYS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKKysrIGIvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCkBAIC03NzQsNiArNzc0LDcgQEAgUGFzc1JlZlB0 cjxJbnNwZWN0b3JPYmplY3Q+IEluc3BlY3RvckRPTUFnZW50OjpidWlsZE9iamVjdEZvck5vZGUo Tm9kZSogbm9kZSwgaW4KICAgICBzd2l0Y2ggKG5vZGUtPm5vZGVUeXBlKCkpIHsKICAgICAgICAg Y2FzZSBOb2RlOjpURVhUX05PREU6CiAgICAgICAgIGNhc2UgTm9kZTo6Q09NTUVOVF9OT0RFOgor ICAgICAgICBjYXNlIE5vZGU6OkNEQVRBX1NFQ1RJT05fTk9ERToKICAgICAgICAgICAgIG5vZGVW YWx1ZSA9IG5vZGUtPm5vZGVWYWx1ZSgpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNh c2UgTm9kZTo6QVRUUklCVVRFX05PREU6CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCmluZGV4IDcyNDdiYTAuLjNjZDIyYWUgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpz CisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpz CkBAIC0xMzIwLDYgKzEzMjAsMTAgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQu cHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgICAgICBpbmZvLnRpdGxlICs9ICIgWyIgKyBu b2RlLmludGVybmFsU3Vic2V0ICsgIl0iOwogICAgICAgICAgICAgICAgIGluZm8udGl0bGUgKz0g IiZndDs8L3NwYW4+IjsKICAgICAgICAgICAgICAgICBicmVhazsKKworICAgICAgICAgICAgY2Fz ZSBOb2RlLkNEQVRBX1NFQ1RJT05fTk9ERToKKyAgICAgICAgICAgICAgICBpbmZvLnRpdGxlID0g IjxzcGFuIGNsYXNzPVwid2Via2l0LWh0bWwtdGV4dC1ub2RlXCI+Jmx0OyFbQ0RBVEFbIiArIG5v ZGUubm9kZVZhbHVlLmVzY2FwZUhUTUwoKSArICJdXSZndDs8L3NwYW4+IjsKKyAgICAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICAgICAgaW5mby50 aXRsZSA9IHRoaXMudHJlZU91dGxpbmUubm9kZU5hbWVUb0NvcnJlY3RDYXNlKG5vZGUubm9kZU5h bWUpLmNvbGxhcHNlV2hpdGVzcGFjZSgpLmVzY2FwZUhUTUwoKTsKICAgICAgICAgfQo= 62808 2010-07-28 03:37:00 -0700 2010-07-28 07:29:46 -0700 [PATCH] Comments addressed cdata.patch text/plain 3768 apavlov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlZGQ3YzBkLi40N2JiOWJjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDct MjcgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnNwZWN0b3Igc2hvdWxkIGRp c3BsYXkgQ0RBVEEgc2VjdGlvbiBkYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjI1OQorCisgICAgICAgICogaW5zcGVjdG9yL2VsZW1lbnRzLXBh bmVsLXhodG1sLXN0cnVjdHVyZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogaW5zcGVjdG9yL2Vs ZW1lbnRzLXBhbmVsLXhodG1sLXN0cnVjdHVyZS54aHRtbDoKKwogMjAxMC0wNy0yNyAgS2VudCBU YW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBW YWZhaS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9lbGVtZW50cy1wYW5lbC14 aHRtbC1zdHJ1Y3R1cmUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2VsZW1l bnRzLXBhbmVsLXhodG1sLXN0cnVjdHVyZS1leHBlY3RlZC50eHQKaW5kZXggOGVjNTA5My4uN2Mw NzA5MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRzLXBhbmVsLXho dG1sLXN0cnVjdHVyZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Vs ZW1lbnRzLXBhbmVsLXhodG1sLXN0cnVjdHVyZS1leHBlY3RlZC50eHQKQEAgLTMsNyArMyw3IEBA IFRlc3RzIHRoYXQgZWxlbWVudHMgcGFuZWwgc2hvd3MgWE1MIGRvbSB0cmVlIHN0cnVjdHVyZSB3 aXRoIGNsb3NpbmcgdGFncyBmb3IgYWxsCiBQYXJhZ3JhcGggQlIgdGVzdAogTmV4dCBsaW5lCiAK LQorIAogYXBwbGljYXRpb24veGh0bWwreG1sIAogPEhUTUwgeG1sbnM9Imh0dHA6Ly93d3cudzMu b3JnLzE5OTkveGh0bWwiPgogPEhlYWQ+4oCmCkBAIC0xNyw2ICsxNyw3IEBAIGFwcGxpY2F0aW9u L3hodG1sK3htbAogPGJyPgogPC9icj4iTmV4dCBsaW5lIgogPC9wPgorPCFbQ0RBVEFbIENEYXRh IENvbnRlbnQgXV0+CiA8aW1nIGFsdD0iUmFuZG9tIEltYWdlIj4KIDwvaW1nPgogPHByZSBpZD0i b3V0cHV0UHJlIj4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9lbGVtZW50cy1w YW5lbC14aHRtbC1zdHJ1Y3R1cmUueGh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZWxlbWVu dHMtcGFuZWwteGh0bWwtc3RydWN0dXJlLnhodG1sCmluZGV4IDZlZjY2OGYuLmQ1ZjA0OTEgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9lbGVtZW50cy1wYW5lbC14aHRtbC1zdHJ1 Y3R1cmUueGh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRzLXBhbmVsLXho dG1sLXN0cnVjdHVyZS54aHRtbApAQCAtMTExLDYgKzExMSw3IEBAIFRlc3RzIHRoYXQgZWxlbWVu dHMgcGFuZWwgc2hvd3MgWE1MIGRvbSB0cmVlIHN0cnVjdHVyZSB3aXRoIGNsb3NpbmcgdGFncyBm b3IgYWxsCiA8aHI+PC9ocj4KIDxwPlBhcmFncmFwaCBCUiB0ZXN0PGJyLz5OZXh0IGxpbmUKIDwv cD4KKzwhW0NEQVRBWyBDRGF0YSBDb250ZW50IF1dPgogCiA8aW1nIGFsdD0iUmFuZG9tIEltYWdl Ij48L2ltZz4KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCBlZWVjMTFmLi5lM2EwNTI5IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA3LTI3ICBB bGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zcGVjdG9yIHNob3VsZCBkaXNwbGF5 IENEQVRBIHNlY3Rpb24gZGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTYyNTkKKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JET01BZ2Vu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01BZ2VudDo6YnVpbGRPYmplY3RG b3JOb2RlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxp bmUuanM6CisgICAgICAgICgpOgorCiAyMDEwLTA3LTI3ICBTYXRpc2ggU2FtcGF0aCAgPHNhdGlz aEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYg LS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKaW5kZXggM2ExNDgzMC4uYWQ0MDQ2NCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcApAQCAtNzc0LDYgKzc3NCw3 IEBAIFBhc3NSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBJbnNwZWN0b3JET01BZ2VudDo6YnVpbGRP YmplY3RGb3JOb2RlKE5vZGUqIG5vZGUsIGluCiAgICAgc3dpdGNoIChub2RlLT5ub2RlVHlwZSgp KSB7CiAgICAgICAgIGNhc2UgTm9kZTo6VEVYVF9OT0RFOgogICAgICAgICBjYXNlIE5vZGU6OkNP TU1FTlRfTk9ERToKKyAgICAgICAgY2FzZSBOb2RlOjpDREFUQV9TRUNUSU9OX05PREU6CiAgICAg ICAgICAgICBub2RlVmFsdWUgPSBub2RlLT5ub2RlVmFsdWUoKTsKICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICBjYXNlIE5vZGU6OkFUVFJJQlVURV9OT0RFOgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMgYi9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwppbmRleCA3MjQ3YmEwLi4z Y2QyMmFlIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNU cmVlT3V0bGluZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNU cmVlT3V0bGluZS5qcwpAQCAtMTMyMCw2ICsxMzIwLDEwIEBAIFdlYkluc3BlY3Rvci5FbGVtZW50 c1RyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICAgICAgaW5mby50aXRs ZSArPSAiIFsiICsgbm9kZS5pbnRlcm5hbFN1YnNldCArICJdIjsKICAgICAgICAgICAgICAgICBp bmZvLnRpdGxlICs9ICImZ3Q7PC9zcGFuPiI7CiAgICAgICAgICAgICAgICAgYnJlYWs7CisKKyAg ICAgICAgICAgIGNhc2UgTm9kZS5DREFUQV9TRUNUSU9OX05PREU6CisgICAgICAgICAgICAgICAg aW5mby50aXRsZSA9ICI8c3BhbiBjbGFzcz1cIndlYmtpdC1odG1sLXRleHQtbm9kZVwiPiZsdDsh W0NEQVRBWyIgKyBub2RlLm5vZGVWYWx1ZS5lc2NhcGVIVE1MKCkgKyAiXV0mZ3Q7PC9zcGFuPiI7 CisgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAgICAg ICAgICAgIGluZm8udGl0bGUgPSB0aGlzLnRyZWVPdXRsaW5lLm5vZGVOYW1lVG9Db3JyZWN0Q2Fz ZShub2RlLm5vZGVOYW1lKS5jb2xsYXBzZVdoaXRlc3BhY2UoKS5lc2NhcGVIVE1MKCk7CiAgICAg ICAgIH0K