162585 2016-09-26 17:26:30 -0700 Cannot run dump-class-layout; dies with "global name 'lldb' is not defined" 2016-09-27 10:21:20 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Mac macOS 10.12 RESOLVED FIXED P2 Normal --- 1 dbates dbates ddkilzer lforschler simon.fraser zalan oldest_to_newest 1233675 0 dbates 2016-09-26 17:26:30 -0700 When I ran dump-class-layout today (09/26) to see the object size of ResourceHandle it died with the following traceback: [[ $ Tools/Scripts/dump-class-layout -c Debug WebCore ResourceHandle Traceback (most recent call last): File "Tools/Scripts/dump-class-layout", line 169, in <module> main() File "Tools/Scripts/dump-class-layout", line 166, in main dump_class(target_path, args.classname) File "Tools/Scripts/dump-class-layout", line 120, in dump_class debugger = lldb.SBDebugger.Create() NameError: global name 'lldb' is not defined ]] I am using Python 2.7.10. 1233676 1 dbates 2016-09-26 17:33:01 -0700 We import the lldb inside the function import_lldb() in dump-class-layout on line 48, <https://trac.webkit.org/browser/trunk/Tools/Scripts/dump-class-layout?rev=188350#L48>. By (2) of <https://docs.python.org/2/reference/simple_stmts.html#import>, the names from the imported module are defined "in the local namespace (of the scope where the import statement occurs)". And each function creates a local namespace by <https://docs.python.org/2/tutorial/classes.html#python-scopes-and-namespaces>. Therefore, import_lldb() does not import the lldb module into the global namespace. 1233679 2 289896 dbates 2016-09-26 17:45:51 -0700 Created attachment 289896 Patch 1233936 3 289896 dbates 2016-09-27 10:21:16 -0700 Comment on attachment 289896 Patch Clearing flags on attachment: 289896 Committed r206441: <http://trac.webkit.org/changeset/206441> 1233937 4 dbates 2016-09-27 10:21:20 -0700 All reviewed patches have been landed. Closing bug. 289896 2016-09-26 17:45:51 -0700 2016-09-27 10:21:16 -0700 Patch bug-162585-20160926174254.patch text/plain 2585 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2Mzc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTM2NDZlZWE2ZDQyNmVkYjI0NWVjOTg3ZjlmZDc2ZTFj MjU2ZjYwMS4uYWZhNWJkZDUyNmFlMjM5YzM2OTNkYjRjMmVlNTE1YTA5M2Y4MTg2MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2 IEBACisyMDE2LTA5LTI2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBDYW5ub3QgcnVuIGR1bXAtY2xhc3MtbGF5b3V0OyBkaWVzIHdpdGggImdsb2JhbCBuYW1l ICdsbGRiJyBpcyBub3QgZGVmaW5lZCIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2MjU4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEltcG9ydCB0aGUgbGxkYiBtb2R1bGUgaW50byB0aGUgZ2xvYmFsIG5h bWVzcGFjZS4KKworICAgICAgICBDdXJyZW50bHkgZHVtcC1jbGFzcy1sYXlvdXQgaW1wb3J0cyB0 aGUgbGxkYiBQeXRob24gbW9kdWxlIHVzaW5nIHRoZSBpbXBvcnQgc3RhdGVtZW50CisgICAgICAg IGZyb20gdGhlIGhlbHBlciBmdW5jdGlvbiBpbXBvcnRfbGxkYi4gVGhlIGltcG9ydCBzdGF0ZW1l bnQgaW1wb3J0cyB0aGUgbmFtZXMgb2YgdGhlCisgICAgICAgIHNwZWNpZmllZCBtb2R1bGUgaW50 byB0aGUgc2NvcGUgb2YgaW1wb3J0X2xsZGIoKTsgPT4gdGhlIG5hbWVzIGltcG9ydGVkIGZyb20g dGhpcworICAgICAgICBtb2R1bGUgY2Fubm90IGJlIGFjY2Vzc2VkIG91dHNpZGUgdGhlIHNjb3Bl IG9mIGltcG9ydF9sbGRiKCkuIE90aGVyIGZ1bmN0aW9ucyBpbgorICAgICAgICB0aGlzIHNjcmlw dCBhc3N1bWUgdGhhdCB0aGUgbGxkYiBtb2R1bGUgd2FzIGltcG9ydGVkIGludG8gdGhlIGdsb2Jh bCBzY29wZS4gV2Ugc2hvdWxkCisgICAgICAgIGltcG9ydCB0aGUgbW9kdWxlIGxsZGIgaW50byB0 aGUgZ2xvYmFsIHNjb3BlLCBpZiBpdCBleGlzdHMsIHNvIHRoYXQgdGhlc2UgZnVuY3Rpb25zCisg ICAgICAgIGNhbiBmaW5kIGl0LiBPdGhlcndpc2UsIHdlIHNob3VsZCBlbWl0IGEgaHVtYW4gcmVh ZGFibGUgZXJyb3IgbWVzc2FnZSB0aGF0IGV4cGxhaW5zCisgICAgICAgIHRoYXQgd2UgZmFpbGVk IHRvIGltcG9ydCB0aGUgbGxkYiBtb2R1bGUuCisKKyAgICAgICAgQWxzbyByZW1vdmUgc29tZSB1 bm5lY2Vzc2FyeSBzZW1pY29sb24gY2hhcmFjdGVycy4KKworICAgICAgICAqIFNjcmlwdHMvZHVt cC1jbGFzcy1sYXlvdXQ6CisgICAgICAgIChpbXBvcnRfbGxkYik6CisKIDIwMTYtMDktMjYgIFl1 c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgVXNpbmcgY2hh cjE2X3QgaW5zdGVhZCBvZiB3Y2hhcl90IGluIFRlc3RXZWJLaXRBUEkgVVJMUGFyc2VyIHRlc3Rz CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2R1bXAtY2xhc3MtbGF5b3V0IGIvVG9vbHMvU2Ny aXB0cy9kdW1wLWNsYXNzLWxheW91dAppbmRleCA5MTRhZGIwMGM3YzFlZWIwNjM2ODQ0YmYwNzQ4 MTlkN2U2ZjhhNDAwLi4zODA3ZGNmNDkyMjM4ZjdkNWE4Zjk5OWNhYThhY2FjNjkyZGFiY2JlIDEw MDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2R1bXAtY2xhc3MtbGF5b3V0CisrKyBiL1Rvb2xzL1Nj cmlwdHMvZHVtcC1jbGFzcy1sYXlvdXQKQEAgLTQyLDEwICs0MiwxNiBAQCBkZWYgZGV2ZWxvcGVy X2RpcigpOgogICAgIHJldHVybiBzdWJwcm9jZXNzLmNoZWNrX291dHB1dChbInhjb2RlLXNlbGVj dCIsICItLXByaW50LXBhdGgiXSkKIAogZGVmIGltcG9ydF9sbGRiKCk6Ci0gICAgeGNvZGVfY29u dGVudHNfcGF0aCA9IG9zLnBhdGguc3BsaXQoZGV2ZWxvcGVyX2RpcigpKVswXTsKLSAgICBsbGRi X2ZyYW1ld29ya19wYXRoID0gb3MucGF0aC5qb2luKHhjb2RlX2NvbnRlbnRzX3BhdGgsICJTaGFy ZWRGcmFtZXdvcmtzIiwgIkxMREIuZnJhbWV3b3JrIiwgIlJlc291cmNlcyIsICJQeXRob24iKTsK KyAgICB4Y29kZV9jb250ZW50c19wYXRoID0gb3MucGF0aC5zcGxpdChkZXZlbG9wZXJfZGlyKCkp WzBdCisgICAgbGxkYl9mcmFtZXdvcmtfcGF0aCA9IG9zLnBhdGguam9pbih4Y29kZV9jb250ZW50 c19wYXRoLCAiU2hhcmVkRnJhbWV3b3JrcyIsICJMTERCLmZyYW1ld29yayIsICJSZXNvdXJjZXMi LCAiUHl0aG9uIikKICAgICBzeXMucGF0aC5hcHBlbmQobGxkYl9mcmFtZXdvcmtfcGF0aCkKLSAg ICBpbXBvcnQgbGxkYgorCisgICAgTExEQl9NT0RVTEVfTkFNRSA9ICJsbGRiIgorICAgIHRyeToK KyAgICAgICAgZ2xvYmFscygpW0xMREJfTU9EVUxFX05BTUVdID0gX19pbXBvcnRfXyhMTERCX01P RFVMRV9OQU1FKQorICAgIGV4Y2VwdCBJbXBvcnRFcnJvcjoKKyAgICAgICAgcHJpbnQgIkZhaWxl ZCB0byBpbXBvcnQge30gZnJvbSB7fSIuZm9ybWF0KExMREJfTU9EVUxFX05BTUUsIGxsZGJfZnJh bWV3b3JrX3BhdGgpCisgICAgICAgIHN5cy5leGl0KDEpCiAKIGRlZiBmaW5kX2J1aWxkX2RpcmVj dG9yeSgpOgogICAgIHJldHVybgo=