162583 2016-09-26 16:05:13 -0700 Exception unwinding code should use a CatchScope instead of a ThrowScope. 2016-09-26 16:14:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 162351 1 mark.lam mark.lam benjamin fpizlo ggaren jfbastien keith_miller msaboff saam oldest_to_newest 1233633 0 mark.lam 2016-09-26 16:05:13 -0700 This is because the exception unwinding code does not throw an exception. It only inspects the exception and passes it to the appropriate handler. 1233635 1 289885 mark.lam 2016-09-26 16:10:04 -0700 Created attachment 289885 proposed patch. 1233636 2 289885 ggaren 2016-09-26 16:11:57 -0700 Comment on attachment 289885 proposed patch. r=me 1233638 3 mark.lam 2016-09-26 16:14:57 -0700 Thanks for the review. Landed in r206401: <http://trac.webkit.org/r206401>. 289885 2016-09-26 16:10:04 -0700 2016-09-26 16:11:57 -0700 proposed patch. bug-162583.patch text/plain 2077 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA2NDAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE2LTA5LTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBF eGNlcHRpb24gdW53aW5kaW5nIGNvZGUgc2hvdWxkIHVzZSBhIENhdGNoU2NvcGUgaW5zdGVhZCBv ZiBhIFRocm93U2NvcGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjI1ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIGlzIGJlY2F1c2UgdGhlIGV4Y2VwdGlvbiB1bndpbmRpbmcgY29kZSBkb2Vz IG5vdCB0aHJvdyBhbiBleGNlcHRpb24uCisgICAgICAgIEl0IG9ubHkgaW5zcGVjdHMgdGhlIHRo cm93biBleGNlcHRpb24gYW5kIHBhc3NlcyBpdCB0byB0aGUgYXBwcm9wcmlhdGUgaGFuZGxlci4K KworICAgICAgICAqIGludGVycHJldGVyL0ludGVycHJldGVyLmNwcDoKKyAgICAgICAgKEpTQzo6 SW50ZXJwcmV0ZXI6OnVud2luZCk6CisgICAgICAgICogaml0L0pJVEV4Y2VwdGlvbnMuY3BwOgor ICAgICAgICAoSlNDOjpnZW5lcmljVW53aW5kKToKKwogMjAxNi0wOS0yNiAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhbiBPcHRpb24gdG8gZGlz YWJsZSB0aGUgQ29kZUNhY2hlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0 ZXIvSW50ZXJwcmV0ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAJKHJldmlzaW9uIDIwNjM5OSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTY3OCw3ICs2NzgsNyBAQCBwcml2YXRlOgogCiBORVZFUl9JTkxJTkUgSGFuZGxlckluZm8q IEludGVycHJldGVyOjp1bndpbmQoVk0mIHZtLCBDYWxsRnJhbWUqJiBjYWxsRnJhbWUsIEV4Y2Vw dGlvbiogZXhjZXB0aW9uLCBVbndpbmRTdGFydCB1bndpbmRTdGFydCkKIHsKLSAgICBhdXRvIHNj b3BlID0gREVDTEFSRV9USFJPV19TQ09QRSh2bSk7CisgICAgYXV0byBzY29wZSA9IERFQ0xBUkVf Q0FUQ0hfU0NPUEUodm0pOwogCiAgICAgaWYgKHVud2luZFN0YXJ0ID09IFVud2luZEZyb21DYWxs ZXJGcmFtZSkgewogICAgICAgICBpZiAoY2FsbEZyYW1lLT5jYWxsZXJGcmFtZU9yVk1FbnRyeUZy YW1lKCkgPT0gdm0udG9wVk1FbnRyeUZyYW1lKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9KSVRFeGNlcHRpb25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L0pJVEV4Y2VwdGlvbnMuY3BwCShyZXZpc2lvbiAyMDYzOTkpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0pJVEV4Y2VwdGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Miw3 ICs0Miw3IEBAIG5hbWVzcGFjZSBKU0MgewogCiB2b2lkIGdlbmVyaWNVbndpbmQoVk0qIHZtLCBF eGVjU3RhdGUqIGNhbGxGcmFtZSwgVW53aW5kU3RhcnQgdW53aW5kU3RhcnQpCiB7Ci0gICAgYXV0 byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUoKnZtKTsKKyAgICBhdXRvIHNjb3BlID0gREVD TEFSRV9DQVRDSF9TQ09QRSgqdm0pOwogICAgIGlmIChPcHRpb25zOjpicmVha09uVGhyb3coKSkg ewogICAgICAgICBDb2RlQmxvY2sqIGNvZGVCbG9jayA9IGNhbGxGcmFtZS0+Y29kZUJsb2NrKCk7 CiAgICAgICAgIGlmIChjb2RlQmxvY2spCg==